November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: f_TC_cell_change_different_*: always expect the auth

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38404?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: SGSN: f_TC_cell_change_different_*: always expect the auth ...................................................................... SGSN: f_TC_cell_change_different_*: always expect the auth The new SGSN will always ask for authentication when receiving Attach or RA which is the correct behaviour as long the LLC layer doesn't indicate integrity or encryption protection. Change-Id: I24579b5fc843caf68e035e106cee4e4ec0a3c735 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/38404/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38404?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I24579b5fc843caf68e035e106cee4e4ec0a3c735 Gerrit-Change-Number: 38404 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: f_TC_paging_ps: call f_gmm_attach() direct

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38403?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: SGSN: f_TC_paging_ps: call f_gmm_attach() direct ...................................................................... SGSN: f_TC_paging_ps: call f_gmm_attach() direct Instead of using the TC function, call f_gmm_attach() direct. Also set explicit the verdict at the end. Change-Id: I68c75f84b01a0cd673ffd8c19ab5f0a8517c5738 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/38403/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38403?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I68c75f84b01a0cd673ffd8c19ab5f0a8517c5738 Gerrit-Change-Number: 38403 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: fix encoding of IMEISV in Auth and Ciphering Response

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38414?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: SGSN: fix encoding of IMEISV in Auth and Ciphering Response ...................................................................... SGSN: fix encoding of IMEISV in Auth and Ciphering Response According to 24.008 the IMEISV field is exact 11 bytes long and must contain a IMEI + SV which is exact 16 digits long, not 15. Change-Id: I79dd79840de58f450c1a05e704fd9bd831455716 --- M sgsn/BSSGP_ConnHdlr.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/14/38414/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38414?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79dd79840de58f450c1a05e704fd9bd831455716 Gerrit-Change-Number: 38414 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

7 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: TC_attach_pdp_act_pmm_idle: use correct Service Request type

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38416?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: SGSN: TC_attach_pdp_act_pmm_idle: use correct Service Request type ...................................................................... SGSN: TC_attach_pdp_act_pmm_idle: use correct Service Request type When the UE requests data service, it must use the data service request type. Change-Id: I9301e7a37d96c3f93e77f7618d6c13dfa1fbe46b --- M sgsn/SGSN_Tests_Iu.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/16/38416/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9301e7a37d96c3f93e77f7618d6c13dfa1fbe46b Gerrit-Change-Number: 38416 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

7 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: gprs/gsm23003: add osmo_mme_id_cmp & osmo_gummei_cmp

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38763?usp=email ) Change subject: gprs/gsm23003: add osmo_mme_id_cmp & osmo_gummei_cmp ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9a6769b1bff16450046181b31a8762ff49955ae4 Gerrit-Change-Number: 38763 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 14 Nov 2024 18:41:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: gsm_utils: add gprs_tlli2tmsi()

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/38764?usp=email to look at the new patch set (#4). Change subject: gsm_utils: add gprs_tlli2tmsi() ...................................................................... gsm_utils: add gprs_tlli2tmsi() A converter function which converts from a TLLI into a TMSI. Change-Id: I9d3464922c89383099a5f3cdd1458c0ecc28ee18 --- M include/osmocom/gsm/gsm_utils.h M src/gsm/gsm_utils.c M src/gsm/libosmogsm.map M tests/gprs/gprs_test.c 4 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/64/38764/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38764?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d3464922c89383099a5f3cdd1458c0ecc28ee18 Gerrit-Change-Number: 38764 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

7 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: gsm_utils: add gprs_tlli2tmsi()

by Jenkins Builder

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38764?usp=email ) Change subject: gsm_utils: add gprs_tlli2tmsi() ...................................................................... Patch Set 3: (2 comments) File src/gsm/gsm_utils.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19919): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/12040c4e_a136b7f3?… : PS3, Line 1031: switch (gprs_tlli_type(tlli)) { switch and case should be at the same indent File tests/gprs/gprs_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19919): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/8c45c00c_4ea05227?… : PS3, Line 113: static void test_ptmsi_tlli() Bad function definition - void test_ptmsi_tlli() should probably be void test_ptmsi_tlli(void) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38764?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d3464922c89383099a5f3cdd1458c0ecc28ee18 Gerrit-Change-Number: 38764 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 14 Nov 2024 17:50:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months, 2 weeks

1
0
0 0

[XS] Change in libosmocore[master]: wip: osmo_mei_cmp(): FIXME

by lynxis lazus

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/38779?usp=email ) Change subject: wip: osmo_mei_cmp(): FIXME ...................................................................... Abandoned part of another commit. pushed by mistake -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id4abe0c33f7ece2909fc1ff6c3c7466fc783c67f Gerrit-Change-Number: 38779 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder

7 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: gsm_utils: add gprs_tlli2tmsi()

by Jenkins Builder

Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38764?usp=email ) Change subject: gsm_utils: add gprs_tlli2tmsi() ...................................................................... Patch Set 2: (11 comments) File src/gsm/gsm_utils.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/dda40a94_09760386?… : PS2, Line 1029: uint32_t ptmsi = (1 << 31) | (1 << 30); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/cb4f4aef_c16baece?… : PS2, Line 1031: switch (gprs_tlli_type(tlli)) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/5c969642_abb11a83?… : PS2, Line 1032: case TLLI_LOCAL: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/8062cc26_f9adae35?… : PS2, Line 1033: case TLLI_FOREIGN: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/b5a21082_135687e1?… : PS2, Line 1034: break; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/26573cdb_85bdb329?… : PS2, Line 1034: break; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/d4f5b9f9_c0e7aa0a?… : PS2, Line 1036: return 0xffffffff; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/75e2f752_6135351a?… : PS2, Line 1036: return 0xffffffff; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/29f3c0c2_d060e37a?… : PS2, Line 1037: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/eb3c3876_72f89c67?… : PS2, Line 1039: ptmsi |= tlli; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19917): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/6dc1e5ee_66a19cab?… : PS2, Line 1040: return ptmsi; please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38764?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d3464922c89383099a5f3cdd1458c0ecc28ee18 Gerrit-Change-Number: 38764 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 14 Nov 2024 17:49:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: gsm_utils: add gprs_tlli2tmsi()

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/38764?usp=email to look at the new patch set (#3). Change subject: gsm_utils: add gprs_tlli2tmsi() ...................................................................... gsm_utils: add gprs_tlli2tmsi() A converter function which converts from a TLLI into a TMSI. Change-Id: I9d3464922c89383099a5f3cdd1458c0ecc28ee18 --- M include/osmocom/gsm/gsm_utils.h M src/gsm/gsm_utils.c M src/gsm/libosmogsm.map M tests/gprs/gprs_test.c 4 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/64/38764/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38764?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d3464922c89383099a5f3cdd1458c0ecc28ee18 Gerrit-Change-Number: 38764 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

7 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024