October 2024 - gerrit-log - lists.osmocom.org

[XS] Change in ...osmo_dia2gsup[master]: fixup: diameter: fix unused macro param in ?SERVICE

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38427?usp=email ) Change subject: fixup: diameter: fix unused macro param in ?SERVICE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38427?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I52a59f3eaf9784352ad971961c2e31bf5ff9ba90 Gerrit-Change-Number: 38427 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Oct 2024 21:50:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

8 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: fixup: diameter: fix unused macro param in ?SERVICE

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38427?usp=email ) Change subject: fixup: diameter: fix unused macro param in ?SERVICE ...................................................................... fixup: diameter: fix unused macro param in ?SERVICE The Product-Name must be a string (list), not an atom. Change-Id: I52a59f3eaf9784352ad971961c2e31bf5ff9ba90 Fixes: 1545311 "diameter: fix unused macro param in ?SERVICE" --- M src/osmo_dia2gsup.erl 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/27/38427/1 diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index eab34a3..26376a4 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -96,7 +96,8 @@ %% @callback gen_server init(State) -> % DIAMETER side - diameter:start_service(?SVC_NAME, ?SERVICE(?MODULE)), + ProdName = atom_to_list(?MODULE), + diameter:start_service(?SVC_NAME, ?SERVICE(ProdName)), Ip = application:get_env(osmo_dia2gsup, diameter_ip, "127.0.0.8"), Port = application:get_env(osmo_dia2gsup, diameter_port, 3868), -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38427?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I52a59f3eaf9784352ad971961c2e31bf5ff9ba90 Gerrit-Change-Number: 38427 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

8 months, 2 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: diameter: assert that diameter:start_service/2 returns ok

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38428?usp=email ) Change subject: diameter: assert that diameter:start_service/2 returns ok ...................................................................... diameter: assert that diameter:start_service/2 returns ok I introduced a regression in 1545311, which would have been spotted much earlier if we had such an assertion in place. Add it. Change-Id: Ief13353d280e3eb80a25b5c9a9effdf537bcc704 Related: 1545311 "diameter: fix unused macro param in ?SERVICE" --- M src/osmo_dia2gsup.erl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/28/38428/1 diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index 26376a4..b8d7a34 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -97,7 +97,7 @@ init(State) -> % DIAMETER side ProdName = atom_to_list(?MODULE), - diameter:start_service(?SVC_NAME, ?SERVICE(ProdName)), + ok = diameter:start_service(?SVC_NAME, ?SERVICE(ProdName)), Ip = application:get_env(osmo_dia2gsup, diameter_ip, "127.0.0.8"), Port = application:get_env(osmo_dia2gsup, diameter_port, 3868), -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ief13353d280e3eb80a25b5c9a9effdf537bcc704 Gerrit-Change-Number: 38428 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

8 months, 2 weeks

1
0
0 0

[S] Change in osmo-hlr[master]: debian/copyright: add gsup_client under GPLv2+

by fixeria

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38423?usp=email ) Change subject: debian/copyright: add gsup_client under GPLv2+ ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Idddcd6356af76987bf57ecd21096299cb2ba896f Gerrit-Change-Number: 38423 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 14 Oct 2024 18:00:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

8 months, 2 weeks

1
0
0 0

[XS] Change in osmo-hlr[master]: gsupclient: add missing SPDX line

by fixeria

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38422?usp=email ) Change subject: gsupclient: add missing SPDX line ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38422?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Iaded691cc0eb2f5dd85efd1915ddef1a747fe518 Gerrit-Change-Number: 38422 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 14 Oct 2024 17:59:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

8 months, 2 weeks

1
0
0 0

[L] Change in osmo-hlr[master]: gsupclient: Introduce gsup_client_mux

by fixeria

Attention is currently required from: laforge, lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38112?usp=email ) Change subject: gsupclient: Introduce gsup_client_mux ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38112?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I916c1bb6cfc48f92fc5db2b5c914eb1b4e25fa7f Gerrit-Change-Number: 38112 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 14 Oct 2024 17:59:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

8 months, 2 weeks

1
0
0 0

[S] Change in osmo-msc[master]: vlr: refactor and rename vlr_timer into vlr_timer_val

by fixeria

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38356?usp=email ) Change subject: vlr: refactor and rename vlr_timer into vlr_timer_val ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38356?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic46ddb578962619fc08bd63645c76852e676fcc9 Gerrit-Change-Number: 38356 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 14 Oct 2024 16:46:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

8 months, 2 weeks

1
0
0 0

[M] Change in upf-benchmark[master]: Rename osmo-pfcp-tool to osmo-upf-genload

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38354?usp=email ) Change subject: Rename osmo-pfcp-tool to osmo-upf-genload ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > we already have rtp-load-gen (osmo-mgw) gtp-load-gen (separate git repo), so it might make sense to […] Ack I'll rename it. -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38354?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: Ie36379b5dcf4ab86276dfda9e25410fe41db1d93 Gerrit-Change-Number: 38354 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 14 Oct 2024 15:08:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

8 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: GMM Service Request: handle PMM IDLE UE correct

by pespin

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: handle PMM IDLE UE correct ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38397?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I29237997e414aea80f254247da54f909410a4b36 Gerrit-Change-Number: 38397 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 14 Oct 2024 15:02:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

8 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr.ttcn: Service Request: expect a CommonId when st...

by pespin

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38415?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr.ttcn: Service Request: expect a CommonId when stopping on SecurityCommand Complete ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38415?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie81c5eb01eb695d0399770b8a7feb9b4549148b3 Gerrit-Change-Number: 38415 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 14 Oct 2024 15:01:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

8 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2024