October 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: sgsn: Validate TLI received in RAB Ass Req
by pespin 15 Oct '24

15 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38433?usp=email ) Change subject: sgsn: Validate TLI received in RAB Ass Req ...................................................................... sgsn: Validate TLI received in RAB Ass Req Related: OS#6508 Change-Id: I3a3699cea981caa89b30742c031d5f232418b0ee --- A library/ITU_X213_Types.ttcn M library/ranap/RANAP_Templates.ttcn M sgsn/BSSGP_ConnHdlr.ttcn M sgsn/gen_links.sh 4 files changed, 193 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/38433/1 diff --git a/library/ITU_X213_Types.ttcn b/library/ITU_X213_Types.ttcn new file mode 100644 index 0000000..ec656c2 --- /dev/null +++ b/library/ITU_X213_Types.ttcn @@ -0,0 +1,172 @@ +module ITU_X213_Types { + +/* ITU_X213_Types, defining abstract TTCN-3 data types for ITU-T Rec. X.213. + * + * (C) 2024 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * All rights reserved. + * Author: Pau Espin Pedrol <pespin(a)sysmocom.de> + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + + +import from General_Types all; +import from Osmocom_Types all; + +/* Network Service access point */ + +/* initial domain part (IDP). = authority and format identifier (AFI) + initial domain identifier (IDI). */ + +type enumerated NSAP_AFI { + NSAP_AFI_IANA_ICP_DEC ('34'H), + NSAP_AFI_IANA_ICP_BIN ('35'H) +} with { variant "FIELDLENGTH(8)" }; + +type enumerated NSAP_IDI_IANA_ICP { + NSAP_IDI_IANA_ICP_IPv6 ('0000'H), + NSAP_IDI_IANA_ICP_IPv4 ('0001'H) +} with { variant "FIELDLENGTH(16)" + variant "BYTEORDER(last)" }; + +type record NSAP_DSP_IANA_ICP_BIN_IPv6 { + OCT16 addr, + OCT1 padding +}; + +type record NSAP_DSP_IANA_ICP_BIN_IPv4 { + OCT4 addr, + octetstring padding optional /* TODO: limit this field to be max 13 bytes (20 - 3 - 4)*/ +}; + +type union NSAP_DSP_IANA_ICP_BIN { + NSAP_DSP_IANA_ICP_BIN_IPv6 ipv6, + NSAP_DSP_IANA_ICP_BIN_IPv4 ipv4, + octetstring other +}; + +type record NSAP_IDI_IANA_ICP_BIN { + NSAP_IDI_IANA_ICP icp, + NSAP_DSP_IANA_ICP_BIN dsp +} with { variant (dsp) "CROSSTAG(ipv6, icp = NSAP_IDI_IANA_ICP_IPv6; + ipv4, icp = NSAP_IDI_IANA_ICP_IPv4; + other, OTHERWISE)" +}; + +type union NSAP_IDI { + NSAP_IDI_IANA_ICP_BIN iana_icp_bin, + octetstring other +}; + +type record NSAP_IDP { + NSAP_AFI afi, + NSAP_IDI idi +} with { variant (idi) "CROSSTAG(iana_icp_bin, afi = NSAP_AFI_IANA_ICP_BIN; + other, OTHERWISE)" +}; + +type record NSAP_Address { + NSAP_IDP idp +}; + + +external function enc_NSAP_Address(in NSAP_Address pco_data) return octetstring +with { extension "prototype(convert)" extension "encode(RAW)" } + +external function dec_NSAP_Address(in octetstring pco_payload) return NSAP_Address +with { extension "prototype(convert) decode(RAW)" }; + +/********************** + * ITU_X213_Templates: + **********************/ + +template (present) NSAP_DSP_IANA_ICP_BIN_IPv6 tr_NSAP_IANA_IPv6_Address(template (present) OCT16 addr := ?) := { + addr := addr, + padding := ? +}; +template (value) NSAP_DSP_IANA_ICP_BIN_IPv6 ts_NSAP_IANA_IPv6_Address(template (value) OCT16 addr) := { + addr := addr, + padding := '00'O +}; + +template (present) NSAP_DSP_IANA_ICP_BIN_IPv4 tr_NSAP_IANA_IPv4_Address(template (present) OCT4 addr := ?, template octetstring padding := *) := { + addr := addr, + padding := padding +}; +template (value) NSAP_DSP_IANA_ICP_BIN_IPv4 ts_NSAP_IANA_IPv4_Address(template (value) OCT4 addr, template (omit) octetstring padding := omit) := { + addr := addr, + padding := padding +}; + +template (present) NSAP_DSP_IANA_ICP_BIN tr_NSAP_IANA_u_IPv6_Address(template (present) OCT16 addr := ?) := { + ipv6 := tr_NSAP_IANA_IPv6_Address(addr) +}; +template (value) NSAP_DSP_IANA_ICP_BIN ts_NSAP_IANA_u_IPv6_Address(template (value) OCT16 addr) := { + ipv6 := ts_NSAP_IANA_IPv6_Address(addr) +}; + +template (present) NSAP_DSP_IANA_ICP_BIN tr_NSAP_IANA_u_IPv4_Address(template (present) OCT4 addr := ?, template octetstring padding := *) := { + ipv4 := tr_NSAP_IANA_IPv4_Address(addr, padding) +}; +template (value) NSAP_DSP_IANA_ICP_BIN ts_NSAP_IANA_u_IPv4_Address(template (value) OCT4 addr, template (omit) octetstring padding := omit) := { + ipv4 := ts_NSAP_IANA_IPv4_Address(addr, padding) +}; + +template (present) NSAP_IDI_IANA_ICP_BIN tr_NSAP_IDI_IANA_ICP_BIN(template (present) NSAP_IDI_IANA_ICP icp := ?, + template (present) NSAP_DSP_IANA_ICP_BIN dsp := ?) := { + icp := icp, + dsp := dsp +}; +template (value) NSAP_IDI_IANA_ICP_BIN ts_NSAP_IDI_IANA_ICP_BIN(template (value) NSAP_IDI_IANA_ICP icp, + template (value) NSAP_DSP_IANA_ICP_BIN dsp) := { + icp := icp, + dsp := dsp +}; + +template (present) NSAP_IDI tr_NSAP_IDI_u_IANA_ICP_BIN(template (present) NSAP_IDI_IANA_ICP_BIN iana_icp_bin := ?) := { + iana_icp_bin := iana_icp_bin +}; +template (value) NSAP_IDI ts_NSAP_IDI_u_IANA_ICP_BIN(template (value) NSAP_IDI_IANA_ICP_BIN iana_icp_bin) := { + iana_icp_bin := iana_icp_bin +}; + +template (present) NSAP_IDP tr_NSAP_IDP(template (present) NSAP_AFI afi := ?, template (present) NSAP_IDI idi := ?) := { + afi := afi, + idi := idi +}; +template (value) NSAP_IDP ts_NSAP_IDP(template (value) NSAP_AFI afi, template (value) NSAP_IDI idi) := { + afi := afi, + idi := idi +}; + +template (present) NSAP_Address tr_NSAP_Address_IANA_BIN_IPv6(template (present) OCT16 addr := ?) := { + idp := tr_NSAP_IDP(NSAP_AFI_IANA_ICP_BIN, + tr_NSAP_IDI_u_IANA_ICP_BIN(tr_NSAP_IDI_IANA_ICP_BIN(NSAP_IDI_IANA_ICP_IPv6, + tr_NSAP_IANA_u_IPv6_Address(addr)))) +}; +template (value) NSAP_Address ts_NSAP_Address_IANA_BIN_IPv6(template (value) OCT16 addr) := { + idp := ts_NSAP_IDP(NSAP_AFI_IANA_ICP_BIN, + ts_NSAP_IDI_u_IANA_ICP_BIN(ts_NSAP_IDI_IANA_ICP_BIN(NSAP_IDI_IANA_ICP_IPv6, + ts_NSAP_IANA_u_IPv6_Address(addr)))) +}; + +template (present) NSAP_Address tr_NSAP_Address_IANA_BIN_IPv4(template (present) OCT4 addr := ?, + template octetstring padding := *) := { + idp := tr_NSAP_IDP(NSAP_AFI_IANA_ICP_BIN, + tr_NSAP_IDI_u_IANA_ICP_BIN(tr_NSAP_IDI_IANA_ICP_BIN(NSAP_IDI_IANA_ICP_IPv4, + tr_NSAP_IANA_u_IPv4_Address(addr, padding)))) +}; +template (value) NSAP_Address ts_NSAP_Address_IANA_BIN_IPv4(template (value) OCT4 addr, + template (omit) octetstring padding := omit) := { + idp := ts_NSAP_IDP(NSAP_AFI_IANA_ICP_BIN, + ts_NSAP_IDI_u_IANA_ICP_BIN(ts_NSAP_IDI_IANA_ICP_BIN(NSAP_IDI_IANA_ICP_IPv4, + ts_NSAP_IANA_u_IPv4_Address(addr, padding)))) +}; +/* IPv4 with padding so that TLA is 20 bytes. This is quite common: */ +template (value) NSAP_Address ts_NSAP_Address_IANA_BIN_IPv4Len20(template (value) OCT4 addr) := + ts_NSAP_Address_IANA_BIN_IPv4(addr, '00000000000000000000000000'O); + + +} with { encode "RAW"; variant "FIELDORDER(msb)" } diff --git a/library/ranap/RANAP_Templates.ttcn b/library/ranap/RANAP_Templates.ttcn index a433d62..5cd9353 100644 --- a/library/ranap/RANAP_Templates.ttcn +++ b/library/ranap/RANAP_Templates.ttcn @@ -1878,5 +1878,12 @@ return rab_id; } +function f_ranap_rab_ass_req_extract_tli(RANAP_PDU ranap) return TransportLayerInformation +{ + var RAB_AssignmentRequest.protocolIEs ies := ranap.initiatingMessage.value_.rAB_AssignmentRequest.protocolIEs; + var TransportLayerInformation tli := ies[0].value_.rAB_SetupOrModifyList[0][0].firstValue.rAB_SetupOrModifyItemFirst.transportLayerInformation; + return tli; +} + } diff --git a/sgsn/BSSGP_ConnHdlr.ttcn b/sgsn/BSSGP_ConnHdlr.ttcn index c39b614..121ac2d 100644 --- a/sgsn/BSSGP_ConnHdlr.ttcn +++ b/sgsn/BSSGP_ConnHdlr.ttcn @@ -17,6 +17,7 @@ import from MobileL3_Types all; import from L3_Templates all; import from L3_Common all; +import from ITU_X213_Types all; import from GSUP_Types all; import from GSUP_Templates all; @@ -696,7 +697,18 @@ var RANAP_PDU ranap; [] BSSAP.receive(tr_RANAP_RabAssReq(?)) -> value ranap { var RAB_ID rab_id := f_ranap_rab_ass_req_extract_rab_id(ranap); - /*TODO: validate received remote IP addr + TEID = apars.ggsn_ip_u + apars.ggsn_tei_u */ + var TransportLayerInformation tli := f_ranap_rab_ass_req_extract_tli(ranap); + + /* Validate received IP address + TEID from SGSN is the one we + * did set up from the GGSN, since the SGSN is expected to do + * Direct Tunnel: */ + var template (present) TransportLayerInformation exp_tli := + tr_TLI_ps(oct2bit(enc_NSAP_Address(valueof(ts_NSAP_Address_IANA_BIN_IPv4Len20(apars.ggsn_ip_u)))), + apars.ggsn_tei_u); + if (not match(tli, exp_tli)) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Rx RAB Ass Req with TLI ", tli, " vs exp ", exp_tli)); + } var template (value) RAB_SetupOrModifiedList l; l := ts_RAB_SMdL_ps(rab_id, oct2bit(apars.rnc_ip_u), apars.rnc_tei_u); BSSAP.send(ts_RANAP_RabAssResp(l)); diff --git a/sgsn/gen_links.sh b/sgsn/gen_links.sh index 8df1a87..2e5d9f9 100755 --- a/sgsn/gen_links.sh +++ b/sgsn/gen_links.sh @@ -89,6 +89,7 @@ FILES+="Osmocom_CTRL_Types.ttcn Osmocom_CTRL_Functions.ttcn Osmocom_CTRL_Adapter.ttcn " FILES+="Osmocom_VTY_Functions.ttcn " FILES+="LLC_Templates.ttcn L3_Templates.ttcn L3_Common.ttcn " +FILES+="ITU_X213_Types.ttcn " FILES+="RAN_Emulation.ttcnpp RAN_Adapter.ttcnpp SCCP_Templates.ttcn " # IPA_Emulation + dependencies FILES+="IPA_Types.ttcn IPA_Emulation.ttcnpp IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc Native_Functions.ttcn Native_FunctionDefs.cc " -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38433?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3a3699cea981caa89b30742c031d5f232418b0ee Gerrit-Change-Number: 38433 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-hlr[master]: debian/copyright: add gsup_client under GPLv2+
by laforge 15 Oct '24

15 Oct '24

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38423?usp=email ) Change subject: debian/copyright: add gsup_client under GPLv2+ ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Idddcd6356af76987bf57ecd21096299cb2ba896f Gerrit-Change-Number: 38423 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Oct 2024 12:07:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-hlr[master]: gsupclient: Introduce gsup_client_mux
by laforge 15 Oct '24

15 Oct '24

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-hlr/+/38112?usp=email ) Change subject: gsupclient: Introduce gsup_client_mux ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/38112?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I916c1bb6cfc48f92fc5db2b5c914eb1b4e25fa7f Gerrit-Change-Number: 38112 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Oct 2024 12:07:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: jobs: Move ttcn3-stp-test* to use testenv
by laforge 15 Oct '24

15 Oct '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ci/+/38432?usp=email ) Change subject: jobs: Move ttcn3-stp-test* to use testenv ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38432?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ifdee05395c4c80a3c9cb60828c268bcbb8f430a8 Gerrit-Change-Number: 38432 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Oct 2024 12:07:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo_dia2gsup[master]: fixup: diameter: fix unused macro param in ?SERVICE
by laforge 15 Oct '24

15 Oct '24

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38427?usp=email ) Change subject: fixup: diameter: fix unused macro param in ?SERVICE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38427?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I52a59f3eaf9784352ad971961c2e31bf5ff9ba90 Gerrit-Change-Number: 38427 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Oct 2024 12:06:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: jobs: Move ttcn3-stp-test* to use testenv
by pespin 15 Oct '24

15 Oct '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/38432?usp=email ) Change subject: jobs: Move ttcn3-stp-test* to use testenv ...................................................................... jobs: Move ttcn3-stp-test* to use testenv Depends: osmo-ttcn3-hacks.git e85c0c3069f03068d7187bf971a3e4139f5c4bd0 Change-Id: Ifdee05395c4c80a3c9cb60828c268bcbb8f430a8 --- M jobs/ttcn3-testsuites-testenv.yml M jobs/ttcn3-testsuites.yml 2 files changed, 20 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/32/38432/1 diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index 83ad078..ed7e07c 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -60,6 +60,11 @@ args: -b osmocom:nightly timer: H 06 * * * + - ttcn3-stp-test: + testsuite: stp + args: -b osmocom:nightly + timer: H 06 * * * + - ttcn3-hnodeb-test: testsuite: hnodeb args: -b osmocom:nightly @@ -164,6 +169,11 @@ args: -b osmocom:latest timer: H 09 * * * + - ttcn3-stp-test-latest: + testsuite: stp + args: -b osmocom:latest + timer: H 09 * * * + - ttcn3-hnodeb-test-latest: testsuite: hnodeb args: -b osmocom:latest @@ -216,6 +226,11 @@ args: -b osmocom:nightly --io-uring -c generic timer: H 11 * * * + - ttcn3-stp-test-io_uring: + testsuite: stp + args: -b osmocom:nightly --io-uring -c generic + timer: H 11 * * * + # --------------------------------------------- # Debian nightly + asan (OS#5301) # --------------------------------------------- @@ -259,6 +274,11 @@ args: -b osmocom:nightly:asan -c 'osmo_ggsn_*' timer: H 12 * * * + - ttcn3-stp-test-asan: + testsuite: stp + args: -b osmocom:nightly:asan + timer: H 13 * * * + - job-template: name: '{job-name}' project-type: freestyle diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 55eb9aa..13e36a0 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -41,8 +41,6 @@ timer: H 05 * * * - ttcn3-remsim-test: timer: H 05 * * * - - ttcn3-stp-test: - timer: H 06 * * * - ttcn3-sccp-test: timer: H 06 * * * - ttcn3-gbproxy-test: @@ -102,8 +100,6 @@ timer: H 09 * * * - ttcn3-remsim-test-latest: timer: H 09 * * * - - ttcn3-stp-test-latest: - timer: H 09 * * * - ttcn3-sccp-test-latest: timer: H 09 * * * - ttcn3-gbproxy-test-latest: @@ -140,8 +136,6 @@ timer: H 11 * * * - ttcn3-gbproxy-test-io_uring: timer: H 11 * * * - - ttcn3-stp-test-io_uring: - timer: H 11 * * * - ttcn3-bts-test-io_uring: timer: H 11 * * * @@ -164,8 +158,6 @@ timer: H 13 * * * - ttcn3-sccp-test-asan: timer: H 13 * * * - - ttcn3-stp-test-asan: - timer: H 13 * * * - job-template: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38432?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ifdee05395c4c80a3c9cb60828c268bcbb8f430a8 Gerrit-Change-Number: 38432 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-msc[master]: vlr: add functions for vlr_is_cs() vlr_is_ps()
by lynxis lazus 15 Oct '24

15 Oct '24

Attention is currently required from: lynxis lazus, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/38405?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: vlr: add functions for vlr_is_cs() vlr_is_ps() ...................................................................... vlr: add functions for vlr_is_cs() vlr_is_ps() Make the code more readable when checking for cs or ps. Change-Id: I88810f3703813e98be8a37d0445ad641b0cac11d --- M include/osmocom/vlr/vlr.h 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/05/38405/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38405?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I88810f3703813e98be8a37d0445ad641b0cac11d Gerrit-Change-Number: 38405 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-msc[master]: vlr: add a logging layer
by lynxis lazus 15 Oct '24

15 Oct '24

Attention is currently required from: lynxis lazus, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/38410?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review-1 by pespin, Verified-1 by Jenkins Builder Change subject: vlr: add a logging layer ...................................................................... vlr: add a logging layer To prepare the split off into a separate library, the logging can't use log category from a define. Use the same strategy as all the other osmo libraries and use a global array which is set on initialisation to define the logging categories. Change-Id: I6d87b38d6d7d704c7c7b2c90ad12187e4b953b8b --- M include/osmocom/vlr/vlr.h M src/libmsc/gsm_04_08.c M src/libmsc/msc_net_init.c M src/libvlr/vlr.c M src/libvlr/vlr_access_req_fsm.c M src/libvlr/vlr_access_req_fsm.h M src/libvlr/vlr_auth_fsm.c M src/libvlr/vlr_core.h M src/libvlr/vlr_lu_fsm.c M src/libvlr/vlr_lu_fsm.h M src/libvlr/vlr_sgs.c M src/libvlr/vlr_sgs_fsm.c M src/libvlr/vlr_sgs_fsm.h 13 files changed, 110 insertions(+), 44 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/10/38410/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6d87b38d6d7d704c7c7b2c90ad12187e4b953b8b Gerrit-Change-Number: 38410 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in ...osmo_dia2gsup[master]: diameter: assert that diameter:start_service/2 returns ok
by lynxis lazus 15 Oct '24

15 Oct '24

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38428?usp=email ) Change subject: diameter: assert that diameter:start_service/2 returns ok ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: b Commit Message: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38428/comment/01b5c6bb_… : PS1, Line 11: Can you use add Fixes: tag like the linux kernel is using? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ief13353d280e3eb80a25b5c9a9effdf537bcc704 Gerrit-Change-Number: 38428 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Oct 2024 03:16:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in ...osmo_dia2gsup[master]: diameter: assert that diameter:start_service/2 returns ok
by pespin 15 Oct '24

15 Oct '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38428?usp=email ) Change subject: diameter: assert that diameter:start_service/2 returns ok ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/38428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ief13353d280e3eb80a25b5c9a9effdf537bcc704 Gerrit-Change-Number: 38428 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Oct 2024 21:51:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0