October 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-upf[master]: pfcp-tool: n-sessions [3/4]: add poll arg to pfcp_tool_mainloop()
by osmith 24 Oct '24

24 Oct '24

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/37759?usp=email ) Change subject: pfcp-tool: n-sessions [3/4]: add poll arg to pfcp_tool_mainloop() ...................................................................... Abandoned (SYS#7165) abandoning as pfcp-tool now lives in upf-benchmark.git -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37759?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I20bb2803b28681face18ee665d8a1aad06d58091 Gerrit-Change-Number: 37759 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-upf[master]: pfcp-tool: n-sessions [2/4]: generalize function args
by osmith 24 Oct '24

24 Oct '24

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/37758?usp=email ) Change subject: pfcp-tool: n-sessions [2/4]: generalize function args ...................................................................... Abandoned (SYS#7165) abandoning as pfcp-tool now lives in upf-benchmark.git -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37758?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I112206049e704b7adad7072b1f7953f7ee4f18ca Gerrit-Change-Number: 37758 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-msc[master]: Release BSS connection when CC transaction fails
by pespin 24 Oct '24

24 Oct '24

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38513?usp=email ) Change subject: Release BSS connection when CC transaction fails ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I guess this is more like an hypotetical case since it's not possible in practice that transaction allocation fails? Or has this been triggered somewhere? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38513?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icb893d5c1ce4c77a29259ce66189576dcaa5a44a Gerrit-Change-Number: 38513 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 24 Oct 2024 11:17:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-upf[master]: pfcp-tool: always use specific PDR ids for access and core
by osmith 24 Oct '24

24 Oct '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/37756?usp=email ) Change subject: pfcp-tool: always use specific PDR ids for access and core ...................................................................... pfcp-tool: always use specific PDR ids for access and core Makes it easier to find the right one later. This will be used to fetch the UPF chosen TEIDs from PFCP responses in upcoming "n-sessions [4/4]" I74a21cc31296ab89a2acda1da8ae9693c1992e66. Related: SYS#6590 Change-Id: Ic343494001c70a84f3402ce5749d08e729551b26 --- M src/osmo-pfcp-tool/pfcp_tool_vty.c 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve neels: Looks good to me, but someone else must approve diff --git a/src/osmo-pfcp-tool/pfcp_tool_vty.c b/src/osmo-pfcp-tool/pfcp_tool_vty.c index f0a46f4..7f68ccf 100644 --- a/src/osmo-pfcp-tool/pfcp_tool_vty.c +++ b/src/osmo-pfcp-tool/pfcp_tool_vty.c @@ -397,6 +397,11 @@ return CMD_SUCCESS; } +enum pdr_id_fixed { + PDR_ID_CORE = 1, + PDR_ID_ACCESS = 2, +}; + int session_tunend_tx_est_req(struct vty *vty, const char **argv, int argc) { struct pfcp_tool_session *session = vty->index; @@ -475,7 +480,7 @@ .create_pdr_count = 2, .create_pdr = { { - .pdr_id = 1, + .pdr_id = PDR_ID_CORE, .precedence = 255, .pdi = { .source_iface = OSMO_PFCP_SOURCE_IFACE_CORE, @@ -492,7 +497,7 @@ .far_id = 1, }, { - .pdr_id = 2, + .pdr_id = PDR_ID_ACCESS, .precedence = 255, .pdi = { .source_iface = OSMO_PFCP_SOURCE_IFACE_ACCESS, @@ -635,7 +640,7 @@ .create_pdr_count = 2, .create_pdr = { { - .pdr_id = 1, + .pdr_id = PDR_ID_CORE, .precedence = 255, .pdi = { .source_iface = OSMO_PFCP_SOURCE_IFACE_CORE, @@ -650,7 +655,7 @@ .far_id = 1, }, { - .pdr_id = 2, + .pdr_id = PDR_ID_ACCESS, .precedence = 255, .pdi = { .source_iface = OSMO_PFCP_SOURCE_IFACE_ACCESS, -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37756?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic343494001c70a84f3402ce5749d08e729551b26 Gerrit-Change-Number: 37756 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-msc[master]: Release BSS connection when CC transaction fails
by pespin 24 Oct '24

24 Oct '24

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38513?usp=email ) Change subject: Release BSS connection when CC transaction fails ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I guess this is more like an hypotetical case since it's not possible in practice that transaction allocation fails? Or has this been triggered somewhere? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38513?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icb893d5c1ce4c77a29259ce66189576dcaa5a44a Gerrit-Change-Number: 38513 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 24 Oct 2024 11:16:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-upf[master]: pfcp-tool: n-sessions [1/4]: add generators for TEID and UE IP
by osmith 24 Oct '24

24 Oct '24

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/37757?usp=email ) Change subject: pfcp-tool: n-sessions [1/4]: add generators for TEID and UE IP ...................................................................... Abandoned (SYS#7165) abandoning as pfcp-tool now lives in upf-benchmark.git -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37757?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Iec164a222782d382aefe8d0342f398ebba1eac05 Gerrit-Change-Number: 37757 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-msc[master]: csd_bs: fix setting of Rate Adaptation for FAX and 3.1 kHz audio
by pespin 24 Oct '24

24 Oct '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/38512?usp=email ) Change subject: csd_bs: fix setting of Rate Adaptation for FAX and 3.1 kHz audio ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38512?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3d608f412859df8988ce7a51aaef65949c80865b Gerrit-Change-Number: 38512 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Oct 2024 11:14:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-msc[master]: csd_bs: do not hard-code GSM48_BCAP_ITCAP_UNR_DIG_INF
by pespin 24 Oct '24

24 Oct '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/38511?usp=email ) Change subject: csd_bs: do not hard-code GSM48_BCAP_ITCAP_UNR_DIG_INF ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38511?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibfb9f0097ca86092320cebed13a7a642080370f1 Gerrit-Change-Number: 38511 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Oct 2024 11:14:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-msc[master]: csd_bs: cosmetic changes to csd_bs_list_to_bearer_cap()
by pespin 24 Oct '24

24 Oct '24

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/38510?usp=email ) Change subject: csd_bs: cosmetic changes to csd_bs_list_to_bearer_cap() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/38510/comment/ba18ef04_6a971676?usp… : PS1, Line 7: csd_bs: cosmetic changes to csd_bs_list_to_bearer_cap() I would avoid the use of "cosmetic" in this patch, since it's really changing the output binary most probably. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38510?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I101f55dfbd0d327269fcce76031a2db265ca2eb9 Gerrit-Change-Number: 38510 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Oct 2024 11:13:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ggsn[master]: ggsn: Rename confusing functions
by pespin 24 Oct '24

24 Oct '24

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/38506?usp=email ) Change subject: ggsn: Rename confusing functions ...................................................................... ggsn: Rename confusing functions It's really confusing having a function operating on a rx path called "encaps" since it's not really encapsulating anything. This confuses the reader by thinking this is the function encapsulating packets into GTP-U. Change-Id: I7ff54f5e57ccc2c436becd1be1b0f728cbcdb12c --- M ggsn/ggsn.c M sgsnemu/sgsnemu.c 2 files changed, 16 insertions(+), 13 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c index a02b97f..6b51bbc 100644 --- a/ggsn/ggsn.c +++ b/ggsn/ggsn.c @@ -667,7 +667,8 @@ return rc; } -/* Internet-originated IP packet, needs to be sent via GTP towards MS */ +/* Rx Internet-originated IP packet from our tun iface, needs to be sent via + * GTPU towards MS. */ static int cb_tun_ind(struct tun_t *tun, void *pack, unsigned len) { struct apn_ctx *apn = tun->priv; @@ -747,8 +748,10 @@ return 0; } -/* MS-originated GTP1-U packet, needs to be sent via TUN device */ -static int encaps_tun(struct pdp_t *pdp, void *pack, unsigned len) +/* Rx MS-originated GTP-U packet, needs to be sent via TUN device. + * "pack" contains the GTP-U payload once decapsulated from GTP-U by libgtp. + * Hence, "pack" should contain an IP packet. */ +static int cb_gtpu_data_ind(struct pdp_t *pdp, void *pack, unsigned len) { struct iphdr *iph = (struct iphdr *)pack; struct ip6_hdr *ip6h = (struct ip6_hdr *)pack; @@ -963,7 +966,7 @@ rc = osmo_fd_register(&ggsn->gtp_fd1u); OSMO_ASSERT(rc == 0); - gtp_set_cb_data_ind(ggsn->gsn, encaps_tun); + gtp_set_cb_data_ind(ggsn->gsn, cb_gtpu_data_ind); gtp_set_cb_create_context_ind(ggsn->gsn, create_context_ind); gtp_set_cb_update_context_ind(ggsn->gsn, update_context_ind); gtp_set_cb_delete_context(ggsn->gsn, delete_context); diff --git a/sgsnemu/sgsnemu.c b/sgsnemu/sgsnemu.c index 9ab0f25..c592aa9 100644 --- a/sgsnemu/sgsnemu.c +++ b/sgsnemu/sgsnemu.c @@ -1196,7 +1196,7 @@ return 0; } -static int encaps_ping4(struct pdp_t *pdp, void *pack, unsigned len) +static int cb_gtpu_data_ind_ping4(struct pdp_t *pdp, void *pack, unsigned len) { struct timeval tv; struct timeval *tp; @@ -1258,7 +1258,7 @@ return 0; } -static int encaps_ping6(struct pdp_t *pdp, struct ip6_hdr *ip6h, unsigned len) +static int cb_gtpu_data_ind_ping6(struct pdp_t *pdp, struct ip6_hdr *ip6h, unsigned len) { const struct icmpv6_echo_hdr *ic6h = (struct icmpv6_echo_hdr *) ((uint8_t*)ip6h + sizeof(*ip6h)); struct timeval tv; @@ -1325,7 +1325,7 @@ } /* Handle a received ping packet. Print out line and update statistics. */ -static int encaps_ping(struct pdp_t *pdp, void *pack, unsigned len) +static int cb_gtpu_data_ind_ping(struct pdp_t *pdp, void *pack, unsigned len) { struct iphdr *iph = (struct iphdr *)pack; struct timeval tv; @@ -1343,9 +1343,9 @@ } switch(iph->version) { case 4: - return encaps_ping4(pdp, pack, len); + return cb_gtpu_data_ind_ping4(pdp, pack, len); case 6: - return encaps_ping6(pdp, (struct ip6_hdr *)pack, len); + return cb_gtpu_data_ind_ping6(pdp, (struct ip6_hdr *)pack, len); default: SYS_ERR(DSGSN, LOGL_ERROR, 0, "Unknown ip header version %d", iph->version); return -1; @@ -1812,7 +1812,7 @@ } } -static int encaps_tun(struct pdp_t *pdp, void *pack, unsigned len) +static int cb_gtpu_data_ind(struct pdp_t *pdp, void *pack, unsigned len) { struct iphdr *iph = (struct iphdr *)pack; struct icmpv6_radv_hdr *ra; @@ -1826,7 +1826,7 @@ break; } - /* printf("encaps_tun. Packet received: forwarding to tun\n"); */ + /* printf("cb_gtpu_data_ind. Packet received: forwarding to tun\n"); */ return tun_encaps((struct tun_t *)pdp->ipif, pack, len); } @@ -1883,9 +1883,9 @@ gtp_set_cb_delete_context(gsn, delete_context); gtp_set_cb_conf(gsn, _gtp_cb_conf); if (options.createif) - gtp_set_cb_data_ind(gsn, encaps_tun); + gtp_set_cb_data_ind(gsn, cb_gtpu_data_ind); else - gtp_set_cb_data_ind(gsn, encaps_ping); + gtp_set_cb_data_ind(gsn, cb_gtpu_data_ind_ping); #if defined(__linux__) if ((options.createif) && (options.netns)) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/38506?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I7ff54f5e57ccc2c436becd1be1b0f728cbcdb12c Gerrit-Change-Number: 38506 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0