October 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: bsc/osmo-stp.cfg: sync with docker-playground
by osmith 24 Oct '24

24 Oct '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38518?usp=email ) Change subject: bsc/osmo-stp.cfg: sync with docker-playground ...................................................................... bsc/osmo-stp.cfg: sync with docker-playground Change-Id: I32fc1374d92405d642027e0c61fdd6a297cd7807 --- M bsc/osmo-stp.cfg 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/bsc/osmo-stp.cfg b/bsc/osmo-stp.cfg index d936d4f..3d47bba 100644 --- a/bsc/osmo-stp.cfg +++ b/bsc/osmo-stp.cfg @@ -56,6 +56,8 @@ asp virt-smlc-0 23908 2905 m3ua local-ip 127.0.0.1 remote-ip 127.0.0.1 + role sg + sctp-role server as virt-smlc m3ua asp virt-smlc-0 routing-key 6 0.23.6 @@ -67,5 +69,7 @@ update route 0.23.6 7.255.7 linkset virt-smlc listen m3ua 2905 accept-asp-connections dynamic-permitted + local-ip 127.0.0.1 listen ipa 5000 accept-asp-connections dynamic-permitted + local-ip 127.0.0.1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38518?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I32fc1374d92405d642027e0c61fdd6a297cd7807 Gerrit-Change-Number: 38518 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: bsc: add testenv.cfg
by osmith 24 Oct '24

24 Oct '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38519?usp=email ) Change subject: bsc: add testenv.cfg ...................................................................... bsc: add testenv.cfg Change-Id: Ib2e92a9ebd78f5553161bcca433f39c7c39f3adf --- A bsc/osmo_bts_omldummy.sh A bsc/testenv_generic.cfg A bsc/testenv_sccplite.cfg A bsc/testenv_vamos.cfg 4 files changed, 112 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/osmo_bts_omldummy.sh b/bsc/osmo_bts_omldummy.sh new file mode 100755 index 0000000..611f750 --- /dev/null +++ b/bsc/osmo_bts_omldummy.sh @@ -0,0 +1,25 @@ +#!/bin/sh -ex +CONFIG="$1" +SITE_ID="$2" +TRX_NUM="$3" + +case "$CONFIG" in + generic|sccplite) + BTS_FEATURES="-fCCN,EGPRS,GPRS,IPv6_NSVC,PAGING_COORDINATION,OSMUX" + ;; + vamos) + BTS_FEATURES="-fCCN,EGPRS,GPRS,IPv6_NSVC,PAGING_COORDINATION,VAMOS,OSMUX" + ;; + *) + set +x + echo "ERROR: unknown CONFIG=$1" + exit 1 + ;; +esac + +respawn.sh \ + osmo-bts-omldummy \ + "$BTS_FEATURES" \ + "127.0.0.1" \ + "$SITE_ID" \ + "$TRX_NUM" diff --git a/bsc/testenv_generic.cfg b/bsc/testenv_generic.cfg new file mode 100644 index 0000000..d453f55 --- /dev/null +++ b/bsc/testenv_generic.cfg @@ -0,0 +1,31 @@ +[testsuite] +program=BSC_Tests +config=BSC_Tests.cfg + +[stp] +program=osmo-stp +make=libosmo-sigtran +package=osmo-stp +copy=osmo-stp.cfg + +[bts-0] +program=osmo_bts_omldummy.sh generic 1234 1 +make=osmo-bts +package=osmo-bts-virtual + +[bts-1] +program=osmo_bts_omldummy.sh generic 1235 1 +make=osmo-bts +package=osmo-bts-virtual + +[bts-2] +program=osmo_bts_omldummy.sh generic 1236 4 +make=osmo-bts +package=osmo-bts-virtual + +[bsc] +program=osmo-bsc +make=osmo-bsc +package=osmo-bsc +copy=osmo-bsc.cfg +vty_port=4242 diff --git a/bsc/testenv_sccplite.cfg b/bsc/testenv_sccplite.cfg new file mode 100644 index 0000000..5d64467 --- /dev/null +++ b/bsc/testenv_sccplite.cfg @@ -0,0 +1,25 @@ +[testsuite] +program=BSC_Tests +config=BSC_Tests_SCCPlite.cfg + +[bts-0] +program=osmo_bts_omldummy.sh sccplite 1234 1 +make=osmo-bts +package=osmo-bts-virtual + +[bts-1] +program=osmo_bts_omldummy.sh sccplite 1235 1 +make=osmo-bts +package=osmo-bts-virtual + +[bts-2] +program=osmo_bts_omldummy.sh sccplite 1236 4 +make=osmo-bts +package=osmo-bts-virtual + +[bsc] +program=osmo-bsc -c osmo-bsc-sccplite.cfg +make=osmo-bsc +package=osmo-bsc +copy=osmo-bsc-sccplite.cfg +vty_port=4242 diff --git a/bsc/testenv_vamos.cfg b/bsc/testenv_vamos.cfg new file mode 100644 index 0000000..51f309f --- /dev/null +++ b/bsc/testenv_vamos.cfg @@ -0,0 +1,31 @@ +[testsuite] +program=BSC_Tests +config=BSC_Tests_VAMOS.cfg + +[stp] +program=osmo-stp +make=libosmo-sigtran +package=osmo-stp +copy=osmo-stp.cfg + +[bts-0] +program=osmo_bts_omldummy.sh vamos 1234 1 +make=osmo-bts +package=osmo-bts-virtual + +[bts-1] +program=osmo_bts_omldummy.sh vamos 1235 1 +make=osmo-bts +package=osmo-bts-virtual + +[bts-2] +program=osmo_bts_omldummy.sh vamos 1236 1 +make=osmo-bts +package=osmo-bts-virtual + +[bsc] +program=osmo-bsc -c osmo-bsc-vamos.cfg +make=osmo-bsc +package=osmo-bsc +copy=osmo-bsc-vamos.cfg +vty_port=4242 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38519?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib2e92a9ebd78f5553161bcca433f39c7c39f3adf Gerrit-Change-Number: 38519 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: test for RUA Disconnect when there is no CN
by pespin 24 Oct '24

24 Oct '24

Attention is currently required from: laforge, neels, osmith. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37809?usp=email ) Change subject: hnbgw: test for RUA Disconnect when there is no CN ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2b5c024a395e736538c0c37db40d34f3b8d99991 Gerrit-Change-Number: 37809 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 24 Oct 2024 13:27:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: ctrl: tweak errmsg for counter mismatch
by osmith 24 Oct '24

24 Oct '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37883?usp=email ) Change subject: ctrl: tweak errmsg for counter mismatch ...................................................................... ctrl: tweak errmsg for counter mismatch - instead of "-1", print "not present", so humans know what is happening. - the comma separated args in setverdict() create a lot of weird quotes. Use string concatenation to have only one set of quotes around the entire error message. Related: OS#6545 Tweaked-by: Oliver Smith <osmith(a)sysmocom.de> Change-Id: I672fcef819a6542a5b3bcfa0a6d9c84d34b468f3 --- M library/Osmocom_CTRL_Functions.ttcn 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/library/Osmocom_CTRL_Functions.ttcn b/library/Osmocom_CTRL_Functions.ttcn index f8788b9..cf19f7e 100644 --- a/library/Osmocom_CTRL_Functions.ttcn +++ b/library/Osmocom_CTRL_Functions.ttcn @@ -295,6 +295,14 @@ f_counter_name_vals_set(vals[instance_nr], countername, val); } + private function f_counter_val_to_str(integer val) return charstring + { + if (val < 0) { + return "not present"; + } + return int2str(val); + } + /* For a specific instance, call f_counter_name_vals_get() and compare with expected counter values. * Set the test verdict accordingly. */ function f_counter_name_vals_expect(IPA_CTRL_PT pt, charstring instance_name, integer instance_nr, @@ -305,8 +313,9 @@ setverdict(fail, "Internal error"); } if (last[i].val != vals[i].val) { - setverdict(fail, "Rate counter mismatch: ", instance_name, " ", instance_nr, - " ", vals[i].name, " is at ", last[i].val, " but expected ", vals[i].val); + setverdict(fail, "Rate counter mismatch: " & instance_name & " " & int2str(instance_nr) + & " " & vals[i].name & " is " & f_counter_val_to_str(last[i].val) + & " but expected " & f_counter_val_to_str(vals[i].val)); } } setverdict(pass); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37883?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I672fcef819a6542a5b3bcfa0a6d9c84d34b468f3 Gerrit-Change-Number: 37883 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-hnbgw[master]: on RUA DT for unknown context, respond with RUA Disconnect
by pespin 24 Oct '24

24 Oct '24

Attention is currently required from: laforge, neels, osmith. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37808?usp=email ) Change subject: on RUA DT for unknown context, respond with RUA Disconnect ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37808?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If0b9a999649c9822f55b42b0cae8408af668e1b8 Gerrit-Change-Number: 37808 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 24 Oct 2024 13:26:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-hnbgw[master]: on RUA Connect failure, respond with RUA Disconnect
by pespin 24 Oct '24

24 Oct '24

Attention is currently required from: laforge, neels, osmith. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37807?usp=email ) Change subject: on RUA Connect failure, respond with RUA Disconnect ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iafb30c31a4c5db53ecdda99a0e0b5937b71e362c Gerrit-Change-Number: 37807 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 24 Oct 2024 13:25:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: improve output for missing -c argument
by fixeria 24 Oct '24

24 Oct '24

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38520?usp=email ) Change subject: testenv: improve output for missing -c argument ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3f273caff702b33d3d74a9e5c8d77b22f27d7cfc Gerrit-Change-Number: 38520 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Oct 2024 13:12:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: bsc: add testenv.cfg
by fixeria 24 Oct '24

24 Oct '24

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38519?usp=email ) Change subject: bsc: add testenv.cfg ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38519?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib2e92a9ebd78f5553161bcca433f39c7c39f3adf Gerrit-Change-Number: 38519 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Oct 2024 13:11:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bsc/osmo-stp.cfg: sync with docker-playground
by fixeria 24 Oct '24

24 Oct '24

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38518?usp=email ) Change subject: bsc/osmo-stp.cfg: sync with docker-playground ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38518?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I32fc1374d92405d642027e0c61fdd6a297cd7807 Gerrit-Change-Number: 38518 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Oct 2024 13:10:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bsc/osmo-bsc{,-vamos}.cfg: add no missing-msc-text
by fixeria 24 Oct '24

24 Oct '24

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38517?usp=email ) Change subject: bsc/osmo-bsc{,-vamos}.cfg: add no missing-msc-text ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38517?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0735e5bce207961ab960294c9f39404ab64a3fb1 Gerrit-Change-Number: 38517 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Oct 2024 13:10:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0