pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/38510?usp=email )
Change subject: csd_bs: cosmetic changes to csd_bs_list_to_bearer_cap()
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/38510/comment/ceab0400_3e528fa0?usp… :
PS1, Line 7: csd_bs: cosmetic changes to csd_bs_list_to_bearer_cap()
> It does not change the way this function behaves though. […]
You are doing at least 2 changes which change the logic and potentially change the instruction set on the output binary:
* Allocating a var in the stack every loop iteration
* Marking the variable as const
So it's not really about changing a typo in a comment or changing the name of a variable.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38510?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I101f55dfbd0d327269fcce76031a2db265ca2eb9
Gerrit-Change-Number: 38510
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 24 Oct 2024 13:31:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, jolly.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38514?usp=email )
Change subject: Indicate error and release BSS connection when SMS transaction fails
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> Is there any ttcn3 test covering this scenario?
This was not yet answered. Sounds like it would be great to have ttcn3 tests covering this kind of scenario, since also fixeria provided some concerns about potential problems.
I'm not saying it's a must, just raising the topic.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38514?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I82da9c283205c69b19ceb4ba40ac5aa7f37d159b
Gerrit-Change-Number: 38514
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 24 Oct 2024 13:29:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38520?usp=email )
Change subject: testenv: improve output for missing -c argument
......................................................................
testenv: improve output for missing -c argument
When a testsuite has multiple testenv.cfg files, the user needs to
explicitly choose a config, or "-c all" for all configs. Improve the
help output to directly print the arguments that need to be passed,
instead of printing the config file names. Mention that wildcards can be
used too.
Old:
[testenv] Found multiple testenv.cfg files:
[testenv] * testenv_generic.cfg
[testenv] * testenv_sccplite.cfg
[testenv] * testenv_vamos.cfg
[testenv] Select a specific config (e.g. '-c generic') or all ('-c all')
New:
[testenv] Found multiple testenv.cfg files, use one of:
[testenv] -c generic
[testenv] -c sccplite
[testenv] -c vamos
[testenv] You can also select all of them (-c all) or use the * character as wildcard.
Related: OS#6494
Change-Id: I3f273caff702b33d3d74a9e5c8d77b22f27d7cfc
---
M _testenv/testenv/testenv_cfg.py
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/_testenv/testenv/testenv_cfg.py b/_testenv/testenv/testenv_cfg.py
index 8bb4119..ea25614 100644
--- a/_testenv/testenv/testenv_cfg.py
+++ b/_testenv/testenv/testenv_cfg.py
@@ -209,11 +209,10 @@
sys.exit(1)
if len(ret) > 1 and not testenv.args.config:
- logging.error("Found multiple testenv.cfg files:")
+ logging.error("Found multiple testenv.cfg files, use one of:")
for path in ret:
- logging.error(f" * {os.path.basename(path)}")
- example = os.path.basename(ret[0]).split("_", 1)[1].split(".cfg", 1)[0]
- logging.error(f"Select a specific config (e.g. '-c {example}') or all ('-c all')")
+ logging.error(f" -c {os.path.basename(path).replace('testenv_', '', 1).replace('.cfg', '')}")
+ logging.error("You can also select all of them (-c all) or use the * character as wildcard.")
sys.exit(1)
return ret
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38520?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3f273caff702b33d3d74a9e5c8d77b22f27d7cfc
Gerrit-Change-Number: 38520
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38503?usp=email )
Change subject: testenv: qemu: get coredump and show backtrace
......................................................................
testenv: qemu: get coredump and show backtrace
If the SUT crashes inside QEMU, copy the coredump via 9p to the outer
system (either host or podman) where we have the same binaries and also
debug symbols, and run gdb there to show the backtrace.
Related: OS#6600
Change-Id: Ia08ac58c43388b5ea4d3712c5ef83f54b538b10a
---
M _testenv/data/scripts/qemu/qemu_functions.sh
M _testenv/data/scripts/qemu/qemu_init.sh
2 files changed, 21 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/_testenv/data/scripts/qemu/qemu_functions.sh b/_testenv/data/scripts/qemu/qemu_functions.sh
index c0dd8cc..e2014a1 100755
--- a/_testenv/data/scripts/qemu/qemu_functions.sh
+++ b/_testenv/data/scripts/qemu/qemu_functions.sh
@@ -1,5 +1,6 @@
#!/bin/sh -ex
INITRD_DIR="$PWD/_initrd"
+CORE_DIR="$PWD/_coredump"
# Add one or more files to the initramfs, with parent directories.
# usr-merge: resolve symlinks for /lib -> /usr/lib etc. so "cp --parents" does
@@ -171,6 +172,8 @@
machine_arg="-machine pc"
fi
+ mkdir -p "$CORE_DIR"
+
# sudo is required to set up networking in qemu_ifup.sh
# </dev/null to deatch stdin, so qemu doesn't capture ^C
sudo sh -c "
@@ -186,6 +189,13 @@
-serial stdio \
-netdev 'tap,id=nettest,script=$TESTENV_QEMU_SCRIPTS/qemu_ifup.sh' \
-device 'virtio-net-pci,netdev=nettest,mac=$(qemu_random_mac)' \
+ -virtfs 'local,path=$CORE_DIR,mount_tag=coredir,security_model=passthrough,fmode=666,writeout=immediate' \
</dev/null
"
+
+ # Show coredump backtrace
+ if [ -e "$CORE_DIR/coredump" ]; then
+ execfn="$(file "$CORE_DIR/coredump" | grep -o "execfn: '.*'" | cut -d "'" -f 2)"
+ gdb --batch "$execfn" "$CORE_DIR/coredump" -ex bt
+ fi
}
diff --git a/_testenv/data/scripts/qemu/qemu_init.sh b/_testenv/data/scripts/qemu/qemu_init.sh
index 1c8b39b..1c100f8 100755
--- a/_testenv/data/scripts/qemu/qemu_init.sh
+++ b/_testenv/data/scripts/qemu/qemu_init.sh
@@ -1,6 +1,7 @@
#!/bin/busybox sh
echo "Running initrd-init.sh"
set -ex
+COREDUMP=/tmp/coredump
export HOME=/root
export LD_LIBRARY_PATH=/usr/local/lib
@@ -27,10 +28,20 @@
ip link set lo up
ip link set eth0 up
+sysctl -w kernel.core_pattern="$COREDUMP"
+ulimit -c unlimited
+
echo "KERNEL_TEST_VM_IS_READY"
# Use '|| true' to avoid "attempting to kill init" kernel panic on failure
/cmd.sh || true
+if [ -e "$COREDUMP" ]; then
+ mkdir -p /mnt/coredir
+ mount -t 9p -o trans=virtio coredir /mnt/coredir -oversion=9p2000.L
+ chmod 666 "$COREDUMP"
+ cp "$COREDUMP" /mnt/coredir
+fi
+
# Avoid kernel panic when init exits
poweroff -f
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38503?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia08ac58c43388b5ea4d3712c5ef83f54b538b10a
Gerrit-Change-Number: 38503
Gerrit-PatchSet: 5
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>