Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email )
Change subject: trau/osmo_ortp: support building without OrtpMemoryFunctions API
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Same as libosmocore and talloc.
It's not the same situation, because again: libosmocore explicitly depends on libtalloc. Whatever ortp is using is the internal details of ortp: they may switch to some other library any day. And btw, bctoolbox is a relatively recent dependency, which was introduced since linphone.org started maintaining ortp. It was not the case for old ortp versions.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I9fe6299fde81faeab86cd6645d67edd2f41e1873
Gerrit-Change-Number: 35502
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Jan 2024 14:42:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/35503?usp=email )
Change subject: fix warnings about implicit declaration of strtol()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/35503?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libsmpp34
Gerrit-Branch: master
Gerrit-Change-Id: I16d9e0171d4c26f721c300e22c78b77f6db4895c
Gerrit-Change-Number: 35503
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Jan 2024 14:36:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email )
Change subject: trau/osmo_ortp: support building without OrtpMemoryFunctions API
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> This is indeed an option, but we don't depend on bctoolbox directly (it's a dependency of ortp itsel […]
include/ortp/port.h does publicly use lots of bctoolbox stuff and does "#include "bctoolbox/port.h"", so my understanding is that bctoolbox is a public dependency of ortp and hecne can also be used.
Same as libosmocore and talloc.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I9fe6299fde81faeab86cd6645d67edd2f41e1873
Gerrit-Change-Number: 35502
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Jan 2024 14:36:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: jolly, laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33317?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now.
Change subject: layer23: migrate away from deprecated gsm48_mi_to_string
......................................................................
Patch Set 4: -Code-Review
(1 comment)
Patchset:
PS4:
> did you test this manually using osmocombb against a network?
I gave this patch a try, and there is a little problem:
```
DRR NOTICE app_ccch_scan.c:285 Paging1: Normal paging chan any to tmsi M(TMSI-0xE8D0A894)
```
so now ccch_scan is printing the MI type twice. I will fix this.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33317?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ida67adaa61689c55505a89e1a1bebde041c91139
Gerrit-Change-Number: 33317
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 08 Jan 2024 14:31:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email )
Change subject: trau/osmo_ortp: support building without OrtpMemoryFunctions API
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Maybe use the new bctoolbox APIs if available instead of falling back to whatever is default?
This is indeed an option, but we don't depend on bctoolbox directly (it's a dependency of ortp itself), so I don't think we can use its API.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I9fe6299fde81faeab86cd6645d67edd2f41e1873
Gerrit-Change-Number: 35502
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Jan 2024 13:37:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email )
Change subject: trau/osmo_ortp: support building without OrtpMemoryFunctions API
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Maybe use the new bctoolbox APIs if available instead of falling back to whatever is default?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I9fe6299fde81faeab86cd6645d67edd2f41e1873
Gerrit-Change-Number: 35502
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Jan 2024 13:29:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/35499?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: pySim-shell: Update manual with examples for using with eUICC ISD-R
......................................................................
pySim-shell: Update manual with examples for using with eUICC ISD-R
Change-Id: I4a0acdad5c7478ee76f92c7610c0e2a5331dea46
---
M docs/shell.rst
1 file changed, 215 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/99/35499/3
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35499?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4a0acdad5c7478ee76f92c7610c0e2a5331dea46
Gerrit-Change-Number: 35499
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: dexter, fixeria, laforge, lynxis lazus.
Hello Jenkins Builder, dexter, fixeria, lynxis lazus,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/35461?usp=email
to look at the new patch set (#11).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Initial proof-of-concept SM-DP+ for GSMA consumer eSIM RSP
......................................................................
Initial proof-of-concept SM-DP+ for GSMA consumer eSIM RSP
This commit introduces
* the osmo-smdpp.py program implementing the main procedures and the
HTTP/REST based ES9+
* python modules for ES8+ and non-volatile RSP Session State storage
* the ASN.1 source files required to parse/encode RSP
* 3GPP test certificates from SGP.26
* an unsigned profile package (UPP) of a SAIP v2.3 TS48 test profile
As I couldn't get the 'Klein' tls support to work, the SM-DP+ code
currently does not support HTTPS/TLS but plan HTTP, so you either have
to modify your LPA to use HTTP instead of HTTPS, or put a TLS proxy in
front.
I have successfully installed an eSIM profile on a test eUICC that
contains certificate/key data within the test CI defined in GSMA SGP.26
Change-Id: I6232847432dc6920cd2bd08c84d7099c29ca1c11
---
A .checkpatch.conf
M docs/index.rst
A docs/osmo-smdpp.rst
A osmo-smdpp.py
M pySim/esim/__init__.py
A pySim/esim/asn1/rsp/PKIX1Explicit88.asn
A pySim/esim/asn1/rsp/PKIX1Implicit88.asn
A pySim/esim/asn1/rsp/rsp.asn
A pySim/esim/es8p.py
A pySim/esim/rsp.py
M requirements.txt
A smdpp-data/certs/CertificateIssuer/CERT_CI_ECDSA_BRP.der
A smdpp-data/certs/CertificateIssuer/CERT_CI_ECDSA_BRP.pem
A smdpp-data/certs/CertificateIssuer/CERT_CI_ECDSA_NIST.der
A smdpp-data/certs/CertificateIssuer/CERT_CI_ECDSA_NIST.pem
A smdpp-data/certs/CertificateIssuer/CI-csr.cnf
A smdpp-data/certs/DPauth/CERT_S_SM_DP2auth_ECDSA_BRP.der
A smdpp-data/certs/DPauth/CERT_S_SM_DP2auth_ECDSA_NIST.der
A smdpp-data/certs/DPauth/CERT_S_SM_DPauth_ECDSA_BRP.der
A smdpp-data/certs/DPauth/CERT_S_SM_DPauth_ECDSA_NIST.der
A smdpp-data/certs/DPauth/PK_S_SM_DP2auth_ECDSA_BRP.pem
A smdpp-data/certs/DPauth/PK_S_SM_DP2auth_ECDSA_NIST.pem
A smdpp-data/certs/DPauth/PK_S_SM_DPauth_ECDSA_BRP.pem
A smdpp-data/certs/DPauth/PK_S_SM_DPauth_ECDSA_NIST.pem
A smdpp-data/certs/DPauth/SK_S_SM_DP2auth_ECDSA_BRP.pem
A smdpp-data/certs/DPauth/SK_S_SM_DP2auth_ECDSA_NIST.pem
A smdpp-data/certs/DPauth/SK_S_SM_DPauth_ECDSA_BRP.pem
A smdpp-data/certs/DPauth/SK_S_SM_DPauth_ECDSA_NIST.pem
A smdpp-data/certs/DPauth/data_sig.der
A smdpp-data/certs/DPpb/CERT_S_SM_DP2pb_ECDSA_BRP.der
A smdpp-data/certs/DPpb/CERT_S_SM_DP2pb_ECDSA_NIST.der
A smdpp-data/certs/DPpb/CERT_S_SM_DPpb_ECDSA_BRP.der
A smdpp-data/certs/DPpb/CERT_S_SM_DPpb_ECDSA_NIST.der
A smdpp-data/certs/DPpb/PK_S_SM_DP2pb_ECDSA_BRP.pem
A smdpp-data/certs/DPpb/PK_S_SM_DP2pb_ECDSA_NIST.pem
A smdpp-data/certs/DPpb/PK_S_SM_DPpb_ECDSA_BRP.pem
A smdpp-data/certs/DPpb/PK_S_SM_DPpb_ECDSA_NIST.pem
A smdpp-data/certs/DPpb/SK_S_SM_DP2pb_ECDSA_BRP.pem
A smdpp-data/certs/DPpb/SK_S_SM_DP2pb_ECDSA_NIST.pem
A smdpp-data/certs/DPpb/SK_S_SM_DPpb_ECDSA_BRP.pem
A smdpp-data/certs/DPpb/SK_S_SM_DPpb_ECDSA_NIST.pem
A smdpp-data/certs/DPtls/CERT_S_SM_DP2_TLS.csr.cnf
A smdpp-data/certs/DPtls/CERT_S_SM_DP2_TLS.der
A smdpp-data/certs/DPtls/CERT_S_SM_DP2_TLS.ext.cnf
A smdpp-data/certs/DPtls/CERT_S_SM_DP4_TLS.csr.cnf
A smdpp-data/certs/DPtls/CERT_S_SM_DP4_TLS.der
A smdpp-data/certs/DPtls/CERT_S_SM_DP4_TLS.ext.cnf
A smdpp-data/certs/DPtls/CERT_S_SM_DP8_TLS.csr.cnf
A smdpp-data/certs/DPtls/CERT_S_SM_DP8_TLS.der
A smdpp-data/certs/DPtls/CERT_S_SM_DP8_TLS.ext.cnf
A smdpp-data/certs/DPtls/CERT_S_SM_DP_TLS.csr.cnf
A smdpp-data/certs/DPtls/CERT_S_SM_DP_TLS.ext.cnf
A smdpp-data/certs/DPtls/CERT_S_SM_DP_TLS_BRP.der
A smdpp-data/certs/DPtls/CERT_S_SM_DP_TLS_NIST.der
A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2021/CERT_S_SM_DP2_TLS.der
A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2021/CERT_S_SM_DP4_TLS.der
A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2021/CERT_S_SM_DP8_TLS.der
A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2021/CERT_S_SM_DP_TLS_BRP.der
A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2021/CERT_S_SM_DP_TLS_NIST.der
A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2022/CERT_S_SM_DP2_TLS.der
A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2022/CERT_S_SM_DP4_TLS.der
A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2022/CERT_S_SM_DP8_TLS.der
A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2022/CERT_S_SM_DP_TLS_BRP.der
A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2022/CERT_S_SM_DP_TLS_NIST.der
A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2023/CERT_S_SM_DP2_TLS.der
A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2023/CERT_S_SM_DP4_TLS.der
A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2023/CERT_S_SM_DP8_TLS.der
A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2023/CERT_S_SM_DP_TLS_BRP.der
A smdpp-data/certs/DPtls/Old_TLS_Validity/Expired 2023/CERT_S_SM_DP_TLS_NIST.der
A smdpp-data/certs/DPtls/PK_S_SM_DP2_TLS_NIST.pem
A smdpp-data/certs/DPtls/PK_S_SM_DP4_TLS.pem
A smdpp-data/certs/DPtls/PK_S_SM_DP8_TLS.pem
A smdpp-data/certs/DPtls/PK_S_SM_DP_TLS_BRP.pem
A smdpp-data/certs/DPtls/PK_S_SM_DP_TLS_NIST.pem
A smdpp-data/certs/DPtls/SK_S_SM_DP2_TLS_NIST.pem
A smdpp-data/certs/DPtls/SK_S_SM_DP4_TLS.pem
A smdpp-data/certs/DPtls/SK_S_SM_DP8_TLS.pem
A smdpp-data/certs/DPtls/SK_S_SM_DP_TLS_BRP.pem
A smdpp-data/certs/DPtls/SK_S_SM_DP_TLS_NIST.pem
A smdpp-data/certs/README
A smdpp-data/upp/TS48 V2 eSIM_GTP_SAIP2.1_NoBERTLV.rename2der
A smdpp-data/upp/TS48 V2 eSIM_GTP_SAIP2.3_NoBERTLV.rename2der
A tests/test_esim.py
M tests/test_esim_bsp.py
84 files changed, 3,189 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/61/35461/11
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35461?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6232847432dc6920cd2bd08c84d7099c29ca1c11
Gerrit-Change-Number: 35461
Gerrit-PatchSet: 11
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset