January 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmocom-bb[master]: layer23/mobile: use osmo_mobile_identity API
by fixeria 08 Jan '24

08 Jan '24

Attention is currently required from: fixeria, jolly, laforge, pespin. fixeria has uploaded a new patch set (#5) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33318?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by pespin, Code-Review+2 by laforge, Verified+1 by Jenkins Builder, Verified+1 by fixeria The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: layer23/mobile: use osmo_mobile_identity API ...................................................................... layer23/mobile: use osmo_mobile_identity API Migrate from deprecated gsm48_mi_to_string() API. Change-Id: Ib0d7f76cd635e8d1092ffc1d07ecb29ec0435dda Depends: libosmocore.git If4f7be606e54cfa1c59084cf169785b1cbda5cf5 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 31 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/18/33318/5 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33318?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib0d7f76cd635e8d1092ffc1d07ecb29ec0435dda Gerrit-Change-Number: 33318 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmocom-bb[master]: layer23/ccch_scan: use osmo_mobile_identity API
by fixeria 08 Jan '24

08 Jan '24

Attention is currently required from: jolly, laforge, pespin. fixeria has uploaded a new patch set (#5) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33317?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: layer23/ccch_scan: use osmo_mobile_identity API ...................................................................... layer23/ccch_scan: use osmo_mobile_identity API * Migrate from deprecated gsm48_mi_to_string() API. * Take a chance to unfify printing of mobile identity. * Use osmo_load32be() for printing TMSI - this is what the osmo_mobile_identity API does internally. Change-Id: Ida67adaa61689c55505a89e1a1bebde041c91139 Depends: libosmocore.git If4f7be606e54cfa1c59084cf169785b1cbda5cf5 --- M src/host/layer23/src/misc/app_ccch_scan.c 1 file changed, 49 insertions(+), 48 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/17/33317/5 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33317?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ida67adaa61689c55505a89e1a1bebde041c91139 Gerrit-Change-Number: 33317 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmocom-bb[master]: layer23: migrate away from gsm48_generate_mid_from_*
by fixeria 08 Jan '24

08 Jan '24

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33318?usp=email ) Change subject: layer23: migrate away from gsm48_generate_mid_from_* ...................................................................... Patch Set 4: Verified+1 Code-Review+1 (1 comment) Patchset: PS4: I gave this patch a spin in a test network and confirmed that paging works. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33318?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib0d7f76cd635e8d1092ffc1d07ecb29ec0435dda Gerrit-Change-Number: 33318 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 08 Jan 2024 15:32:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-abis[master]: trau/osmo_ortp: support building without OrtpMemoryFunctions API
by pespin 08 Jan '24

08 Jan '24

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email ) Change subject: trau/osmo_ortp: support building without OrtpMemoryFunctions API ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I am saying that for libosmo-abis, bcmtoolbox is not a direct (but indirect or implicit) dependency, pulled by ortp. If it's in the public header, imho it's not an indirect or implicit dependency, it's explicitly part of the ortp API. Otherwise it would be hidden in private headers or .c files. > This is why I don't think it's a good idea to use API of bcmtoolbox. Agree. > I am inclined to remove this talloc-to-ortp integration completely I don't have a strong opinion there, so as you wish. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I9fe6299fde81faeab86cd6645d67edd2f41e1873 Gerrit-Change-Number: 35502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Jan 2024 15:11:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-abis[master]: trau/osmo_ortp: support building without OrtpMemoryFunctions API
by fixeria 08 Jan '24

08 Jan '24

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email ) Change subject: trau/osmo_ortp: support building without OrtpMemoryFunctions API ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > * Yes, it's a public dependency and it's part of the public API of the library How does this contradict what I am saying? I am not saying that `bcmtoolbox` is not a public dependency of `ortp`. I am saying that for libosmo-abis, `bcmtoolbox` is **not a direct** (but indirect or implicit) dependency, pulled by `ortp`. We don't require `bcmtoolbox` in our `configure.ac` nor in `debian/control`. This is why I don't think it's a good idea to use API of `bcmtoolbox`. >> they may switch to some other library any day. > That would break its ABI/API. This whole situation with libosmo-abis not building against recent `ortp` indicates that they don't care that much about breaking API/ABI. They also did modify signatures of existing public functions, and this is why we have quirks like `HAVE_ORTP_LOG_DOMAIN` and `RTP_SIGNAL_PTR_CAST`. I am inclined to remove this talloc-to-ortp integration completely (even for old ortp versions), as was suggested by Hoernchen in the IRC. It's questionable whether we really want to use talloc here. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I9fe6299fde81faeab86cd6645d67edd2f41e1873 Gerrit-Change-Number: 35502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Jan 2024 15:07:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: Update titan.ProtocolModules.GTP_v13.5.0 to current master
by pespin 08 Jan '24

08 Jan '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35506?usp=email ) Change subject: Update titan.ProtocolModules.GTP_v13.5.0 to current master ...................................................................... Update titan.ProtocolModules.GTP_v13.5.0 to current master Current master contains a fix for missing mandatory field in MM Context IE. Change-Id: I36c87ed98c752a54650e4453ccdff45463d0bc96 --- M deps/Makefile 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/35506/1 diff --git a/deps/Makefile b/deps/Makefile index c6031cb..11ff460 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -92,7 +92,7 @@ titan.ProtocolModules.BSSMAP_commit= 4acb6ab5f058477f0b90c2da182d52054e3614b0 titan.ProtocolModules.DNS_commit= R.7.B titan.ProtocolModules.GRE_commit= R.2.A-5-g654c446 -titan.ProtocolModules.GTP_v13.5.0_commit= 54219599037626c675610d3a44433d01af264fbb +titan.ProtocolModules.GTP_v13.5.0_commit= 6b769f985eb91bf5a4332f29faa4a043b23ce62e titan.ProtocolModules.GTPv2_v13.7.0_commit= R.2.A-5-g85cb124 titan.ProtocolModules.ICMP_commit= e49d9fb9f7de637b4bf4803dc6b6e911a8661640 titan.ProtocolModules.ICMPv6_commit= 46f4d9b6e1e3c794294a92588401a81e4881dd27 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35506?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I36c87ed98c752a54650e4453ccdff45463d0bc96 Gerrit-Change-Number: 35506 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: mme: TC_s1ap_tau_unknown_guti: expect UeContextReleaseCmd
by pespin 08 Jan '24

08 Jan '24

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35505?usp=email ) Change subject: mme: TC_s1ap_tau_unknown_guti: expect UeContextReleaseCmd ...................................................................... mme: TC_s1ap_tau_unknown_guti: expect UeContextReleaseCmd The MME is sending the message after TAU Reject, and it may be forwarded through TTCN3 components while some of them are already being torn down since the test is finished. Change-Id: I6b915d0e32a46fa9546b3b1b96aa69ad43baae9e --- M mme/MME_Tests.ttcn 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/05/35505/1 diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index 0c5c8e9..f4f41e2 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -1297,6 +1297,7 @@ } } + as_s1ap_handle_UeContextReleaseCmd(); } testcase TC_s1ap_tau_unknown_guti() runs on MTC_CT { var charstring id := testcasename(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35505?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6b915d0e32a46fa9546b3b1b96aa69ad43baae9e Gerrit-Change-Number: 35505 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: gsm: fix osmo_mobile_identity_decode(): init *mi on error
by pespin 08 Jan '24

08 Jan '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35504?usp=email ) Change subject: gsm: fix osmo_mobile_identity_decode(): init *mi on error ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: It shouldn't matter in principle since callers should check the return value, but fine. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1c1503120c6c0e5479d8350fe762470bdb6266b8 Gerrit-Change-Number: 35504 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Jan 2024 14:49:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-abis[master]: trau/osmo_ortp: support building without OrtpMemoryFunctions API
by pespin 08 Jan '24

08 Jan '24

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email ) Change subject: trau/osmo_ortp: support building without OrtpMemoryFunctions API ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: If "#include "bctoolbox/port.h"" happens in some public header of ortp.h, then: - Yes, it's a public dependency and it's part of the public API of the library - Yes, it's like libosmocore and ortp. > Whatever ortp is using is the internal details of ortp If it's ina public header, it's not internal details. Internal details means private header or .c files. > they may switch to some other library any day. That would break its ABI/API. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I9fe6299fde81faeab86cd6645d67edd2f41e1873 Gerrit-Change-Number: 35502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Jan 2024 14:48:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsm: fix osmo_mobile_identity_decode(): init *mi on error
by fixeria 08 Jan '24

08 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35504?usp=email ) Change subject: gsm: fix osmo_mobile_identity_decode(): init *mi on error ...................................................................... gsm: fix osmo_mobile_identity_decode(): init *mi on error Change-Id: I1c1503120c6c0e5479d8350fe762470bdb6266b8 --- M src/gsm/gsm48.c 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/35504/1 diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c index 4f79026..64b1765 100644 --- a/src/gsm/gsm48.c +++ b/src/gsm/gsm48.c @@ -641,8 +641,10 @@ char *str = NULL; /* initialize to avoid uninitialized false warnings on some gcc versions (11.1.0) */ size_t str_size = 0; /* initialize to avoid uninitialized false warnings on some gcc versions (11.1.0) */ - if (!mi_data || mi_len < 1) - return -EBADMSG; + if (!mi_data || mi_len < 1) { + rc = -EBADMSG; + goto return_error; + } nibbles_len = (mi_len - 1) * 2 + ((mi_data[0] & GSM_MI_ODD) ? 1 : 0); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1c1503120c6c0e5479d8350fe762470bdb6266b8 Gerrit-Change-Number: 35504 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0