Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email ) Change subject: trau/osmo_ortp: support building without OrtpMemoryFunctions API ...................................................................... Patch Set 1: (1 comment) Patchset: PS1:

* Yes, it's a public dependency and it's part of the public API of the library

How does this contradict what I am saying? I am not saying that `bcmtoolbox` is not a public dependency of `ortp`. I am saying that for libosmo-abis, `bcmtoolbox` is **not a direct** (but indirect or implicit) dependency, pulled by `ortp`. We don't require `bcmtoolbox` in our `configure.ac` nor in `debian/control`. This is why I don't think it's a good idea to use API of `bcmtoolbox`.

...

they may switch to some other library any day. That would break its ABI/API.

This whole situation with libosmo-abis not building against recent `ortp` indicates that they don't care that much about breaking API/ABI. They also did modify signatures of existing public functions, and this is why we have quirks like `HAVE_ORTP_LOG_DOMAIN` and `RTP_SIGNAL_PTR_CAST`. I am inclined to remove this talloc-to-ortp integration completely (even for old ortp versions), as was suggested by Hoernchen in the IRC. It's questionable whether we really want to use talloc here. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35502?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I9fe6299fde81faeab86cd6645d67edd2f41e1873 Gerrit-Change-Number: 35502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 08 Jan 2024 15:07:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment