January 2024 - gerrit-log - lists.osmocom.org

[S] Change in docker-playground[master]: upgrade gerrit to 3.7.6
by laforge 10 Jan '24

10 Jan '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35548?usp=email ) Change subject: upgrade gerrit to 3.7.6 ...................................................................... upgrade gerrit to 3.7.6 Change-Id: I6266b1dbfbad71aca95d45f812354f7336b8bd69 --- M gerrit/Dockerfile 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/gerrit/Dockerfile b/gerrit/Dockerfile index dec08da..2e27e3b 100644 --- a/gerrit/Dockerfile +++ b/gerrit/Dockerfile @@ -1,4 +1,4 @@ -FROM gerritcodereview/gerrit:3.7.4 +FROM gerritcodereview/gerrit:3.7.6 USER root RUN yum -y install zip unzip patch -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6266b1dbfbad71aca95d45f812354f7336b8bd69 Gerrit-Change-Number: 35548 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in docker-playground[master]: debian-{buster,bullseye}-jenkins: Add python3-cryptography from debian
by laforge 10 Jan '24

10 Jan '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35546?usp=email ) Change subject: debian-{buster,bullseye}-jenkins: Add python3-cryptography from debian ...................................................................... debian-{buster,bullseye}-jenkins: Add python3-cryptography from debian This avoids having to use rust to build the cryptography module during pySim requirements.txt Change-Id: I9246c9260b1d227ce6e290058caa33e04407d11f --- M debian-bullseye-jenkins/Dockerfile M debian-buster-jenkins/Dockerfile 2 files changed, 14 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian-bullseye-jenkins/Dockerfile b/debian-bullseye-jenkins/Dockerfile index 75f0fec..3c186cc 100644 --- a/debian-bullseye-jenkins/Dockerfile +++ b/debian-bullseye-jenkins/Dockerfile @@ -110,6 +110,7 @@ python-setuptools \ python2.7 \ python3 \ + python3-cryptography \ python3-gi \ python3-mako \ python3-nwdiag \ diff --git a/debian-buster-jenkins/Dockerfile b/debian-buster-jenkins/Dockerfile index 6dffc25..cf443f0 100644 --- a/debian-buster-jenkins/Dockerfile +++ b/debian-buster-jenkins/Dockerfile @@ -109,6 +109,7 @@ python-yaml \ python2.7 \ python3 \ + python3-cryptography \ python3-gi \ python3-mako \ python3-nwdiag \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35546?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9246c9260b1d227ce6e290058caa33e04407d11f Gerrit-Change-Number: 35546 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in docker-playground[master]: upgrade gerrit to 3.7.6
by laforge 10 Jan '24

10 Jan '24

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35548?usp=email ) Change subject: upgrade gerrit to 3.7.6 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6266b1dbfbad71aca95d45f812354f7336b8bd69 Gerrit-Change-Number: 35548 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 10 Jan 2024 16:05:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: debian-{buster,bullseye}-jenkins: Add python3-cryptography from debian
by laforge 10 Jan '24

10 Jan '24

Attention is currently required from: daniel, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35546?usp=email ) Change subject: debian-{buster,bullseye}-jenkins: Add python3-cryptography from debian ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35546?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9246c9260b1d227ce6e290058caa33e04407d11f Gerrit-Change-Number: 35546 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Jan 2024 16:05:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: euicc: Fix decoding of SubjectKeyIdentifier.
by laforge 10 Jan '24

10 Jan '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35523?usp=email ) Change subject: euicc: Fix decoding of SubjectKeyIdentifier. ...................................................................... euicc: Fix decoding of SubjectKeyIdentifier. There's actually no additional TLV structure inside the Tag 0x04. Change-Id: Ic922355308747a888083c5b26765d272b6b20bd0 --- M pySim/euicc.py 1 file changed, 14 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pySim/euicc.py b/pySim/euicc.py index e405f30..81fbd1e 100644 --- a/pySim/euicc.py +++ b/pySim/euicc.py @@ -94,13 +94,11 @@ # SGP.22 Section 5.7.8: GetEUICCInfo class SVN(BER_TLV_IE, tag=0x82): _construct = VersionType -class SubjectKeyIdentifier(BER_TLV_IE, tag=0x81): +class SubjectKeyIdentifier(BER_TLV_IE, tag=0x04): _construct = HexAdapter(GreedyBytes) -class SubjectKeyIdentifierSeq(BER_TLV_IE, tag=0x04, nested=[SubjectKeyIdentifier]): +class EuiccCiPkiListForVerification(BER_TLV_IE, tag=0xa9, nested=[SubjectKeyIdentifier]): pass -class EuiccCiPkiListForVerification(BER_TLV_IE, tag=0xa9, nested=[SubjectKeyIdentifierSeq]): - pass -class EuiccCiPkiListForSigning(BER_TLV_IE, tag=0xaa, nested=[SubjectKeyIdentifierSeq]): +class EuiccCiPkiListForSigning(BER_TLV_IE, tag=0xaa, nested=[SubjectKeyIdentifier]): pass class EuiccInfo1(BER_TLV_IE, tag=0xbf20, nested=[SVN, EuiccCiPkiListForVerification, EuiccCiPkiListForSigning]): pass -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35523?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic922355308747a888083c5b26765d272b6b20bd0 Gerrit-Change-Number: 35523 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: euicc: Fix decoding of SubjectKeyIdentifier.
by laforge 10 Jan '24

10 Jan '24

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35523?usp=email ) Change subject: euicc: Fix decoding of SubjectKeyIdentifier. ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35523?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic922355308747a888083c5b26765d272b6b20bd0 Gerrit-Change-Number: 35523 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 10 Jan 2024 16:05:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: debian-{buster,bullseye}-jenkins: Add python3-cryptography from debian
by laforge 10 Jan '24

10 Jan '24

Attention is currently required from: daniel, fixeria, laforge. Hello Jenkins Builder, daniel, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/35546?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by daniel, Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: debian-{buster,bullseye}-jenkins: Add python3-cryptography from debian ...................................................................... debian-{buster,bullseye}-jenkins: Add python3-cryptography from debian This avoids having to use rust to build the cryptography module during pySim requirements.txt Change-Id: I9246c9260b1d227ce6e290058caa33e04407d11f --- M debian-bullseye-jenkins/Dockerfile M debian-buster-jenkins/Dockerfile 2 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/46/35546/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35546?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9246c9260b1d227ce6e290058caa33e04407d11f Gerrit-Change-Number: 35546 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in docker-playground[master]: upgrade gerrit to 3.7.6
by laforge 10 Jan '24

10 Jan '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/35548?usp=email ) Change subject: upgrade gerrit to 3.7.6 ...................................................................... upgrade gerrit to 3.7.6 Change-Id: I6266b1dbfbad71aca95d45f812354f7336b8bd69 --- M gerrit/Dockerfile 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/48/35548/1 diff --git a/gerrit/Dockerfile b/gerrit/Dockerfile index dec08da..2e27e3b 100644 --- a/gerrit/Dockerfile +++ b/gerrit/Dockerfile @@ -1,4 +1,4 @@ -FROM gerritcodereview/gerrit:3.7.4 +FROM gerritcodereview/gerrit:3.7.6 USER root RUN yum -y install zip unzip patch -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35548?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6266b1dbfbad71aca95d45f812354f7336b8bd69 Gerrit-Change-Number: 35548 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmocom-bb[master]: firmware: fix shebang in solve_envs.py: s/python/python3/
by fixeria 10 Jan '24

10 Jan '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35547?usp=email ) Change subject: firmware: fix shebang in solve_envs.py: s/python/python3/ ...................................................................... firmware: fix shebang in solve_envs.py: s/python/python3/ This patch fixes [currently missing] Jenkins build verification. Currently it's just skipping the firmware due to errors: make -C target/firmware CROSS_COMPILE=arm-none-eabi- make[1]: Entering directory '/build/src/target/firmware' /usr/bin/env: 'python': No such file or directory /usr/bin/env: 'python': No such file or directory /usr/bin/env: 'python': No such file or directory /usr/bin/env: 'python': No such file or directory /usr/bin/env: 'python': No such file or directory /usr/bin/env: 'python': No such file or directory ... Change-Id: Ibfcc17ca2736da82d60db3b0e350b74e788031b0 --- M src/target/firmware/solve_envs.py 1 file changed, 23 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/47/35547/1 diff --git a/src/target/firmware/solve_envs.py b/src/target/firmware/solve_envs.py index b010897..da1b0e1 100755 --- a/src/target/firmware/solve_envs.py +++ b/src/target/firmware/solve_envs.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 import sys -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35547?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibfcc17ca2736da82d60db3b0e350b74e788031b0 Gerrit-Change-Number: 35547 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: debian-bullseye-jenkins: Add python3-cryptography from debian
by fixeria 10 Jan '24

10 Jan '24

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35546?usp=email ) Change subject: debian-bullseye-jenkins: Add python3-cryptography from debian ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35546?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9246c9260b1d227ce6e290058caa33e04407d11f Gerrit-Change-Number: 35546 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 10 Jan 2024 15:54:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0