January 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: firmware: fix shebang in solve_envs.py: s/python/python3/
by fixeria 10 Jan '24

10 Jan '24

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35547?usp=email ) Change subject: firmware: fix shebang in solve_envs.py: s/python/python3/ ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: This patch does the trick: https://jenkins.osmocom.org/jenkins/job/gerrit-osmocom-bb-build/a1=default,… ``` make -C target/firmware CROSS_COMPILE=arm-none-eabi- make[1]: Entering directory '/build/src/target/firmware' CC apps/hello_world/main.o ... ``` -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35547?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibfcc17ca2736da82d60db3b0e350b74e788031b0 Gerrit-Change-Number: 35547 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 10 Jan 2024 16:21:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: pgw: Expect EchoResp in CLIENT port of component who sent EchoReq
by laforge 10 Jan '24

10 Jan '24

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35516?usp=email ) Change subject: pgw: Expect EchoResp in CLIENT port of component who sent EchoReq ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35516?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1764fdf81192597e393d79d34cb8f221aa79bbd9 Gerrit-Change-Number: 35516 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Jan 2024 16:08:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTPv2_Emulation: routing improvements: Prioritize response, fallback ...
by laforge 10 Jan '24

10 Jan '24

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35515?usp=email ) Change subject: GTPv2_Emulation: routing improvements: Prioritize response, fallback to TEID ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35515?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie96d65085fb352489150183415dbd6cc8237a47c Gerrit-Change-Number: 35515 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Jan 2024 16:08:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTPv2_Templates: Fix tEID field optional tr_PDU_GTP2C_msgtypes()
by laforge 10 Jan '24

10 Jan '24

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35514?usp=email ) Change subject: GTPv2_Templates: Fix tEID field optional tr_PDU_GTP2C_msgtypes() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35514?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I65044b8758046704e22f9057f34ce5fdbb7aabfe Gerrit-Change-Number: 35514 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Jan 2024 16:07:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: S1AP_Emulation: Add port message to reset NAS count values
by laforge 10 Jan '24

10 Jan '24

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35512?usp=email ) Change subject: S1AP_Emulation: Add port message to reset NAS count values ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35512?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I61d7b919aba8f58a020c18ae9b9bba4108d59010 Gerrit-Change-Number: 35512 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Jan 2024 16:07:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: NAS_Templates: Introduce template tr_PDU_NAS_EPS_TrackingAreaUpdateAc...
by laforge 10 Jan '24

10 Jan '24

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35511?usp=email ) Change subject: NAS_Templates: Introduce template tr_PDU_NAS_EPS_TrackingAreaUpdateAccept ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35511?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba19ac8293fecfe0b150155cebe50cbe4d32fe4d Gerrit-Change-Number: 35511 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Jan 2024 16:07:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: NAS_Templates: Allow passing old_guti and ptmsi_sig to TAU Req template
by laforge 10 Jan '24

10 Jan '24

Attention is currently required from: daniel, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35510?usp=email ) Change subject: NAS_Templates: Allow passing old_guti and ptmsi_sig to TAU Req template ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File library/NAS_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35510/comment/10d449eb_03c0… PS1, Line 153: ts_NAS_MobileId_GUTI_(template (value) GUTI guti) := { > I find the naming a bit weird and easy to mix up with the one above (which imho should be named diff […] yeah, the above can be named ...GUTI_From_components() or whatever. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35510?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5e0204e772edefc49a63b73fc4aad2fed5c14cac Gerrit-Change-Number: 35510 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Jan 2024 16:07:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: ASCI: Correctly confirm talker, so originator can be identified
by laforge 10 Jan '24

10 Jan '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35544?usp=email ) Change subject: ASCI: Correctly confirm talker, so originator can be identified ...................................................................... ASCI: Correctly confirm talker, so originator can be identified Fix the issue that MSC rejects call termination, because talker can't be identified as originator of the call. Fixes: OS#6325 Change-Id: I0381e25e15624e6b7577910c95700a355ed3f811 --- M msc/MSC_Tests_ASCI.ttcn 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/msc/MSC_Tests_ASCI.ttcn b/msc/MSC_Tests_ASCI.ttcn index 76d8d3c..c8bf2da 100644 --- a/msc/MSC_Tests_ASCI.ttcn +++ b/msc/MSC_Tests_ASCI.ttcn @@ -244,9 +244,12 @@ var octetstring gcc_term_req := '3500001900'O; var octetstring bcc_term_req := '3500001a00'O; var octetstring xcc_termination := '340110'O; + /* L3 info carries the mobile identity of the talker requesting the uplink. */ + var octetstring uplink_req_conf := '061103505902082926240000000033'O; var myBSSMAP_Cause cause_success := GSM0808_CAUSE_CALL_CONTROL; var template (value) PDU_BSSAP ts_uplink_rel_ind := ts_BSSMAP_UplinkRelInd(enum2int(cause_success), omit); var template (value) PDU_BSSAP ts_uplink_req := ts_BSSMAP_UplinkReq; + var template (value) PDU_BSSAP ts_uplink_req_conf := ts_BSSMAP_UplinkReqConf(ts_CellId_CI(42), omit, uplink_req_conf); var PDU_BSSAP rx_bssap; f_init_handler(pars); @@ -316,6 +319,9 @@ log("Got Uplink Request Acknowledge: ", rx_bssap); COORD.send(COORD_UPLINK_REQ_ACK); f_sleep(0.2); + /* The BSC confirms the uplink and provides mobile identity to identify originator. */ + log("Sending Uplink Req Confirm: ", ts_uplink_req_conf); + BSSAP.send(ts_uplink_req_conf); /* The MS requests termination of the call. */ log("Sending GCC Termination Request: ", gcc_term_req); BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_GCC(cpars.transaction_id, gcc_term_req))); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35544?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0381e25e15624e6b7577910c95700a355ed3f811 Gerrit-Change-Number: 35544 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: ASCI: Correctly confirm talker, so originator can be identified
by laforge 10 Jan '24

10 Jan '24

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35544?usp=email ) Change subject: ASCI: Correctly confirm talker, so originator can be identified ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35544?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0381e25e15624e6b7577910c95700a355ed3f811 Gerrit-Change-Number: 35544 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 10 Jan 2024 16:06:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: firmware: fix shebang in solve_envs.py: s/python/python3/
by laforge 10 Jan '24

10 Jan '24

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/35547?usp=email ) Change subject: firmware: fix shebang in solve_envs.py: s/python/python3/ ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35547?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibfcc17ca2736da82d60db3b0e350b74e788031b0 Gerrit-Change-Number: 35547 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 Jan 2024 16:05:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0