Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34537?usp=email )
Change subject: IuUP_Emulation: fix AMR SID SDU size
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
merging this one on purpose to make it easier to work on the followup patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34537?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9afb28ca6e23f7976edcc130ea012be34e04eb4b
Gerrit-Change-Number: 34537
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Sep 2023 10:58:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34542?usp=email )
Change subject: bsc: add test TC_ncc_permitted_si2
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File bsc/BSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34542/comment/05b4d0ca_8c94…
PS1, Line 12430: break;
this looks wrong? why are you exiting the altstep (without failing the test) if the value doesn't match?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34542?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibff5c4392d8c19b5bce479b6fa5e33086cdb1272
Gerrit-Change-Number: 34542
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Sep 2023 10:51:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment