Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34542?usp=email ) Change subject: bsc: add test TC_ncc_permitted_si2 ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34542/comment/05b4d0ca_8c940... PS1, Line 12430: break; this looks wrong? why are you exiting the altstep (without failing the test) if the value doesn't match? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34542?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibff5c4392d8c19b5bce479b6fa5e33086cdb1272 Gerrit-Change-Number: 34542 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Comment-Date: Wed, 27 Sep 2023 10:51:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment