September 2023 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-python-tests[master]: Bump version: 0.2.1 → 0.3.0

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/34401?usp=email ) Change subject: Bump version: 0.2.1 → 0.3.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/34401?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I56fbc66dd7bbf50a966063a00f8a8e6c583d7d56 Gerrit-Change-Number: 34401 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Sep 2023 12:56:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in ...osmo-python-tests[master]: Bump version: 0.2.1 → 0.3.0

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/34401?usp=email ) Change subject: Bump version: 0.2.1 → 0.3.0 ...................................................................... Bump version: 0.2.1 → 0.3.0 Change-Id: I56fbc66dd7bbf50a966063a00f8a8e6c583d7d56 --- M debian/changelog 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests refs/changes/01/34401/1 diff --git a/debian/changelog b/debian/changelog index c2bba57..75c8dea 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,17 @@ +osmo-python-tests (0.3.0) unstable; urgency=medium + + [ Vadim Yanitskiy ] + * InteractVty: re.escape() the VTY prompt in connect() + * osmoutil: print return code in end_proc() + * setup.py: do not install scripts/{soap,ctrl2cgi}.py + * osmoutil: return proc's return code from end_proc() + + [ Oliver Smith ] + * debian: set compat level to 10 + * systemd: depend on networking-online.target + + -- Pau Espin Pedrol <pespin(a)sysmocom.de> Wed, 13 Sep 2023 14:48:02 +0200 + osmo-python-tests (0.2.1) unstable; urgency=medium [ Harald Welte ] -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/34401?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I56fbc66dd7bbf50a966063a00f8a8e6c583d7d56 Gerrit-Change-Number: 34401 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 0

[L] Change in osmo-ci[master]: jobs: update trigger timers

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34400?usp=email ) Change subject: jobs: update trigger timers ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34400?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib68f9a78bae27a63706a8c95715bf6a244b7bf1d Gerrit-Change-Number: 34400 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Sep 2023 11:54:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[M] Change in osmo-mgw[master]: mgcp_client_fsm: fix inconsistent API (param_present, param).

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34351?usp=email ) Change subject: mgcp_client_fsm: fix inconsistent API (param_present, param). ...................................................................... Patch Set 3: (3 comments) File include/osmocom/mgcp_client/mgcp_client.h: https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/96831704_316cf607 PS2, Line 121: struct mgcp_msg { > I have checked this one. It is not used from outside. […] Can you point me to the API allocating and returning a pointer to this struct? because I cannot find it. If you mean this struct is not used at all outside of the lib, then why is it in a public header? File include/osmocom/mgcp_client/mgcp_client_fsm.h: https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/9d7793ba_2ce016a8 PS2, Line 70: struct mgcp_codec_param2 codecs_param[MGCP_MAX_CODECS]; > Yes, that is a real problem ;-/ I will add an alloc function in a different patch. Ok, better sort that kind of problems *before* this patch. File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/6a99cd39_9d7ca82f PS2, Line 1376: LOGPMGW(mgcp, LOGL_DEBUG, "using depreacted struct member mgcp_msg->param, please use mgcp_msg->codecs_param!\n"); > Done You marked as DONE but I see no change... -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34351?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I50d737f3f3d45e4004c64101700a471fe75b3436 Gerrit-Change-Number: 34351 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Sep 2023 11:52:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[S] Change in osmo-mgw[master]: mgcp_client_fsm: explain member param in struct mgcp_conn_peer better

by pespin

Attention is currently required from: dexter, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34350?usp=email ) Change subject: mgcp_client_fsm: explain member param in struct mgcp_conn_peer better ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34350?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iea4dc1e72fccaa464ce503fae88b5d8a867b1d19 Gerrit-Change-Number: 34350 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Sep 2023 11:49:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[M] Change in osmo-mgw[master]: mgcp_client_fsm: allow the same codec multiple times in ptmap

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34349?usp=email ) Change subject: mgcp_client_fsm: allow the same codec multiple times in ptmap ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Let's see what others have to say here. I'm not against merging this patch, but this is only a hack/interim solution which is not entirely solving the problems imho, only fixing one more specific case. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34349?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie13ce59d3165936a16e16588b4d58f0ce7e0ae67 Gerrit-Change-Number: 34349 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Sep 2023 11:49:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[M] Change in osmo-sgsn[master]: sgsn_rim: forward message based on RIM ROUTING ADDRESS

by pespin

Attention is currently required from: dexter, laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/34122?usp=email ) Change subject: sgsn_rim: forward message based on RIM ROUTING ADDRESS ...................................................................... Patch Set 4: (1 comment) File src/sgsn/sgsn_libgtp.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/34122/comment/e56eb675_e87c4edb PS3, Line 721: rim_ra_discr = rim_ra_discr_encoded[0]; > Done You marked this as Done but didn't do what you were asked to do. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/34122?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ifd2b915ed2f05130cff8ee77714b82005c17de3d Gerrit-Change-Number: 34122 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 13 Sep 2023 11:47:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 9 months

1
0
0 0

[L] Change in osmo-ci[master]: jobs: update trigger timers

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/34400?usp=email ) Change subject: jobs: update trigger timers ...................................................................... jobs: update trigger timers Ensure we trigger building new OBS packages first, then wait plenty of time until the binary packages are available (and run jobs in the meantime that don't need them), and only after that we run the jobs that need the binary packages. Otherwise TTCN3 jobs may test the packages from the previous day, and some jobs may fail completely due to packages not being completely built yet. For example, yesterday the new Osmocom CNI releases were tagged, which means the :latest packages also need to be rebuilt (-> building all OBS packages takes longer). The osmocom-release-manuals and -tarballs jobs failed, because the new binary packages were not available yet when they ran. Change all timers to the format "H 20 * * *" to have a deterministic hour and semi-random minute based on the job name. Change-Id: Ib68f9a78bae27a63706a8c95715bf6a244b7bf1d --- M jobs/README.adoc M jobs/coverity.yml M jobs/master-builds-dahdi.yml M jobs/octsim_osmo-ccid-firmware.yml M jobs/osmocom-api.yml M jobs/osmocom-build-tags-against-master.yml M jobs/osmocom-list-commits.yml M jobs/osmocom-obs-sync.yml M jobs/osmocom-obs-wireshark.yml M jobs/osmocom-obs.yml M jobs/osmocom-release-manuals.yml M jobs/osmocom-release-tarballs.yml M jobs/registry-rebuild-upload-fpga-build.yml M jobs/registry-triggers.yml M jobs/registry-update-base-images.yml M jobs/repo-install-test.yml M jobs/ttcn3-testsuites.yml 17 files changed, 189 insertions(+), 120 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/00/34400/1 diff --git a/jobs/README.adoc b/jobs/README.adoc index 32da7c1..86fc485 100644 --- a/jobs/README.adoc +++ b/jobs/README.adoc @@ -102,3 +102,46 @@ Note that running multiple jobs in parallel influence the ccache statistics, and it's impossible to tell which job caused which change in the stats (that's why they are not printed at the end of each job, it would be confusing). + +*timers* + +A lot of the jenkins jobs run daily with a timer: + + triggers: + - timed: "H 20 * * *" + +or weekly: + + triggers: + - timed: "H 20 * * H" + +Use H for the minute / day of week, to have it derivated as hash of the job +name. Replace 20 with the hour (UTC) the job should run. + +The jobs follow this timetable, to ensure we don't attempt to use binary +packages before they have been built (leading to failing jobs). + + 18:00 - 21:00 OBS related + 18:XX osmocom-obs-sync (sync Debian:12 etc. with openSUSE OBS) + 19:XX osmocom-obs-wireshark + 20:XX osmocom-obs (new binary packages start building on OBS!) + + 22:00 - 03:00 Jobs that don't need binary packages + 22:XX coverity + 22:XX octsim_osmo-ccid-firmware + 22:XX osmo-gsm-tester-runner (virtual) + 23:XX master-builds-dahdi + 00:XX osmocom-api + 00:XX registry-update-base-images + 01:XX osmocom-build-tags-against-master + 01:XX osmocom-list-commits + 02:XX registry-triggers + 02:XX registry-rebuild-upload-fpga-build (weekly) + + 04:00 - 18:00 Jobs that need binary packages + ttcn3-testsuites + 04:XX osmocom-release-manuals + 05:XX osmocom-release-tarballs + 06:XX repo-install-test + +master-builds: to avoid complexity, these run throughout the day (H H * * *). diff --git a/jobs/coverity.yml b/jobs/coverity.yml index a2663a8..42c060a 100644 --- a/jobs/coverity.yml +++ b/jobs/coverity.yml @@ -43,7 +43,7 @@ branches: - '$BRANCH' triggers: - - timed: "@daily" + - timed: "H 22 * * *" publishers: - email: notify-every-unstable-build: true diff --git a/jobs/master-builds-dahdi.yml b/jobs/master-builds-dahdi.yml index 3d263e3..8f6d070 100644 --- a/jobs/master-builds-dahdi.yml +++ b/jobs/master-builds-dahdi.yml @@ -52,7 +52,7 @@ before: true triggers: - - timed: "H H * * *" + - timed: "H 23 * * *" builders: - shell: | diff --git a/jobs/octsim_osmo-ccid-firmware.yml b/jobs/octsim_osmo-ccid-firmware.yml index 534cf13..7db1039 100644 --- a/jobs/octsim_osmo-ccid-firmware.yml +++ b/jobs/octsim_osmo-ccid-firmware.yml @@ -49,5 +49,5 @@ triggers: - reverse: jobs: master-osmo-ccid-firmware, - - timed: H H * * * + - timed: H 22 * * * wrappers: [] diff --git a/jobs/osmocom-api.yml b/jobs/osmocom-api.yml index 294ccaa..312496b 100644 --- a/jobs/osmocom-api.yml +++ b/jobs/osmocom-api.yml @@ -15,7 +15,7 @@ notify-every-unstable-build: true recipients: jenkins-notifications(a)lists.osmocom.org triggers: - - timed: "H H * * *" + - timed: "H 00 * * *" wrappers: - ssh-agent-credentials: users: diff --git a/jobs/osmocom-build-tags-against-master.yml b/jobs/osmocom-build-tags-against-master.yml index 4ea4055..e33c9a3 100644 --- a/jobs/osmocom-build-tags-against-master.yml +++ b/jobs/osmocom-build-tags-against-master.yml @@ -40,7 +40,7 @@ git-config-name: 'Jenkins Builder' git-config-email: 'jenkins(a)osmocom.org' triggers: - - timed: "@midnight" + - timed: "H 01 * * *" publishers: - archive: allow-empty: false diff --git a/jobs/osmocom-list-commits.yml b/jobs/osmocom-list-commits.yml index 43ce171..d367499 100644 --- a/jobs/osmocom-list-commits.yml +++ b/jobs/osmocom-list-commits.yml @@ -34,7 +34,7 @@ git-config-name: 'Jenkins Builder' git-config-email: 'jenkins(a)osmocom.org' triggers: - - timed: "@midnight" + - timed: "H 01 * * *" publishers: - archive: allow-empty: false diff --git a/jobs/osmocom-obs-sync.yml b/jobs/osmocom-obs-sync.yml index 2dd9888..fef1e83 100644 --- a/jobs/osmocom-obs-sync.yml +++ b/jobs/osmocom-obs-sync.yml @@ -44,7 +44,7 @@ --docker \ $DISTROS triggers: - - timed: "H H * * *" + - timed: "H 18 * * *" wrappers: - ansicolor: colormap: xterm diff --git a/jobs/osmocom-obs-wireshark.yml b/jobs/osmocom-obs-wireshark.yml index 9d4d04e..213a1f3 100644 --- a/jobs/osmocom-obs-wireshark.yml +++ b/jobs/osmocom-obs-wireshark.yml @@ -34,7 +34,7 @@ git-config-email: 'jenkins(a)osmocom.org' wipe-workspace: true triggers: - - timed: "H 05 * * *" + - timed: "H 19 * * *" publishers: - email: diff --git a/jobs/osmocom-obs.yml b/jobs/osmocom-obs.yml index 4870066..eb77f4d 100644 --- a/jobs/osmocom-obs.yml +++ b/jobs/osmocom-obs.yml @@ -50,7 +50,7 @@ git-config-name: 'Jenkins Builder' git-config-email: 'jenkins(a)osmocom.org' triggers: - - timed: "H 00 * * *" # run before repo-install-test.yml + - timed: "H 20 * * *" publishers: - email: diff --git a/jobs/osmocom-release-manuals.yml b/jobs/osmocom-release-manuals.yml index a120127..c9d04ae 100644 --- a/jobs/osmocom-release-manuals.yml +++ b/jobs/osmocom-release-manuals.yml @@ -34,7 +34,7 @@ git-config-email: 'jenkins(a)osmocom.org' wipe-workspace: true triggers: - - timed: "@midnight" + - timed: "H 04 * * *" publishers: - email: notify-every-unstable-build: true diff --git a/jobs/osmocom-release-tarballs.yml b/jobs/osmocom-release-tarballs.yml index 557898a..4b3c8dc 100644 --- a/jobs/osmocom-release-tarballs.yml +++ b/jobs/osmocom-release-tarballs.yml @@ -35,7 +35,7 @@ git-config-email: 'jenkins(a)osmocom.org' wipe-workspace: true triggers: - - timed: "@midnight" + - timed: "H 05 * * *" publishers: - email: notify-every-unstable-build: true diff --git a/jobs/registry-rebuild-upload-fpga-build.yml b/jobs/registry-rebuild-upload-fpga-build.yml index c4b750a..1846e49 100644 --- a/jobs/registry-rebuild-upload-fpga-build.yml +++ b/jobs/registry-rebuild-upload-fpga-build.yml @@ -29,7 +29,7 @@ docker push $REGISTRY/$USER/fpga-build cd .. triggers: - - timed: "@weekly" + - timed: "H 02 * * H" publishers: - email: diff --git a/jobs/registry-triggers.yml b/jobs/registry-triggers.yml index 0395976..da7d402 100644 --- a/jobs/registry-triggers.yml +++ b/jobs/registry-triggers.yml @@ -27,7 +27,7 @@ - pollscm: cron: "H/5 * * * *" ignore-post-commit-hooks: false - - timed: "H H * * *" + - timed: "H 02 * * *" publishers: - trigger: project: '{obj:trigger}' diff --git a/jobs/registry-update-base-images.yml b/jobs/registry-update-base-images.yml index 6c4074e..f3f20e3 100644 --- a/jobs/registry-update-base-images.yml +++ b/jobs/registry-update-base-images.yml @@ -39,7 +39,7 @@ docker push $dst done triggers: - - timed: "@daily" + - timed: "H 00 * * *" publishers: - email: diff --git a/jobs/repo-install-test.yml b/jobs/repo-install-test.yml index eba2a79..1340e20 100644 --- a/jobs/repo-install-test.yml +++ b/jobs/repo-install-test.yml @@ -60,7 +60,7 @@ git-config-name: 'Jenkins Builder' git-config-email: 'jenkins(a)osmocom.org' triggers: - - timed: "H 10 * * *" # run after osmocom-obs.yml + - timed: "H 06 * * *" publishers: - email: diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 8568068..4c15f84 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -17,24 +17,25 @@ jobs: - "{job-name}" # Folders from docker-playground.git + # timer: 10 per hour from 04:00 - 18:00, see jobs/README.adoc job-name: # debian nightly - order by time - nplab-m3ua-test: - timer: 10 03 * * * + timer: H 04 * * * - nplab-sua-test: - timer: 15 03 * * * + timer: H 04 * * * - ttcn3-ggsn-test: - timer: 00 04 * * * + timer: H 04 * * * - ttcn3-ggsn-test-kernel: - timer: 10 04 * * * + timer: H 04 * * * description: | Test osmo-ggsn master with the Debian kernel. - ttcn3-ggsn-test-kernel-latest: - timer: 20 04 * * * + timer: H 04 * * * description: | Test osmo-ggsn latest with the Debian kernel. - ttcn3-ggsn-test-kernel-latest-net-next: - timer: 25 04 * * * + timer: H 04 * * * # Cache the linux source tree in the workspace of one node wipe_workspace: false node: ttcn3-ggsn-test-kernel-git @@ -43,7 +44,7 @@ <a href="https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/"> net-next.git</a>. - ttcn3-ggsn-test-kernel-latest-torvalds: - timer: 30 04 * * * + timer: H 04 * * * # Cache the linux source tree in the workspace of one node wipe_workspace: false node: ttcn3-ggsn-test-kernel-git @@ -52,233 +53,233 @@ <a href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/"> torvalds/linux.git</a>. - ttcn3-ggsn-test-ogs: - timer: 35 04 * * * + timer: H 04 * * * description: | Test open5gs-smfd + open5gs-upfd main. email: jenkins-notifications(a)lists.osmocom.org acetcom(a)gmail.com - ttcn3-msc-test: - timer: 40 04 * * * + timer: H 04 * * * - ttcn3-pcu-test: - timer: 00 05 * * * + timer: H 04 * * * - ttcn3-pcu-test-sns: - timer: 15 05 * * * + timer: H 05 * * * - ttcn3-sgsn-test: - timer: 30 05 * * * + timer: H 05 * * * - ttcn3-bsc-test: - timer: 00 06 * * * + timer: H 05 * * * - ttcn3-mgw-test: - timer: 30 06 * * * + timer: H 05 * * * - ttcn3-hlr-test: - timer: 45 06 * * * + timer: H 05 * * * - ttcn3-bts-test: - timer: 00 07 * * * + timer: H 05 * * * - ttcn3-sip-test: - timer: 30 07 * * * + timer: H 05 * * * - ttcn3-bscnat-test: - timer: 00 08 * * * + timer: H 05 * * * disabled: true - ttcn3-bsc-test-sccplite: - timer: 30 08 * * * + timer: H 05 * * * - ttcn3-remsim-test: - timer: 00 09 * * * + timer: H 05 * * * - ttcn3-stp-test: - timer: 30 09 * * * + timer: H 06 * * * - ttcn3-sccp-test: - timer: 00 10 * * * + timer: H 06 * * * - ttcn3-smlc-test: - timer: 10 10 * * * + timer: H 06 * * * - ttcn3-gbproxy-test: - timer: 20 10 * * * + timer: H 06 * * * - ttcn3-gbproxy-test-fr: - timer: 30 10 * * * + timer: H 06 * * * node: hdlc - ttcn3-cbc-test: - timer: 40 10 * * * + timer: H 06 * * * - ttcn3-ns-test: - timer: 00 11 * * * + timer: H 06 * * * - ttcn3-ns-test-sns: - timer: 10 11 * * * + timer: H 06 * * * - ttcn3-ns-test-fr: - timer: 20 11 * * * + timer: H 06 * * * node: hdlc - ttcn3-ns-test-sgsn-sns: - timer: 30 11 * * * + timer: H 06 * * * - ttcn3-pcap-client-test: - timer: 40 11 * * * + timer: H 07 * * * - ttcn3-bsc-test-vamos: - timer: 00 12 * * * + timer: H 07 * * * - ttcn3-hnodeb-test: - timer: 40 12 * * * + timer: H 07 * * * - ttcn3-upf-test: - timer: 00 13 * * * + timer: H 07 * * * - ttcn3-hnbgw-test: - timer: 40 13 * * * + timer: H 07 * * * - ttcn3-fr-test: - timer: 40 10 * * * + timer: H 07 * * * node: hdlc - ttcn3-pgw-test: - timer: 00 14 * * * + timer: H 07 * * * description: | Test open5gs-smfd + open5gs-upfd PGW main. email: jenkins-notifications(a)lists.osmocom.org acetcom(a)gmail.com - ttcn3-mme-test-ogs: - timer: 15 14 * * * + timer: H 07 * * * description: | Test open5gs-mme email: jenkins-notifications(a)lists.osmocom.org acetcom(a)gmail.com - ttcn3-dia2gsup-test: - timer: 30 14 * * * + timer: H 07 * * * # debian latest stable - nplab-m3ua-test-latest: - timer: 10 03 * * * + timer: H 07 * * * - nplab-sua-test-latest: - timer: 15 03 * * * + timer: H 08 * * * - ttcn3-ggsn-test-latest: - timer: 00 04 * * * + timer: H 08 * * * - ttcn3-msc-test-latest: - timer: 30 04 * * * + timer: H 08 * * * - ttcn3-pcu-test-latest: - timer: 00 05 * * * + timer: H 08 * * * - ttcn3-pcu-test-sns-latest: - timer: 15 05 * * * + timer: H 08 * * * - ttcn3-sgsn-test-latest: - timer: 30 05 * * * + timer: H 08 * * * - ttcn3-bsc-test-latest: - timer: 00 06 * * * + timer: H 08 * * * - ttcn3-mgw-test-latest: - timer: 30 06 * * * + timer: H 08 * * * - ttcn3-hlr-test-latest: - timer: 45 06 * * * + timer: H 08 * * * - ttcn3-bts-test-latest: - timer: 00 07 * * * + timer: H 08 * * * - ttcn3-sip-test-latest: - timer: 30 07 * * * + timer: H 09 * * * - ttcn3-bscnat-test-latest: - timer: 00 08 * * * + timer: H 09 * * * disabled: true - ttcn3-bsc-test-sccplite-latest: - timer: 30 08 * * * + timer: H 09 * * * - ttcn3-remsim-test-latest: - timer: 00 09 * * * + timer: H 09 * * * - ttcn3-stp-test-latest: - timer: 30 09 * * * + timer: H 09 * * * - ttcn3-sccp-test-latest: - timer: 00 10 * * * + timer: H 09 * * * - ttcn3-smlc-test-latest: - timer: 10 10 * * * + timer: H 09 * * * - ttcn3-gbproxy-test-latest: - timer: 20 10 * * * + timer: H 09 * * * - ttcn3-gbproxy-test-fr-latest: - timer: 30 10 * * * + timer: H 09 * * * node: hdlc - ttcn3-cbc-test-latest: - timer: 40 10 * * * + timer: H 09 * * * - ttcn3-pcap-client-test-latest: - timer: 40 11 * * * + timer: H 10 * * * - ttcn3-hnodeb-test-latest: - timer: 40 12 * * * + timer: H 10 * * * - ttcn3-upf-test-latest: - timer: 00 13 * * * + timer: H 10 * * * disabled: true - ttcn3-hnbgw-test-latest: - timer: 40 13 * * * + timer: H 10 * * * # Jobs below use uppercase TTCN3-$DISTRO, so they get listed separately from the ttcn3-* (debian) jobs # centos7 nightly - TTCN3-centos7-pcap-client-test: - timer: 10 13 * * * + timer: H 10 * * * # centos7 latest - TTCN3-centos7-pcap-client-test-latest: - timer: 40 13 * * * + timer: H 10 * * * # centos8 nightly - TTCN3-centos-ggsn-test: - timer: 00 04 * * * + timer: H 10 * * * - TTCN3-centos-msc-test: - timer: 30 04 * * * + timer: H 10 * * * - TTCN3-centos-pcu-test: - timer: 00 05 * * * + timer: H 10 * * * - TTCN3-centos-pcu-test-sns: - timer: 15 05 * * * + timer: H 10 * * * - TTCN3-centos-sgsn-test: - timer: 30 05 * * * + timer: H 11 * * * - TTCN3-centos-bsc-test: - timer: 00 06 * * * + timer: H 11 * * * - TTCN3-centos-mgw-test: - timer: 30 06 * * * + timer: H 11 * * * - TTCN3-centos-hlr-test: - timer: 45 06 * * * + timer: H 11 * * * - TTCN3-centos-bts-test: - timer: 00 07 * * * + timer: H 11 * * * - TTCN3-centos-sip-test: - timer: 30 07 * * * + timer: H 11 * * * - TTCN3-centos-bsc-test-sccplite: - timer: 30 08 * * * + timer: H 11 * * * - TTCN3-centos-remsim-test: - timer: 00 09 * * * + timer: H 11 * * * disabled: true - TTCN3-centos-stp-test: - timer: 30 09 * * * + timer: H 11 * * * - TTCN3-centos-gbproxy-test: - timer: 20 10 * * * + timer: H 11 * * * - TTCN3-centos-cbc-test: - timer: 40 10 * * * + timer: H 12 * * * # centos8 latest stable - TTCN3-centos-ggsn-test-latest: - timer: 00 04 * * * + timer: H 12 * * * - TTCN3-centos-msc-test-latest: - timer: 30 04 * * * + timer: H 12 * * * - TTCN3-centos-pcu-test-latest: - timer: 00 05 * * * + timer: H 12 * * * - TTCN3-centos-pcu-test-sns-latest: - timer: 15 05 * * * + timer: H 12 * * * - TTCN3-centos-sgsn-test-latest: - timer: 30 05 * * * + timer: H 12 * * * - TTCN3-centos-bsc-test-latest: - timer: 00 06 * * * + timer: H 12 * * * - TTCN3-centos-mgw-test-latest: - timer: 30 06 * * * + timer: H 12 * * * - TTCN3-centos-hlr-test-latest: - timer: 45 06 * * * + timer: H 12 * * * - TTCN3-centos-bts-test-latest: - timer: 00 07 * * * + timer: H 12 * * * - TTCN3-centos-sip-test-latest: - timer: 30 07 * * * + timer: H 13 * * * - TTCN3-centos-bsc-test-sccplite-latest: - timer: 30 08 * * * + timer: H 13 * * * - TTCN3-centos-remsim-test-latest: - timer: 00 09 * * * + timer: H 13 * * * disabled: true - TTCN3-centos-stp-test-latest: - timer: 30 09 * * * + timer: H 13 * * * - TTCN3-centos-smlc-test-latest: - timer: 10 10 * * * + timer: H 13 * * * - TTCN3-centos-sccp-test-latest: - timer: 00 10 * * * + timer: H 13 * * * - TTCN3-centos-gbproxy-test-latest: - timer: 20 10 * * * + timer: H 13 * * * - TTCN3-centos-cbc-test-latest: - timer: 40 10 * * * + timer: H 13 * * * # centos8 2023q1 (SYS#6283) - TTCN3-centos-pcu-test-2023q1: - timer: 00 17 * * * + timer: H 13 * * * - TTCN3-centos-pcu-test-sns-2023q1: - timer: 15 17 * * * + timer: H 13 * * * - TTCN3-centos-bsc-test-2023q1: - timer: 30 17 * * * + timer: H 14 * * * - TTCN3-centos-mgw-test-2023q1: - timer: 45 17 * * * + timer: H 14 * * * - TTCN3-centos-bts-test-2023q1: - timer: 00 18 * * * + timer: H 14 * * * - TTCN3-centos-smlc-test-2023q1: - timer: 15 18 * * * + timer: H 14 * * * - TTCN3-centos-gbproxy-test-2023q1: - timer: 30 18 * * * + timer: H 14 * * * - job-template: name: '{job-name}' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34400?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib68f9a78bae27a63706a8c95715bf6a244b7bf1d Gerrit-Change-Number: 34400 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 9 months

1
0
0 0

[M] Change in osmo-bsc[master]: bts_siemens_bs11: remove ip.access nanoBTS specific code

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34321?usp=email ) Change subject: bts_siemens_bs11: remove ip.access nanoBTS specific code ...................................................................... bts_siemens_bs11: remove ip.access nanoBTS specific code This code is unreachable, because this file is all about Siemens BS11. Take a chance to remove redundant BTS type check in nm_reconfig_bts(). Change-Id: I2db92fe448b1f4cd25c1e5c6e1bb9593795c9cb2 Related: OS#4505 --- M src/osmo-bsc/bts_siemens_bs11.c 1 file changed, 41 insertions(+), 56 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_siemens_bs11.c b/src/osmo-bsc/bts_siemens_bs11.c index d1fbeaa..9e4f091 100644 --- a/src/osmo-bsc/bts_siemens_bs11.c +++ b/src/osmo-bsc/bts_siemens_bs11.c @@ -423,57 +423,35 @@ patch_nm_tables(trx->bts); - switch (trx->bts->type) { - case GSM_BTS_TYPE_BS11: - /* FIXME: discover this by fetching an attribute */ + /* FIXME: discover this by fetching an attribute */ #if 0 - trx->nominal_power = 15; /* 15dBm == 30mW PA configuration */ + trx->nominal_power = 15; /* 15dBm == 30mW PA configuration */ #else - trx->nominal_power = 24; /* 24dBm == 250mW PA configuration */ + trx->nominal_power = 24; /* 24dBm == 250mW PA configuration */ #endif - abis_nm_conn_terr_sign(trx, e1l->e1_nr, e1l->e1_ts, - e1l->e1_ts_ss); - abis_nm_establish_tei(trx->bts, trx->nr, e1l->e1_nr, - e1l->e1_ts, e1l->e1_ts_ss, trx->rsl_tei_primary); + abis_nm_conn_terr_sign(trx, e1l->e1_nr, e1l->e1_ts, + e1l->e1_ts_ss); + abis_nm_establish_tei(trx->bts, trx->nr, e1l->e1_nr, + e1l->e1_ts, e1l->e1_ts_ss, trx->rsl_tei_primary); - /* Set Radio Attributes */ - if (trx == trx->bts->c0) - abis_nm_set_radio_attr(trx, bs11_attr_radio, - sizeof(bs11_attr_radio)); - else { - uint8_t trx1_attr_radio[sizeof(bs11_attr_radio)]; - uint8_t arfcn_low = trx->arfcn & 0xff; - uint8_t arfcn_high = (trx->arfcn >> 8) & 0x0f; - memcpy(trx1_attr_radio, bs11_attr_radio, - sizeof(trx1_attr_radio)); + /* Set Radio Attributes */ + if (trx == trx->bts->c0) + abis_nm_set_radio_attr(trx, bs11_attr_radio, + sizeof(bs11_attr_radio)); + else { + uint8_t trx1_attr_radio[sizeof(bs11_attr_radio)]; + uint8_t arfcn_low = trx->arfcn & 0xff; + uint8_t arfcn_high = (trx->arfcn >> 8) & 0x0f; + memcpy(trx1_attr_radio, bs11_attr_radio, + sizeof(trx1_attr_radio)); - /* patch ARFCN into TRX Attributes */ - trx1_attr_radio[2] &= 0xf0; - trx1_attr_radio[2] |= arfcn_high; - trx1_attr_radio[3] = arfcn_low; + /* patch ARFCN into TRX Attributes */ + trx1_attr_radio[2] &= 0xf0; + trx1_attr_radio[2] |= arfcn_high; + trx1_attr_radio[3] = arfcn_low; - abis_nm_set_radio_attr(trx, trx1_attr_radio, - sizeof(trx1_attr_radio)); - } - break; - case GSM_BTS_TYPE_NANOBTS: - switch (trx->bts->band) { - case GSM_BAND_850: - case GSM_BAND_900: - trx->nominal_power = 20; - break; - case GSM_BAND_1800: - case GSM_BAND_1900: - trx->nominal_power = 23; - break; - default: - LOGP(DNM, LOGL_ERROR, "Unsupported nanoBTS GSM band %s\n", - gsm_band_name(trx->bts->band)); - break; - } - break; - default: - break; + abis_nm_set_radio_attr(trx, trx1_attr_radio, + sizeof(trx1_attr_radio)); } for (i = 0; i < TRX_NR_TS; i++) @@ -484,17 +462,11 @@ { struct gsm_bts_trx *trx; - switch (bts->type) { - case GSM_BTS_TYPE_BS11: - patch_nm_tables(bts); - abis_nm_raw_msg(bts, sizeof(msg_1), msg_1); /* set BTS SiteMgr attr*/ - abis_nm_set_bts_attr(bts, bs11_attr_bts, sizeof(bs11_attr_bts)); - abis_nm_raw_msg(bts, sizeof(msg_3), msg_3); /* set BTS handover attr */ - abis_nm_raw_msg(bts, sizeof(msg_4), msg_4); /* set BTS power control attr */ - break; - default: - break; - } + patch_nm_tables(bts); + abis_nm_raw_msg(bts, sizeof(msg_1), msg_1); /* set BTS SiteMgr attr*/ + abis_nm_set_bts_attr(bts, bs11_attr_bts, sizeof(bs11_attr_bts)); + abis_nm_raw_msg(bts, sizeof(msg_3), msg_3); /* set BTS handover attr */ + abis_nm_raw_msg(bts, sizeof(msg_4), msg_4); /* set BTS power control attr */ llist_for_each_entry(trx, &bts->trx_list, list) nm_reconfig_trx(trx); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34321?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2db92fe448b1f4cd25c1e5c6e1bb9593795c9cb2 Gerrit-Change-Number: 34321 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 9 months

1
0
0 0

[M] Change in osmo-bsc[master]: abis_nm: parse feature flags in NM_ATT_IPACC_SUPP_FEATURES

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34323?usp=email ) Change subject: abis_nm: parse feature flags in NM_ATT_IPACC_SUPP_FEATURES ...................................................................... abis_nm: parse feature flags in NM_ATT_IPACC_SUPP_FEATURES Since change [1], among with the other attributes we started requesting NM_ATT_IPACC_SUPP_FEATURES from the BTS. This patch adds the logic for parsing the response (so far only printing supported features). Change-Id: I64cffa0bdead3617cc169c83b0f6ddf74f0866a7 Related: [1] 43440e1fc5758c52e80a0d182afa7c9d16b21426 Depends: libosmocore.git Ia4208e10d61843dd6ae77398f6624c918dc81ea4 Related: OS#4505 --- M include/osmocom/bsc/bts_ipaccess_nanobts_omlattr.h M src/osmo-bsc/abis_nm.c M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c 3 files changed, 97 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/include/osmocom/bsc/bts_ipaccess_nanobts_omlattr.h b/include/osmocom/bsc/bts_ipaccess_nanobts_omlattr.h index dd97a0a..9f51efd 100644 --- a/include/osmocom/bsc/bts_ipaccess_nanobts_omlattr.h +++ b/include/osmocom/bsc/bts_ipaccess_nanobts_omlattr.h @@ -23,12 +23,19 @@ #include <stdint.h> #include <osmocom/core/msgb.h> +#include <osmocom/gsm/tlv.h> struct gsm_bts_sm; struct gsm_bts; struct gsm_bts_trx; struct gsm_gprs_nsvc; +extern const struct tlv_definition ipacc_eie_tlv_def; + +int ipacc_parse_supp_features(const struct gsm_bts *bts, + const struct abis_om_fom_hdr *foh, + const uint8_t *data, uint16_t data_len); + struct msgb *nanobts_gen_set_bts_attr(struct gsm_bts *bts); struct msgb *nanobts_gen_set_nse_attr(struct gsm_bts_sm *bts_sm); struct msgb *nanobts_gen_set_cell_attr(struct gsm_bts *bts); diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index aa6a3a5..1b544fe 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -52,6 +52,7 @@ #include <osmocom/bsc/nm_common_fsm.h> #include <osmocom/gsm/bts_features.h> #include <osmocom/bsc/ipaccess.h> +#include <osmocom/bsc/bts_ipaccess_nanobts_omlattr.h> #define OM_ALLOC_SIZE 1024 #define OM_HEADROOM_SIZE 128 @@ -560,7 +561,6 @@ return ari + num_unreported + 1; /* we have to account for 1st byte with number of unreported attributes */ } - /* Parse Attribute Response Info content for 3GPP TS 52.021 §9.4.30 Manufacturer Id */ static void parse_osmo_bts_features(struct gsm_bts *bts, const uint8_t *data, uint16_t data_len) @@ -618,6 +618,12 @@ parse_osmo_bts_features(bts, TLVP_VAL(tp, NM_ATT_MANUF_ID), TLVP_LEN(tp, NM_ATT_MANUF_ID)); } + /* fall-through */ + case GSM_BTS_TYPE_NANOBTS: + if (TLVP_PRESENT(tp, NM_ATT_IPACC_SUPP_FEATURES)) { + ipacc_parse_supp_features(bts, foh, TLVP_VAL(tp, NM_ATT_IPACC_SUPP_FEATURES), + TLVP_LEN(tp, NM_ATT_IPACC_SUPP_FEATURES)); + } break; default: break; diff --git a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c index d78f23b..c65b701 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c @@ -26,6 +26,73 @@ #include <osmocom/bsc/bts.h> #include <osmocom/gsm/bts_features.h> +const struct tlv_definition ipacc_eie_tlv_def = { + .def = { + /* TODO: add more values from enum ipac_eie */ + [NM_IPAC_EIE_FREQ_BANDS] = { TLV_TYPE_TL16V }, + [NM_IPAC_EIE_MAX_TA] = { TLV_TYPE_TL16V }, + [NM_IPAC_EIE_CIPH_ALGOS] = { TLV_TYPE_TL16V }, + [NM_IPAC_EIE_CHAN_TYPES] = { TLV_TYPE_TL16V }, + [NM_IPAC_EIE_CHAN_MODES] = { TLV_TYPE_TL16V }, + [NM_IPAC_EIE_GPRS_CODING] = { TLV_TYPE_TL16V }, + [NM_IPAC_EIE_RTP_FEATURES] = { TLV_TYPE_TL16V }, + [NM_IPAC_EIE_RSL_FEATURES] = { TLV_TYPE_TL16V }, + } +}; + +static inline uint32_t ipacc_parse_supp_flags(const struct abis_om_fom_hdr *foh, + const struct value_string *flags, + const struct tlv_p_entry *e, + const char *text) +{ + uint32_t u32 = 0; + + for (unsigned int i = 0; i < OSMO_MAX(e->len, 4); i++) + u32 |= e->val[i] << (i * 8); + for (const struct value_string *vs = flags; vs->value && vs->str; vs++) { + if (u32 & vs->value) + LOGPFOH(DNM, LOGL_DEBUG, foh, "%s '%s' is supported\n", text, vs->str); + } + + return u32; +} + +/* Parse ip.access Supported Features IE */ +int ipacc_parse_supp_features(const struct gsm_bts *bts, + const struct abis_om_fom_hdr *foh, + const uint8_t *data, uint16_t data_len) +{ + const struct tlv_p_entry *e; + struct tlv_parsed tp; + + if (tlv_parse(&tp, &ipacc_eie_tlv_def, data, data_len, 0, 0) < 0) { + LOGPFOH(DNM, LOGL_ERROR, foh, "%s(): tlv_parse failed\n", __func__); + return -EINVAL; + } + + /* TODO: store the flags in the respective MO state */ + if ((e = TLVP_GET(&tp, NM_IPAC_EIE_FREQ_BANDS)) != NULL) + ipacc_parse_supp_flags(foh, abis_nm_ipacc_freq_band_desc, e, "Freq. band"); + if ((e = TLVP_GET(&tp, NM_IPAC_EIE_CIPH_ALGOS)) != NULL) + ipacc_parse_supp_flags(foh, abis_nm_ipacc_ciph_algo_desc, e, "Ciphering algorithm"); + if ((e = TLVP_GET(&tp, NM_IPAC_EIE_CHAN_TYPES)) != NULL) + ipacc_parse_supp_flags(foh, abis_nm_ipacc_chant_desc, e, "Channel type"); + if ((e = TLVP_GET(&tp, NM_IPAC_EIE_CHAN_MODES)) != NULL) + ipacc_parse_supp_flags(foh, abis_nm_ipacc_chanm_desc, e, "Channel mode"); + if ((e = TLVP_GET(&tp, NM_IPAC_EIE_GPRS_CODING)) != NULL) + ipacc_parse_supp_flags(foh, abis_nm_ipacc_gprs_coding_desc, e, "GPRS Coding Scheme"); + if ((e = TLVP_GET(&tp, NM_IPAC_EIE_RTP_FEATURES)) != NULL) + ipacc_parse_supp_flags(foh, abis_nm_ipacc_rtp_feat_desc, e, "RTP Feature"); + if ((e = TLVP_GET(&tp, NM_IPAC_EIE_RSL_FEATURES)) != NULL) + ipacc_parse_supp_flags(foh, abis_nm_ipacc_rsl_feat_desc, e, "RSL Feature"); + if (TLVP_PRES_LEN(&tp, NM_IPAC_EIE_MAX_TA, 1)) { + uint8_t u8 = *TLVP_VAL(&tp, NM_IPAC_EIE_MAX_TA); + LOGPFOH(DNM, LOGL_DEBUG, foh, "Max Timing Advance %u\n", u8); + } + + return 0; +} + /* 3GPP TS 52.021 section 8.6.1 Set BTS Attributes */ struct msgb *nanobts_gen_set_bts_attr(struct gsm_bts *bts) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34323?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I64cffa0bdead3617cc169c83b0f6ddf74f0866a7 Gerrit-Change-Number: 34323 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2023