osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/34405?usp=email )
Change subject: contrib/jenkins: do install --user
......................................................................
Patch Set 1: Verified+1
(1 comment)
Patchset:
PS1:
CI failure is unrelated, fix is in the next patch
--
To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/34405?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Change-Id: Iebed8e3832047e8f19e5a88fcddd1a8242b9f096
Gerrit-Change-Number: 34405
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 13 Sep 2023 14:02:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/34406?usp=email )
Change subject: tests/test_py3: fix deprecated loop arg
......................................................................
tests/test_py3: fix deprecated loop arg
The loop arg has been removed in python 3.10. The same event loop will
be used without passing the argument, so it can be removed.
Fix for:
TypeError: gather() got an unexpected keyword argument 'loop'
Related: https://stackoverflow.com/a/60315290
Related: https://docs.python.org/3/library/asyncio-task.html#asyncio.gather
Change-Id: I776bc463246e7a1a9adbb7c06012353d65694507
---
M tests/test_py3.py
1 file changed, 18 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests refs/changes/06/34406/1
diff --git a/tests/test_py3.py b/tests/test_py3.py
index 0d526a9..710dcb8 100644
--- a/tests/test_py3.py
+++ b/tests/test_py3.py
@@ -46,7 +46,7 @@
print('Serving on {}...'.format(server.sockets[0].getsockname()))
# Async client running in the subprocess plugged to the same event loop
- loop.run_until_complete(asyncio.gather(asyncio.create_subprocess_exec('./scripts/osmo_ctrl.py', '-g', 'mnc', '-d', test_host, '-p', test_port), loop = loop))
+ loop.run_until_complete(asyncio.gather(asyncio.create_subprocess_exec('./scripts/osmo_ctrl.py', '-g', 'mnc', '-d', test_host, '-p', test_port)))
loop.run_forever()
--
To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/34406?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Change-Id: I776bc463246e7a1a9adbb7c06012353d65694507
Gerrit-Change-Number: 34406
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange