August 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: pcu_sock: use PCU_IF_SAPI_AGCH_2 instead PCU_IF_SAPI_AGCH

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34059 ) Change subject: pcu_sock: use PCU_IF_SAPI_AGCH_2 instead PCU_IF_SAPI_AGCH ...................................................................... Patch Set 4: Code-Review+2 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/34059/comment/5a247c05_3683d840 PS4, Line 14: CAUTION: This patch breaks compatibility to current master osmo-pcu (See : also "Depends") Normally such breaking changes should be accompanied with the protocol version bump. It's definitely not good that we end up with software A speaking PCUIFv11 being not compatible with older software B speaking the same PCUIFv11 (even despite we didn't tag releases yet). The PCUIFv11 is in development since March (and in used by both osmo-{bts,pcu} since July), but months later still being modified. This creates compatibility problems for people using nightly/master builds and makes life harder for those doing git-bisect... File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/34059/comment/4c7ee6c3_5090bc07 PS4, Line 733: struct bts_agch_msg_cb *msg_cb const -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34059 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I29858fa20ad8bd0aefe81a5c40ad77a2559a8c10 Gerrit-Change-Number: 34059 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Aug 2023 21:42:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in osmo-bts[master]: pcuif_proto: use confirm flag in struct gsm_pcu_if_pch

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34191 ) Change subject: pcuif_proto: use confirm flag in struct gsm_pcu_if_pch ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34191 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3364d2268bdef9c4d2feeb8e3d51a64e34bca68c Gerrit-Change-Number: 34191 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Aug 2023 21:19:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Translate GSUP Auth Info Answer error Cause in Diamater AIA

by fixeria

Attention is currently required from: pespin, daniel, lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259 ) Change subject: Translate GSUP Auth Info Answer error Cause in Diamater AIA ...................................................................... Patch Set 1: (1 comment) File src/server_cb.erl: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/82dd6a5a_… PS1, Line 197: TODO: more values This TODO can be removed I guess? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I32622713c2c1f40e1d9c5597ffab8cb211171fc2 Gerrit-Change-Number: 34259 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 30 Aug 2023 20:43:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Add GMM error cause present in osmo-hlr's gsm48_gmm_cause_vty_names

by fixeria

Attention is currently required from: pespin, daniel, lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34258 ) Change subject: Add GMM error cause present in osmo-hlr's gsm48_gmm_cause_vty_names ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I77336cb2c76a516ecea5b46500da91fd4230176d Gerrit-Change-Number: 34258 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 30 Aug 2023 18:57:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Translate GSUP Auth Info Answer error Cause in Diamater AIA

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259 ) Change subject: Translate GSUP Auth Info Answer error Cause in Diamater AIA ...................................................................... Patch Set 1: (1 comment) File src/server_cb.erl: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/40e0d681_… PS1, Line 185: gsup_cause2dia(?GMM_CAUSE_ILLEGAL_MS) -> {[], [?EXP_RES(?DIAMETER_ERROR_USER_UNKNOWN)]}; I may actually want to return a Result-Code in some of this instead, I need to check what do we have in "Diameter Base Protocol" -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I32622713c2c1f40e1d9c5597ffab8cb211171fc2 Gerrit-Change-Number: 34259 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 30 Aug 2023 18:52:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Add GMM error cause present in osmo-hlr's gsm48_gmm_cause_vty_names

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34258 ) Change subject: Add GMM error cause present in osmo-hlr's gsm48_gmm_cause_vty_names ...................................................................... Add GMM error cause present in osmo-hlr's gsm48_gmm_cause_vty_names Change-Id: I77336cb2c76a516ecea5b46500da91fd4230176d --- M src/server_cb.erl 1 file changed, 18 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/58/34258/1 diff --git a/src/server_cb.erl b/src/server_cb.erl index 35dbb63..482ba9a 100644 --- a/src/server_cb.erl +++ b/src/server_cb.erl @@ -165,11 +165,17 @@ % 10.5.5.14 -define(GMM_CAUSE_IMSI_UNKNOWN, 16#02). --define(GMM_CAUSE_PLMN_NOTALLOWED, 16#0b). +-define(GMM_CAUSE_ILLEGAL_MS, 16#03). -define(GMM_CAUSE_GPRS_NOTALLOWED, 16#07). --define(GMM_CAUSE_INV_MAND_INFO, 16#60). +-define(GMM_CAUSE_PLMN_NOTALLOWED, 16#0b). +-define(GMM_CAUSE_LA_NOTALLOWED, 16#0c). +-define(GMM_CAUSE_ROAMING_NOTALLOWED, 16#0d). +-define(GMM_CAUSE_NO_SUIT_CELL_IN_LA, 16#0f). -define(GMM_CAUSE_NET_FAIL, 16#11). -% TODO: more values +-define(GMM_CAUSE_CONGESTION, 16#16). +-define(GMM_CAUSE_GSM_AUTH_UNACCEPT, 16#17). +-define(GMM_CAUSE_INV_MAND_INFO, 16#60). +-define(GMM_CAUSE_PROTO_ERR_UNSPEC, 16#6f). -define(EXP_RES(Foo), #'Experimental-Result'{'Vendor-Id'=fixme, 'Experimental-Result-Code'=Foo}). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I77336cb2c76a516ecea5b46500da91fd4230176d Gerrit-Change-Number: 34258 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Translate GSUP Auth Info Answer error Cause in Diamater AIA

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259 ) Change subject: Translate GSUP Auth Info Answer error Cause in Diamater AIA ...................................................................... Translate GSUP Auth Info Answer error Cause in Diamater AIA Change-Id: I32622713c2c1f40e1d9c5597ffab8cb211171fc2 --- M src/server_cb.erl 1 file changed, 26 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/59/34259/1 diff --git a/src/server_cb.erl b/src/server_cb.erl index 482ba9a..a6450dd 100644 --- a/src/server_cb.erl +++ b/src/server_cb.erl @@ -177,15 +177,23 @@ -define(GMM_CAUSE_INV_MAND_INFO, 16#60). -define(GMM_CAUSE_PROTO_ERR_UNSPEC, 16#6f). --define(EXP_RES(Foo), #'Experimental-Result'{'Vendor-Id'=fixme, 'Experimental-Result-Code'=Foo}). +-define(EXP_RES(Foo), #'Experimental-Result'{'Vendor-Id'=10415, 'Experimental-Result-Code'=Foo}). -type empty_or_intl() :: [] | [integer()]. -spec gsup_cause2dia(integer()) -> {empty_or_intl(), empty_or_intl()}. gsup_cause2dia(?GMM_CAUSE_IMSI_UNKNOWN) -> {[], [?EXP_RES(?DIAMETER_ERROR_USER_UNKNOWN)]}; -gsup_cause2dia(?GMM_CAUSE_PLMN_NOTALLOWED) -> {[], [?DIAMETER_ERROR_ROAMING_NOT_ALLOWED]}; -gsup_cause2dia(?GMM_CAUSE_GPRS_NOTALLOWED) -> {[], [?DIAMETER_ERROR_RAT_NOT_ALLOWED]}; -%gsup_cause2dia(?GMM_CAUSE_INV_MAND_INFO) -> -%gsup_cause2dia(?GMM_CAUSE_NET_FAIL) -> +gsup_cause2dia(?GMM_CAUSE_ILLEGAL_MS) -> {[], [?EXP_RES(?DIAMETER_ERROR_USER_UNKNOWN)]}; +gsup_cause2dia(?GMM_CAUSE_PLMN_NOTALLOWED) -> {[], [?EXP_RES(?DIAMETER_ERROR_ROAMING_NOT_ALLOWED)]}; +gsup_cause2dia(?GMM_CAUSE_GPRS_NOTALLOWED) -> {[], [?EXP_RES(?DIAMETER_ERROR_RAT_NOT_ALLOWED)]}; + +gsup_cause2dia(?GMM_CAUSE_LA_NOTALLOWED) -> {[], [?EXP_RES(?DIAMETER_ERROR_RAT_NOT_ALLOWED)]}; +gsup_cause2dia(?GMM_CAUSE_ROAMING_NOTALLOWED) -> {[], [?EXP_RES(?DIAMETER_ERROR_ROAMING_NOT_ALLOWED)]}; +gsup_cause2dia(?GMM_CAUSE_NO_SUIT_CELL_IN_LA) -> {[], [?EXP_RES(?DIAMETER_ERROR_UNKOWN_SERVING_NODE)]}; +gsup_cause2dia(?GMM_CAUSE_NET_FAIL) -> {[], [?EXP_RES(?DIAMETER_AUTHENTICATION_DATA_UNAVAILABLE)]}; +gsup_cause2dia(?GMM_CAUSE_CONGESTION) -> {[], [?EXP_RES(?DIAMETER_AUTHENTICATION_DATA_UNAVAILABLE)]}; +gsup_cause2dia(?GMM_CAUSE_GSM_AUTH_UNACCEPT) -> {[], [?EXP_RES(?DIAMETER_ERROR_USER_UNKNOWN)]}; +gsup_cause2dia(?GMM_CAUSE_INV_MAND_INFO) -> {[], [?EXP_RES(?DIAMETER_ERROR_UNKOWN_SERVING_NODE)]}; +gsup_cause2dia(?GMM_CAUSE_PROTO_ERR_UNSPEC) -> {[], [?EXP_RES(?DIAMETER_ERROR_UNKOWN_SERVING_NODE)]}; % TODO: more values gsup_cause2dia(_) -> {fixme, []}. @@ -229,9 +237,11 @@ Resp = #'AIA'{'Session-Id'=SessionId, 'Origin-Host'=OH, 'Origin-Realm'=OR, 'Result-Code'=2001, 'Auth-Session-State'=1, 'Authentication-Info'=AuthInfo}; - #{message_type := send_auth_info_err} -> + #{message_type := send_auth_info_err, cause:=Cause} -> + {Res, ExpRes} = gsup_cause2dia(Cause), Resp = #'AIA'{'Session-Id'=SessionId, 'Origin-Host'=OH, 'Origin-Realm'=OR, - 'Result-Code'=?DIAMETER_ERROR_USER_UNKNOWN, + 'Result-Code'=Res, + 'Experimental-Result'=ExpRes, 'Auth-Session-State'=1}; timeout -> Resp = #'AIA'{'Session-Id'=SessionId, 'Origin-Host'=OH, 'Origin-Realm'=OR, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I32622713c2c1f40e1d9c5597ffab8cb211171fc2 Gerrit-Change-Number: 34259 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 11 months

1
0
0 0

[S] Change in libosmocore[master]: osmo_io: Change parent of msghdr to iofd (instead of msg)

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34256 ) Change subject: osmo_io: Change parent of msghdr to iofd (instead of msg) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I41277190e3020cd8fa625bd57a743973e2a65c4b Gerrit-Change-Number: 34256 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Aug 2023 15:42:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in libosmocore[master]: osmo_io: Use local variable to reference msghdr->msg

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34257 ) Change subject: osmo_io: Use local variable to reference msghdr->msg ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I336ef7a5460dd18bf8e0f4ac5e97747f9fec5a35 Gerrit-Change-Number: 34257 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Aug 2023 15:41:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[S] Change in libosmocore[master]: osmo_io: Change parent of msghdr to iofd (instead of msg)

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34256 ) Change subject: osmo_io: Change parent of msghdr to iofd (instead of msg) ...................................................................... osmo_io: Change parent of msghdr to iofd (instead of msg) msg was made a parent of msghdr after discussion in change I3a279b55a3adff96948120683c844e1508d0ba94 It turns out this violates some assumptions made in osmo_io, specifically that the user read callback shall free msg, but we expect msghdr to remain valid until after that callback returns. In general I think it is cleaner to make iofd a parent of msghdr. Change-Id: I41277190e3020cd8fa625bd57a743973e2a65c4b --- M src/core/osmo_io.c 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/56/34256/1 diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index e176099..c67787b 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -120,7 +120,7 @@ talloc_steal(iofd, msg); } - hdr = talloc_zero(msg, struct iofd_msghdr); + hdr = talloc_zero(iofd, struct iofd_msghdr); if (!hdr) { if (free_msg) talloc_free(msg); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I41277190e3020cd8fa625bd57a743973e2a65c4b Gerrit-Change-Number: 34256 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023