Attention is currently required from: dexter.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/34059 )
Change subject: pcu_sock: use PCU_IF_SAPI_AGCH_2 instead PCU_IF_SAPI_AGCH
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bts/+/34059/comment/5a247c05_3683d840
PS4, Line 14: CAUTION: This patch breaks compatibility to current master osmo-pcu (See
: also "Depends")
Normally such breaking changes should be accompanied with the protocol version bump.
It's definitely not good that we end up with software A speaking PCUIFv11 being not
compatible with older software B speaking the same PCUIFv11 (even despite we didn't
tag releases yet). The PCUIFv11 is in development since March (and in used by both
osmo-{bts,pcu} since July), but months later still being modified. This creates
compatibility problems for people using nightly/master builds and makes life harder for
those doing git-bisect...
File src/common/bts.c:
https://gerrit.osmocom.org/c/osmo-bts/+/34059/comment/4c7ee6c3_5090bc07
PS4, Line 733: struct bts_agch_msg_cb *msg_cb
const
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/34059
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I29858fa20ad8bd0aefe81a5c40ad77a2559a8c10
Gerrit-Change-Number: 34059
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 30 Aug 2023 21:42:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment