August 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: PCUIF: fix coding of 'lqual_cb' field in PCUIF_data

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34247 ) Change subject: PCUIF: fix coding of 'lqual_cb' field in PCUIF_data ...................................................................... PCUIF: fix coding of 'lqual_cb' field in PCUIF_data This patch fixes BTS_Tests.TC_pcu_data_ind_lqual_cb, which is currently failing due to incorrect decoding of the 'lqual_cb' field: "Link quality -32512 does not match expected value -256" The COMP attribute is documented in TITAN's reference guide, see 4-ttcn3_language_extensions.adoc#attributes for more info. Change-Id: I79b8cd41010f212898fbf39c4c600ace69603e79 Related: OS#5954 --- M library/PCUIF_Types.ttcn 1 file changed, 22 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn index b8bd6e9..b6a1bfa 100644 --- a/library/PCUIF_Types.ttcn +++ b/library/PCUIF_Types.ttcn @@ -103,7 +103,10 @@ uint16_t ber10k, int16_t ta_offs_qbits, int16_t lqual_cb -} with { variant (data) "FIELDLENGTH(162), ALIGN(left)" }; +} with { + variant (data) "FIELDLENGTH(162), ALIGN(left)" + variant (lqual_cb) "COMP(2scompl)" +}; type record PCUIF_data_cnf { PCUIF_Sapi sapi, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34247 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79b8cd41010f212898fbf39c4c600ace69603e79 Gerrit-Change-Number: 34247 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: PCUIF: fix coding of 'lqual_cb' field in PCUIF_data

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34247 ) Change subject: PCUIF: fix coding of 'lqual_cb' field in PCUIF_data ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34247 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79b8cd41010f212898fbf39c4c600ace69603e79 Gerrit-Change-Number: 34247 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Aug 2023 09:19:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: ASCI: Add tests for voice group/broadcast calls at MSC

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979 ) Change subject: ASCI: Add tests for voice group/broadcast calls at MSC ...................................................................... ASCI: Add tests for voice group/broadcast calls at MSC Related: OS#4854 Change-Id: I4bbe739ea55ecf9f7ebf9ee413df69f29aa642f8 --- M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.cfg M msc/MSC_Tests.ttcn A msc/MSC_Tests_ASCI.ttcn 4 files changed, 718 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index 396c3f7..e25d496 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -1517,7 +1517,7 @@ } } -private altstep as_optional_mgcp_mdcx(HostName mgw_rtp_ip, PortNumber mgw_rtp_port) runs on BSC_ConnHdlr { +altstep as_optional_mgcp_mdcx(HostName mgw_rtp_ip, PortNumber mgw_rtp_port) runs on BSC_ConnHdlr { var MgcpCommand mgcp_cmd; [] MGCP.receive(tr_MDCX) -> value mgcp_cmd { log("as_optional_mgcp_mdcx: rx MDCX"); @@ -1540,7 +1540,7 @@ } } -private altstep as_optional_mgcp_dlcx(CallParameters cpars) runs on BSC_ConnHdlr { +altstep as_optional_mgcp_dlcx(CallParameters cpars) runs on BSC_ConnHdlr { var MgcpCommand mgcp_cmd; var boolean respond_to_dlcx := not (isbound(cpars.mgw_drop_dlcx) and valueof(cpars.mgw_drop_dlcx)); [] MGCP.receive(tr_DLCX(?)) -> value mgcp_cmd { diff --git a/msc/MSC_Tests.cfg b/msc/MSC_Tests.cfg index 7894099..ee36336 100644 --- a/msc/MSC_Tests.cfg +++ b/msc/MSC_Tests.cfg @@ -17,6 +17,7 @@ [EXECUTE] MSC_Tests.control MSC_Tests_Iu.control +MSC_Tests_ASCI.control #MSC_Tests.TC_cr_before_reset #MSC_Tests.TC_lu_imsi_noauth_tmsi #MSC_Tests.TC_lu_imsi_noauth_notmsi diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 0bd1b02..6f23e5f 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -13,6 +13,7 @@ */ friend module MSC_Tests_Iu; +friend module MSC_Tests_ASCI; import from General_Types all; import from Osmocom_Types all; diff --git a/msc/MSC_Tests_ASCI.ttcn b/msc/MSC_Tests_ASCI.ttcn new file mode 100644 index 0000000..76d8d3c --- /dev/null +++ b/msc/MSC_Tests_ASCI.ttcn @@ -0,0 +1,704 @@ +module MSC_Tests_ASCI { + +/* Osmocom MSC test suite for ASCI support in TTCN-3 + * (C) 2023 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * All Rights Reserved + * + * Author: Andreas Eversberg + * + * Released under the terms of GNU General Public License, Version 2 or + * (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +import from General_Types all; +import from Osmocom_Types all; + +import from BSC_ConnectionHandler all; +import from MSC_Tests all; + +import from Osmocom_VTY_Functions all; + +import from GSUP_Emulation all; +import from RAN_Emulation all; +import from MGCP_Emulation all; + +import from RANAP_Templates all; + +import from BSSAP_Types all; +import from BSSMAP_Templates all; + +import from L3_Templates all; + +import from MobileL3_CommonIE_Types all; + + +/* Call control for VGCS and VBS + * + * There are 3 connection: + * - "call" = voice group/broadcast call initiated by the calling subscriber + * - "control" = VGCS/VBS call control connection + * - "channel" = VGCS/VBS channel resource connection + * + * All 3 connections have their own handlers. They send their test results via + * COORD messages to the main test function. There the result is collected and + * the outcome of the test is checked. + */ + +/* Test functions */ +const charstring COORD_TEST_NO_CALLREF := "TEST_NO_CALLREF"; +const charstring COORD_TEST_SETUP_REFUSE := "TEST_SETUP_REFUSE"; +const charstring COORD_TEST_ASSIGN_FAIL := "TEST_ASSIGN_FAIL"; +const charstring COORD_TEST_COMPLETE_VGCS := "TEST_COMPLETE_VGCS"; +const charstring COORD_TEST_COMPLETE_VBS := "TEST_COMPLETE_VBS"; + +/* COORD pipes for each connection */ +type component asci_CT extends MTC_CT { + port BSC_ConnHdlr_Coord_PT COORD_call; + port BSC_ConnHdlr_Coord_PT COORD_control; + port BSC_ConnHdlr_Coord_PT COORD_channel; +} + +/* COORD messages for test events */ +const charstring COORD_SETUP := "SETUP"; +const charstring COORD_VGCS_SETUP := "VGCS_SETUP"; +const charstring COORD_VGCS_ASSIGN := "VGCS_ASSIGN"; +const charstring COORD_UPLINK_SEIZED := "UPLINK_SEIZED"; +const charstring COORD_GCC_CONNECT := "GCC_CONNECT"; +const charstring COORD_BCC_CONNECT := "BCC_CONNECT"; +const charstring COORD_GCC_SET_PARAM := "GCC_SET_PARAM"; +const charstring COORD_BCC_SET_PARAM := "BCC_SET_PARAM"; +const charstring COORD_UPLINK_REQ_ACK := "UPLINK_REQ_ACK"; +const charstring COORD_GCC_TERMINATION := "GCC_TERMINATION"; +const charstring COORD_BCC_TERMINATION := "BCC_TERMINATION"; +const charstring COORD_GCC_TERMINATION_FAIL := "GCC_TERMINATION_FAIL"; +const charstring COORD_BCC_TERMINATION_FAIL := "BCC_TERMINATION_FAIL"; +const charstring COORD_ASSIGNMENT := "ASSIGNMENT"; +const charstring COORD_CLEAR := "CLEAR"; + +template (value) DescriptiveGroupOrBroadcastCallReference_V + ts_BSSMAP_IE_GroupCallRef(integer cr, + BIT1 sf, + BIT1 af, + BIT3 prio, + BIT4 ci) := { + binaryCodingOfGroupOrBroadcastCallReference := int2bit(cr, 27), + sF := sf, + aF := af, + callPriority := prio, + cipheringInformation := ci, + spare := '0000'B +} + +function f_gen_asci_ass_res(integer bssap_idx := 0, + template (value) BSSMAP_IE_ChannelType ch_type := ts_BSSMAP_IE_ChannelType, + template (value) BSSMAP_IE_CellIdentifier cell_id := ts_CellId_CI(0), + template (omit) BSSMAP_IE_AoIP_TransportLayerAddress aoip_tla := omit, + template (omit) BSSMAP_IE_SpeechCodec codec := omit, + template (omit) OCT4 call_id := omit) +runs on BSC_ConnHdlr return template (value) PDU_BSSAP { + if (mp_bssap_cfg[bssap_idx].transport == BSSAP_TRANSPORT_AoIP) { + return ts_BSSMAP_VGCS_VBS_AssignmentRes(ch_type, cell_id, omit, omit, aoip_tla, codec, call_id); + } else { + var template (value) BSSMAP_IE_CircuitIdentityCode cic := ts_BSSMAP_IE_CIC(0,1); + return ts_BSSMAP_VGCS_VBS_AssignmentRes(ch_type, cell_id, omit, cic, omit, omit, omit); + } +} + +/* "call" connection handling */ +private function f_tc_vgcs_call(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr +{ + /* Receive test case from main function. */ + var charstring test; + COORD.receive(charstring:?) -> value test; + + /* Initialize variables and templates. */ + var CallParameters cpars := valueof(t_CallParams('12345'H, 0)); + var template (value) DescriptiveGroupOrBroadcastCallReference_V callref := + ts_BSSMAP_IE_GroupCallRef(oct2int('190000'O), '1'B, '0'B, '000'B, '0000'B); + if (test == COORD_TEST_COMPLETE_VBS) { + callref := ts_BSSMAP_IE_GroupCallRef(oct2int('1a0000'O), '0'B, '0'B, '000'B, '0000'B); + } + var template BSSMAP_IE_ChannelType tr_ch_type := tr_BSSMAP_IE_ChannelType('0001'B, ChRate_TCHF, Spdi_TCHF_FR); + var template PDU_BSSAP tr_assignment_req := tr_BSSMAP_AssignmentReq(); + tr_assignment_req.pdu.bssmap.assignmentRequest.channelType := tr_ch_type; + tr_assignment_req.pdu.bssmap.assignmentRequest.groupCallReference := + tr_BSSMAP_IE_GroupCallRef(bit2oct(encvalue(callref))); + /* Due to a bug in dec_PDU_BSSAP(), we do not get the callref IE, so we need to match it with omit. */ + tr_assignment_req.pdu.bssmap.assignmentRequest.groupCallReference := omit; + var template (value) PDU_BSSAP ts_assignment_cpl := ts_BSSMAP_AssignmentComplete(omit, omit, omit, omit); + var octetstring xcc_termination_21 := '340121'O; + var octetstring xcc_termination_11 := '340111'O; + var PDU_BSSAP rx_bssap; + + f_init_handler(pars); + + /* Location Update to make subscriber known. */ + f_perform_lu(); + + /* MGW */ + f_create_mgcp_expect(ExpectCriteria:{omit,omit,omit}); + var default crcx := activate(as_optional_mgcp_crcx(cpars)); + var default mdcx := activate(as_optional_mgcp_mdcx(cpars.mgw_conn_2.mgw_rtp_ip, cpars.mgw_conn_2.mgw_rtp_port)); + var default dlcx := activate(as_optional_mgcp_dlcx(cpars)); + + /* Establish connection using the service type, defined by the test. */ + if (test == COORD_TEST_COMPLETE_VBS) { + f_establish_fully(EST_TYPE_VBS); + } else { + f_establish_fully(EST_TYPE_VGCS); + } + + /* Send incorrect call reference, if selected by test. */ + log("Sending SETUP."); + select (test) { + case (COORD_TEST_NO_CALLREF) { + BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_GCC(cpars.transaction_id, '3200002900'O))); + } + case (COORD_TEST_COMPLETE_VBS) { + BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_BCC(cpars.transaction_id, '3200001a00'O))); + } + case else { + BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_GCC(cpars.transaction_id, '3200001900'O))); + } + } + COORD.send(COORD_SETUP); + + timer T := 10.0; + T.start; + alt { + [] BSSAP.receive(tr_assignment_req) -> value rx_bssap { + /* The MSC sends and Assignment Request to assign the calling subscriber to the VGCS/VBS channel. */ + log("Got Assignment Request: ", rx_bssap); + COORD.send(COORD_ASSIGNMENT); + log("Sending Assignment Complete: ", ts_assignment_cpl); + BSSAP.send(ts_assignment_cpl); + repeat; + } + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_GCC(cpars.transaction_id, xcc_termination_21))) { + /* The MSC terminates the group call with cause 21 = requested service not subscribed. */ + log("Got GCC Termination with failure."); + COORD.send(COORD_GCC_TERMINATION_FAIL); + repeat; + } + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_BCC(cpars.transaction_id, xcc_termination_21))) { + /* The MSC terminates the broadcast call with cause 21 = requested service not subscribed. */ + log("Got BCC Termination with failure."); + COORD.send(COORD_BCC_TERMINATION_FAIL); + repeat; + } + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_GCC(cpars.transaction_id, xcc_termination_11))) { + /* The MSC terminates the group call with cause 11 = network failure. */ + log("Got GCC Termination with failure."); + COORD.send(COORD_GCC_TERMINATION_FAIL); + repeat; + } + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_BCC(cpars.transaction_id, xcc_termination_11))) { + /* The MSC terminates the broadcast call with cause 11 = network failure. */ + log("Got BCC Termination with failure."); + COORD.send(COORD_BCC_TERMINATION_FAIL); + repeat; + } + [] BSSAP.receive(tr_BSSMAP_ClearCommand) { + /* The SCCP connection is released. */ + log("Got Clear Command on initial connection."); + COORD.send(COORD_CLEAR); + repeat; + } + [] BSSAP.receive { + setverdict(fail, "Got unexpected message on initial connection."); + } + [] COORD.receive(COORD_CLEAR) { } + [] T.timeout { + setverdict(fail, "Timeout waiting for Message"); + } + } + + deactivate(crcx); + deactivate(mdcx); + deactivate(dlcx); +} + +/* "control" connection handling */ +private function f_tc_vgcs_control(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr +{ + /* Receive test case from main function. */ + var charstring test; + COORD.receive(charstring:?) -> value test; + + /* Initialize variables and templates. */ + var CallParameters cpars := valueof(t_CallParams('12345'H, 0)); + var template (value) DescriptiveGroupOrBroadcastCallReference_V callref := + ts_BSSMAP_IE_GroupCallRef(oct2int('190000'O), '1'B, '0'B, '000'B, '0000'B); + if (test == COORD_TEST_COMPLETE_VBS) { + callref := ts_BSSMAP_IE_GroupCallRef(oct2int('1a0000'O), '0'B, '0'B, '000'B, '0000'B); + } + var template PDU_BSSAP tr_vgcs_vbs_setup := tr_BSSMAP_VGCS_VBS_Setup(bit2oct(encvalue(callref))); + var template (value) PDU_BSSAP ts_vgcs_vbs_setup_ack := ts_BSSMAP_VGCS_VBS_SetupAck(omit); + var myBSSMAP_Cause cause_fail := GSM0808_CAUSE_EQUIPMENT_FAILURE; + var template (value) PDU_BSSAP ts_vgcs_vbs_setup_refuse := ts_BSSMAP_VGCS_VBS_SetupRefuse(enum2int(cause_fail)); + var octetstring gcc_connect := '330000190001'O; + var octetstring bcc_connect := '3300001a0001'O; + var octetstring xcc_set_param := '3A07'O; + var octetstring gcc_term_req := '3500001900'O; + var octetstring bcc_term_req := '3500001a00'O; + var octetstring xcc_termination := '340110'O; + var myBSSMAP_Cause cause_success := GSM0808_CAUSE_CALL_CONTROL; + var template (value) PDU_BSSAP ts_uplink_rel_ind := ts_BSSMAP_UplinkRelInd(enum2int(cause_success), omit); + var template (value) PDU_BSSAP ts_uplink_req := ts_BSSMAP_UplinkReq; + var PDU_BSSAP rx_bssap; + + f_init_handler(pars); + + f_create_bssmap_exp_n_connect(193); + + timer T := 7.0; + T.start; + alt { + [] BSSAP.receive(tr_vgcs_vbs_setup) -> value rx_bssap { + /* The MSC sets up call control on the BSC. The test case will send an ack or a refuse. */ + log("Got VGCS/VBS Setup: ", rx_bssap); + COORD.send(COORD_VGCS_SETUP); + if (test == COORD_TEST_SETUP_REFUSE) { + log("Sending VGCS/VBS Setup Refuse: ", ts_vgcs_vbs_setup_refuse); + BSSAP.send(ts_vgcs_vbs_setup_refuse); + } else { + log("Sending VGCS/VBS Setup Ack: ", ts_vgcs_vbs_setup_ack); + BSSAP.send(ts_vgcs_vbs_setup_ack); + } + repeat; + } + [] BSSAP.receive(tr_BSSMAP_UplinkSeizedCmd(GSM0808_CAUSE_CALL_CONTROL)) -> value rx_bssap { + /* After setting up the call, the MSC marks the call as busy. */ + log("Got Uplink Seized Cmd: ", rx_bssap); + COORD.send(COORD_UPLINK_SEIZED); + repeat; + } + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_GCC(cpars.transaction_id, gcc_connect))) { + /* The GCC CONNECT message is sent to the calling MS. */ + log("Got GCC Connect."); + COORD.send(COORD_GCC_CONNECT); + repeat; + } + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_BCC(cpars.transaction_id, bcc_connect))) { + /* The BCC CONNECT message is sent to the calling MS. */ + log("Got BCC Connect."); + COORD.send(COORD_BCC_CONNECT); + repeat; + } + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_GCC(cpars.transaction_id, xcc_set_param))) { + /* The GCC SET PARAMETER message is sent to the calling MS. */ + log("Got GCC Set Parameter."); + COORD.send(COORD_GCC_SET_PARAM); + f_sleep(0.2); + /* The MS releases the uplink. */ + log("Sending Uplink Release Ind: ", ts_uplink_rel_ind); + BSSAP.send(ts_uplink_rel_ind); + f_sleep(0.2); + /* The MS requests the uplink again. */ + log("Sending Uplink Req: ", ts_uplink_req); + BSSAP.send(ts_uplink_req); + repeat; + } + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_BCC(cpars.transaction_id, xcc_set_param))) { + /* The BCC SET PARAMETER message is sent to the calling MS. */ + log("Got BCC Set Parameter"); + COORD.send(COORD_BCC_SET_PARAM); + f_sleep(0.2); + /* The MS requests termination of the call. */ + log("Sending BCC Termination Request: ", bcc_term_req); + BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_BCC(cpars.transaction_id, bcc_term_req))); + repeat; + } + [] BSSAP.receive(tr_BSSMAP_UplinkReqAck(*)) -> value rx_bssap { + /* The uplink was granted by the MSC. */ + log("Got Uplink Request Acknowledge: ", rx_bssap); + COORD.send(COORD_UPLINK_REQ_ACK); + f_sleep(0.2); + /* The MS requests termination of the call. */ + log("Sending GCC Termination Request: ", gcc_term_req); + BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_GCC(cpars.transaction_id, gcc_term_req))); + repeat; + } + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_GCC(cpars.transaction_id, xcc_termination))) { + /* The MSC terminates the call towards the MS. */ + log("Got GCC Termination."); + COORD.send(COORD_GCC_TERMINATION); + repeat; + } + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_BCC(cpars.transaction_id, xcc_termination))) { + /* The MSC terminates the call towards the MS. */ + log("Got BCC Termination."); + COORD.send(COORD_BCC_TERMINATION); + repeat; + } + [] BSSAP.receive(tr_BSSMAP_ClearCommand) { + /* The SCCP connection is released. */ + log("Got Clear Command on control connection."); + COORD.send(COORD_CLEAR); + repeat; + } + [] BSSAP.receive(PDU_BSSAP:?) -> value rx_bssap { + setverdict(fail, "Got unexpected BSSAP message on control connection: ", rx_bssap); + } + [] BSSAP.receive { + setverdict(fail, "Got unexpected message on control connection."); + } + [] COORD.receive(COORD_CLEAR) { } + [] T.timeout { + setverdict(fail, "Timeout on control connection."); + } + } +} + +/* "channel" connection handling */ +private function f_tc_vgcs_channel(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr +{ + /* Receive test case from main function. */ + var charstring test; + COORD.receive(charstring:?) -> value test; + + /* Initialize variables and templates. */ + var template (value) DescriptiveGroupOrBroadcastCallReference_V callref := + ts_BSSMAP_IE_GroupCallRef(oct2int('190000'O), '1'B, '0'B, '000'B, '0000'B); + if (test == COORD_TEST_COMPLETE_VBS) { + callref := ts_BSSMAP_IE_GroupCallRef(oct2int('1a0000'O), '0'B, '0'B, '000'B, '0000'B); + } + var template (present) BSSMAP_IE_ChannelType tr_ch_type := + tr_BSSMAP_IE_ChannelType('0001'B, ChRate_TCHF, Spdi_TCHF_FR); + var template (value) BSSMAP_IE_ChannelType ts_ch_type := valueof(ts_BSSMAP_IE_ChannelTypeCTM); + var template (present) BSSMAP_IE_CellIdentifier tr_cell_id := tr_CellId_CI(42); + var template (value) BSSMAP_IE_CellIdentifier ts_cell_id := ts_CellId_CI(42); + var template (value) BSSMAP_IE_AoIP_TransportLayerAddress ts_tla := f_ts_BSSMAP_IE_AoIP_TLA("1.2.3.4", 2342); + var template (value) BSSMAP_IE_SpeechCodec ts_codec := ts_BSSMAP_IE_SpeechCodec({ts_CodecFR}); + var template PDU_BSSAP tr_vgcs_vbs_ass_req := + tr_BSSMAP_VGCS_VBS_AssignmentReq(tr_ch_type, '01'O, tr_cell_id, bit2oct(encvalue(callref)), *, *, *); + var template (value) PDU_BSSAP ts_vgcs_vbs_ass_res := + f_gen_asci_ass_res(0, ts_ch_type, ts_cell_id, ts_tla, ts_codec, '01000000'O); + var myBSSMAP_Cause cause_fail := GSM0808_CAUSE_EQUIPMENT_FAILURE; + var template (value) PDU_BSSAP ts_vgcs_vbs_ass_fail := ts_BSSMAP_VGCS_VBS_AssignmentFail(enum2int(cause_fail)); + var PDU_BSSAP rx_bssap; + + f_init_handler(pars); + + /* Wait some time before registering, because this has to be the second connection to be registered. */ + f_sleep(0.5); + f_create_bssmap_exp_n_connect(193); + + timer T := 7.0; + T.start; + alt { + [] BSSAP.receive(tr_vgcs_vbs_ass_req) -> value rx_bssap { + /* The MSC allocates channel on the given BTS. The test case will send a result or a failure. */ + log("Got VGCS/VBS Assignment Request: ", rx_bssap); + COORD.send(COORD_VGCS_ASSIGN); + if (test == COORD_TEST_ASSIGN_FAIL) { + log("Sending VGCS/VBS Assignment Failure: ", ts_vgcs_vbs_ass_fail); + BSSAP.send(ts_vgcs_vbs_ass_fail); + } else { + log("Sending VGCS/VBS Assignment Result: ", ts_vgcs_vbs_ass_res); + BSSAP.send(ts_vgcs_vbs_ass_res); + } + repeat; + } + [] BSSAP.receive(tr_BSSMAP_ClearCommand) { + /* The SCCP connection is released. */ + log("Got Clear Command on channel connection."); + COORD.send(COORD_CLEAR); + repeat; + } + [] BSSAP.receive(PDU_BSSAP:?) -> value rx_bssap { + setverdict(fail, "Got unexpected BSSAP message on channel connection: ", rx_bssap); + } + [] BSSAP.receive { + setverdict(fail, "Got unexpected message on channel connection."); + } + [] COORD.receive(COORD_CLEAR) { } + [] T.timeout { + setverdict(fail, "Timeout on channel connection."); + } + } +} + +/* Main function for call test */ +private function f_TC_asci_call(charstring test) runs on asci_CT +{ + var BSC_ConnHdlr vc_conn_call, vc_conn_control, vc_conn_channel; + var boolean got_vgcs_setup := false; + var boolean got_vgcs_assign := false; + var boolean got_uplink_seized := false; + var boolean got_gcc_connect := false; + var boolean got_bcc_connect := false; + var boolean got_gcc_set_param := false; + var boolean got_bcc_set_param := false; + var boolean got_uplink_req_ack := false; + var boolean got_gcc_termination := false; + var boolean got_bcc_termination := false; + var boolean got_gcc_termination_fail := false; + var boolean got_bcc_termination_fail := false; + var boolean got_assignment := false; + var boolean connection_call := false; + var boolean connection_control := false; + var boolean connection_channel := false; + var charstring event; + + f_init(); + + /* Enable ASCI in VTY and setup a VGC and a VBS. */ + f_vty_config(MSCVTY, "asci", "enable"); + f_vty_config2(MSCVTY, { "asci", "gcr", "vgc 200"}, "cell 0.24.1 42"); + f_vty_config2(MSCVTY, { "asci", "gcr", "vbc 208"}, "cell 0.24.1 42"); + + vc_conn_call := f_start_handler(refers(f_tc_vgcs_call), 33); + vc_conn_control := f_start_handler(refers(f_tc_vgcs_control), 34); + vc_conn_channel := f_start_handler(refers(f_tc_vgcs_channel), 35); + + connect(self:COORD_call, vc_conn_call:COORD); + connect(self:COORD_control, vc_conn_control:COORD); + connect(self:COORD_channel, vc_conn_channel:COORD); + + COORD_call.send(test); + COORD_control.send(test); + COORD_channel.send(test); + + /* Receive the test events until all three connections are released or not established. */ + timer T := 7.0, Texit := 0.5; + T.start; + alt { + [] COORD_call.receive(COORD_SETUP) -> value event { + log("Got test event: ", event); + connection_call := true; + repeat; + } + [] COORD_control.receive(COORD_VGCS_SETUP) -> value event { + log("Got test event: ", event); + got_vgcs_setup := true; + connection_control := true; + repeat; + } + [] COORD_channel.receive(COORD_VGCS_ASSIGN) -> value event { + log("Got test event: ", event); + got_vgcs_assign := true; + connection_channel := true; + repeat; + } + [] COORD_control.receive(COORD_UPLINK_REQ_ACK) -> value event { + log("Got test event: ", event); + got_uplink_req_ack := true; + repeat; + } + [] COORD_control.receive(COORD_GCC_CONNECT) -> value event { + log("Got test event: ", event); + got_gcc_connect := true; + repeat; + } + [] COORD_control.receive(COORD_BCC_CONNECT) -> value event { + log("Got test event: ", event); + got_bcc_connect := true; + repeat; + } + [] COORD_control.receive(COORD_GCC_SET_PARAM) -> value event { + log("Got test event: ", event); + got_gcc_set_param := true; + repeat; + } + [] COORD_control.receive(COORD_BCC_SET_PARAM) -> value event { + log("Got test event: ", event); + got_bcc_set_param := true; + repeat; + } + [] COORD_control.receive(COORD_UPLINK_SEIZED) -> value event { + log("Got test event: ", event); + got_uplink_seized := true; + repeat; + } + [] COORD_call.receive(COORD_GCC_TERMINATION_FAIL) -> value event { + log("Got test event: ", event); + got_gcc_termination_fail := true; + repeat; + } + [] COORD_call.receive(COORD_BCC_TERMINATION_FAIL) -> value event { + log("Got test event: ", event); + got_bcc_termination_fail := true; + repeat; + } + [] COORD_control.receive(COORD_GCC_TERMINATION) -> value event { + log("Got test event: ", event); + got_gcc_termination := true; + repeat; + } + [] COORD_control.receive(COORD_BCC_TERMINATION) -> value event { + log("Got test event: ", event); + got_bcc_termination := true; + repeat; + } + [] COORD_call.receive(COORD_ASSIGNMENT) -> value event { + log("Got test event: ", event); + got_assignment := true; + repeat; + } + [not connection_call] COORD_call.receive(COORD_CLEAR) -> value event { + setverdict(fail, "Received CLEAR COMMAND of initial call twice."); + } + [] COORD_call.receive(COORD_CLEAR) -> value event { + log("Got test event: ", event); + connection_call := false; + if (connection_call or connection_control or connection_channel) { + repeat; + } + Texit.start; + repeat; + } + [not connection_control] COORD_control.receive(COORD_CLEAR) -> value event { + setverdict(fail, "Received CLEAR COMMAND control connection twice."); + } + [] COORD_control.receive(COORD_CLEAR) -> value event { + log("Got test event: ", event); + connection_control := false; + if (connection_call or connection_control or connection_channel) { + repeat; + } + Texit.start; + repeat; + } + [not connection_channel] COORD_channel.receive(COORD_CLEAR) -> value event { + setverdict(fail, "Received CLEAR COMMAND of channel connection twice."); + } + [] COORD_channel.receive(COORD_CLEAR) -> value event { + log("Got test event: ", event); + connection_channel := false; + if (connection_call or connection_control or connection_channel) { + repeat; + } + Texit.start; + repeat; + } + [] COORD_call.receive { + setverdict(fail, "Unhandled COORD_call, please fix!"); + } + [] COORD_control.receive { + setverdict(fail, "Unhandled COORD_control, please fix!"); + } + [] COORD_channel.receive { + setverdict(fail, "Unhandled COORD_channel, please fix!"); + } + [] T.timeout { + setverdict(fail, "Timeout waiting for Test result"); + } + [] Texit.timeout { + log("All connection are cleared now."); + } + } + + /* Tell the connection handlers to exit. */ + COORD_call.send(COORD_CLEAR); + COORD_control.send(COORD_CLEAR); + COORD_channel.send(COORD_CLEAR); + + vc_conn_call.done; + vc_conn_control.done; + vc_conn_channel.done; + + if (getverdict == fail) { + return; + } + + /* Check if the outcome of each test is as expected. */ + select (test) { + case (COORD_TEST_NO_CALLREF) { + if (not got_vgcs_setup and + not got_vgcs_assign and + got_gcc_termination_fail) { + setverdict(pass); + } + } + case (COORD_TEST_SETUP_REFUSE) { + if (got_vgcs_setup and + not got_vgcs_assign and + got_gcc_termination_fail) { + setverdict(pass); + } + } + case (COORD_TEST_ASSIGN_FAIL) { + if (got_vgcs_setup and + got_vgcs_assign and + got_gcc_termination_fail) { + setverdict(pass); + } + } + case (COORD_TEST_COMPLETE_VGCS) { + if (got_vgcs_setup and + got_vgcs_assign and + got_uplink_req_ack and + got_gcc_connect and + got_gcc_set_param and + got_uplink_seized and + got_gcc_termination and + got_assignment) { + setverdict(pass); + } + } + case (COORD_TEST_COMPLETE_VBS) { + if (got_vgcs_setup and + got_vgcs_assign and + not got_uplink_req_ack and + got_bcc_connect and + got_bcc_set_param and + got_uplink_seized and + got_bcc_termination and + got_assignment) { + setverdict(pass); + } + } + case else { + setverdict(fail, "Test case has no check for the outcome, please fix! Test was: ", test); + } + } + + if (getverdict == pass) { + log("All expected events have been received. The test passed."); + } else { + setverdict(fail, "Not all expected event received."); + } +} + +/* A call is tried, but the given call reference does not exit. */ +testcase TC_no_callref() runs on asci_CT +{ + f_TC_asci_call(COORD_TEST_NO_CALLREF); +} + +/* The VGCS/VBS is refused by the BSC. */ +testcase TC_setup_refuse() runs on asci_CT +{ + f_TC_asci_call(COORD_TEST_SETUP_REFUSE); +} + +/* The VGCS/VBS channel is refused by the BSC. */ +testcase TC_assign_fail() runs on asci_CT +{ + f_TC_asci_call(COORD_TEST_ASSIGN_FAIL); +} + +/* The VGCS call is completed and the MS releases and requests the uplink again. Then it terminates the call. */ +testcase TC_complete_vgcs() runs on asci_CT +{ + f_TC_asci_call(COORD_TEST_COMPLETE_VGCS); +} + +/* The VBS call is completed and the MS terminates the call. */ +testcase TC_complete_vbs() runs on asci_CT +{ + f_TC_asci_call(COORD_TEST_COMPLETE_VBS); +} + +control { + execute( TC_no_callref() ); + execute( TC_setup_refuse() ); + execute( TC_assign_fail() ); + execute( TC_complete_vgcs() ); + execute( TC_complete_vbs() ); +} + +} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4bbe739ea55ecf9f7ebf9ee413df69f29aa642f8 Gerrit-Change-Number: 33979 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: ASCI: Add tests for voice group/broadcast calls at MSC

by laforge

Attention is currently required from: jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979 ) Change subject: ASCI: Add tests for voice group/broadcast calls at MSC ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4bbe739ea55ecf9f7ebf9ee413df69f29aa642f8 Gerrit-Change-Number: 33979 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Aug 2023 09:18:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[M] Change in libosmocore[master]: ns2: Add VTY option to change the max write queue size for UDP

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34245 ) Change subject: ns2: Add VTY option to change the max write queue size for UDP ...................................................................... ns2: Add VTY option to change the max write queue size for UDP Ensure that existing binds are updated as well. In some cases the default max length of the osmo_io txqueue could be too small. Set it to 128 by default and add a VTY option to change it for an NSI (program-wide). Change-Id: I993b87fd6b83b3981f5e293f70b931075afec715 Related: SYS#6550 --- M src/gb/gprs_ns2.c M src/gb/gprs_ns2_internal.h M src/gb/gprs_ns2_udp.c M src/gb/gprs_ns2_vty.c 4 files changed, 58 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c index 02d2266..4e496c1 100644 --- a/src/gb/gprs_ns2.c +++ b/src/gb/gprs_ns2.c @@ -1451,6 +1451,8 @@ nsi->timeout[NS_TOUT_TSNS_CONFIG_RETRIES] = 3; nsi->timeout[NS_TOUT_TSNS_PROCEDURES_RETRIES] = 3; + nsi->txqueue_max_length = NS_DEFAULT_TXQUEUE_MAX_LENGTH; + return nsi; } diff --git a/src/gb/gprs_ns2_internal.h b/src/gb/gprs_ns2_internal.h index 37b142e..7ac77e5 100644 --- a/src/gb/gprs_ns2_internal.h +++ b/src/gb/gprs_ns2_internal.h @@ -80,6 +80,8 @@ #define NS_ALLOC_SIZE 3072 #define NS_ALLOC_HEADROOM 20 +#define NS_DEFAULT_TXQUEUE_MAX_LENGTH 128 + enum ns2_timeout { NS_TOUT_TNS_BLOCK, NS_TOUT_TNS_BLOCK_RETRIES, @@ -164,6 +166,8 @@ /*! workaround for rate counter until rate counter accepts char str as index */ uint32_t nsvc_rate_ctr_idx; uint32_t bind_rate_ctr_idx; + + uint32_t txqueue_max_length; }; @@ -450,6 +454,7 @@ struct gprs_ns2_vc_bind *ns2_ip_get_bind_by_index(struct gprs_ns2_inst *nsi, struct osmo_sockaddr *remote, int index); +void ns2_ip_set_txqueue_max_length(struct gprs_ns2_vc_bind *bind, unsigned int max_length); /* sns */ int ns2_sns_rx(struct gprs_ns2_vc *nsvc, struct msgb *msg, struct tlv_parsed *tp); diff --git a/src/gb/gprs_ns2_udp.c b/src/gb/gprs_ns2_udp.c index f24eae6..1dcc303 100644 --- a/src/gb/gprs_ns2_udp.c +++ b/src/gb/gprs_ns2_udp.c @@ -336,6 +336,7 @@ priv->iofd = osmo_iofd_setup(bind, rc, "NS bind", OSMO_IO_FD_MODE_RECVFROM_SENDTO, &ioops, bind); osmo_iofd_register(priv->iofd, rc); osmo_iofd_set_alloc_info(priv->iofd, 4096, 128); + osmo_iofd_set_txqueue_max_length(priv->iofd, nsi->txqueue_max_length); /* IPv4: max fragmented payload can be (13 bit) * 8 byte => 65535. * IPv6: max payload can be 65535 (RFC 2460). @@ -574,6 +575,14 @@ return NULL; } +void ns2_ip_set_txqueue_max_length(struct gprs_ns2_vc_bind *bind, unsigned int max_length) +{ + struct priv_bind *priv = bind->priv; + OSMO_ASSERT(gprs_ns2_is_ip_bind(bind)); + + osmo_iofd_set_txqueue_max_length(priv->iofd, max_length); +} + /*! set the signalling and data weight for this bind * \param[in] bind * \param[in] signalling the signalling weight diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c index 3046fff..3132e34 100644 --- a/src/gb/gprs_ns2_vty.c +++ b/src/gb/gprs_ns2_vty.c @@ -36,6 +36,7 @@ #include <osmocom/core/fsm.h> #include <osmocom/core/linuxlist.h> #include <osmocom/core/msgb.h> +#include <osmocom/core/osmo_io.h> #include <osmocom/core/rate_ctr.h> #include <osmocom/core/select.h> #include <osmocom/core/talloc.h> @@ -595,6 +596,9 @@ get_value_string(gprs_ns_timer_strs, i), vty_nsi->timeout[i], VTY_NEWLINE); + if (vty_nsi->txqueue_max_length != NS_DEFAULT_TXQUEUE_MAX_LENGTH) + vty_out(vty, " txqueue-max-length %u%s", vty_nsi->txqueue_max_length, VTY_NEWLINE); + ret = config_write_ns_bind(vty); if (ret) return ret; @@ -1707,6 +1711,27 @@ return CMD_WARNING; } +DEFUN(cfg_ns_txqueue_max_length, cfg_ns_txqueue_max_length_cmd, + "txqueue-max-length <1-4096>", + "Set the maximum length of the txqueue (for UDP)\n" + "Maximum length of the txqueue\n") +{ + struct gprs_ns2_vc_bind *bind; + uint32_t max_length = atoi(argv[0]); + vty_nsi->txqueue_max_length = max_length; + + + llist_for_each_entry(bind, &vty_nsi->binding, list) { + if (!gprs_ns2_is_ip_bind(bind)) + continue; + + ns2_ip_set_txqueue_max_length(bind, max_length); + } + + + return CMD_SUCCESS; +} + DEFUN(cfg_ns_nse_ip_sns_bind, cfg_ns_nse_ip_sns_bind_cmd, "ip-sns-bind BINDID", "IP SNS binds\n" @@ -2292,6 +2317,8 @@ install_lib_element(L_NS_NODE, &cfg_ns_ip_sns_default_bind_cmd); install_lib_element(L_NS_NODE, &cfg_no_ns_ip_sns_default_bind_cmd); + install_lib_element(L_NS_NODE, &cfg_ns_txqueue_max_length_cmd); + install_node(&ns_bind_node, NULL); install_lib_element(L_NS_BIND_NODE, &cfg_ns_bind_listen_cmd); install_lib_element(L_NS_BIND_NODE, &cfg_no_ns_bind_listen_cmd); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I993b87fd6b83b3981f5e293f70b931075afec715 Gerrit-Change-Number: 34245 Gerrit-PatchSet: 5 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 11 months

1
0
0 0

[M] Change in libosmocore[master]: ns2: Add VTY option to change the max write queue size for UDP

by laforge

Attention is currently required from: pespin, daniel, lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34245 ) Change subject: ns2: Add VTY option to change the max write queue size for UDP ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I993b87fd6b83b3981f5e293f70b931075afec715 Gerrit-Change-Number: 34245 Gerrit-PatchSet: 4 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 30 Aug 2023 09:18:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[M] Change in libosmocore[master]: ns2: Add VTY option to change the max write queue size for UDP

by fixeria

Attention is currently required from: pespin, daniel, lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34245 ) Change subject: ns2: Add VTY option to change the max write queue size for UDP ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I993b87fd6b83b3981f5e293f70b931075afec715 Gerrit-Change-Number: 34245 Gerrit-PatchSet: 4 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 30 Aug 2023 08:58:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: ASCI: Add tests for voice group/broadcast calls at MSC

by jolly

Attention is currently required from: laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979 ) Change subject: ASCI: Add tests for voice group/broadcast calls at MSC ...................................................................... Patch Set 4: (1 comment) File msc/MSC_Tests_ASCI.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979/comment/0878fc21_b6b3… PS3, Line 667: testcase TC_no_callref() runs on asci_CT { f_TC_asci_call(COORD_TEST_NO_CALLREF); } > ok, jolly please do that final change and then we can get it submitted. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4bbe739ea55ecf9f7ebf9ee413df69f29aa642f8 Gerrit-Change-Number: 33979 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Aug 2023 08:52:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: ASCI: Add tests for voice group/broadcast calls at MSC

by jolly

Attention is currently required from: jolly, pespin. Hello Jenkins Builder, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979 to look at the new patch set (#4). Change subject: ASCI: Add tests for voice group/broadcast calls at MSC ...................................................................... ASCI: Add tests for voice group/broadcast calls at MSC Related: OS#4854 Change-Id: I4bbe739ea55ecf9f7ebf9ee413df69f29aa642f8 --- M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.cfg M msc/MSC_Tests.ttcn A msc/MSC_Tests_ASCI.ttcn 4 files changed, 718 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/79/33979/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4bbe739ea55ecf9f7ebf9ee413df69f29aa642f8 Gerrit-Change-Number: 33979 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 11 months

1
0
0 0

[M] Change in libosmocore[master]: ns2: Add VTY option to change the max write queue size for UDP

by daniel

Attention is currently required from: fixeria, pespin, lynxis lazus. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34245 ) Change subject: ns2: Add VTY option to change the max write queue size for UDP ...................................................................... Patch Set 4: (1 comment) File src/gb/gprs_ns2_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/34245/comment/3600f3b8_c115f5c2 PS3, Line 54: "osmocom/core/osmo_io.h" > cosmetic: use `<`/`>` and move above to other includes from `core` Thanks -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34245 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I993b87fd6b83b3981f5e293f70b931075afec715 Gerrit-Change-Number: 34245 Gerrit-PatchSet: 4 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 30 Aug 2023 08:40:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023