laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34247 ) Change subject: PCUIF: fix coding of 'lqual_cb' field in PCUIF_data ...................................................................... PCUIF: fix coding of 'lqual_cb' field in PCUIF_data This patch fixes BTS_Tests.TC_pcu_data_ind_lqual_cb, which is currently failing due to incorrect decoding of the 'lqual_cb' field: "Link quality -32512 does not match expected value -256" The COMP attribute is documented in TITAN's reference guide, see 4-ttcn3_language_extensions.adoc#attributes for more info. Change-Id: I79b8cd41010f212898fbf39c4c600ace69603e79 Related: OS#5954 --- M library/PCUIF_Types.ttcn 1 file changed, 22 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn index b8bd6e9..b6a1bfa 100644 --- a/library/PCUIF_Types.ttcn +++ b/library/PCUIF_Types.ttcn @@ -103,7 +103,10 @@ uint16_t ber10k, int16_t ta_offs_qbits, int16_t lqual_cb -} with { variant (data) "FIELDLENGTH(162), ALIGN(left)" }; +} with { + variant (data) "FIELDLENGTH(162), ALIGN(left)" + variant (lqual_cb) "COMP(2scompl)" +}; type record PCUIF_data_cnf { PCUIF_Sapi sapi, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34247 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79b8cd41010f212898fbf39c4c600ace69603e79 Gerrit-Change-Number: 34247 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged