August 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: rsl: Introduce new osmocom extension IE RSL_IE_OSMO_ABS_FRAME_NUMBER

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34131 ) Change subject: rsl: Introduce new osmocom extension IE RSL_IE_OSMO_ABS_FRAME_NUMBER ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: I know we didn't do it in the past, but maybe add a comment after the definition stating it is a uint32_t in network byte order? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34131 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia28caa24dd141b1162b6e11500d753353fe6500d Gerrit-Change-Number: 34131 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Aug 2023 06:12:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in libosmocore[master]: lapdm: Track fn of primitives in struct lapdm_msg_ctx

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34130 ) Change subject: lapdm: Track fn of primitives in struct lapdm_msg_ctx ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icf986f4202703eb452bedc1b749bb8ce0c73706f Gerrit-Change-Number: 34130 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Aug 2023 06:12:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in libosmocore[master]: tlv: Introduce API msgb_tv32_push()

by laforge

Attention is currently required from: pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34124 ) Change subject: tlv: Introduce API msgb_tv32_push() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I68d5693a18d55ce8d0647359044157d7e5bfae50 Gerrit-Change-Number: 34124 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Aug 2023 06:11:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmo-ci[master]: update obs-mirror include list

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34015 ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: update obs-mirror include list ...................................................................... update obs-mirror include list * add Debian 12 for latest and nightly package archive * replace nightly Ubuntu 22.04 with 23.04 * stop nightly Debian 10 archive (11 + 12 is sufficient) Change-Id: I4f4103732a6dc3d73ada85482c6a2f806b4100aa --- M contrib/obs-mirror/obs-mirror-include.txt 1 file changed, 17 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/obs-mirror/obs-mirror-include.txt b/contrib/obs-mirror/obs-mirror-include.txt index c69474c..6458090 100644 --- a/contrib/obs-mirror/obs-mirror-include.txt +++ b/contrib/obs-mirror/obs-mirror-include.txt @@ -2,15 +2,17 @@ latest/CentOS_8 latest/Debian_10 latest/Debian_11 +latest/Debian_12 latest/Raspbian_10 latest/Raspbian_11 latest/xUbuntu_18.04 latest/xUbuntu_20.04 latest/xUbuntu_21.04 latest/xUbuntu_22.04 +latest/xUbuntu_23.04 nightly/CentOS_8 -nightly/Debian_10 nightly/Debian_11 +nightly/Debian_12 nightly/Raspbian_11 -nightly/xUbuntu_22.04 +nightly/xUbuntu_23.04 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34015 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4f4103732a6dc3d73ada85482c6a2f806b4100aa Gerrit-Change-Number: 34015 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: attempt to fix sporadic test failures

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34127 ) Change subject: hnbgw: attempt to fix sporadic test failures ...................................................................... hnbgw: attempt to fix sporadic test failures Give some more wait time for RANAP RESET after f_cn_nr_init(). Intended to fix sporadic failures of HNBGW_Tests... - TC_rab_assign_mgcp_to - TC_ranap_cs_mo_disconnect Change-Id: Ia5144dbbc5168b3707e714e12b805f5d640fa774 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index df6fc8e..b1f6cae 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -533,6 +533,11 @@ if (start_hnb) { f_start_hnbs(); } + + /* Sometimes, the RUA InitialUE-Message from a test happens too quickly, before the RANAP RESET from + * RAN_Emulation is through, after above f_cn_nr_init(). In the pcap it seems to be a matter of 50 ms. Give some + * grace. */ + f_sleep(1.0); } friend function f_shutdown_helper() runs on test_CT { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia5144dbbc5168b3707e714e12b805f5d640fa774 Gerrit-Change-Number: 34127 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: attempt to fix sporadic test failures

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34127 ) Change subject: hnbgw: attempt to fix sporadic test failures ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia5144dbbc5168b3707e714e12b805f5d640fa774 Gerrit-Change-Number: 34127 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Aug 2023 00:34:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[M] Change in osmo-gsm-manuals[master]: add static SS7 routing example to cs7-config.adoc

by neels

Attention is currently required from: laforge, pespin, msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273 ) Change subject: add static SS7 routing example to cs7-config.adoc ...................................................................... Patch Set 3: (3 comments) Patchset: PS1: > A quick reminder as another month has passed since my last request here. Done File common/chapters/cs7-config.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273/comment/ce90e7ce_1971… PS1, Line 365: Every component has a distinct M3UA port. For > IIRC the reason for assuming fixed ports are necessary was: […] would be good to get feedback on whether I'm correct... https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273/comment/3af033d6_65c3… PS1, Line 390: .osmo-bsc.cfg > I think it makes more sense to move each of these below the bullet list of each component above. […] my intention was to explain first, and provide long examples below, to not break the flow of reading... -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/32273 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I44afddf7004f5bf37eec706ca3da12c04f83f8fa Gerrit-Change-Number: 32273 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Aug 2023 00:33:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmocom-bb[master]: l1gprs: Improve logging fn and tn in BLOCK.req

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34141 ) Change subject: l1gprs: Improve logging fn and tn in BLOCK.req ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iba29d88770e79fee0e4ac3c8f4e833907afa5b52 Gerrit-Change-Number: 34141 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Aug 2023 19:40:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[M] Change in osmocom-bb[master]: trxcon: properly handle PDCH slotmask in UL/DL TBF CFG.Req

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34139 ) Change subject: trxcon: properly handle PDCH slotmask in UL/DL TBF CFG.Req ...................................................................... Patch Set 2: Code-Review-1 (3 comments) File include/l1gprs.h: https://gerrit.osmocom.org/c/osmocom-bb/+/34139/comment/ff0b21e6_228efa91 PS2, Line 37: void *priv The `priv` is already accessible via `gprs->priv`, this argument can be removed. https://gerrit.osmocom.org/c/osmocom-bb/+/34139/comment/525c012d_572ad765 PS2, Line 48: changed_cb It's currently way too generic: "something has changed, figure out what exactly yourself by checking the internal state". I suggest adding a more specific callback: ``` pdch_state_cb(struct l1gprs_pdch *pdch, bool active) ``` and call it either when the total TBF count becomes higher than 0 (`active=true`), or when it becomes 0 again (`active=true`). This will hide the implementation details a bit and eliminate the need for the API user to iterate over all PDCHs looking for potential changes. Also, a comment documenting this new field is missing. File src/host/trxcon/src/trxcon_fsm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34139/comment/7605072d_e32e77a3 PS1, Line 577: handle_tbf_cfg_req(trxcon); > Using trxcon specific API from l1gprs is not an option. […] I see you already implemented this in the new patchset revision. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4c2ff25217fba0b6b4704f023071b86ed9afb55c Gerrit-Change-Number: 34139 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Aug 2023 19:34:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years

1
0
0 0

[M] Change in osmocom-bb[master]: trxcon: properly handle PDCH slotmask in UL/DL TBF CFG.Req

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34139 ) Change subject: trxcon: properly handle PDCH slotmask in UL/DL TBF CFG.Req ...................................................................... Patch Set 2: (1 comment) File src/host/trxcon/src/trxcon_fsm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34139/comment/d4c0f09b_2c7443cf PS1, Line 577: handle_tbf_cfg_req(trxcon); > This patch is missing updating in the case where l1gprs_handle_ul_tbf_cfg_req() delays call to l1gpr […] Using trxcon specific API from l1gprs is not an option. The reason is that it's also employed by virtphy and [some day] will be employed by the firmware. We need an abstract API for that, something like `l1gprs_pdch_state_cb()`. It can either be a callback stored in `struct l1gprs_state`, or even better an external function to be defined by the l1gprs API user. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4c2ff25217fba0b6b4704f023071b86ed9afb55c Gerrit-Change-Number: 34139 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Aug 2023 19:14:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023