August 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmocom-bb[master]: l1gprs: Fix slotmask update on already registered tbf

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34140 ) Change subject: l1gprs: Fix slotmask update on already registered tbf ...................................................................... Patch Set 1: Code-Review+1 (4 comments) Patchset: PS1: Looks fine in general, mostly cosmetic notes. File src/shared/l1gprs.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34140/comment/31953718_d24b8aa9 PS1, Line 142: pdch->tn Using scoped variable `tn` would make the code a bit shorter. `pdch->tn` is guaranteed to be equal to the respective index in `gprs->pdch[]` array. https://gerrit.osmocom.org/c/osmocom-bb/+/34140/comment/de1a00b1_83b84a8b PS1, Line 155: TS%u `LOGP_PDCH` does print timeslot number, printing it again is redundant. https://gerrit.osmocom.org/c/osmocom-bb/+/34140/comment/7f5a8db3_cff58101 PS1, Line 165: TS%u Same here. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34140 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5d64488d2aa740e91e01fad17f2af3ded24b12ef Gerrit-Change-Number: 34140 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Aug 2023 19:07:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmocom-bb[master]: l1ctl: Fix fill ph_data_param fn field

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34129 ) Change subject: l1ctl: Fix fill ph_data_param fn field ...................................................................... l1ctl: Fix fill ph_data_param fn field This commit fixes recent previous commit filling in the fn field. The dl->frame_nr is network order, and we want to pass a host order integer in the primitive. Use the tm.fn which already includes the proper value calculated from dl->frame_nr. Fixes: d524c17d907b39189c1c7b465b8f40db2d79f55b Related: OS#3626 Change-Id: Id96015c8b419932abb8095c6cb85aceef34e366f --- M src/host/layer23/src/common/l1ctl.c 1 file changed, 17 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/host/layer23/src/common/l1ctl.c b/src/host/layer23/src/common/l1ctl.c index 08fb646..b2ad505 100644 --- a/src/host/layer23/src/common/l1ctl.c +++ b/src/host/layer23/src/common/l1ctl.c @@ -317,7 +317,7 @@ PRIM_OP_INDICATION, msg); pp.u.data.chan_nr = dl->chan_nr; pp.u.data.link_id = dl->link_id; - pp.u.data.fn = dl->frame_nr; + pp.u.data.fn = tm.fn; /* send it up into LAPDm */ return lapdm_phsap_up(&pp.oph, le); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id96015c8b419932abb8095c6cb85aceef34e366f Gerrit-Change-Number: 34129 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years

1
0
0 0

[S] Change in osmocom-bb[master]: l1ctl: Fix fill ph_data_param fn field

by pespin

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34129 ) Change subject: l1ctl: Fix fill ph_data_param fn field ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/34129/comment/ff4533c7_fa92a038 PS1, Line 7: Fix fill ph_data_param fn field > A more usual way to say that you're fixing a previously merged commit is "fixup: ...". I added "Fixes:" tag at the bottom, that's enough imho. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id96015c8b419932abb8095c6cb85aceef34e366f Gerrit-Change-Number: 34129 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Aug 2023 18:27:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmocom-bb[master]: l1ctl: Fix fill ph_data_param fn field

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34129 ) Change subject: l1ctl: Fix fill ph_data_param fn field ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/34129/comment/8d06562b_968a0bbc PS1, Line 7: Fix fill ph_data_param fn field A more usual way to say that you're fixing a previously merged commit is "fixup: ...". -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id96015c8b419932abb8095c6cb85aceef34e366f Gerrit-Change-Number: 34129 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Aug 2023 18:25:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: pass TBF starting time from CFG UL/DL TBF Req

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33232 ) Change subject: layer23: modem: pass TBF starting time from CFG UL/DL TBF Req ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iae53c6e704a5b868a265216d4cb48b1edc2d7e61 Gerrit-Change-Number: 33232 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Aug 2023 18:23:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmocom-bb[master]: l1gprs: Improve logging fn and tn in BLOCK.req

by pespin

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34141 to look at the new patch set (#3). Change subject: l1gprs: Improve logging fn and tn in BLOCK.req ...................................................................... l1gprs: Improve logging fn and tn in BLOCK.req Change-Id: Iba29d88770e79fee0e4ac3c8f4e833907afa5b52 --- M src/shared/l1gprs.c 1 file changed, 17 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/41/34141/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iba29d88770e79fee0e4ac3c8f4e833907afa5b52 Gerrit-Change-Number: 34141 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years

1
0
0 0

[S] Change in osmocom-bb[master]: l1gprs: Log slotmask when logging TBF

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34142 ) Change subject: l1gprs: Log slotmask when logging TBF ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib96b01c591dbcc6aa9e0527e0be499ef8aee2863 Gerrit-Change-Number: 34142 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Aug 2023 18:22:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmocom-bb[master]: l1gprs: Improve logging fn and tn in BLOCK.req

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34141 ) Change subject: l1gprs: Improve logging fn and tn in BLOCK.req ...................................................................... Patch Set 2: (2 comments) File src/shared/l1gprs.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34141/comment/d4886f86_5c1172b2 PS1, Line 635: tn=%u > Printing `tn` is redundant here because `LOGP_PDCH` does print timeslot number of the respective PDC […] Ack https://gerrit.osmocom.org/c/osmocom-bb/+/34141/comment/9f2a49e4_aeda45a4 PS1, Line 640: tn=%u > Same here. Ack -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iba29d88770e79fee0e4ac3c8f4e833907afa5b52 Gerrit-Change-Number: 34141 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Aug 2023 18:21:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmocom-bb[master]: l1gprs: Improve logging fn and tn in BLOCK.req

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34141 ) Change subject: l1gprs: Improve logging fn and tn in BLOCK.req ...................................................................... Patch Set 1: (2 comments) File src/shared/l1gprs.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34141/comment/277f0b3a_de84c3ed PS1, Line 635: tn=%u Printing `tn` is redundant here because `LOGP_PDCH` does print timeslot number of the respective PDCH already. https://gerrit.osmocom.org/c/osmocom-bb/+/34141/comment/522042e9_ecaca7c9 PS1, Line 640: tn=%u Same here. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iba29d88770e79fee0e4ac3c8f4e833907afa5b52 Gerrit-Change-Number: 34141 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Aug 2023 18:19:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: pass TBF starting time from CFG UL/DL TBF Req

by pespin

Attention is currently required from: pespin, fixeria. pespin has uploaded a new patch set (#7) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33232 ) Change subject: layer23: modem: pass TBF starting time from CFG UL/DL TBF Req ...................................................................... layer23: modem: pass TBF starting time from CFG UL/DL TBF Req Change-Id: Iae53c6e704a5b868a265216d4cb48b1edc2d7e61 Depends: libosmo-gprs.git I27a7a896fe3839fa4f9b8cd9500c4ab7867bbaa0 Related: OS#5500 --- M src/host/layer23/src/modem/grr.c 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/32/33232/7 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iae53c6e704a5b868a265216d4cb48b1edc2d7e61 Gerrit-Change-Number: 33232 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2023