Attention is currently required from: pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34140 )

Change subject: l1gprs: Fix slotmask update on already registered tbf ......................................................................

Patch Set 1: Code-Review+1

(4 comments)

Patchset:

PS1: Looks fine in general, mostly cosmetic notes.

File src/shared/l1gprs.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34140/comment/31953718_d24b8aa9 PS1, Line 142: pdch->tn Using scoped variable `tn` would make the code a bit shorter. `pdch->tn` is guaranteed to be equal to the respective index in `gprs->pdch[]` array.

https://gerrit.osmocom.org/c/osmocom-bb/+/34140/comment/de1a00b1_83b84a8b PS1, Line 155: TS%u `LOGP_PDCH` does print timeslot number, printing it again is redundant.

https://gerrit.osmocom.org/c/osmocom-bb/+/34140/comment/7f5a8db3_cff58101 PS1, Line 165: TS%u Same here.