Attention is currently required from: pespin.

Patch set 1:Code-Review +1

View Change

4 comments:

• Patchset:

  • Patch Set #1:

    Looks fine in general, mostly cosmetic notes.

• File src/shared/l1gprs.c:

  • Patch Set #1, Line 142: pdch->tn

    Using scoped variable `tn` would make the code a bit shorter.
    `pdch->tn` is guaranteed to be equal to the respective index in `gprs->pdch[]` array.

  • Patch Set #1, Line 155: TS%u

    `LOGP_PDCH` does print timeslot number, printing it again is redundant.

  • Patch Set #1, Line 165: TS%u

    Same here.

To view, visit change 34140. To unsubscribe, or for help writing mail filters, visit settings.