Attention is currently required from: pespin.
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32955 )
Change subject: ms: flexible template for value_type buffer sum
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> Why is it multiplying it by 2 in some cases?
To quote the actual commit message: "number of complex and single samples".. look at the types, as the template naame it's a normed abs that will just do the right thing.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32955
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I3c9953073555e3a7f70b78b0946dfdf949175a82
Gerrit-Change-Number: 32955
Gerrit-PatchSet: 4
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 07 Jul 2023 12:28:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32955 )
Change subject: ms: flexible template for value_type buffer sum
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Why is it multiplying it by 2 in some cases?
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32955
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I3c9953073555e3a7f70b78b0946dfdf949175a82
Gerrit-Change-Number: 32955
Gerrit-PatchSet: 4
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 07 Jul 2023 12:26:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: jolly.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33617 )
Change subject: ASCI: Send release on VGCS/VBS channel via unit data
......................................................................
Patch Set 3:
(1 comment)
File src/osmo-bsc/lchan_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/33617/comment/ccf005a8_91defc8b
PS3, Line 1424: /* As UI to all listeners in group receive mdoe */
typo: mode
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33617
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib777fe98c8ce2342082d88d227b796167d92cfe1
Gerrit-Change-Number: 33617
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Fri, 07 Jul 2023 12:13:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment