July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: S1AP_Templates: fix tr_S1AP_SetupReq
by dexter 07 Jul '23

07 Jul '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33633 ) Change subject: S1AP_Templates: fix tr_S1AP_SetupReq ...................................................................... S1AP_Templates: fix tr_S1AP_SetupReq The S1_SETUP_REQUEST may have an optional IE eNB_Name in between Global eNB ID and Supported TAs Related: OS#5760 Change-Id: Id4b52921053884e79349301598b75c264b7f058c --- M library/s1ap/S1AP_Templates.ttcn 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/33633/1 diff --git a/library/s1ap/S1AP_Templates.ttcn b/library/s1ap/S1AP_Templates.ttcn index 056afa9..52890f5 100644 --- a/library/s1ap/S1AP_Templates.ttcn +++ b/library/s1ap/S1AP_Templates.ttcn @@ -69,7 +69,7 @@ id := S1AP_Constants.id_Global_ENB_ID, criticality := ignore, value_ := { Global_ENB_ID := p_global_ENB_ID } - }, { + }, *, { id := S1AP_Constants.id_SupportedTAs, criticality := reject, value_ := {SupportedTAs := p_supportedTAs} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33633 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id4b52921053884e79349301598b75c264b7f058c Gerrit-Change-Number: 33633 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: S1AP_Templates: cosmetic: fix sourcecode formatting
by dexter 07 Jul '23

07 Jul '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33632 ) Change subject: S1AP_Templates: cosmetic: fix sourcecode formatting ...................................................................... S1AP_Templates: cosmetic: fix sourcecode formatting Change-Id: I6e70377315fdcc7ea6d0708fc6de87c335539282 Related: OS#5760 --- M library/s1ap/S1AP_Templates.ttcn 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/32/33632/1 diff --git a/library/s1ap/S1AP_Templates.ttcn b/library/s1ap/S1AP_Templates.ttcn index 6c5dbce..056afa9 100644 --- a/library/s1ap/S1AP_Templates.ttcn +++ b/library/s1ap/S1AP_Templates.ttcn @@ -203,7 +203,7 @@ id := S1AP_Constants.id_Cause, criticality := ignore, value_ := { Cause := cause } - } , { + }, { id := S1AP_Constants.id_ResetType, criticality := reject, value_ := { resetType := reset_type } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6e70377315fdcc7ea6d0708fc6de87c335539282 Gerrit-Change-Number: 33632 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: S1AP_Templates: fix tr_S1AP_InitialCtxSetupResp
by dexter 07 Jul '23

07 Jul '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33635 ) Change subject: S1AP_Templates: fix tr_S1AP_InitialCtxSetupResp ...................................................................... S1AP_Templates: fix tr_S1AP_InitialCtxSetupResp The INITIAL CONTEXT SETUP RESPONSE message may have optional elements at the end. Related: OS#5760 Change-Id: Ic28c94093e55db0dc1fa18d36e22d328788cb3fc --- M library/s1ap/S1AP_Templates.ttcn 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/35/33635/1 diff --git a/library/s1ap/S1AP_Templates.ttcn b/library/s1ap/S1AP_Templates.ttcn index afe4308..69e3f8b 100644 --- a/library/s1ap/S1AP_Templates.ttcn +++ b/library/s1ap/S1AP_Templates.ttcn @@ -628,7 +628,7 @@ id := S1AP_Constants.id_E_RABFailedToSetupListBearerSURes, criticality := ignore, value_ := {E_RABList := rab_items} - } + }, * } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33635 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic28c94093e55db0dc1fa18d36e22d328788cb3fc Gerrit-Change-Number: 33635 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-trx[master]: ms: prettify scheduling + add odroid
by pespin 07 Jul '23

07 Jul '23

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32943 ) Change subject: ms: prettify scheduling + add odroid ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > There are currently 2 supoorted targets: odroid and rpi, nothing else, and dynamic config stuff for […] As commented previously I don't like the idea of hardcoding sets of general scheduling prios/configs for specific machines, imho that should be configurable through vty and to ease users a specific cfg file can be stored somewhere or displayed in the user manual. Waiting to see what others think about this topic. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32943 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Icaf42fd5f76dc2d53dc526558aa8ceaa9c190f7b Gerrit-Change-Number: 32943 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 12:39:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc/BSC_ConnHdlr: f_mt_call: unregister IMSI
by pespin 07 Jul '23

07 Jul '23

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33594 ) Change subject: msc/BSC_ConnHdlr: f_mt_call: unregister IMSI ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33594 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie9b180b95348d7e84650c14a331c5091a1e67d1f Gerrit-Change-Number: 33594 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 12:36:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: library/RAN_Emulation: testcase.stop -> mtc.stop
by pespin 07 Jul '23

07 Jul '23

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33630 ) Change subject: library/RAN_Emulation: testcase.stop -> mtc.stop ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Reading `Misc_Helpers.f_shutdown`, it will evaluate to the same `setverdict(fail, …)` and `mtc. […] I agree with fixeria that we should tend to use MISC_Helpers.f_shutdown when possible. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8923975f6cb48f5f628e2ac5dc412f0f3ab97aab Gerrit-Change-Number: 33630 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 12:34:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: ms: flexible template for value_type buffer sum
by pespin 07 Jul '23

07 Jul '23

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32955 ) Change subject: ms: flexible template for value_type buffer sum ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32955 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I3c9953073555e3a7f70b78b0946dfdf949175a82 Gerrit-Change-Number: 32955 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 12:32:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: csd_bs_list_remove: fix removal logic
by pespin 07 Jul '23

07 Jul '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33593 ) Change subject: csd_bs_list_remove: fix removal logic ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I638d4e063fee6bad45ab14d8ad6b9ad847a7127a Gerrit-Change-Number: 33593 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 12:30:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-msc[master]: test: add csd_test
by pespin 07 Jul '23

07 Jul '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33592 ) Change subject: test: add csd_test ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icc98de75e97c75216a71caf94355d09330c95cba Gerrit-Change-Number: 33592 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 12:30:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-msc[master]: gsm48_cc_tx_setup: use MNCC bcaps for CSD
by pespin 07 Jul '23

07 Jul '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33590 ) Change subject: gsm48_cc_tx_setup: use MNCC bcaps for CSD ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I56e49ebc41696912a81b8f4f63fbc36d0b605e9e Gerrit-Change-Number: 33590 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jul 2023 12:29:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0