Attention is currently required from: Hoernchen.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/32943 )
Change subject: ms: prettify scheduling + add odroid
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> There are currently 2 supoorted targets: odroid and rpi, nothing else, and dynamic config stuff for […]
As commented previously I don't like the idea of hardcoding sets of general scheduling prios/configs for specific machines, imho that should be configurable through vty and to ease users a specific cfg file can be stored somewhere or displayed in the user manual.
Waiting to see what others think about this topic.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/32943
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Icaf42fd5f76dc2d53dc526558aa8ceaa9c190f7b
Gerrit-Change-Number: 32943
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 07 Jul 2023 12:39:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33630 )
Change subject: library/RAN_Emulation: testcase.stop -> mtc.stop
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Reading `Misc_Helpers.f_shutdown`, it will evaluate to the same `setverdict(fail, …)` and `mtc. […]
I agree with fixeria that we should tend to use MISC_Helpers.f_shutdown when possible.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33630
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8923975f6cb48f5f628e2ac5dc412f0f3ab97aab
Gerrit-Change-Number: 33630
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 07 Jul 2023 12:34:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment