Attention is currently required from: neels.
Hello Jenkins Builder, neels, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/33686
to look at the new patch set (#3).
Change subject: osmo_io: Add function to change the maximum length of the tx_queue
......................................................................
osmo_io: Add function to change the maximum length of the tx_queue
Change-Id: If3d1de8bffe1123002515878655ea9e02b482888
---
M include/osmocom/core/osmo_io.h
M src/core/libosmocore.map
M src/core/osmo_io.c
3 files changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/86/33686/3
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33686
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If3d1de8bffe1123002515878655ea9e02b482888
Gerrit-Change-Number: 33686
Gerrit-PatchSet: 3
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33591 )
Change subject: csd_bs_list_to_gsm0808_channel_type: add T 300
......................................................................
Patch Set 3:
(2 comments)
File src/libmsc/csd_bs.c:
https://gerrit.osmocom.org/c/osmo-msc/+/33591/comment/547cf694_12cd611d
PS1, Line 187: GSM0808_DATA_HALF_LM
> I agree
Done
https://gerrit.osmocom.org/c/osmo-msc/+/33591/comment/32f4f86e_aaf0640c
PS1, Line 196: GSM0808_DATA_FULL_BM
> technically it is true, one can carry those rates over TCH/H. […]
I've kept them at GSM0808_DATA_FULL_BM and extended the commit message to note that FULL_PREF was considered.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33591
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I7297cc481fbe36355b5231ca800cf566a1ee93c0
Gerrit-Change-Number: 33591
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Jul 2023 09:53:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith, fixeria.
Hello Jenkins Builder, laforge, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-msc/+/33591
to look at the new patch set (#3).
Change subject: csd_bs_list_to_gsm0808_channel_type: add T 300
......................................................................
csd_bs_list_to_gsm0808_channel_type: add T 300
There is no GSM0808_DATA_RATE_TRANSP_300 (not in libosmocore and not in
3GPP TS 48.008 § 3.2.11 on which the enum is based). As I understand it,
we need to use GSM0808_DATA_RATE_TRANSP_600 and half rate TCH.
As pointed out in review, either TCH/H2.4 or TCH/F2.4 would work, so
use GSM0808_DATA_FULL_PREF. It was also considered using FULL_PREF for
other rates below 9600, but while it is technically possible we are not
setting it here as TCH/F provides so much more redundancy and hence
robustness.
Use GSM0808_DATA_FULL_BM instead of GSM0808_SPEECH_FULL_BM. The value is
0x8 for both, but this is the correct name.
Related: OS#4394
Change-Id: I7297cc481fbe36355b5231ca800cf566a1ee93c0
---
M src/libmsc/csd_bs.c
1 file changed, 33 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/91/33591/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33591
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I7297cc481fbe36355b5231ca800cf566a1ee93c0
Gerrit-Change-Number: 33591
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
laforge has submitted this change. ( https://gerrit.osmocom.org/c/titan.ProtocolModules.BSSMAP/+/33713 )
Change subject: Fix message type of UPLINK SEIZED COMMAND
......................................................................
Fix message type of UPLINK SEIZED COMMAND
The UPLINK SEIZED COMMAND, as defines in "type record
PDU_BSSMAP_UplinkSeizedCommand" has wrong message type. It is '4E'O,
but it must be '4D'O. I verified it against the TS 48.008. 4E'O is
used for CHANGE CIRCUIT message.
Related: OS#6087
Change-Id: I61ff2532a4d6eb3aa1ed96cdeb1f2c848ef4447e
---
M src/BSSAP_Types.ttcn
1 file changed, 17 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, approved; Verified
diff --git a/src/BSSAP_Types.ttcn b/src/BSSAP_Types.ttcn
index 7b9592e..70c10e1 100644
--- a/src/BSSAP_Types.ttcn
+++ b/src/BSSAP_Types.ttcn
@@ -2612,12 +2612,12 @@
// UPLINK SEIZED COMMAND- 48.008 subclause 3.2.1.63
type record PDU_BSSMAP_UplinkSeizedCommand
{
- OCT1 messageType, // H'4E
+ OCT1 messageType, // H'4D
BSSMAP_IE_Cause cause,
BSSMAP_IE_TalkerPriority talkerPriority optional,
BSSMAP_IE_EmergencySetIndication emergencySetIndication optional,
BSSMAP_IE_TalkerIdentity talkerIdentity optional
-} with { variant "PRESENCE (messageType = '4E'O)" }
+} with { variant "PRESENCE (messageType = '4D'O)" }
--
To view, visit https://gerrit.osmocom.org/c/titan.ProtocolModules.BSSMAP/+/33713
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: titan.ProtocolModules.BSSMAP
Gerrit-Branch: master
Gerrit-Change-Id: I61ff2532a4d6eb3aa1ed96cdeb1f2c848ef4447e
Gerrit-Change-Number: 33713
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/titan.ProtocolModules.BSSMAP/+/33713 )
Change subject: Fix message type of UPLINK SEIZED COMMAND
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/titan.ProtocolModules.BSSMAP/+/33713
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: titan.ProtocolModules.BSSMAP
Gerrit-Branch: master
Gerrit-Change-Id: I61ff2532a4d6eb3aa1ed96cdeb1f2c848ef4447e
Gerrit-Change-Number: 33713
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 12 Jul 2023 09:11:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment