Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33715 )
Change subject: MME_Tests: add Gn interface
......................................................................
Patch Set 1:
(1 comment)
File mme/MME_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33715/comment/b5e65cb9_99b2…
PS1, Line 602: f_gtp_register_teid('00000000'O);
This looks strange. TEID 0 is special and I would expect it's not needed to register it. In fact, it should be broadcasted to all the GTP ports registered imho.
We can also leave it this way and reigster it explicitly on the requested handler. But better check the internals to make sure TEID is not already handled specially.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33715
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I38b668df15b3dd10542b4aa8790b9ea33c1f9635
Gerrit-Change-Number: 33715
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Jul 2023 11:48:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33714 )
Change subject: GTP_Emulation: make GTPU optional
......................................................................
Patch Set 1:
(2 comments)
File mme/gen_links.sh:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33714/comment/18c16e37_af3f…
PS1, Line 43: FILES="GTPC_EncDec.cc GTPC_Types.ttcn GTPU_EncDec.cc GTPU_Types.ttcn"
All changes in this file look non related to the commit?
File mme/regen_makefile.sh:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33714/comment/0df1f28a_1dc3…
PS1, Line 9: BSSGP_EncDec.cc
non-related to this commit?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33714
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I509a229fcaf02ea5149df42816af27bba46d3bff
Gerrit-Change-Number: 33714
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Jul 2023 11:44:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33720 )
Change subject: MGW_Tests: Add test for "confecho" connection.
......................................................................
MGW_Tests: Add test for "confecho" connection.
The test uses two connections: "confecho" and "sendonly". It is expected
that "confecho" connection receives as many RTP packets as it sends,
because it echoes back its packets. It is also expected that "sendonly"
connection receives the same amount of RTP packets.
Change-Id: I7df4a58ad9287a564b2daf7548b882c03787f7f2
---
M mgw/MGCP_Test.ttcn
1 file changed, 67 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/33720/1
diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index 7d01b97..6b2d569 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -2283,6 +2283,58 @@
setverdict(pass);
}
+ testcase TC_two_crcx_confecho_sendonly_rtp() runs on dummy_CT {
+ var RtpFlowData flow[2];
+ var MgcpEndpoint ep := c_mgw_ep_rtpbridge & "2@" & c_mgw_domain;
+ var MgcpCallId call_id := '1225'H;
+ var RtpemStats stats[2];
+
+ f_init(ep);
+
+ /* "Talker" is sending to MGW and receives echo. */
+ flow[0] := valueof(t_RtpFlow(mp_local_ipv4, mp_remote_ipv4, 112, "GSM-HR-08/8000/1"));
+ flow[0].em.portnr := 10000;
+ f_flow_create(RTPEM[0], ep, call_id, "confecho", flow[0]);
+
+ /* "Listener" receives from MGW. */
+ flow[1] := valueof(t_RtpFlow(mp_local_ipv4, mp_remote_ipv4, 112, "GSM-HR-08/8000/1"));
+ flow[1].em.portnr := 20000;
+ f_flow_create(RTPEM[1], ep, call_id, "sendonly", flow[1]);
+
+
+ f_rtpem_mode(RTPEM[0], RTPEM_MODE_BIDIR);
+ f_rtpem_mode(RTPEM[1], RTPEM_MODE_BIDIR);
+ f_sleep(1.0);
+ f_flow_delete(RTPEM[0], ep, call_id);
+ f_flow_delete(RTPEM[1]);
+
+ stats[0] := f_rtpem_stats_get(RTPEM[0]);
+ stats[1] := f_rtpem_stats_get(RTPEM[1]);
+
+ /* The "Talker" will receive his RTP, so TX must match RX.
+ * As RTP from "Listener" is ignored, no extra packets shall be received. */
+ if (stats[0].num_pkts_tx != stats[0].num_pkts_rx) {
+ setverdict(fail);
+ }
+ if (stats[0].bytes_payload_tx != stats[0].bytes_payload_rx) {
+ setverdict(fail);
+ }
+
+ /* The "Listener" will also receive RTP of the "Talker",
+ * so TX of "Talker" must match RX of "Listener". */
+ if (stats[0].num_pkts_tx != stats[1].num_pkts_rx) {
+ setverdict(fail);
+ }
+ if (stats[0].bytes_payload_tx != stats[1].bytes_payload_rx) {
+ setverdict(fail);
+ }
+
+ f_rtpem_stats_err_check(stats[0]);
+ f_rtpem_stats_err_check(stats[1]);
+
+ setverdict(pass);
+ }
+
/* create two local RTP emulations; create two connections on MGW EP, see if
* exchanged data is converted between ts101318 and rfc5993 */
@@ -3081,6 +3133,7 @@
execute(TC_two_crcx_mdcx_and_rtp());
execute(TC_two_crcx_and_unsolicited_rtp());
execute(TC_two_crcx_and_one_mdcx_rtp_ho());
+ execute(TC_two_crcx_confecho_sendonly_rtp());
execute(TC_ts101318_rfc5993_rtp_conversion());
execute(TC_ts101318_rfc5993_rtp_conversion_fmtp());
execute(TC_amr_oa_bwe_rtp_conversion());
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33720
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7df4a58ad9287a564b2daf7548b882c03787f7f2
Gerrit-Change-Number: 33720
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-MessageType: newchange
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33718 )
Change subject: BSC_Tests_ASCI: Do not expect UPLINK BUSY message
......................................................................
BSC_Tests_ASCI: Do not expect UPLINK BUSY message
There is no UPLINK BUSY message sent by BSC, if the talker
requests/establishes the uplink. Due to timing reason, the message is
sent by the BTS itself towards the MS.
Change-Id: I2e3b866eca174ae212ea986980d508e48e31fa57
---
M bsc/BSC_Tests_ASCI.ttcn
1 file changed, 19 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/18/33718/1
diff --git a/bsc/BSC_Tests_ASCI.ttcn b/bsc/BSC_Tests_ASCI.ttcn
index 78e4356..ebf8407 100644
--- a/bsc/BSC_Tests_ASCI.ttcn
+++ b/bsc/BSC_Tests_ASCI.ttcn
@@ -213,8 +213,9 @@
setverdict(fail, "VGCS: No uplink request as expected!");
return;
}
- if (not uplink_busy) {
- setverdict(fail, "VGCS: Uplink not busy as expected!");
+ /* UPLINK BUSY is automatically sent by BTS, but not by BSC. */
+ if (uplink_busy) {
+ setverdict(fail, "VGCS: Uplink set to busy, this is not expected!");
return;
}
log("VGCS: Uplink requested and uplink marked busy as expected!");
@@ -226,8 +227,9 @@
setverdict(fail, "VGCS: No uplink request confirm as expected!");
return;
}
- if (not uplink_busy) {
- setverdict(fail, "VGCS: Uplink not busy as expected!");
+ /* UPLINK BUSY is automatically sent by BTS, but not by BSC. */
+ if (uplink_busy) {
+ setverdict(fail, "VGCS: Uplink set to busy, this is not expected!");
return;
}
log("VGCS: Uplink established and uplink marked busy as expected!");
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33718
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2e3b866eca174ae212ea986980d508e48e31fa57
Gerrit-Change-Number: 33718
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-MessageType: newchange