July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: bts/osmo-bts.cfg: reduce {DPCU,DLIMB} logging verbosity
by pespin 12 Jul '23

12 Jul '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33721 ) Change subject: bts/osmo-bts.cfg: reduce {DPCU,DLIMB} logging verbosity ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieb0768ac0db4d79eb45ca41dea941284cc55f407 Gerrit-Change-Number: 33721 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jul 2023 15:27:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: print DL TCH length in f_TC_speech_osmux()
by fixeria 12 Jul '23

12 Jul '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33722 ) Change subject: BTS_Tests: print DL TCH length in f_TC_speech_osmux() ...................................................................... BTS_Tests: print DL TCH length in f_TC_speech_osmux() I forgot to update this function in [1]. Change-Id: I2a2dccd32aaf94afc31bd44f14fdc1cfdf554d2d Related: [1] I5848bd8acd220c1c4d2db01b71bb57e785dc9de7 --- M bts/BTS_Tests.ttcn 1 file changed, 15 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/22/33722/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index b8c4118..7691187 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -8439,9 +8439,9 @@ Td.start(2.0); alt { [] L1CTL.receive(tr_L1CTL_TRAFFIC_IND(g_chan_nr, frame := exp_rtp_pl)) -> value l1_dl { - log("TCH received: ", l1_dl.payload.traffic_ind.data); - L1CTL.send(ts_L1CTL_TRAFFIC_REQ(g_chan_nr, l1_dl.dl_info.link_id, - l1_dl.payload.traffic_ind.data)); + var octetstring data := l1_dl.payload.traffic_ind.data; + log("TCH received (len=", lengthof(data), "): ", data); + L1CTL.send(ts_L1CTL_TRAFFIC_REQ(g_chan_nr, l1_dl.dl_info.link_id, data)); setverdict(pass); } [] L1CTL.receive(tr_L1CTL_TRAFFIC_IND(g_chan_nr, frame := ?)) -> value l1_dl { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33722 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2a2dccd32aaf94afc31bd44f14fdc1cfdf554d2d Gerrit-Change-Number: 33722 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts/osmo-bts.cfg: reduce {DPCU,DLIMB} logging verbosity
by fixeria 12 Jul '23

12 Jul '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33721 ) Change subject: bts/osmo-bts.cfg: reduce {DPCU,DLIMB} logging verbosity ...................................................................... bts/osmo-bts.cfg: reduce {DPCU,DLIMB} logging verbosity Change-Id: Ieb0768ac0db4d79eb45ca41dea941284cc55f407 --- M bts/osmo-bts.cfg 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/33721/1 diff --git a/bts/osmo-bts.cfg b/bts/osmo-bts.cfg index 6bd22bf..e80f51b 100644 --- a/bts/osmo-bts.cfg +++ b/bts/osmo-bts.cfg @@ -22,10 +22,10 @@ logging level pag info logging level l1c info logging level dsp info - logging level pcu debug + logging level pcu info logging level trx info logging level osmux info - logging level lmib debug + logging level lmib info logging level lmux info ! line vty -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ieb0768ac0db4d79eb45ca41dea941284cc55f407 Gerrit-Change-Number: 33721 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: run TCH and SACCH loops in f_TC_speech_osmux()
by fixeria 12 Jul '23

12 Jul '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33723 ) Change subject: BTS_Tests: run TCH and SACCH loops in f_TC_speech_osmux() ...................................................................... BTS_Tests: run TCH and SACCH loops in f_TC_speech_osmux() I forgot to update this function in [1]. Let's make it consistent with the f_TC_speech_rtp(). More details can be found in the linked patch. Change-Id: I8c2f8bb4cc4b44378af5536893bc73fde368b3fe Related: [1] Ifb69669b75df5b390d7056cefaf0ef1df69d9bd4 --- M bts/BTS_Tests.ttcn 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/33723/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 7691187..3433666 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -8465,6 +8465,8 @@ amr_cmr := amr_ft); Tu.start(2.0); alt { + [] as_l1_tch_loop(); + [] as_l1_sacch(); [] OsmuxEM_DATA.receive(osmux_pdu_exp) -> value osmux_pdu { var boolean matched := false; for (var integer i := 0; i < osmux_pdu.osmux_amr.header.ctr + 1; i := i + 1) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33723 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8c2f8bb4cc4b44378af5536893bc73fde368b3fe Gerrit-Change-Number: 33723 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: pySim/cards: Add type annotations
by dexter 12 Jul '23

12 Jul '23

Attention is currently required from: laforge, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33692 ) Change subject: pySim/cards: Add type annotations ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id5752a64b59097584301c860ebf74d858ed3d240 Gerrit-Change-Number: 33692 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jul 2023 14:45:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: ASCI: Add support for Group/Broadcast channel activation
by jolly 12 Jul '23

12 Jul '23

Attention is currently required from: laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33599 ) Change subject: ASCI: Add support for Group/Broadcast channel activation ...................................................................... Patch Set 4: (1 comment) File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/33599/comment/e3de1454_d3873fd1 PS3, Line 408: bool vamos, bool vgcs, bool vbs) > it's a bit odd that we pass multiple separate bool variables in here, where in reality only one of t […] I will provide it as another patch, because this would affect existing code. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic0c0597d149d0758d6766937d99660fa02e0e139 Gerrit-Change-Number: 33599 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 12 Jul 2023 14:43:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[L] Change in pysim[master]: create pySim.legacy.ts_51_011.py and move legacy code there
by dexter 12 Jul '23

12 Jul '23

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33693 ) Change subject: create pySim.legacy.ts_51_011.py and move legacy code there ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33693 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I20ceea3fdb02ee70d8c8889c078b2e5a0f17c83b Gerrit-Change-Number: 33693 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 12 Jul 2023 14:33:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: pySim-shell: Add a mode where a pySim-shell cmd can be passed by shell
by dexter 12 Jul '23

12 Jul '23

Attention is currently required from: laforge, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33705 ) Change subject: pySim-shell: Add a mode where a pySim-shell cmd can be passed by shell ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Tested it Works fine! -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0ed379b23a4b1126006fd8f9e7ba2ba07fb01ada Gerrit-Change-Number: 33705 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jul 2023 14:29:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: cards: all UICC should use sel_ctrl="0400" and SIM "0000"
by dexter 12 Jul '23

12 Jul '23

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33697 ) Change subject: cards: all UICC should use sel_ctrl="0400" and SIM "0000" ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33697 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iad197c2b560c5ea05c54a122144361de5742aafd Gerrit-Change-Number: 33697 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 12 Jul 2023 14:17:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: pySim-shell: Iterate over CardApplication sub-classes
by dexter 12 Jul '23

12 Jul '23

Attention is currently required from: laforge, fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33700 ) Change subject: pySim-shell: Iterate over CardApplication sub-classes ...................................................................... Patch Set 2: Verified+1 Code-Review+1 (1 comment) Patchset: PS2: Tested it, seems to work fine. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33700 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia6918e49d73d80acfaf09506e604d4929d37f1b6 Gerrit-Change-Number: 33700 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jul 2023 14:07:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0