July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-remsim[master]: user_shell: Fix unchecked return value of osmo_fd_register()
by fixeria 18 Jul '23

18 Jul '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33779 ) Change subject: user_shell: Fix unchecked return value of osmo_fd_register() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I68ed44464573b9a6fecd07cf13fd2d6f4a1013bb Gerrit-Change-Number: 33779 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 18 Jul 2023 11:52:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-remsim[master]: user_ifdhandler: Fix missing check of osmo_fd_register return val
by fixeria 18 Jul '23

18 Jul '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33778 ) Change subject: user_ifdhandler: Fix missing check of osmo_fd_register return val ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I99d7254b6cc3bf5ead800dafabc77a965857911c Gerrit-Change-Number: 33778 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 18 Jul 2023 11:51:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-remsim[master]: rspro_client_fsm: Fix integer overflow calculating re-establishment d...
by fixeria 18 Jul '23

18 Jul '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33777 ) Change subject: rspro_client_fsm: Fix integer overflow calculating re-establishment delay ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ib1cca5ac0d27807936a52e0c013f0442350ecc00 Gerrit-Change-Number: 33777 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 18 Jul 2023 11:51:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: scripts/kernel-test/run-qemu: update qemu args
by fixeria 18 Jul '23

18 Jul '23

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33776 ) Change subject: scripts/kernel-test/run-qemu: update qemu args ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33776 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iba84d8e61c2d9cbd687d803066db0c04aca9f805 Gerrit-Change-Number: 33776 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jul 2023 11:50:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: hnbgw: Skip asn1 talloc mem checks in osmo-hnbgw-latest
by pespin 18 Jul '23

18 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/33781 ) Change subject: hnbgw: Skip asn1 talloc mem checks in osmo-hnbgw-latest ...................................................................... hnbgw: Skip asn1 talloc mem checks in osmo-hnbgw-latest Depends: osmo-ttcn3-hacks.git Change-Id I5c18cf2d6797bcf0bef13d71ab0b69f1403b474f Change-Id: I1a933795ffef3cea97fcf34b1c513e71f3256c83 --- M ttcn3-hnbgw-test/HNBGW_Tests.cfg M ttcn3-hnbgw-test/jenkins.sh 2 files changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/81/33781/1 diff --git a/ttcn3-hnbgw-test/HNBGW_Tests.cfg b/ttcn3-hnbgw-test/HNBGW_Tests.cfg index 5d07cb1..a76d5fd 100644 --- a/ttcn3-hnbgw-test/HNBGW_Tests.cfg +++ b/ttcn3-hnbgw-test/HNBGW_Tests.cfg @@ -108,7 +108,7 @@ rctx := 8 } }; - +HNBGW_Tests.mp_validate_talloc_asn1 := true; [MAIN_CONTROLLER] diff --git a/ttcn3-hnbgw-test/jenkins.sh b/ttcn3-hnbgw-test/jenkins.sh index e93c8af..51dd825 100755 --- a/ttcn3-hnbgw-test/jenkins.sh +++ b/ttcn3-hnbgw-test/jenkins.sh @@ -31,6 +31,10 @@ mkdir $base_dir/hnbgw-tester/unix cp "$tests_cfg" $base_dir/hnbgw-tester/ write_mp_osmo_repo "$base_dir/hnbgw-tester/HNBGW_Tests.cfg" + # Can be removed once a new release osmo-hnbgw > 1.4.0 is avilable: + if ! image_suffix_is_master; then + sed -i 's/HNBGW_Tests.mp_validate_talloc_asn1 := true/HNBGW_Tests.mp_validate_talloc_asn1 := false/g' "$base_dir/hnbgw-tester/HNBGW_Tests.cfg" + fi mkdir $base_dir/stp cp "$stp_cfg" $base_dir/stp/ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1a933795ffef3cea97fcf34b1c513e71f3256c83 Gerrit-Change-Number: 33781 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in docker-playground[master]: scripts/kernel-test/run-qemu: set init=/init
by fixeria 18 Jul '23

18 Jul '23

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33775 ) Change subject: scripts/kernel-test/run-qemu: set init=/init ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33775 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I063c7625acaa15130d8361d4e944c3773c9b37c4 Gerrit-Change-Number: 33775 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jul 2023 11:49:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce module parameter mp_validate_talloc_asn1
by pespin 18 Jul '23

18 Jul '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33780 ) Change subject: hnbgw: Introduce module parameter mp_validate_talloc_asn1 ...................................................................... hnbgw: Introduce module parameter mp_validate_talloc_asn1 This allows selectively disabling ASN.1 memory checks, which still fail in current osmo-hnbgw-latest. Change-Id: I5c18cf2d6797bcf0bef13d71ab0b69f1403b474f --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/33780/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index f38fc0c..a89837a 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -185,6 +185,8 @@ /* IP address from which the SUT (osmo-hnbgw) sends PFCP requests, and to which the ttcn3 UPF emulation sends * PFCP responses. */ charstring mp_pfcp_ip_remote := "127.0.0.2"; + + boolean mp_validate_talloc_asn1 := true; } function MSC_UnitdataCallback(RANAP_PDU ranap) runs on RAN_Emulation_CT return template RANAP_PDU { @@ -460,7 +462,9 @@ } friend function f_shutdown_helper() runs on test_CT { - f_verify_talloc_bytes(HNBGWVTY, {"asn1_context"}, 1); + if (mp_validate_talloc_asn1) { + f_verify_talloc_bytes(HNBGWVTY, {"asn1_context"}, 1); + } all component.stop; setverdict(pass); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5c18cf2d6797bcf0bef13d71ab0b69f1403b474f Gerrit-Change-Number: 33780 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-remsim[master]: user_shell: Fix unchecked return value of osmo_fd_register()
by pespin 18 Jul '23

18 Jul '23

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33779 ) Change subject: user_shell: Fix unchecked return value of osmo_fd_register() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I68ed44464573b9a6fecd07cf13fd2d6f4a1013bb Gerrit-Change-Number: 33779 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 18 Jul 2023 11:46:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-remsim[master]: user_ifdhandler: Fix missing check of osmo_fd_register return val
by pespin 18 Jul '23

18 Jul '23

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33778 ) Change subject: user_ifdhandler: Fix missing check of osmo_fd_register return val ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I99d7254b6cc3bf5ead800dafabc77a965857911c Gerrit-Change-Number: 33778 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 18 Jul 2023 11:46:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-remsim[master]: rspro_client_fsm: Fix integer overflow calculating re-establishment d...
by pespin 18 Jul '23

18 Jul '23

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33777 ) Change subject: rspro_client_fsm: Fix integer overflow calculating re-establishment delay ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ib1cca5ac0d27807936a52e0c013f0442350ecc00 Gerrit-Change-Number: 33777 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 18 Jul 2023 11:46:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0