July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-e1d[master]: Check return code of fcntl() in several plaaces
by pespin 18 Jul '23

18 Jul '23

Attention is currently required from: laforge, tnt. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/33782 ) Change subject: Check return code of fcntl() in several plaaces ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/33782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I46843174eb4699a59421dc3f3b900a3894c67081 Gerrit-Change-Number: 33782 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Tue, 18 Jul 2023 13:16:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: scripts/kernel-test: fixup for initrd_add_file
by laforge 18 Jul '23

18 Jul '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33786 ) Change subject: scripts/kernel-test: fixup for initrd_add_file ...................................................................... scripts/kernel-test: fixup for initrd_add_file The previous versions happened to work too in my testing with osmo-ggsn. Use the correct loop variable. Fixes: 0660fc4e ("scripts/kernel-test: adjust to usr-merge") Change-Id: I0c0ca91116a8cd156b185bb53512371bbcb76515 --- M scripts/kernel-test/initrd-build.sh 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/scripts/kernel-test/initrd-build.sh b/scripts/kernel-test/initrd-build.sh index 6c17ffa..d942719 100755 --- a/scripts/kernel-test/initrd-build.sh +++ b/scripts/kernel-test/initrd-build.sh @@ -10,10 +10,10 @@ for i in "$@"; do case "$i" in /bin/*|/sbin/*|/lib/*|/lib64/*) - cp -a --parents "$@" /tmp/initrd/usr + cp -a --parents "$i" /tmp/initrd/usr ;; *) - cp -a --parents "$@" /tmp/initrd + cp -a --parents "$i" /tmp/initrd ;; esac done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0c0ca91116a8cd156b185bb53512371bbcb76515 Gerrit-Change-Number: 33786 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in docker-playground[master]: scripts/kernel-test: fixup for initrd_add_file
by laforge 18 Jul '23

18 Jul '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/33786 ) Change subject: scripts/kernel-test: fixup for initrd_add_file ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/33786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0c0ca91116a8cd156b185bb53512371bbcb76515 Gerrit-Change-Number: 33786 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jul 2023 13:10:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in simtrace2[master]: Fix unchecked return value of osmo_libusb_init()
by laforge 18 Jul '23

18 Jul '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/33792 ) Change subject: Fix unchecked return value of osmo_libusb_init() ...................................................................... Fix unchecked return value of osmo_libusb_init() Fixes: CID#307501: Unchecked return value (CHECKED_RETURN) Change-Id: Ic1f600dfd44d15da165a17d84f0faab6f6fd69c3 --- M host/src/simtrace2_usb.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/92/33792/1 diff --git a/host/src/simtrace2_usb.c b/host/src/simtrace2_usb.c index 8ebc4f7..b329ead 100644 --- a/host/src/simtrace2_usb.c +++ b/host/src/simtrace2_usb.c @@ -78,7 +78,7 @@ int main(int argc, char **argv) { osmo_init_logging2(NULL, &log_info); - osmo_libusb_init(NULL); + OSMO_ASSERT(osmo_libusb_init(NULL) == 0); find_devices(); return 0; } -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/33792 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ic1f600dfd44d15da165a17d84f0faab6f6fd69c3 Gerrit-Change-Number: 33792 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-uecups[master]: gtp_tunnel: Avoid double-unlock in error path of gtp_tunnel_alloc
by laforge 18 Jul '23

18 Jul '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-uecups/+/33791 ) Change subject: gtp_tunnel: Avoid double-unlock in error path of gtp_tunnel_alloc ...................................................................... gtp_tunnel: Avoid double-unlock in error path of gtp_tunnel_alloc Fixes: CID#307509: Double unlock (LOCK) Change-Id: Ie6e4c08d2c235fbe90516c3dfe2c82963fd70a6f --- M daemon/gtp_tunnel.c 1 file changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/91/33791/1 diff --git a/daemon/gtp_tunnel.c b/daemon/gtp_tunnel.c index f9075f7..87d1e69 100644 --- a/daemon/gtp_tunnel.c +++ b/daemon/gtp_tunnel.c @@ -28,7 +28,7 @@ t = talloc_zero(d, struct gtp_tunnel); if (!t) - goto out_unlock; + goto out; t->d = d; t->name = talloc_asprintf(t, "%s-R%08x-T%08x", cpars->tun_name, cpars->rx_teid, cpars->tx_teid); t->tun_dev = tun_device_find_or_create(d, cpars->tun_name, cpars->tun_netns_name); @@ -72,14 +72,13 @@ return t; out_ep: + pthread_rwlock_unlock(&d->rwlock); _gtp_endpoint_release(t->gtp_ep); out_tun: _tun_device_release(t->tun_dev); out_free: talloc_free(t); -out_unlock: - pthread_rwlock_unlock(&d->rwlock); - +out: return NULL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/33791 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: Ie6e4c08d2c235fbe90516c3dfe2c82963fd70a6f Gerrit-Change-Number: 33791 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-remsim[master]: user_simtrace2: Fix uninitialized ifm->path
by laforge 18 Jul '23

18 Jul '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33790 ) Change subject: user_simtrace2: Fix uninitialized ifm->path ...................................................................... user_simtrace2: Fix uninitialized ifm->path Let's memset the entire ifm before calling osmo_libusb_open_claim_interface() Fixes: CID#307510: Uninitialized scalar variable (UNINIT) Change-Id: I2bd0dac76b6d028d10f12f3f58a2aee123ca8562 --- M src/client/user_simtrace2.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/90/33790/1 diff --git a/src/client/user_simtrace2.c b/src/client/user_simtrace2.c index 29ab196..19bda88 100644 --- a/src/client/user_simtrace2.c +++ b/src/client/user_simtrace2.c @@ -411,6 +411,7 @@ ci->priv = bc; bc->cardem = ci; + memset(&ifm, 0, sizeof(ifm)); ifm->vendor = cfg->usb.vendor_id; ifm->product = cfg->usb.product_id; ifm->configuration = cfg->usb.config_id; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/33790 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2bd0dac76b6d028d10f12f3f58a2aee123ca8562 Gerrit-Change-Number: 33790 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-e1-recorder[master]: e1_recorder: Fix potential null-dereference
by laforge 18 Jul '23

18 Jul '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1-recorder/+/33789 ) Change subject: e1_recorder: Fix potential null-dereference ...................................................................... e1_recorder: Fix potential null-dereference Fixes: CID#307523: Dereference null return value (NULL_RETURNS) Change-Id: I481f0695f971f5cd2e77b8c9c62d423a70e0840d --- M src/e1_recorder.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-recorder refs/changes/89/33789/1 diff --git a/src/e1_recorder.c b/src/e1_recorder.c index 996ede4..cc21bc0 100644 --- a/src/e1_recorder.c +++ b/src/e1_recorder.c @@ -77,6 +77,7 @@ if (rline->mirror.enabled) { struct e1inp_line *other_line = e1inp_line_find(rline->mirror.line_nr); + OSMO_ASSERT(other_line); struct e1inp_ts *other_ts; other_ts = &other_line->ts[ts->num-1]; if (!other_ts) { -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-recorder/+/33789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-recorder Gerrit-Branch: master Gerrit-Change-Id: I481f0695f971f5cd2e77b8c9c62d423a70e0840d Gerrit-Change-Number: 33789 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-uecups[master]: daemon_vty: avoid null-dereference in argc < 0 case
by laforge 18 Jul '23

18 Jul '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-uecups/+/33788 ) Change subject: daemon_vty: avoid null-dereference in argc < 0 case ...................................................................... daemon_vty: avoid null-dereference in argc < 0 case in show_gtp_cmd, we have two different checks (argc > 0) vs (argc) which means in theory argc could be negative and the second clause would be executed without the first having set up related data such as 'ai'. Fixes: CID#307521: Explicit null dereferenced (FORWARD_NULL) Change-Id: I4149b0b191a34168ba6649338d3cdf6c6af6cfe7 --- M daemon/daemon_vty.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/88/33788/1 diff --git a/daemon/daemon_vty.c b/daemon/daemon_vty.c index cfbe421..c5cca74 100644 --- a/daemon/daemon_vty.c +++ b/daemon/daemon_vty.c @@ -145,7 +145,7 @@ show_ep_hdr(vty); pthread_rwlock_rdlock(&g_daemon->rwlock); - if (argc) { + if (argc > 0) { ep = _gtp_endpoint_find(g_daemon, (const struct sockaddr_storage *) ai->ai_addr); if (!ep) { pthread_rwlock_unlock(&g_daemon->rwlock); -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/33788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I4149b0b191a34168ba6649338d3cdf6c6af6cfe7 Gerrit-Change-Number: 33788 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-uecups[master]: gtp_daemon: Fix error paths in gtp_daemon_alloc()
by laforge 18 Jul '23

18 Jul '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-uecups/+/33787 ) Change subject: gtp_daemon: Fix error paths in gtp_daemon_alloc() ...................................................................... gtp_daemon: Fix error paths in gtp_daemon_alloc() Fixes: CID#307527: Unchecked return value (CHECKED_RETURN) Change-Id: I690b24671567aac4dca24389309ebaa3e76e272c --- M daemon/gtp_daemon.c 1 file changed, 23 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/87/33787/1 diff --git a/daemon/gtp_daemon.c b/daemon/gtp_daemon.c index b5b7ac8..31ae39f 100644 --- a/daemon/gtp_daemon.c +++ b/daemon/gtp_daemon.c @@ -54,6 +54,7 @@ struct gtp_daemon *gtp_daemon_alloc(void *ctx) { + int rc; struct gtp_daemon *d = talloc_zero(ctx, struct gtp_daemon); if (!d) return NULL; @@ -66,7 +67,12 @@ d->main_thread = pthread_self(); d->itq = osmo_it_q_alloc(d, "itq", 4096, gtp_daemon_itq_read_cb, d); - osmo_fd_register(&d->itq->event_ofd); + if (!d->itq) + goto out_free; + + rc = osmo_fd_register(&d->itq->event_ofd); + if (rc < 0) + goto out_free_q; INIT_LLIST_HEAD(&d->cups_clients); @@ -74,4 +80,10 @@ d->cfg.cups_local_port = UECUPS_SCTP_PORT; return d; + +out_free_q: + osmo_it_q_destroy(d->itq); +out_free: + talloc_free(d); + return NULL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/33787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I690b24671567aac4dca24389309ebaa3e76e272c Gerrit-Change-Number: 33787 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce module parameter mp_validate_talloc_asn1
by osmith 18 Jul '23

18 Jul '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33780 ) Change subject: hnbgw: Introduce module parameter mp_validate_talloc_asn1 ...................................................................... Patch Set 1: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5c18cf2d6797bcf0bef13d71ab0b69f1403b474f Gerrit-Change-Number: 33780 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Jul 2023 12:33:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0