Attention is currently required from: jolly.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/32931
to look at the new patch set (#3).
Change subject: ASCI: Add IE transcoding according to 3GPP TS 48.008
......................................................................
ASCI: Add IE transcoding according to 3GPP TS 48.008
Change-Id: Ic1fc714bb04228a7f32e9925811e21c8efc610bd
---
M include/osmocom/gsm/gsm0808_utils.h
M src/gsm/gsm0808_utils.c
M src/gsm/libosmogsm.map
3 files changed, 568 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/31/32931/3
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32931
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic1fc714bb04228a7f32e9925811e21c8efc610bd
Gerrit-Change-Number: 32931
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: jolly.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32935 )
Change subject: Add short L3 header to gsm_04_08.h
......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/gsm/protocol/gsm_04_08.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7330):
https://gerrit.osmocom.org/c/libosmocore/+/32935/comment/3207804c_fb62a707
PS2, Line 1424: /* Secion 11.3.2.1 3GPP TS 24.007: Short PDISC */
'Secion' may be misspelled - perhaps 'Section'?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32935
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0eceb380e401e1f842edbaa92f4b4738703a031c
Gerrit-Change-Number: 32935
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 24 May 2023 11:47:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: jolly.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32931 )
Change subject: ASCI: Add IE transcoding according to 3GPP TS 48.008
......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/gsm/gsm0808_utils.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7329):
https://gerrit.osmocom.org/c/libosmocore/+/32931/comment/b4540fd7_632442bb
PS2, Line 481: const struct gsm0808_cell_id_list_segment *ci);
code indent should use tabs where possible
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32931
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic1fc714bb04228a7f32e9925811e21c8efc610bd
Gerrit-Change-Number: 32931
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 24 May 2023 11:47:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: jolly.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32932 )
Change subject: ASCI: Add message definition and encoding according to 3GPP TS 48.008
......................................................................
Patch Set 2:
(1 comment)
File src/gsm/gsm0808.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7328):
https://gerrit.osmocom.org/c/libosmocore/+/32932/comment/3698af6a_9720a8e3
PS2, Line 2154: * message type infromation in the specifications. */
'infromation' may be misspelled - perhaps 'information'?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32932
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib94c64136c31ce4af67c314a8550d93946cc844f
Gerrit-Change-Number: 32932
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 24 May 2023 11:47:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: jolly, dexter.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32930 )
Change subject: ASCI: Add 3GPP TS 44.068 and 44.069 protocol definitions
......................................................................
Patch Set 2:
(8 comments)
File src/gsm/gsm44068.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7326):
https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/05f588df_0328ddfb
PS2, Line 64: { OSMO_GSM44068_CAUSE_APP_NOT_SUPPORTED_ON_PROTO,"Application not supported on the protocol" },
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7326):
https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/291cbded_34f1a193
PS2, Line 71: { OSMO_GSM44068_CAUSE_NET_WANTS_TO_MAINTAIN_CALL,"Network wants to maintain call" },
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7326):
https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/e5dbe3b5_0e30d5fa
PS2, Line 73: { OSMO_GSM44068_CAUSE_SERVICE_OPTION_NOT_SUBSCR,"Service option not supported" },
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7326):
https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/db87a087_bd0393da
PS2, Line 74: { OSMO_GSM44068_CAUSE_REQUESTED_SERVICE_NOT_SUB,"Requested service option not subscribed" },
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7326):
https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/a568bf27_f1d08cc4
PS2, Line 76: { OSMO_GSM44068_CAUSE_CALL_CANNOT_BE_IDENTIFIED,"Call cannot be identified" },
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7326):
https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/a4966215_70bc7898
PS2, Line 77: { OSMO_GSM44068_CAUSE_RETRY_UPON_ENTRY_NEW_CALL,"retry upon entry into a new cell" },
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7326):
https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/1391d5ea_0c8c2622
PS2, Line 79: { OSMO_GSM44068_CAUSE_SEMANTICALLY_INCORRECT_MSG,"Semantically incorrect message" },
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-7326):
https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/cbca1cd1_f11e9ab3
PS2, Line 81: { OSMO_GSM44068_CAUSE_MESSAGE_TYPE_NON_EXISTENT,"Message type non-existent or not implemented" },
space required after that ',' (ctx:VxV)
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32930
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3554cea47e714c8fca18c3e9c0e6e80695915a90
Gerrit-Change-Number: 32930
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 24 May 2023 11:47:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: jolly.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/32931
to look at the new patch set (#2).
Change subject: ASCI: Add IE transcoding according to 3GPP TS 48.008
......................................................................
ASCI: Add IE transcoding according to 3GPP TS 48.008
Change-Id: Ic1fc714bb04228a7f32e9925811e21c8efc610bd
---
M include/osmocom/gsm/gsm0808_utils.h
M src/gsm/gsm0808_utils.c
M src/gsm/libosmogsm.map
3 files changed, 568 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/31/32931/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32931
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic1fc714bb04228a7f32e9925811e21c8efc610bd
Gerrit-Change-Number: 32931
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-MessageType: newpatchset
Attention is currently required from: jolly.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/32932
to look at the new patch set (#2).
Change subject: ASCI: Add message definition and encoding according to 3GPP TS 48.008
......................................................................
ASCI: Add message definition and encoding according to 3GPP TS 48.008
Change-Id: Ib94c64136c31ce4af67c314a8550d93946cc844f
---
M include/osmocom/gsm/gsm0808.h
M include/osmocom/gsm/protocol/gsm_08_08.h
M src/gsm/gsm0808.c
M src/gsm/libosmogsm.map
4 files changed, 914 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/32/32932/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32932
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib94c64136c31ce4af67c314a8550d93946cc844f
Gerrit-Change-Number: 32932
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-MessageType: newpatchset