Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/32719
to look at the new patch set (#5).
Change subject: WIP: apply pylint on cmd2 1.5 and later versions seperately
......................................................................
WIP: apply pylint on cmd2 1.5 and later versions seperately
Change-Id: I129b8c90ac80d75e125c81f5d5028fae3e295e6d
---
M contrib/jenkins.sh
1 file changed, 23 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/19/32719/5
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/32719
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I129b8c90ac80d75e125c81f5d5028fae3e295e6d
Gerrit-Change-Number: 32719
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32719 )
Change subject: WIP: apply pylinth on cmd2 1.5 and later versions seperately
......................................................................
Patch Set 4:
(2 comments)
This change is ready for review.
Patchset:
PS4:
My approach seems to be problematic. Not sure if it makes sense to take the effort to debug this.
File contrib/jenkins.sh:
https://gerrit.osmocom.org/c/pysim/+/32719/comment/dcff107e_728daba0
PS4, Line 36: pip uninstall -y cmd2
I am getting error messages around the pip install/uninstall commandlines. In particular:
+ [ ! -d ./pysim-testdata/ ]
+ pip uninstall -y cmd2
Skipping cmd2 as it is not installed.
This does not make sense. Pylint should need a cmd2 version to be installed in order to do the linting. How can it even complain about things like constructor arguments when cmd2 is not installed?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/32719
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I129b8c90ac80d75e125c81f5d5028fae3e295e6d
Gerrit-Change-Number: 32719
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 24 May 2023 08:41:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: neels.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32911
to look at the new patch set (#2).
Change subject: drop dead code: cnlink.T_RafC
......................................................................
drop dead code: cnlink.T_RafC
This looks like working RANAP RESET handling, but is in fact dead code.
Instead of testing and completing this implementation, I will copy the
RESET handling FSM from osmo-bsc, which is proven to work well.
See Id3eefdea889a736fd5957b80280fa45b9547b792
"detect in/active CN links by RANAP RESET"
The future patch will start to use transmit_rst(). So instead of
dropping now and resurrecting later, let's keep the code -- but it has
to be '#if 0'-ed to avoid compiler complaints about the unused function.
Related: SYS#6412
Change-Id: I7cacaec631051cf5420202f2f0dd9665a5565b17
---
M include/osmocom/hnbgw/hnbgw.h
M src/osmo-hnbgw/hnbgw_cn.c
2 files changed, 28 insertions(+), 55 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/11/32911/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32911
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I7cacaec631051cf5420202f2f0dd9665a5565b17
Gerrit-Change-Number: 32911
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915 )
Change subject: immediately SCCP RLSD on HNB re-register
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
> iiuc MAP_RUA_ST_DISCONNECTED means the CN side is down, and MAP_RUA_ST_DISRUPTED means the RAN side […]
ST_DISCONNECTED means we received a RUA Disconnect message.
ST_DISRUPTED means the HNB has stopped responding for whatever reason. The RUA connection is just gone without a graceful RUA Disconnect message. We noticed that and need to clean up.
I tried to explain in the commit msg...
File src/osmo-hnbgw/context_map_sccp.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915/comment/effd0a12_fa1cc689
PS1, Line 362: tx_sccp_df1(fi, ranap_msg);
: tx_sccp_rlsd(fi);
> it's a bit odd to see code here that naming-wise claims to directly transmit protocol meassages like […]
I understand the "tx" as "send down the user SAP", not necessarily transmit on a wire.
In this particular instance, there will actually be an SCCP RLSD message sent on the wire, which is the point of this patch. If a RUA conn is gone without telling the CN via RANAP Iu Release, then osmo-hnbgw will tell the CN via immediate SCCP RLSD message.
If you think this name should be changed, i'm open to that. let's do that in a separate patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I4e78617ad39bb73fe92097c8a1a8069da6a7f6a1
Gerrit-Change-Number: 32915
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 24 May 2023 01:39:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: jolly, laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405 )
Change subject: BSSMAP_Templates: Add VBS/VGCS related templates
......................................................................
Patch Set 6:
(1 comment)
File library/BSSMAP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405/comment/b8d4bfb5_94ab…
PS6, Line 668: if (istemplatekind(cid, "omit")) {
I think you also need to handle template kind `*` here, otherwise this function is no different from `ts_BSSMAP_IE_CallIdentifier()`?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I949f731de794b22292b01d0ddf9a75a9e7e7e71d
Gerrit-Change-Number: 32405
Gerrit-PatchSet: 6
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 23 May 2023 21:13:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment