May 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: coding: fix API doc: TCH/H needs 6 bursts, not 8

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32964 ) Change subject: coding: fix API doc: TCH/H needs 6 bursts, not 8 ...................................................................... coding: fix API doc: TCH/H needs 6 bursts, not 8 Change-Id: Iea787ec4c3b15a74f59d45825eae03740c5d28fa --- M src/coding/gsm0503_coding.c 1 file changed, 13 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved falconia: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/coding/gsm0503_coding.c b/src/coding/gsm0503_coding.c index 6f76824..f27b13d 100644 --- a/src/coding/gsm0503_coding.c +++ b/src/coding/gsm0503_coding.c @@ -1976,7 +1976,7 @@ /*! Perform channel decoding of a HR(v1) channel according TS 05.03 * \param[out] tch_data Codec frame in TS 101 318 canonical format - * \param[in] bursts buffer containing the symbols of 8 bursts + * \param[in] bursts buffer containing the symbols of 6 bursts * \param[in] odd Odd (1) or even (0) frame number * \param[out] n_errors Number of detected bit errors * \param[out] n_bits_total Total number of bits @@ -2054,7 +2054,7 @@ /*! Perform channel decoding of a HR(v1) channel according TS 05.03, * deprecated legacy API. * \param[out] tch_data Codec frame in pseudo-RFC5993 format - * \param[in] bursts buffer containing the symbols of 8 bursts + * \param[in] bursts buffer containing the symbols of 6 bursts * \param[in] odd Odd (1) or even (0) frame number * \param[out] n_errors Number of detected bit errors * \param[out] n_bits_total Total number of bits @@ -2635,7 +2635,7 @@ /*! Perform channel decoding of a TCH/AFS channel according TS 05.03 * \param[out] tch_data Codec frame in RTP payload format - * \param[in] bursts buffer containing the symbols of 8 bursts + * \param[in] bursts buffer containing the symbols of 6 bursts * \param[in] odd Is this an odd (1) or even (0) frame number? * \param[in] codec_mode_req is this CMR (1) or CMC (0) * \param[in] codec array of active codecs (active codec set) @@ -2658,7 +2658,7 @@ /*! Perform channel decoding of a TCH/AFS channel according TS 05.03 * \param[out] tch_data Codec frame in RTP payload format - * \param[in] bursts buffer containing the symbols of 8 bursts + * \param[in] bursts buffer containing the symbols of 6 bursts * \param[in] odd Is this an odd (1) or even (0) frame number? * \param[in] codec_mode_req is this CMR (1) or CMC (0) * \param[in] codec array of active codecs (active codec set) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32964 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iea787ec4c3b15a74f59d45825eae03740c5d28fa Gerrit-Change-Number: 32964 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: coding: fix API doc: TCH/AFS vs TCH/AHS

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32965 ) Change subject: coding: fix API doc: TCH/AFS vs TCH/AHS ...................................................................... coding: fix API doc: TCH/AFS vs TCH/AHS Change-Id: Iaed1653c6001545f69ec6b466760f30d42bc4386 --- M src/coding/gsm0503_coding.c 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved falconia: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/coding/gsm0503_coding.c b/src/coding/gsm0503_coding.c index f27b13d..f42deb2 100644 --- a/src/coding/gsm0503_coding.c +++ b/src/coding/gsm0503_coding.c @@ -2633,7 +2633,7 @@ return id; } -/*! Perform channel decoding of a TCH/AFS channel according TS 05.03 +/*! Perform channel decoding of a TCH/AHS channel according TS 05.03 * \param[out] tch_data Codec frame in RTP payload format * \param[in] bursts buffer containing the symbols of 6 bursts * \param[in] odd Is this an odd (1) or even (0) frame number? @@ -2656,7 +2656,7 @@ n_bits_total, NULL); } -/*! Perform channel decoding of a TCH/AFS channel according TS 05.03 +/*! Perform channel decoding of a TCH/AHS channel according TS 05.03 * \param[out] tch_data Codec frame in RTP payload format * \param[in] bursts buffer containing the symbols of 6 bursts * \param[in] odd Is this an odd (1) or even (0) frame number? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32965 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iaed1653c6001545f69ec6b466760f30d42bc4386 Gerrit-Change-Number: 32965 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: coding: fix API doc: TCH/AFS vs TCH/AHS

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32965 ) Change subject: coding: fix API doc: TCH/AFS vs TCH/AHS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32965 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iaed1653c6001545f69ec6b466760f30d42bc4386 Gerrit-Change-Number: 32965 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 19:16:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: coding: fix API doc: TCH/H needs 6 bursts, not 8

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32964 ) Change subject: coding: fix API doc: TCH/H needs 6 bursts, not 8 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32964 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iea787ec4c3b15a74f59d45825eae03740c5d28fa Gerrit-Change-Number: 32964 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 19:16:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: libosmocoding.map: export gsm0503_tch_hr_decode2()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32967 ) Change subject: libosmocoding.map: export gsm0503_tch_hr_decode2() ...................................................................... libosmocoding.map: export gsm0503_tch_hr_decode2() In commit 57a3b3a51fff I added new function gsm0503_tch_hr_decode2(), but I forgot to add it to libosmocoding.map - and without the latter, osmo-bts-trx and other applications can't use the new function. Fix that omission. Related: OS#5688 Change-Id: I6e75ca95409b5c368e8e04d0e0aba41e0331d9e6 --- M src/coding/libosmocoding.map 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/coding/libosmocoding.map b/src/coding/libosmocoding.map index ff6ea80..a78da27 100644 --- a/src/coding/libosmocoding.map +++ b/src/coding/libosmocoding.map @@ -107,6 +107,7 @@ gsm0503_tch_fr_decode; gsm0503_tch_hr_encode; gsm0503_tch_hr_decode; +gsm0503_tch_hr_decode2; gsm0503_tch_afs_encode; gsm0503_tch_afs_decode; gsm0503_tch_afs_decode_dtx; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6e75ca95409b5c368e8e04d0e0aba41e0331d9e6 Gerrit-Change-Number: 32967 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: libosmocoding.map: export gsm0503_tch_hr_decode2()

by laforge

Attention is currently required from: falconia, fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32967 ) Change subject: libosmocoding.map: export gsm0503_tch_hr_decode2() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6e75ca95409b5c368e8e04d0e0aba41e0331d9e6 Gerrit-Change-Number: 32967 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 23 May 2023 19:15:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add VBS/VGCS related templates

by laforge

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405 ) Change subject: BSSMAP_Templates: Add VBS/VGCS related templates ...................................................................... Patch Set 5: (6 comments) File library/BSSMAP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405/comment/e37a2fd2_40d8… PS5, Line 2437: template (value) BIT2 priority > This value is optional. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405/comment/64374cb7_44b5… PS5, Line 2453: template (present) BIT2 priority > dito Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405/comment/b9269ae1_bb1a… PS5, Line 2519: template BIT2 prio > Must be optional also. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405/comment/3e69906a_1548… PS5, Line 2520: ts_BSSAP_BSSMAP > Must be tr_BSSAP_BSSMAP. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405/comment/a8f4ef0a_0228… PS5, Line 2609: 4E > Should be 4D. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405/comment/18e80bfd_e2fc… PS5, Line 2627: 4E > dito Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I949f731de794b22292b01d0ddf9a75a9e7e7e71d Gerrit-Change-Number: 32405 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 23 May 2023 19:15:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: BSSMAP_Templates: Add VBS/VGCS related templates

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, jolly, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405 to look at the new patch set (#6). Change subject: BSSMAP_Templates: Add VBS/VGCS related templates ...................................................................... BSSMAP_Templates: Add VBS/VGCS related templates As we want to test VBS/VGCS related aspects of BSC and/or MSC soon, we will need related templates to construct and match related messages and IEs. This requires titan.ProtocolModules.BSSMAP updated for modern-day VGCS/VBS related message definitions as I submitted in https://gitlab.eclipse.org/eclipse/titan/titan.ProtocolModules.BSSMAP_v11.2… Change-Id: I949f731de794b22292b01d0ddf9a75a9e7e7e71d --- M library/BSSMAP_Templates.ttcn 1 file changed, 726 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/05/32405/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I949f731de794b22292b01d0ddf9a75a9e7e7e71d Gerrit-Change-Number: 32405 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages

by laforge

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647 ) Change subject: GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages ...................................................................... Patch Set 1: (2 comments) File library/GSM_RR_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647/comment/1050d9b0_e561… PS1, Line 592: cksn > This key must be optional. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647/comment/922891b4_2087… PS1, Line 654: 10.5.2.66 > 10.5.2. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79ca7ee2b94bb370cd7162cfd9db436049998041 Gerrit-Change-Number: 32647 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Tue, 23 May 2023 19:10:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, jolly, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647 to look at the new patch set (#2). Change subject: GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages ...................................................................... GSM_RR_Types: Add support for VBS/VGCS related L3 RR messages This adds support for the VBS/VGCS related L3 RR messages to GsmRrL3Union / GsmRrL3Message. Only those with proper L3 header and classic "tabular" syntax are supported so far, no CSN.1 messages with short L2 header for SACCH. Change-Id: I79ca7ee2b94bb370cd7162cfd9db436049998041 --- M library/GSM_RR_Types.ttcn 1 file changed, 125 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/47/32647/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79ca7ee2b94bb370cd7162cfd9db436049998041 Gerrit-Change-Number: 32647 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023