May 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: deps/Makefile: Update titan.ProtocolModules.BSSMAP to new rebased mas...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32599 ) Change subject: deps/Makefile: Update titan.ProtocolModules.BSSMAP to new rebased master reference ...................................................................... deps/Makefile: Update titan.ProtocolModules.BSSMAP to new rebased master reference The master branch in osmocom's gerrit repository has been rebased on top of current upstream master, hence the commit hash changed. Update it. Related: OS#6011 Change-Id: Ife9dba3fc98d287d71b2334453dd9ce71471ddcb --- M deps/Makefile 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/deps/Makefile b/deps/Makefile index 9bdfb8e..b8b072e 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -89,7 +89,7 @@ titan.ProtocolEmulations.SCCP_commit= 17a894fc6620a0df11d0d98c897fb66168276b16 titan.ProtocolModules.BSSAPP_v7.3.0_commit= R.2.A-4-g20cfaf8 titan.ProtocolModules.BSSGP_v13.0.0_commit= e97d92a8b66bec399babea52f593771b76cb175a -titan.ProtocolModules.BSSMAP_commit= 24f967b2f77bfdd2e6eabf1e82fa76239095f772 +titan.ProtocolModules.BSSMAP_commit= e03923ec75e0c31a44b322cb75f6a192aad114a2 titan.ProtocolModules.DNS_commit= R.7.B titan.ProtocolModules.GRE_commit= R.2.A-5-g654c446 titan.ProtocolModules.GTP_v13.5.0_commit= 54219599037626c675610d3a44433d01af264fbb -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ife9dba3fc98d287d71b2334453dd9ce71471ddcb Gerrit-Change-Number: 32599 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: deps/Makefile: Update titan.ProtocolModules.BSSMAP to new rebased mas...

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32599 ) Change subject: deps/Makefile: Update titan.ProtocolModules.BSSMAP to new rebased master reference ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ife9dba3fc98d287d71b2334453dd9ce71471ddcb Gerrit-Change-Number: 32599 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 May 2023 10:41:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: Store and use SAPI & NSAPI in apn->pdp

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32597 ) Change subject: layer23: Store and use SAPI & NSAPI in apn->pdp ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If82c94ca9c84a94e63a9a5d642a27a7b4e3ff089 Gerrit-Change-Number: 32597 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 May 2023 10:36:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[L] Change in osmocom-bb[master]: layer23: Introduce apn_fsm

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32596 ) Change subject: layer23: Introduce apn_fsm ...................................................................... Patch Set 2: (2 comments) File src/host/layer23/src/common/apn_fsm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/32596/comment/0a01b0bc_e042f00c PS2, Line 103: apn_fsm_state_chg(fi, APN_ST_DISABLED); Don't we need to check *((bool *)data)? I guess the assumption is that it is false here, as I understand the BTS/other layers would send that to disable the APN, and then later on send it again with true to enable it again? Same for st_apn_active(). https://gerrit.osmocom.org/c/osmocom-bb/+/32596/comment/b52edfe0_a75fe921 PS2, Line 139: apn_fsm_state_chg(fi, APN_ST_INACTIVE); * is this correct, receiving CTX_ACC and then going to inactive here? * what about APN_EV_RX_SM_ACT_PDP_CTX_REJ? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2cc732dfb020d31ab89025e7e22276b819dcb24a Gerrit-Change-Number: 32596 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 May 2023 10:34:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: MGCP_Test: move template RtpFlowData up

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32178 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: MGCP_Test: move template RtpFlowData up ...................................................................... MGCP_Test: move template RtpFlowData up The template RtpFlowData is defined in the middle of the code, lets move it up below the related record definition Change-Id: If854f708e4da8b3a7b02d1ace2eb7caa3e2f2bfb --- M mgw/MGCP_Test.ttcn 1 file changed, 35 insertions(+), 23 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index f1936ce..909ad25 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -355,6 +355,29 @@ RtpOsmuxFlowData osmux } + template RtpFlowData t_RtpFlow(charstring host_a, charstring host_b, uint7_t pt, + charstring codec, template charstring fmtp := omit) := { + em := { + hostname := host_a, + portnr := omit + }, + mgw := { + hostname := host_b, + portnr := omit + }, + codec_descr := {{ + pt := pt, + codec := codec, + fmtp := fmtp + }}, + osmux:= { + local_cid_sent := false, + local_cid := omit, + remote_cid := omit, + cfg := omit + } + } + /* To be used with f_flow_create/modify... functions */ function f_gen_sdp(RtpFlowData flow) runs on dummy_CT return SDP_Message { var template SDP_Message sdp; @@ -1795,29 +1818,6 @@ setverdict(pass); } - template RtpFlowData t_RtpFlow(charstring host_a, charstring host_b, uint7_t pt, - charstring codec, template charstring fmtp := omit) := { - em := { - hostname := host_a, - portnr := omit - }, - mgw := { - hostname := host_b, - portnr := omit - }, - codec_descr := {{ - pt := pt, - codec := codec, - fmtp := fmtp - }}, - osmux:= { - local_cid_sent := false, - local_cid := omit, - remote_cid := omit, - cfg := omit - } - } - /* transmit RTP streams between two RTP Emulations back-to-back; expect no loss */ testcase TC_rtpem_selftest() runs on dummy_CT { var RtpemStats stats[2]; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If854f708e4da8b3a7b02d1ace2eb7caa3e2f2bfb Gerrit-Change-Number: 32178 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: deps/Makefile: Update titan.ProtocolModules.BSSMAP to new rebased mas...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32599 ) Change subject: deps/Makefile: Update titan.ProtocolModules.BSSMAP to new rebased master reference ...................................................................... deps/Makefile: Update titan.ProtocolModules.BSSMAP to new rebased master reference The master branch in osmocom's gerrit repository has been rebased on top of current upstream master, hence the commit hash changed. Update it. Related: OS#6011 Change-Id: Ife9dba3fc98d287d71b2334453dd9ce71471ddcb --- M deps/Makefile 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/99/32599/1 diff --git a/deps/Makefile b/deps/Makefile index 9bdfb8e..b8b072e 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -89,7 +89,7 @@ titan.ProtocolEmulations.SCCP_commit= 17a894fc6620a0df11d0d98c897fb66168276b16 titan.ProtocolModules.BSSAPP_v7.3.0_commit= R.2.A-4-g20cfaf8 titan.ProtocolModules.BSSGP_v13.0.0_commit= e97d92a8b66bec399babea52f593771b76cb175a -titan.ProtocolModules.BSSMAP_commit= 24f967b2f77bfdd2e6eabf1e82fa76239095f772 +titan.ProtocolModules.BSSMAP_commit= e03923ec75e0c31a44b322cb75f6a192aad114a2 titan.ProtocolModules.DNS_commit= R.7.B titan.ProtocolModules.GRE_commit= R.2.A-5-g654c446 titan.ProtocolModules.GTP_v13.5.0_commit= 54219599037626c675610d3a44433d01af264fbb -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ife9dba3fc98d287d71b2334453dd9ce71471ddcb Gerrit-Change-Number: 32599 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: MGCP_Test: add fmtp to template t_RtpFlow

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32177 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: MGCP_Test: add fmtp to template t_RtpFlow ...................................................................... MGCP_Test: add fmtp to template t_RtpFlow When creating a flow with fmtp parameters we must always add them in a second step. Lets update t_RtpFlow, so that it supports fmtp as an optional parameter. Change-Id: I04b17c0d233c1db4b9ba1306a4e0555914519bf8 --- M mgw/MGCP_Test.ttcn 1 file changed, 22 insertions(+), 13 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index c9e355b..f1936ce 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -1397,13 +1397,12 @@ }; /* from us to MGW */ - flow[0] := valueof(t_RtpFlow(local_ip_rtp, remote_ip_rtp, 112, "AMR/8000")); + flow[0] := valueof(t_RtpFlow(local_ip_rtp, remote_ip_rtp, 112, "AMR/8000", fmtp)); flow[0].rtp_cfg := c_RtpemDefaultCfg flow[0].rtp_cfg.rx_payloads[0].payload_type := flow[0].codec_descr[0].pt; flow[0].rtp_cfg.rx_payloads[0].fixed_payload := amr_payload; flow[0].rtp_cfg.tx_payloads[0].payload_type := flow[0].codec_descr[0].pt; flow[0].rtp_cfg.tx_payloads[0].fixed_payload := amr_payload; - flow[0].codec_descr[0].fmtp := fmtp; /* bind local RTP emulation sockets */ flow[0].em.portnr := 10000; f_flow_create(RTPEM[0], ep, call_id, "sendrecv", flow[0]); @@ -1796,8 +1795,8 @@ setverdict(pass); } - template (value) RtpFlowData t_RtpFlow(charstring host_a, charstring host_b, uint7_t pt, - charstring codec) := { + template RtpFlowData t_RtpFlow(charstring host_a, charstring host_b, uint7_t pt, + charstring codec, template charstring fmtp := omit) := { em := { hostname := host_a, portnr := omit @@ -1808,7 +1807,8 @@ }, codec_descr := {{ pt := pt, - codec := codec + codec := codec, + fmtp := fmtp }}, osmux:= { local_cid_sent := false, @@ -2283,7 +2283,7 @@ f_vty_transceive(MGWVTY, "rtp-patch rfc5993hr"); /* Connection #0 (Bidirectional) */ - flow[0] := valueof(t_RtpFlow(mp_local_ipv4, mp_remote_ipv4, 111, "GSM-HR-08/8000")); + flow[0] := valueof(t_RtpFlow(mp_local_ipv4, mp_remote_ipv4, 111, "GSM-HR-08/8000", fmtp0)); /* bind local RTP emulation sockets */ flow[0].em.portnr := 10000; flow[0].rtp_cfg := c_RtpemDefaultCfg; @@ -2291,18 +2291,16 @@ flow[0].rtp_cfg.tx_payloads[0].payload_type := flow[0].codec_descr[0].pt; flow[0].rtp_cfg.rx_payloads[0].fixed_payload := pl0; flow[0].rtp_cfg.tx_payloads[0].fixed_payload := pl0; - flow[0].codec_descr[0].fmtp := fmtp0; f_flow_create(RTPEM[0], ep, call_id, "sendrecv", flow[0]); /* Connection #1 (Bidirectional) */ - flow[1] := valueof(t_RtpFlow(mp_local_ipv4, mp_remote_ipv4, 111, "GSM-HR-08/8000")); + flow[1] := valueof(t_RtpFlow(mp_local_ipv4, mp_remote_ipv4, 111, "GSM-HR-08/8000", fmtp1)); flow[1].em.portnr := 20000; flow[1].rtp_cfg := c_RtpemDefaultCfg; flow[1].rtp_cfg.rx_payloads[0].payload_type := flow[1].codec_descr[0].pt; flow[1].rtp_cfg.tx_payloads[0].payload_type := flow[1].codec_descr[0].pt; flow[1].rtp_cfg.rx_payloads[0].fixed_payload := pl1; flow[1].rtp_cfg.tx_payloads[0].fixed_payload := pl1; - flow[1].codec_descr[0].fmtp := fmtp1; f_flow_create(RTPEM[1], ep, call_id, "sendrecv", flow[1]); /* Send RTP packets to connection #0, receive on connection #1 */ @@ -2363,7 +2361,7 @@ f_init(ep); /* Connection #0 (Bidirectional) */ - flow[0] := valueof(t_RtpFlow(mp_local_ipv4, mp_remote_ipv4, 96, "AMR/8000")); + flow[0] := valueof(t_RtpFlow(mp_local_ipv4, mp_remote_ipv4, 96, "AMR/8000", fmtp0)); /* bind local RTP emulation sockets */ flow[0].em.portnr := 10000; flow[0].rtp_cfg := c_RtpemDefaultCfg; @@ -2371,18 +2369,16 @@ flow[0].rtp_cfg.tx_payloads[0].payload_type := flow[0].codec_descr[0].pt; flow[0].rtp_cfg.rx_payloads[0].fixed_payload := pl0; flow[0].rtp_cfg.tx_payloads[0].fixed_payload := pl0; - flow[0].codec_descr[0].fmtp := fmtp0; f_flow_create(RTPEM[0], ep, call_id, "sendrecv", flow[0]); /* Connection #1 (Bidirectional) */ - flow[1] := valueof(t_RtpFlow(mp_local_ipv4, mp_remote_ipv4, 112, "AMR/8000")); + flow[1] := valueof(t_RtpFlow(mp_local_ipv4, mp_remote_ipv4, 112, "AMR/8000", fmtp1)); flow[1].em.portnr := 20000; flow[1].rtp_cfg := c_RtpemDefaultCfg; flow[1].rtp_cfg.rx_payloads[0].payload_type := flow[1].codec_descr[0].pt; flow[1].rtp_cfg.tx_payloads[0].payload_type := flow[1].codec_descr[0].pt; flow[1].rtp_cfg.rx_payloads[0].fixed_payload := pl1; flow[1].rtp_cfg.tx_payloads[0].fixed_payload := pl1; - flow[1].codec_descr[0].fmtp := fmtp1; f_flow_create(RTPEM[1], ep, call_id, "sendrecv", flow[1]); /* Send RTP packets to connection #0, receive on connection #1 */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32177 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I04b17c0d233c1db4b9ba1306a4e0555914519bf8 Gerrit-Change-Number: 32177 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: grr: Log ignored CCCH ImmAss

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32589 ) Change subject: layer23: modem: grr: Log ignored CCCH ImmAss ...................................................................... layer23: modem: grr: Log ignored CCCH ImmAss There seems to be some bug when using virtphy where sometimes the received T2 and/or T3 in the ImmASs is not matching what we sent. This helps in showing the problem and not failing silently. Change-Id: Iaecd2616733d84f35a825916fe888142800b426b --- M src/host/layer23/src/modem/grr.c 1 file changed, 25 insertions(+), 5 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/host/layer23/src/modem/grr.c b/src/host/layer23/src/modem/grr.c index b6abae5..e225460 100644 --- a/src/host/layer23/src/modem/grr.c +++ b/src/host/layer23/src/modem/grr.c @@ -238,17 +238,24 @@ struct osmo_gprs_rlcmac_prim *rlcmac_prim; /* Discard CS channel assignment */ - if ((ia->page_mode >> 4) == 0) + if ((ia->page_mode >> 4) == 0) { + LOGP(DRR, LOGL_INFO, "%s(): Discard CS channel assignment\n", __func__); return 0; + } - if (rr->state != GSM48_RR_ST_CONN_PEND) + if (rr->state != GSM48_RR_ST_CONN_PEND) { + LOGP(DRR, LOGL_INFO, "%s(): rr_state != GSM48_RR_ST_CONN_PEND\n", __func__); return 0; - if (!grr_match_req_ref(ms, &ia->req_ref)) + } + if (!grr_match_req_ref(ms, &ia->req_ref)) { + LOGP(DRR, LOGL_INFO, "%s(): req_ref mismatch (RA=0x%02x, T1=%u, T3=%u, T2=%u)\n", + __func__, ia->req_ref.ra, ia->req_ref.t1, + ia->req_ref.t3_high << 3 | ia->req_ref.t3_low, ia->req_ref.t2); return 0; + } if (rsl_dec_chan_nr(ia->chan_desc.chan_nr, &ch_type, &ch_subch, &ch_ts) != 0) { - LOGP(DRR, LOGL_ERROR, - "%s(): rsl_dec_chan_nr(chan_nr=0x%02x) failed\n", + LOGP(DRR, LOGL_ERROR, "%s(): rsl_dec_chan_nr(chan_nr=0x%02x) failed\n", __func__, ia->chan_desc.chan_nr); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaecd2616733d84f35a825916fe888142800b426b Gerrit-Change-Number: 32589 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: gmm: Activate PDP Context of APN after GPRS attach

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32590 ) ( 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: layer23: modem: gmm: Activate PDP Context of APN after GPRS attach ...................................................................... layer23: modem: gmm: Activate PDP Context of APN after GPRS attach Change-Id: Icb667a6a3359267d2eb20e11a40eb27a8c3f7e2d --- M src/host/layer23/src/modem/gmm.c 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/host/layer23/src/modem/gmm.c b/src/host/layer23/src/modem/gmm.c index 62c6d5e..f3a936a 100644 --- a/src/host/layer23/src/modem/gmm.c +++ b/src/host/layer23/src/modem/gmm.c @@ -44,12 +44,14 @@ #include <osmocom/bb/common/apn.h> #include <osmocom/bb/common/ms.h> #include <osmocom/bb/modem/gmm.h> +#include <osmocom/bb/modem/sm.h> #include <osmocom/bb/modem/modem.h> static int modem_gmm_prim_up_cb(struct osmo_gprs_gmm_prim *gmm_prim, void *user_data) { const char *pdu_name = osmo_gprs_gmm_prim_name(gmm_prim); struct osmocom_ms *ms = user_data; + struct osmobb_apn *apn; int rc = 0; switch (gmm_prim->oph.sap) { @@ -61,6 +63,11 @@ __func__, pdu_name, gmm_prim->gmmreg.attach_cnf.acc.allocated_ptmsi); ms->subscr.ptmsi = gmm_prim->gmmreg.attach_cnf.acc.allocated_ptmsi; app_data.modem_state = MODEM_ST_ATTACHED; + /* Activate APN if not yet already: */ + apn = llist_first_entry_or_null(&ms->gprs.apn_list, struct osmobb_apn, list); + if (!apn || apn->cfg.shutdown) + break; + modem_sm_smreg_pdp_act_req(ms, apn); } else { uint8_t cause = gmm_prim->gmmreg.attach_cnf.rej.cause; LOGP(DGMM, LOGL_ERROR, "%s(): Rx %s: Attach rejected, cause=%u (%s)\n", -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icb667a6a3359267d2eb20e11a40eb27a8c3f7e2d Gerrit-Change-Number: 32590 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: grr: Log ignored CCCH ImmAss

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32589 ) Change subject: layer23: modem: grr: Log ignored CCCH ImmAss ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaecd2616733d84f35a825916fe888142800b426b Gerrit-Change-Number: 32589 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 04 May 2023 10:06:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023