Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32606 )
Change subject: PCUIF_Types: add record PCUIF_pch_dt
......................................................................
Patch Set 1:
(1 comment)
File library/PCUIF_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32606/comment/8aec80d3_1ead…
PS1, Line 320: octetstring data length(162)
so we need data to be of fixed size?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32606
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia705d3a6fe7adb863acd29e968f8dc6b2066a497
Gerrit-Change-Number: 32606
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 May 2023 14:07:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32605 )
Change subject: PCUIF_Types: add message type PCU_IF_MSG_E1_CCU_IND
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32605/comment/602371f0_1f86…
PS1, Line 9: Even though we do not need it right now, let's add the message type
message type message type
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32605/comment/67a530bb_58df…
PS1, Line 10: message type PCU_IF_MSG_E1_CCU_IND. This messagetype has been added
messagetype
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32605
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib6482d88e924f285658b933f32be42a4f63bee71
Gerrit-Change-Number: 32605
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 May 2023 14:06:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32600 )
Change subject: Makefile: workaround Eclipse Gitlab rate limiting
......................................................................
Makefile: workaround Eclipse Gitlab rate limiting
Got this while pulling in the entire set of deps:
"""
remote: You have reached the limit of requests you can make to Eclipse GitLab.
This could be caused by too many open tabs, which query the GitLab server in
the background. Please close unused tabs, or put them to sleep so they don't
issue requests needlessly.
"""
Change-Id: I5866154a6af88875a446e092f0926cdc4a1a9fc4
---
M Makefile
1 file changed, 20 insertions(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
osmith: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
diff --git a/Makefile b/Makefile
index 4b6a5e2..c399714 100644
--- a/Makefile
+++ b/Makefile
@@ -65,9 +65,11 @@
default: deps all
+# Eclipse GitLab has rate limiting and sometimes to many concurrent conns fail.
+# If -jN fails, retry with -j1.
.PHONY: deps
deps:
- $(MAKE) $(PARALLEL_MAKE) -C deps
+ ($(MAKE) $(PARALLEL_MAKE) -C deps || $(MAKE) -j1 -C deps)
# deps-update target for backwards compat; now does the same as 'make deps'
.PHONY: deps-update
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32600
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5866154a6af88875a446e092f0926cdc4a1a9fc4
Gerrit-Change-Number: 32600
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32606 )
Change subject: PCUIF_Types: add record PCUIF_pch_dt
......................................................................
PCUIF_Types: add record PCUIF_pch_dt
The record PCUIF_pch_dt, coresponds to struct gsm_pcu_if_pch_dt in
pcuif_proto.h. It will be needed when we introduce support for the TLLI
based confirmation of IMMEDIATE ASSIGNMENT messages that are sent via
the PCH.
Related: OS#5927
Change-Id: Ia705d3a6fe7adb863acd29e968f8dc6b2066a497
---
M library/PCUIF_Types.ttcn
1 file changed, 26 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/32606/1
diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn
index a6af2a0..db61991 100644
--- a/library/PCUIF_Types.ttcn
+++ b/library/PCUIF_Types.ttcn
@@ -312,6 +312,17 @@
other, OTHERWISE)"
};
+/* Record to send a (confirmed) IMMEDIATE ASSIGNMENT message via PCH. The record is sent by the PCU to the BTS as a
+ * data request (data_req) under SAPI PCU_IF_SAPI_PCH_DT. */
+type record PCUIF_pch_dt {
+ OCT4 tlli,
+ octetstring imsi length(17),
+ octetstring data length(162)
+} with {
+ variant (tlli) "BYTEORDER(last)"
+ variant (imsi) "FIELDLENGTH(17), ALIGN(left)"
+ variant (data) "FIELDLENGTH(162), ALIGN(left)"
+};
type union PCUIF_MsgUnion {
PCUIF_data data_req,
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32606
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia705d3a6fe7adb863acd29e968f8dc6b2066a497
Gerrit-Change-Number: 32606
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newchange
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32604 )
Change subject: PCUIF_Types: rename PCU_IF_SAPI_AGCH_DT to PCU_IF_SAPI_PCH_DT
......................................................................
PCUIF_Types: rename PCU_IF_SAPI_AGCH_DT to PCU_IF_SAPI_PCH_DT
The SAPI PCU_IF_SAPI_AGCH_DT has been renamed to PCU_IF_SAP_PCH_DT in
the recent pcuif_proto.h version since the IMMEDIATE ASSIGNMENT what it
is used for is sent on the PCH not on the AGCH.
The SAPI constant is currently not used in the TTCN3 testsuite, but it
will soon be used when we introduce support for the recent PCUIF which
will then use the direct TLLI (DT) method.
Related: OS#5927
Change-Id: Ifc09067bcb0f9f422ca429313fa09fea081dc316
---
M library/PCUIF_Types.ttcn
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/32604/1
diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn
index dcae4e6..76306a3 100644
--- a/library/PCUIF_Types.ttcn
+++ b/library/PCUIF_Types.ttcn
@@ -53,7 +53,7 @@
PCU_IF_SAPI_PDTCH ('05'O),
PCU_IF_SAPI_PRACH ('06'O),
PCU_IF_SAPI_PTCCH ('07'O),
- PCU_IF_SAPI_AGCH_DT ('08'O)
+ PCU_IF_SAPI_PCH_DT ('08'O)
} with { variant "FIELDLENGTH(8)" };
type record PCUIF_Flags {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32604
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifc09067bcb0f9f422ca429313fa09fea081dc316
Gerrit-Change-Number: 32604
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newchange