May 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: f_rtpem_activate(): pad TCH/FS frames with 'FF'O

by falconia

Attention is currently required from: fixeria. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32793 ) Change subject: BTS_Tests: f_rtpem_activate(): pad TCH/FS frames with 'FF'O ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32793 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib42b783574caf5cbaf64b2eb5dd1d2b2a6637c2f Gerrit-Change-Number: 32793 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 May 2023 15:26:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in osmo-bts[master]: trx: remove model-specific BFI packet formats

by falconia

falconia has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32788 ) Change subject: trx: remove model-specific BFI packet formats ...................................................................... trx: remove model-specific BFI packet formats As detailed in OS#6033, osmo-bts-trx was emitting its own invented packet formats to signal BFIs (bad frame indications), different from the vty-configured ("rtp continuous-streaming" or not) BFI signaling method implemented in l1sap and used by all other BTS models. In the case of EFR codec, the made-up BFI format previously used by osmo-bts-trx caused EFR operation to be broken: a spec-compliant EFR decoder on the receiving end of the RTP stream (a network transcoder or the MS on the other GSM call leg) would receive and decode garbage EFR frames of 244 zero bits instead of invoking the spec-defined bad frame handler, causing bad audio artifacts for the user. The same situation would also happen for FR1 codec, but the application of ECU masked this bug: with the ECU invoked in the UL output path, the BFI emitting code for FR1 never executed. In the case of AMR and HR1 codecs, the model-specific BFI packet format of osmo-bts-trx is currently harmless, but: * The extra code adds unnecessary complexity; * BFI packet formats are inconsistent between osmo-bts-trx and other OsmoBTS models; * BFI format is even inconsistent within osmo-bts-trx itself, as under certain conditions the common code in l1sap will override the UL payload from the BTS model and emit its own form of BFI instead. Fix all of the above by removing trx model-specific BFI formats for all codecs, and let l1sap handle all BFIs. Related: OS#6033 Change-Id: I8f9fb5b8c5b2cad4b92ac693c0040779f811981a --- M src/osmo-bts-trx/sched_lchan_tchf.c M src/osmo-bts-trx/sched_lchan_tchh.c 2 files changed, 51 insertions(+), 53 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index 6d6fb0b..43a3784 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -295,35 +295,11 @@ goto compose_l1sap; } - switch (tch_mode) { - case GSM48_CMODE_SPEECH_V1: /* FR */ - memset(tch_data, 0, GSM_FR_BYTES); - tch_data[0] = 0xd0; - rc = GSM_FR_BYTES; - break; - case GSM48_CMODE_SPEECH_EFR: /* EFR */ - memset(tch_data, 0, GSM_EFR_BYTES); - tch_data[0] = 0xc0; - rc = GSM_EFR_BYTES; - break; - case GSM48_CMODE_SPEECH_AMR: /* AMR */ - rc = osmo_amr_rtp_enc(tch_data, - chan_state->codec[chan_state->ul_cmr], - chan_state->codec[chan_state->ul_ft], - AMR_BAD); - if (rc < 2) { - LOGL1SB(DL1P, LOGL_ERROR, l1ts, bi, - "Failed to encode AMR_BAD frame (rc=%d), " - "not sending BFI\n", rc); - return -EINVAL; - } - memset(tch_data + sizeof(struct amr_hdr), 0, rc - sizeof(struct amr_hdr)); - break; - default: - LOGL1SB(DL1P, LOGL_ERROR, l1ts, bi, - "TCH mode %u invalid, please fix!\n", tch_mode); - return -EINVAL; - } + /* In order to signal BFI in our UL RTP output, we need + * to push an empty payload to l1sap. The upper layer + * will choose the correct RTP representation of this + * BFI based on model-independent vty config. */ + rc = 0; } } diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c b/src/osmo-bts-trx/sched_lchan_tchh.c index 41965c4..5872c33 100644 --- a/src/osmo-bts-trx/sched_lchan_tchh.c +++ b/src/osmo-bts-trx/sched_lchan_tchh.c @@ -333,30 +333,11 @@ goto compose_l1sap; } - switch (tch_mode) { - case GSM48_CMODE_SPEECH_V1: /* HR */ - tch_data[0] = 0x70; /* F = 0, FT = 111 */ - memset(tch_data + 1, 0, 14); - rc = 15; - break; - case GSM48_CMODE_SPEECH_AMR: /* AMR */ - rc = osmo_amr_rtp_enc(tch_data, - chan_state->codec[chan_state->ul_cmr], - chan_state->codec[chan_state->ul_ft], - AMR_BAD); - if (rc < 2) { - LOGL1SB(DL1P, LOGL_ERROR, l1ts, bi, - "Failed to encode AMR_BAD frame (rc=%d), " - "not sending BFI\n", rc); - return -EINVAL; - } - memset(tch_data + sizeof(struct amr_hdr), 0, rc - sizeof(struct amr_hdr)); - break; - default: - LOGL1SB(DL1P, LOGL_ERROR, l1ts, bi, - "TCH mode %u invalid, please fix!\n", tch_mode); - return -EINVAL; - } + /* In order to signal BFI in our UL RTP output, we need + * to push an empty payload to l1sap. The upper layer + * will choose the correct RTP representation of this + * BFI based on model-independent vty config. */ + rc = 0; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8f9fb5b8c5b2cad4b92ac693c0040779f811981a Gerrit-Change-Number: 32788 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: Define sim_pin_required field as bool

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32799 ) Change subject: layer23: Define sim_pin_required field as bool ...................................................................... layer23: Define sim_pin_required field as bool Change-Id: I7c5105da08176f4743f1f3e56ddad9ac170717c7 --- M src/host/layer23/include/osmocom/bb/common/subscriber.h M src/host/layer23/src/common/subscriber.c 2 files changed, 14 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/99/32799/1 diff --git a/src/host/layer23/include/osmocom/bb/common/subscriber.h b/src/host/layer23/include/osmocom/bb/common/subscriber.h index e9779e6..792df62 100644 --- a/src/host/layer23/include/osmocom/bb/common/subscriber.h +++ b/src/host/layer23/include/osmocom/bb/common/subscriber.h @@ -89,7 +89,7 @@ /* talk to SIM */ uint8_t sim_state; - uint8_t sim_pin_required; /* state: wait for PIN */ + bool sim_pin_required; /* state: wait for PIN */ uint8_t sim_file_index; uint32_t sim_handle_query; uint32_t sim_handle_update; diff --git a/src/host/layer23/src/common/subscriber.c b/src/host/layer23/src/common/subscriber.c index 9d392d1..bc5031b 100644 --- a/src/host/layer23/src/common/subscriber.c +++ b/src/host/layer23/src/common/subscriber.c @@ -970,7 +970,7 @@ l23_vty_ms_notify(ms, NULL); l23_vty_ms_notify(ms, "Please give PIN for ICCID %s (you have " "%d tries left)\n", subscr->iccid, payload[1]); - subscr->sim_pin_required = 1; + subscr->sim_pin_required = true; break; case SIM_CAUSE_PIN1_BLOCKED: LOGP(DMM, LOGL_NOTICE, "PIN is blocked\n"); @@ -982,14 +982,14 @@ "(you have %d tries left)\n", subscr->iccid, payload[1]); } - subscr->sim_pin_required = 1; + subscr->sim_pin_required = true; break; case SIM_CAUSE_PUC_BLOCKED: LOGP(DMM, LOGL_NOTICE, "PUC is blocked\n"); l23_vty_ms_notify(ms, NULL); l23_vty_ms_notify(ms, "PUC is blocked\n"); - subscr->sim_pin_required = 1; + subscr->sim_pin_required = true; break; default: if (sf->func && !sf->mandatory) { @@ -1013,7 +1013,7 @@ /* if pin was successfully unlocked, then resend request */ if (subscr->sim_pin_required) { - subscr->sim_pin_required = 0; + subscr->sim_pin_required = false; subscr_sim_request(ms); return; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32799 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7c5105da08176f4743f1f3e56ddad9ac170717c7 Gerrit-Change-Number: 32799 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: Define barr field as bool

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmocom-bb/+/32798 ) Change subject: layer23: Define barr field as bool ...................................................................... layer23: Define barr field as bool Change-Id: I02b95fa5437be1325cfa80fc40350280540fe802 --- M src/host/layer23/include/osmocom/bb/common/settings.h M src/host/layer23/include/osmocom/bb/common/subscriber.h M src/host/layer23/src/common/vty.c 3 files changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/98/32798/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32798 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I02b95fa5437be1325cfa80fc40350280540fe802 Gerrit-Change-Number: 32798 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: Define (r)plmn_valid field as bool

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32797 ) Change subject: layer23: Define (r)plmn_valid field as bool ...................................................................... layer23: Define (r)plmn_valid field as bool Change-Id: Ia2316bae5e4f5035f31b4da3937e025537aaf224 --- M src/host/layer23/include/osmocom/bb/common/settings.h M src/host/layer23/include/osmocom/bb/common/subscriber.h M src/host/layer23/src/common/subscriber.c M src/host/layer23/src/common/vty.c M src/host/layer23/src/mobile/gsm322.c 5 files changed, 17 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/97/32797/1 diff --git a/src/host/layer23/include/osmocom/bb/common/settings.h b/src/host/layer23/include/osmocom/bb/common/settings.h index bae9848..add8dc3 100644 --- a/src/host/layer23/include/osmocom/bb/common/settings.h +++ b/src/host/layer23/include/osmocom/bb/common/settings.h @@ -64,7 +64,7 @@ uint8_t ki_type; uint8_t ki[16]; /* 128 bit max */ uint8_t barr; - uint8_t rplmn_valid; + bool rplmn_valid; struct osmo_plmn_id rplmn; uint16_t lac; bool imsi_attached; diff --git a/src/host/layer23/include/osmocom/bb/common/subscriber.h b/src/host/layer23/include/osmocom/bb/common/subscriber.h index b829b2e..cbcfd0e 100644 --- a/src/host/layer23/include/osmocom/bb/common/subscriber.h +++ b/src/host/layer23/include/osmocom/bb/common/subscriber.h @@ -80,7 +80,7 @@ char sim_spn[17]; /* name of service privider */ /* PLMN last registered */ - uint8_t plmn_valid; + bool plmn_valid; struct osmo_plmn_id plmn; /* our access */ diff --git a/src/host/layer23/src/common/subscriber.c b/src/host/layer23/src/common/subscriber.c index e10f40a..9d392d1 100644 --- a/src/host/layer23/src/common/subscriber.c +++ b/src/host/layer23/src/common/subscriber.c @@ -913,7 +913,7 @@ /* if LAI is valid, set RPLMN */ if (subscr->lai.lac > 0x0000 && subscr->lai.lac < 0xfffe) { - subscr->plmn_valid = 1; + subscr->plmn_valid = true; memcpy(&subscr->plmn, &subscr->lai.plmn, sizeof(struct osmo_plmn_id)); LOGP(DMM, LOGL_INFO, "-> SIM card registered to %s (%s, %s)\n", osmo_plmn_name(&subscr->plmn), diff --git a/src/host/layer23/src/common/vty.c b/src/host/layer23/src/common/vty.c index c76f498..67105a0 100644 --- a/src/host/layer23/src/common/vty.c +++ b/src/host/layer23/src/common/vty.c @@ -513,9 +513,9 @@ return CMD_WARNING; } memcpy(&set->test_sim.rplmn, &plmn, sizeof(plmn)); - set->test_sim.rplmn_valid = 1; + set->test_sim.rplmn_valid = true; } else { - set->test_sim.rplmn_valid = 0; + set->test_sim.rplmn_valid = false; } if (argc >= 4) @@ -1041,7 +1041,7 @@ struct osmocom_ms *ms = vty->index; struct gsm_settings *set = &ms->settings; - set->test_sim.rplmn_valid = 0; + set->test_sim.rplmn_valid = false; set->test_sim.rplmn.mcc = 1; set->test_sim.rplmn.mnc = 1; set->test_sim.rplmn.mnc_3_digits = false; @@ -1067,7 +1067,7 @@ vty_out(vty, "Given MNC invalid%s", VTY_NEWLINE); return CMD_WARNING; } - set->test_sim.rplmn_valid = 1; + set->test_sim.rplmn_valid = true; memcpy(&set->test_sim.rplmn, &plmn, sizeof(plmn)); if (argc >= 3) diff --git a/src/host/layer23/src/mobile/gsm322.c b/src/host/layer23/src/mobile/gsm322.c index 60996b2..6ad3cd0 100644 --- a/src/host/layer23/src/mobile/gsm322.c +++ b/src/host/layer23/src/mobile/gsm322.c @@ -1685,7 +1685,7 @@ struct gsm_subscriber *subscr = &ms->subscr; /* set last registered PLMN */ - subscr->plmn_valid = 1; + subscr->plmn_valid = true; memcpy(&subscr->plmn, &plmn->plmn, sizeof(struct osmo_plmn_id)); new_m_state(plmn, GSM322_M2_ON_PLMN); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32797 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia2316bae5e4f5035f31b4da3937e025537aaf224 Gerrit-Change-Number: 32797 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: Define imsi_attached field as bool

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32795 ) Change subject: layer23: Define imsi_attached field as bool ...................................................................... layer23: Define imsi_attached field as bool Change-Id: I47e234dcef4c5af09023318dda45d40c8c92b312 --- M src/host/layer23/include/osmocom/bb/common/settings.h M src/host/layer23/include/osmocom/bb/common/subscriber.h M src/host/layer23/src/common/vty.c M src/host/layer23/src/mobile/gsm48_mm.c 4 files changed, 17 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/95/32795/1 diff --git a/src/host/layer23/include/osmocom/bb/common/settings.h b/src/host/layer23/include/osmocom/bb/common/settings.h index f66874c..f480aad 100644 --- a/src/host/layer23/include/osmocom/bb/common/settings.h +++ b/src/host/layer23/include/osmocom/bb/common/settings.h @@ -67,7 +67,7 @@ uint8_t rplmn_valid; struct osmo_plmn_id rplmn; uint16_t lac; - uint8_t imsi_attached; + bool imsi_attached; uint8_t always; /* ...search hplmn... */ }; diff --git a/src/host/layer23/include/osmocom/bb/common/subscriber.h b/src/host/layer23/include/osmocom/bb/common/subscriber.h index e2a8dab..f44401d 100644 --- a/src/host/layer23/include/osmocom/bb/common/subscriber.h +++ b/src/host/layer23/include/osmocom/bb/common/subscriber.h @@ -49,7 +49,7 @@ enum gsm_subscriber_sim_type sim_type; /* type of sim */ bool sim_valid; /* sim inserted and valid */ enum gsm_sub_sim_ustate ustate; /* update status */ - uint8_t imsi_attached; /* attached state */ + bool imsi_attached; /* attached state */ /* IMSI & co */ char imsi[OSMO_IMSI_BUF_SIZE]; diff --git a/src/host/layer23/src/common/vty.c b/src/host/layer23/src/common/vty.c index c315689..ef2de24 100644 --- a/src/host/layer23/src/common/vty.c +++ b/src/host/layer23/src/common/vty.c @@ -1053,8 +1053,7 @@ return CMD_SUCCESS; } -static int _testsim_rplmn_cmd(struct vty *vty, int argc, const char *argv[], - int attached) +static int _testsim_rplmn_cmd(struct vty *vty, int argc, const char *argv[], bool attached) { struct osmocom_ms *ms = vty->index; struct gsm_settings *set = &ms->settings; @@ -1081,10 +1080,7 @@ else set->test_sim.tmsi = GSM_RESERVED_TMSI; - if (attached) - set->test_sim.imsi_attached = 1; - else - set->test_sim.imsi_attached = 0; + set->test_sim.imsi_attached = attached; l23_vty_restart_required_warn(vty, ms); @@ -1097,7 +1093,7 @@ "Optionally set location area code\n" "Optionally set current assigned TMSI") { - return _testsim_rplmn_cmd(vty, argc, argv, 0); + return _testsim_rplmn_cmd(vty, argc, argv, false); } DEFUN(cfg_testsim_rplmn_att, cfg_testsim_rplmn_att_cmd, @@ -1106,7 +1102,7 @@ "Set location area code\nSet current assigned TMSI\n" "Indicate to MM that card is already attached") { - return _testsim_rplmn_cmd(vty, argc, argv, 1); + return _testsim_rplmn_cmd(vty, argc, argv, true); } DEFUN(cfg_testsim_hplmn, cfg_testsim_hplmn_cmd, "hplmn-search (everywhere|foreign-country)", diff --git a/src/host/layer23/src/mobile/gsm48_mm.c b/src/host/layer23/src/mobile/gsm48_mm.c index 95808ee..2bba0e1 100644 --- a/src/host/layer23/src/mobile/gsm48_mm.c +++ b/src/host/layer23/src/mobile/gsm48_mm.c @@ -2234,7 +2234,7 @@ && (subscr->imsi_attached || !s->att_allowed)) { LOGP(DMM, LOGL_INFO, "Loc. upd. not required.\n"); - subscr->imsi_attached = 1; + subscr->imsi_attached = true; /* go straight to normal service state */ new_mm_state(mm, GSM48_MM_ST_MM_IDLE, @@ -2413,7 +2413,7 @@ mm->lupd_attempt = 0; /* mark SIM as attached */ - subscr->imsi_attached = 1; + subscr->imsi_attached = true; /* set the status in the sim to updated */ new_sim_ustate(subscr, GSM_SIM_U1_UPDATED); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32795 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I47e234dcef4c5af09023318dda45d40c8c92b312 Gerrit-Change-Number: 32795 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: Define barr field as bool

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32798 ) Change subject: layer23: Define barr field as bool ...................................................................... layer23: Define barr field as bool Change-Id: I02b95fa5437be1325cfa80fc40350280540fe802 --- M src/host/layer23/include/osmocom/bb/common/settings.h M src/host/layer23/src/common/vty.c 2 files changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/98/32798/1 diff --git a/src/host/layer23/include/osmocom/bb/common/settings.h b/src/host/layer23/include/osmocom/bb/common/settings.h index add8dc3..f24b006 100644 --- a/src/host/layer23/include/osmocom/bb/common/settings.h +++ b/src/host/layer23/include/osmocom/bb/common/settings.h @@ -63,7 +63,7 @@ uint32_t tmsi; uint8_t ki_type; uint8_t ki[16]; /* 128 bit max */ - uint8_t barr; + bool barr; bool rplmn_valid; struct osmo_plmn_id rplmn; uint16_t lac; diff --git a/src/host/layer23/src/common/vty.c b/src/host/layer23/src/common/vty.c index 67105a0..44fc053 100644 --- a/src/host/layer23/src/common/vty.c +++ b/src/host/layer23/src/common/vty.c @@ -1019,7 +1019,7 @@ struct osmocom_ms *ms = vty->index; struct gsm_settings *set = &ms->settings; - set->test_sim.barr = 1; + set->test_sim.barr = true; return CMD_SUCCESS; } @@ -1030,7 +1030,7 @@ struct osmocom_ms *ms = vty->index; struct gsm_settings *set = &ms->settings; - set->test_sim.barr = 0; + set->test_sim.barr = false; return CMD_SUCCESS; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32798 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I02b95fa5437be1325cfa80fc40350280540fe802 Gerrit-Change-Number: 32798 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: Define always_search_hplmn field as bool

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32796 ) Change subject: layer23: Define always_search_hplmn field as bool ...................................................................... layer23: Define always_search_hplmn field as bool Change-Id: I0efc16a2362fbfec64cf6ca85bb32db8beb241a3 --- M src/host/layer23/include/osmocom/bb/common/settings.h M src/host/layer23/include/osmocom/bb/common/subscriber.h M src/host/layer23/src/common/subscriber.c M src/host/layer23/src/common/vty.c 4 files changed, 16 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/96/32796/1 diff --git a/src/host/layer23/include/osmocom/bb/common/settings.h b/src/host/layer23/include/osmocom/bb/common/settings.h index f480aad..bae9848 100644 --- a/src/host/layer23/include/osmocom/bb/common/settings.h +++ b/src/host/layer23/include/osmocom/bb/common/settings.h @@ -68,7 +68,7 @@ struct osmo_plmn_id rplmn; uint16_t lac; bool imsi_attached; - uint8_t always; /* ...search hplmn... */ + bool always_search_hplmn; }; struct gsm_settings { diff --git a/src/host/layer23/include/osmocom/bb/common/subscriber.h b/src/host/layer23/include/osmocom/bb/common/subscriber.h index f44401d..b829b2e 100644 --- a/src/host/layer23/include/osmocom/bb/common/subscriber.h +++ b/src/host/layer23/include/osmocom/bb/common/subscriber.h @@ -72,7 +72,7 @@ uint8_t t6m_hplmn; /* timer for hplmn search */ /* special things */ - uint8_t always_search_hplmn; + bool always_search_hplmn; /* search hplmn in other countries also (for test cards) */ uint8_t any_timeout; /* timer to restart 'any cell selection' */ diff --git a/src/host/layer23/src/common/subscriber.c b/src/host/layer23/src/common/subscriber.c index 4b0ac2c..e10f40a 100644 --- a/src/host/layer23/src/common/subscriber.c +++ b/src/host/layer23/src/common/subscriber.c @@ -526,7 +526,7 @@ subscr->lai.lac = set->test_sim.lac; subscr->tmsi = set->test_sim.tmsi; subscr->ptmsi = GSM_RESERVED_TMSI; - subscr->always_search_hplmn = set->test_sim.always; + subscr->always_search_hplmn = set->test_sim.always_search_hplmn; subscr->t6m_hplmn = 1; /* try to find home network every 6 min */ OSMO_STRLCPY_ARRAY(subscr->imsi, set->test_sim.imsi); diff --git a/src/host/layer23/src/common/vty.c b/src/host/layer23/src/common/vty.c index ef2de24..c76f498 100644 --- a/src/host/layer23/src/common/vty.c +++ b/src/host/layer23/src/common/vty.c @@ -1115,10 +1115,10 @@ switch (argv[0][0]) { case 'e': - set->test_sim.always = 1; + set->test_sim.always_search_hplmn = true; break; case 'f': - set->test_sim.always = 0; + set->test_sim.always_search_hplmn = false; break; } @@ -1213,9 +1213,9 @@ } else if (!l23_vty_hide_default) vty_out(vty, "%s no rplmn%s", prefix, VTY_NEWLINE); - if (!l23_vty_hide_default || set->test_sim.always) + if (!l23_vty_hide_default || set->test_sim.always_search_hplmn) vty_out(vty, "%s hplmn-search %s%s", prefix, - (set->test_sim.always) ? "everywhere" : "foreign-country", + set->test_sim.always_search_hplmn ? "everywhere" : "foreign-country", VTY_NEWLINE); return CMD_SUCCESS; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32796 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0efc16a2362fbfec64cf6ca85bb32db8beb241a3 Gerrit-Change-Number: 32796 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[M] Change in osmocom-bb[master]: layer23: vty: Rename testism node functions

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/32794 to look at the new patch set (#2). Change subject: layer23: vty: Rename testism node functions ...................................................................... layer23: vty: Rename testism node functions Change-Id: If84297f026e6804436a0bf16c5c992161cd71ee4 --- M src/host/layer23/src/common/vty.c 1 file changed, 37 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/94/32794/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32794 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If84297f026e6804436a0bf16c5c992161cd71ee4 Gerrit-Change-Number: 32794 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: BTS_Tests: f_rtpem_activate(): pad TCH/FS frames with 'FF'O

by pespin

Attention is currently required from: falconia, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32793 ) Change subject: BTS_Tests: f_rtpem_activate(): pad TCH/FS frames with 'FF'O ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32793 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib42b783574caf5cbaf64b2eb5dd1d2b2a6637c2f Gerrit-Change-Number: 32793 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 May 2023 13:54:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023