May 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-sgsn[master]: copyright: fix typo: sysmocom s/s.m.f.c./s.f.m.c./ GmbH

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/32778 ) Change subject: copyright: fix typo: sysmocom s/s.m.f.c./s.f.m.c./ GmbH ...................................................................... copyright: fix typo: sysmocom s/s.m.f.c./s.f.m.c./ GmbH Change-Id: Ie2d864d5171e0da2e8a6c8551d151fd14f89bf05 --- M src/sgsn/gprs_gmm_fsm.c M src/sgsn/gprs_mm_state_gb_fsm.c M src/sgsn/gprs_mm_state_iu_fsm.c M src/sgsn/gtp_ggsn.c M src/sgsn/gtp_mme.c 5 files changed, 14 insertions(+), 5 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/sgsn/gprs_gmm_fsm.c b/src/sgsn/gprs_gmm_fsm.c index e9c31d0..57e1ec3 100644 --- a/src/sgsn/gprs_gmm_fsm.c +++ b/src/sgsn/gprs_gmm_fsm.c @@ -1,6 +1,6 @@ /* GMM mobility management states on the network side, 3GPP TS 24.008 § 4.1.3.3 */ /* - * (C) 2019 by sysmocom - s.m.f.c. GmbH <info(a)sysmocom.de> + * (C) 2019 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> * All Rights Reserved * * SPDX-License-Identifier: AGPL-3.0+ diff --git a/src/sgsn/gprs_mm_state_gb_fsm.c b/src/sgsn/gprs_mm_state_gb_fsm.c index 5a007e9..dde7b77 100644 --- a/src/sgsn/gprs_mm_state_gb_fsm.c +++ b/src/sgsn/gprs_mm_state_gb_fsm.c @@ -1,6 +1,6 @@ /* TS 23.060 § 6.1.1 Mobility Management States (A/Gb mode) */ /* - * (C) 2019 by sysmocom - s.m.f.c. GmbH <info(a)sysmocom.de> + * (C) 2019 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> * All Rights Reserved * * SPDX-License-Identifier: AGPL-3.0+ diff --git a/src/sgsn/gprs_mm_state_iu_fsm.c b/src/sgsn/gprs_mm_state_iu_fsm.c index 5ac0097..c2e9c44 100644 --- a/src/sgsn/gprs_mm_state_iu_fsm.c +++ b/src/sgsn/gprs_mm_state_iu_fsm.c @@ -1,6 +1,6 @@ /* TS 23.060 § 6.1.2 Mobility Management States (Iu mode) */ /* - * (C) 2019 by sysmocom - s.m.f.c. GmbH <info(a)sysmocom.de> + * (C) 2019 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> * All Rights Reserved * * SPDX-License-Identifier: AGPL-3.0+ diff --git a/src/sgsn/gtp_ggsn.c b/src/sgsn/gtp_ggsn.c index 7cc65f8..14cdfea 100644 --- a/src/sgsn/gtp_ggsn.c +++ b/src/sgsn/gtp_ggsn.c @@ -1,7 +1,7 @@ /* GGSN context (peer) */ /* (C) 2009 by Harald Welte <laforge(a)gnumonks.org> - * (C) 2023 by sysmocom - s.m.f.c. GmbH <info(a)sysmocom.de> + * (C) 2023 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> * * All Rights Reserved * diff --git a/src/sgsn/gtp_mme.c b/src/sgsn/gtp_mme.c index b96c90d..3d7ec76 100644 --- a/src/sgsn/gtp_mme.c +++ b/src/sgsn/gtp_mme.c @@ -1,6 +1,6 @@ /* TS 29.060 § 7.5.14 RAN Information Management Messages */ /* - * (C) 2021 by sysmocom - s.m.f.c. GmbH <info(a)sysmocom.de> + * (C) 2021 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> * All Rights Reserved * * SPDX-License-Identifier: AGPL-3.0+ -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/32778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie2d864d5171e0da2e8a6c8551d151fd14f89bf05 Gerrit-Change-Number: 32778 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[S] Change in osmo-mgw[master]: copyright: fix typo: sysmocom s/s.m.f.c./s.f.m.c./ GmbH

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32775 ) Change subject: copyright: fix typo: sysmocom s/s.m.f.c./s.f.m.c./ GmbH ...................................................................... copyright: fix typo: sysmocom s/s.m.f.c./s.f.m.c./ GmbH Change-Id: I0de7650ad119d9a5d2585e2af981c5f1ff8e7058 --- M debian/copyright M src/libosmo-mgcp-client/mgcp_client_vty.c 2 files changed, 12 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/debian/copyright b/debian/copyright index 0849a79..b2690ed 100644 --- a/debian/copyright +++ b/debian/copyright @@ -6,7 +6,7 @@ Copyright: 2009-2014 On-Waves 2009-2015 Holger Hans Peter Freyther <zecke(a)selfish.org> 2013 Jacob Erlbeck <jerlbeck(a)sysmocom.de> - 2016-2017 sysmocom s.m.f.c. GmbH <info(a)sysmocom.de> + 2016-2017 sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> License: AGPL-3.0+ This program is free software; you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by @@ -22,7 +22,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. Files: src/libosmo-mgcp-client/* include/osmocom/mgcp_client/* -Copyright: 2016 by sysmocom s.m.f.c. GmbH <info(a)sysmocom.de> +Copyright: 2016 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> Based on OpenBSC interface to quagga VTY (libmsc/vty_interface_layer3.c) 2009 by Harald Welte <laforge(a)gnumonks.org> 2009-2011 by Holger Hans Peter Freyther diff --git a/src/libosmo-mgcp-client/mgcp_client_vty.c b/src/libosmo-mgcp-client/mgcp_client_vty.c index 2a221d3..336733b 100644 --- a/src/libosmo-mgcp-client/mgcp_client_vty.c +++ b/src/libosmo-mgcp-client/mgcp_client_vty.c @@ -1,5 +1,5 @@ /* MGCP client interface to quagga VTY */ -/* (C) 2016 by sysmocom s.m.f.c. GmbH <info(a)sysmocom.de> +/* (C) 2016 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> * Based on OpenBSC interface to quagga VTY (libmsc/vty_interface_layer3.c) * (C) 2009 by Harald Welte <laforge(a)gnumonks.org> * (C) 2009-2011 by Holger Hans Peter Freyther -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32775 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I0de7650ad119d9a5d2585e2af981c5f1ff8e7058 Gerrit-Change-Number: 32775 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

[M] Change in osmo-bts[master]: trx: remove model-specific BFI packet formats

by fixeria

Attention is currently required from: falconia, fixeria. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32788 ) Change subject: trx: remove model-specific BFI packet formats ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Fine with me. Once merged, I will also port this change to trxcon. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8f9fb5b8c5b2cad4b92ac693c0040779f811981a Gerrit-Change-Number: 32788 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-Comment-Date: Fri, 19 May 2023 10:52:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[arehbein/osmo_io_ipa]: core: Add function to update osmo_io_ops field for osmo_io_fd

by arehbein

Attention is currently required from: daniel. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32713 ) Change subject: core: Add function to update osmo_io_ops field for osmo_io_fd ...................................................................... Patch Set 3: (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/32713/comment/dbe4b031_0c8cbd15 PS2, Line 557: osmo_iofd_update_ioops > I'd rename it osmo_iofd_set_ioops() Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: arehbein/osmo_io_ipa Gerrit-Change-Id: Ie45402ad8e86e3cecf75ad78a512c17e61e68b19 Gerrit-Change-Number: 32713 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 May 2023 10:52:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: core: Add function to update osmo_io_ops field for osmo_io_fd

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/32790 ) Change subject: core: Add function to update osmo_io_ops field for osmo_io_fd ...................................................................... core: Add function to update osmo_io_ops field for osmo_io_fd Added, because the field 'io_ops' of 'struct osmo_io_fd' is not a reference, so subsequent changes to the osmo_io_ops structure that was used to set it up aren't automatically reflected in the osmo_io_fd structure that got its copy. Change-Id: Ie45402ad8e86e3cecf75ad78a512c17e61e68b19 --- M include/osmocom/core/osmo_io.h M src/core/libosmocore.map M src/core/osmo_io.c 3 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/90/32790/1 diff --git a/include/osmocom/core/osmo_io.h b/include/osmocom/core/osmo_io.h index ffc8cfa..c19ca67 100644 --- a/include/osmocom/core/osmo_io.h +++ b/include/osmocom/core/osmo_io.h @@ -88,3 +88,5 @@ int osmo_iofd_get_fd(const struct osmo_io_fd *iofd); const char *osmo_iofd_get_name(const struct osmo_io_fd *iofd); + +void osmo_iofd_set_ioops(struct osmo_io_fd *iofd, const struct osmo_io_ops *ioops); diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map index 7bca331..bce3399 100644 --- a/src/core/libosmocore.map +++ b/src/core/libosmocore.map @@ -267,6 +267,7 @@ osmo_iofd_sendto_msgb; osmo_iofd_set_alloc_info; osmo_iofd_set_data; +osmo_iofd_set_ioops; osmo_iofd_set_priv_nr; osmo_iofd_setup; osmo_iofd_txqueue_clear; diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index cfb6d68..b06e63c 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -599,4 +599,12 @@ return iofd->name; } +/*! Set the osmo_io_ops for an iofd + * \param[in] iofd Target iofd file descriptor + * \param[in] ioops osmo_io_ops structure to be set */ +void osmo_iofd_set_ioops(struct osmo_io_fd *iofd, const struct osmo_io_ops *ioops) +{ + iofd->io_ops = *ioops; +} + #endif /* defined(__linux__) */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32790 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie45402ad8e86e3cecf75ad78a512c17e61e68b19 Gerrit-Change-Number: 32790 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: coding: fix decoding of EFR triplicated bits

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32767 ) Change subject: coding: fix decoding of EFR triplicated bits ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I47def75cdb066ed6372df4567404cc828589ed53 Gerrit-Change-Number: 32767 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 May 2023 10:47:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: osmo_io: Support detecting non-blocking connect()

by daniel

Attention is currently required from: laforge. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32759 ) Change subject: osmo_io: Support detecting non-blocking connect() ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Patchset: PS6: +1 from Harald -> +2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I893cbc3becd5e125f2f06b3654578aed0aacadf3 Gerrit-Change-Number: 32759 Gerrit-PatchSet: 6 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 19 May 2023 10:11:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[M] Change in libosmocore[master]: osmo_io: Improve handling and documentation of segmentation_cb

by daniel

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/32758 to look at the new patch set (#5). Change subject: osmo_io: Improve handling and documentation of segmentation_cb ...................................................................... osmo_io: Improve handling and documentation of segmentation_cb The read length is not needed in the segmentation callback, msgb already has all the necessary information, the parameter previously was just msgb_length(msg). Also handle negative return values (except -EAGAIN) of the callback as errors which cause the msg to be dropped. -EAGAIN will defer the msg. Change-Id: I6a0eebb8d4490f09a3cc6eb97d4ff47b4a8fd377 --- M include/osmocom/core/osmo_io.h M src/core/osmo_io.c 2 files changed, 48 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/58/32758/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6a0eebb8d4490f09a3cc6eb97d4ff47b4a8fd377 Gerrit-Change-Number: 32758 Gerrit-PatchSet: 5 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

[M] Change in libosmocore[master]: osmo_io: Improve handling and documentation of segmentation_cb

by daniel

Attention is currently required from: laforge, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32758 ) Change subject: osmo_io: Improve handling and documentation of segmentation_cb ...................................................................... Patch Set 4: (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/32758/comment/fc85dc24_304fcc84 PS3, Line 249: } else if (pending_len < 0) { > Ok I see the root of the confusion now I think, "pending_len" as positive is not really the pending_ […] I think it's more important what someone else who didn't write this thinks. I named it pending_len because it's the length that msg_pending msgb will have. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6a0eebb8d4490f09a3cc6eb97d4ff47b4a8fd377 Gerrit-Change-Number: 32758 Gerrit-PatchSet: 4 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 May 2023 10:04:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

[S] Change in libosmocore[master]: osmo_io: Support detecting non-blocking connect()

by pespin

Attention is currently required from: laforge, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32759 ) Change subject: osmo_io: Support detecting non-blocking connect() ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I893cbc3becd5e125f2f06b3654578aed0aacadf3 Gerrit-Change-Number: 32759 Gerrit-PatchSet: 5 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 May 2023 09:48:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2023