Attention is currently required from: laforge, pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32758 )
Change subject: osmo_io: Improve handling and documentation of segmentation_cb
......................................................................
Patch Set 4:
(1 comment)
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/32758/comment/fc85dc24_304fcc84
PS3, Line 249: } else if (pending_len < 0) {
Ok I see the root of the confusion now I think, "pending_len" as positive is not really the pending_ […]
I think it's more important what someone else who didn't write this thinks.
I named it pending_len because it's the length that msg_pending msgb will have.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32758
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6a0eebb8d4490f09a3cc6eb97d4ff47b4a8fd377
Gerrit-Change-Number: 32758
Gerrit-PatchSet: 4
Gerrit-Owner: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Fri, 19 May 2023 10:04:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: daniel
dwillmann@sysmocom.de
Gerrit-MessageType: comment