April 2023 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo_dia2gsup[master]: Allow to add APN wildcard via configuration

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32513 ) Change subject: Allow to add APN wildcard via configuration ...................................................................... Allow to add APN wildcard via configuration If the osmo-hlr doesn't send a default APN but it is required. Set application environment append_default_apn to "true". See the example sys.config. Change-Id: I5767cb3c4082809f2ac5a4361a4758b54f24ad48 --- M examples/sys.config M src/server_cb.erl 2 files changed, 44 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/13/32513/1 diff --git a/examples/sys.config b/examples/sys.config index 8814893..8ad9bdf 100644 --- a/examples/sys.config +++ b/examples/sys.config @@ -8,5 +8,7 @@ {origin_host, "hss.localdomain"}, {origin_realm, "localdomain"}, - {vendor_id, 0} + {vendor_id, 0}, + % Append default APN to diameter + {append_default_apn, "false"} ]}]. diff --git a/src/server_cb.erl b/src/server_cb.erl index fc8e397..709ef44 100644 --- a/src/server_cb.erl +++ b/src/server_cb.erl @@ -136,6 +136,22 @@ 'Pre-emption-Vulnerability'=1} }). +-spec gen_default_apn(integer()) -> #'APN-Configuration'{}. +gen_default_apn(ContextIdentifier) -> + #'APN-Configuration'{'Context-Identifier' = ContextIdentifier, + 'PDN-Type' = ?PDN_TYPE_DEFAULT, + % The EPS-Subscribed-QoS-Profile AVP and the AMBR AVP shall be present in the + % APN-Configuration AVP when the APN-Configuration AVP is sent in the + % APN-Configuration-Profile AVP and when the APN-Configuration-Profile AVP is + % sent within a ULA (as part of the Subscription-Data AVP). + 'EPS-Subscribed-QoS-Profile' = ?EPS_QOS_DEFAULT, + 'AMBR' = #'AMBR'{'Max-Requested-Bandwidth-UL' = 100000000, + 'Max-Requested-Bandwidth-DL' = 100000000}, + % The default APN Configuration shall not contain the Wildcard APN (see 3GPP TS + % 23.003 [3], clause 9.2); the default APN shall always contain an explicit APN + 'Service-Selection' = "*" + }. + -spec gsup_pdp2dia_apn('GSUPPdpInfo'()) -> #'APN-Configuration'{}. gsup_pdp2dia_apn(GsupPdpInfo) -> #'APN-Configuration'{'Context-Identifier' = maps:get(pdp_context_id, GsupPdpInfo), @@ -275,7 +291,18 @@ 'PDP-Context'=PdpContexts}, % build the APN-Configuration-Profile - ApnCfgList = lists:map(fun gsup_pdp2dia_apn/1, PdpInfoList), + ApnCfgList2 = lists:map(fun gsup_pdp2dia_apn/1, PdpInfoList), + % append default apn + AppendDefaultApn = application:get_env(osmo_dia2gsup, append_default_apn, "true"), + case AppendDefaultApn of + "true" -> + LastApn = lists:last(ApnCfgList2), + ApnCfgList = ApnCfgList2 ++ [gen_default_apn(LastApn#'APN-Configuration'.'Context-Identifier' + 1)]; + _ -> + ApnCfgList = ApnCfgList2 + end, + lager:info("ApnCfgList: ~p~n", [ApnCfgList]), + FirstApn = lists:nth(1, ApnCfgList), DefaultCtxId = FirstApn#'APN-Configuration'.'Context-Identifier', ApnCfgProf = #'APN-Configuration-Profile'{'Context-Identifier' = DefaultCtxId, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I5767cb3c4082809f2ac5a4361a4758b54f24ad48 Gerrit-Change-Number: 32513 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[M] Change in osmo-hlr[master]: hlr: use talloc for memory allocation in osmo_gsup_create_insert_subs...

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32511 ) Change subject: hlr: use talloc for memory allocation in osmo_gsup_create_insert_subscriber_data_msg ...................................................................... Patch Set 1: (2 comments) File src/hlr.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6548): https://gerrit.osmocom.org/c/osmo-hlr/+/32511/comment/9ae3769d_0c840646 PS1, Line 162: cont_err: labels should not be indented File src/lu_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6548): https://gerrit.osmocom.org/c/osmo-hlr/+/32511/comment/051d3cd9_32426c75 PS1, Line 248: lu->is_ps? OSMO_GSUP_CN_DOMAIN_PS : OSMO_GSUP_CN_DOMAIN_CS, spaces required around that '?' (ctx:VxW) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/32511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I00b5c2dfadcf6e0740e93b4c3292d2654d22e80c Gerrit-Change-Number: 32511 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 26 Apr 2023 17:40:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmo-hlr[master]: hlr: use talloc for memory allocation in osmo_gsup_create_insert_subs...

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32511 ) Change subject: hlr: use talloc for memory allocation in osmo_gsup_create_insert_subscriber_data_msg ...................................................................... hlr: use talloc for memory allocation in osmo_gsup_create_insert_subscriber_data_msg Don't use static buffers for APN and MSISDN. When encoding multiple APNs the static buffer might be to small. In prepration to support multiple APNs in subscriber data Change-Id: I00b5c2dfadcf6e0740e93b4c3292d2654d22e80c --- M include/osmocom/hlr/gsup_server.h M src/gsup_server.c M src/hlr.c M src/lu_fsm.c 4 files changed, 38 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/11/32511/1 diff --git a/include/osmocom/hlr/gsup_server.h b/include/osmocom/hlr/gsup_server.h index 9c562e2..86ae4ec 100644 --- a/include/osmocom/hlr/gsup_server.h +++ b/include/osmocom/hlr/gsup_server.h @@ -69,8 +69,6 @@ int osmo_gsup_configure_wildcard_apn(struct osmo_gsup_message *gsup, uint8_t *apn_buf, size_t apn_buf_size); int osmo_gsup_create_insert_subscriber_data_msg(struct osmo_gsup_message *gsup, const char *imsi, const char *msisdn, - uint8_t *msisdn_enc, size_t msisdn_enc_size, - uint8_t *apn_buf, size_t apn_buf_size, - enum osmo_gsup_cn_domain cn_domain); + enum osmo_gsup_cn_domain cn_domain, void *talloc_ctx); int osmo_gsup_forward_to_local_peer(struct osmo_gsup_server *server, const struct osmo_cni_peer_id *to_peer, struct osmo_gsup_req *req, struct osmo_gsup_message *modified_gsup); diff --git a/src/gsup_server.c b/src/gsup_server.c index f0d8101..b14a791 100644 --- a/src/gsup_server.c +++ b/src/gsup_server.c @@ -446,19 +446,16 @@ * \param[out] gsup The gsup message to populate. * \param[in] imsi The subscriber's IMSI. * \param[in] msisdn The subscriber's MSISDN. - * \param[out] msisdn_enc A buffer large enough to store the MSISDN in encoded form. - * \param[in] msisdn_enc_size Size of the buffer (must be >= OSMO_GSUP_MAX_CALLED_PARTY_BCD_LEN). - * \param[out] apn_buf A buffer large enough to store an APN (required if cn_domain is OSMO_GSUP_CN_DOMAIN_PS). - * \param[in] apn_buf_size Size of APN buffer (must be >= APN_MAXLEN). * \param[in] cn_domain The CN Domain of the subscriber connection. + * \param[in] talloc_ctx To allocation memory for dynamic fields (msisdn, apn) in the gsup field * \returns 0 on success, and negative on error. */ int osmo_gsup_create_insert_subscriber_data_msg(struct osmo_gsup_message *gsup, const char *imsi, const char *msisdn, - uint8_t *msisdn_enc, size_t msisdn_enc_size, - uint8_t *apn_buf, size_t apn_buf_size, - enum osmo_gsup_cn_domain cn_domain) + enum osmo_gsup_cn_domain cn_domain, + void *talloc_ctx) { int len; + char *msisdn_buf = talloc_size(talloc_ctx, OSMO_GSUP_MAX_CALLED_PARTY_BCD_LEN); OSMO_ASSERT(gsup); *gsup = (struct osmo_gsup_message){ @@ -467,27 +464,22 @@ osmo_strlcpy(gsup->imsi, imsi, sizeof(gsup->imsi)); - if (msisdn_enc_size < OSMO_GSUP_MAX_CALLED_PARTY_BCD_LEN) - return -ENOSPC; - - OSMO_ASSERT(msisdn_enc); - len = gsm48_encode_bcd_number(msisdn_enc, msisdn_enc_size, 0, msisdn); + len = gsm48_encode_bcd_number(msisdn_buf, OSMO_GSUP_MAX_CALLED_PARTY_BCD_LEN, 0, msisdn); if (len < 1) { LOGP(DLGSUP, LOGL_ERROR, "%s: Error: cannot encode MSISDN '%s'\n", imsi, msisdn); return -ENOSPC; } - gsup->msisdn_enc = msisdn_enc; + gsup->msisdn_enc = msisdn_buf; gsup->msisdn_enc_len = len; #pragma message "FIXME: deal with encoding the following data: gsup.hlr_enc" gsup->cn_domain = cn_domain; if (gsup->cn_domain == OSMO_GSUP_CN_DOMAIN_PS) { - OSMO_ASSERT(apn_buf_size >= APN_MAXLEN); - OSMO_ASSERT(apn_buf); + char *apn_buf = talloc_size(talloc_ctx, APN_MAXLEN); /* FIXME: PDP infos - use more fine-grained access control instead of wildcard APN */ - osmo_gsup_configure_wildcard_apn(gsup, apn_buf, apn_buf_size); + osmo_gsup_configure_wildcard_apn(gsup, apn_buf, APN_MAXLEN); } return 0; diff --git a/src/hlr.c b/src/hlr.c index 8183d9b..9f9cb58 100644 --- a/src/hlr.c +++ b/src/hlr.c @@ -85,8 +85,7 @@ llist_for_each_entry(co, &g_hlr->gs->clients, list) { struct osmo_gsup_message gsup = { }; - uint8_t msisdn_enc[OSMO_GSUP_MAX_CALLED_PARTY_BCD_LEN]; - uint8_t apn[APN_MAXLEN]; + void *sub_upd_ctx = talloc_named_const(NULL, 1, "hlr_sub_upd_notify"); struct msgb *msg_out; uint8_t *peer; int peer_len; @@ -102,7 +101,7 @@ peer_compare = subscr->vlr_number; } else { /* We have not yet received a location update from this GSUP client.*/ - continue; + goto cont_err; } peer_len = osmo_gsup_conn_ccm_get(co, &peer, IPAC_IDTAG_SERNR); @@ -111,7 +110,7 @@ "IMSI='%s': cannot get peer name for connection %s:%u\n", subscr->imsi, co && co->conn && co->conn->server? co->conn->server->addr : "unset", co && co->conn && co->conn->server? co->conn->server->port : 0); - continue; + goto cont_err; } peer_strlen = strnlen((const char*)peer, peer_len); @@ -123,7 +122,7 @@ "IMSI %s: subscriber change: skipping %s peer %s\n", subscr->imsi, cn_domain == OSMO_GSUP_CN_DOMAIN_PS ? "PS" : "CS", osmo_quote_str((char*)peer, -1)); - continue; + goto cont_err; } LOGP(DLGSUP, LOGL_DEBUG, @@ -131,14 +130,13 @@ subscr->imsi, cn_domain == OSMO_GSUP_CN_DOMAIN_PS ? "PS" : "CS", osmo_quote_str(peer_compare, -1)); - if (osmo_gsup_create_insert_subscriber_data_msg(&gsup, subscr->imsi, subscr->msisdn, msisdn_enc, - sizeof(msisdn_enc), apn, sizeof(apn), cn_domain) != 0) { + if (osmo_gsup_create_insert_subscriber_data_msg(&gsup, subscr->imsi, subscr->msisdn, cn_domain, sub_upd_ctx) != 0) { LOGP(DLGSUP, LOGL_ERROR, "IMSI='%s': Cannot notify GSUP client; could not create gsup message " "for %s:%u\n", subscr->imsi, co && co->conn && co->conn->server? co->conn->server->addr : "unset", co && co->conn && co->conn->server? co->conn->server->port : 0); - continue; + goto cont_err; } /* Send ISD to MSC/SGSN */ @@ -149,7 +147,7 @@ "for %s:%u\n", subscr->imsi, co && co->conn && co->conn->server? co->conn->server->addr : "unset", co && co->conn && co->conn->server? co->conn->server->port : 0); - continue; + goto cont_err; } osmo_gsup_encode(msg_out, &gsup); @@ -159,8 +157,11 @@ "for %s:%u\n", subscr->imsi, co && co->conn && co->conn->server? co->conn->server->addr : "unset", co && co->conn && co->conn->server? co->conn->server->port : 0); - continue; + goto cont_err; } + cont_err: + talloc_free(sub_upd_ctx); + continue; } } diff --git a/src/lu_fsm.c b/src/lu_fsm.c index deb180b..ef653a0 100644 --- a/src/lu_fsm.c +++ b/src/lu_fsm.c @@ -241,19 +241,19 @@ struct lu *lu = fi->priv; struct hlr_subscriber *subscr = &lu->subscr; struct osmo_gsup_message gsup; - uint8_t msisdn_enc[OSMO_GSUP_MAX_CALLED_PARTY_BCD_LEN]; - uint8_t apn[APN_MAXLEN]; + void *lu_isr_ctx = talloc_named_const(NULL, 1, "lu_isr"); if (osmo_gsup_create_insert_subscriber_data_msg(&gsup, subscr->imsi, - subscr->msisdn, msisdn_enc, sizeof(msisdn_enc), - apn, sizeof(apn), - lu->is_ps? OSMO_GSUP_CN_DOMAIN_PS : OSMO_GSUP_CN_DOMAIN_CS)) { + subscr->msisdn, + lu->is_ps? OSMO_GSUP_CN_DOMAIN_PS : OSMO_GSUP_CN_DOMAIN_CS, + lu_isr_ctx)) { lu_failure(lu, GMM_CAUSE_NET_FAIL, "cannot encode Insert Subscriber Data message"); return; } if (osmo_gsup_req_respond(lu->update_location_req, &gsup, false, false)) lu_failure(lu, GMM_CAUSE_NET_FAIL, "cannot send %s", osmo_gsup_message_type_name(gsup.message_type)); + talloc_free(lu_isr_ctx); } void lu_fsm_wait_insert_data_result(struct osmo_fsm_inst *fi, uint32_t event, void *data) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/32511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I00b5c2dfadcf6e0740e93b4c3292d2654d22e80c Gerrit-Change-Number: 32511 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[L] Change in osmo-hlr[master]: Add support for multiple APN profiles for subscriber data

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32512 ) Change subject: Add support for multiple APN profiles for subscriber data ...................................................................... Add support for multiple APN profiles for subscriber data Previous the HLR sent in the Insert Subscriber Data call only the wildcard APN as a single entry. This violates the spec because the first entry (with the lowest context_id) is always the default APN, but it is forbidden to have a wildcard APN as default apn. Introduce a default template/profile which can contain multiple APNs. This profile is always sent out to the SGSN/MME as part of Insert-Subscriber-Data. In the future a subscriber might have a profile template name written into the database which will resolve to a "pdp-profile premium" in the configuration. To be backward compatible, if the pdp-profile default section is missing, the HLR will send out only a wildcard APN. Config example: hlr ps pdp-profile default profile 1 apn internet profile 2 apn * TODO: check if SGSN is fine with this TODO: check if we can inform all PS session on change of the config Change-Id: I540132ee5dcfd09f4816e02e702927e1074ca50f --- M doc/examples/osmo-hlr.cfg M include/osmocom/hlr/hlr.h A include/osmocom/hlr/hlr_ps.h M include/osmocom/hlr/hlr_vty.h M src/gsup_server.c M src/hlr_vty.c M tests/test_nodes.vty 7 files changed, 316 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/12/32512/1 diff --git a/doc/examples/osmo-hlr.cfg b/doc/examples/osmo-hlr.cfg index dabfc8e..dd5292e 100644 --- a/doc/examples/osmo-hlr.cfg +++ b/doc/examples/osmo-hlr.cfg @@ -24,3 +24,9 @@ bind ip 127.0.0.1 ussd route prefix *#100# internal own-msisdn ussd route prefix *#101# internal own-imsi + ps + pdp-profiles default + profile 1 + apn internet + profile 2 + apn * diff --git a/include/osmocom/hlr/hlr.h b/include/osmocom/hlr/hlr.h index b27fb3d..dc0c77e 100644 --- a/include/osmocom/hlr/hlr.h +++ b/include/osmocom/hlr/hlr.h @@ -58,6 +58,14 @@ struct hlr_euse *euse_default; enum gsm48_gmm_cause reject_cause; enum gsm48_gmm_cause no_proxy_reject_cause; + /* PS: APN default configuration used by Subscription Data on ISR */ + struct { + struct { + bool enabled; + struct osmo_gsup_pdp_info pdp_infos[OSMO_GSUP_MAX_NUM_PDP_INFO]; + size_t num_pdp_infos; + } pdp_profile; + } ps; /* NCSS (call independent) session guard timeout value */ int ncss_guard_timeout; diff --git a/include/osmocom/hlr/hlr_ps.h b/include/osmocom/hlr/hlr_ps.h new file mode 100644 index 0000000..d84a0af --- /dev/null +++ b/include/osmocom/hlr/hlr_ps.h @@ -0,0 +1,37 @@ +/* OsmoHLR packet switched header */ + +/* (C) 2023 sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> + * All Rights Reserved + * + * Author: Alexander Couzens <lynxis(a)fe80.eu> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + */ + +struct hlr_pdp_profile { + struct llist_head list; + int context_id; + const char *apn; +} + + +/* PS: APN default configuration used by Subscription Data on ISR */ +struct { + struct { + bool enabled; + struct osmo_gsup_pdp_info pdp_infos[OSMO_GSUP_MAX_NUM_PDP_INFO]; + size_t num_pdp_infos; + } pdp_profile; +} ps; diff --git a/include/osmocom/hlr/hlr_vty.h b/include/osmocom/hlr/hlr_vty.h index 83691b8..1674075 100644 --- a/include/osmocom/hlr/hlr_vty.h +++ b/include/osmocom/hlr/hlr_vty.h @@ -35,6 +35,9 @@ MSLOOKUP_SERVER_NODE, MSLOOKUP_SERVER_MSC_NODE, MSLOOKUP_CLIENT_NODE, + PS_NODE, + PS_PDP_PROFILES_NODE, + PS_PDP_PROFILES_PROFILE_NODE, }; diff --git a/src/gsup_server.c b/src/gsup_server.c index b14a791..5230e69 100644 --- a/src/gsup_server.c +++ b/src/gsup_server.c @@ -32,6 +32,7 @@ #include <osmocom/hlr/gsup_server.h> #include <osmocom/hlr/gsup_router.h> +#include <osmocom/hlr/hlr.h> #define LOG_GSUP_CONN(conn, level, fmt, args...) \ LOGP(DLGSUP, level, "GSUP peer %s: " fmt, \ @@ -455,7 +456,7 @@ void *talloc_ctx) { int len; - char *msisdn_buf = talloc_size(talloc_ctx, OSMO_GSUP_MAX_CALLED_PARTY_BCD_LEN); + uint8_t *msisdn_buf = talloc_size(talloc_ctx, OSMO_GSUP_MAX_CALLED_PARTY_BCD_LEN); OSMO_ASSERT(gsup); *gsup = (struct osmo_gsup_message){ @@ -476,10 +477,15 @@ gsup->cn_domain = cn_domain; if (gsup->cn_domain == OSMO_GSUP_CN_DOMAIN_PS) { - char *apn_buf = talloc_size(talloc_ctx, APN_MAXLEN); - /* FIXME: PDP infos - use more fine-grained access control - instead of wildcard APN */ - osmo_gsup_configure_wildcard_apn(gsup, apn_buf, APN_MAXLEN); + if (g_hlr->ps.pdp_profile.enabled) { + memcpy(gsup->pdp_infos, + g_hlr->ps.pdp_profile.pdp_infos, + sizeof(struct osmo_gsup_pdp_info) * g_hlr->ps.pdp_profile.num_pdp_infos); + gsup->num_pdp_infos = g_hlr->ps.pdp_profile.num_pdp_infos; + } else { + char *apn_buf = talloc_size(talloc_ctx, APN_MAXLEN); + osmo_gsup_configure_wildcard_apn(gsup, apn_buf, APN_MAXLEN); + } } return 0; diff --git a/src/hlr_vty.c b/src/hlr_vty.c index 02e0cde..b4bbec6 100644 --- a/src/hlr_vty.c +++ b/src/hlr_vty.c @@ -26,9 +26,12 @@ */ #include <errno.h> +#include <string.h> #include <osmocom/core/talloc.h> #include <osmocom/gsm/protocol/gsm_04_08_gprs.h> +#include <osmocom/gsm/apn.h> + #include <osmocom/vty/vty.h> #include <osmocom/vty/stats.h> #include <osmocom/vty/command.h> @@ -103,6 +106,172 @@ return CMD_SUCCESS; } +struct cmd_node ps_node = { + PS_NODE, + "%s(config-hlr-ps)# ", + 1, +}; + +DEFUN(cfg_ps, + cfg_ps_cmd, + "ps", + "Configure the PS options") +{ + vty->node = PS_NODE; + return CMD_SUCCESS; +} + +struct cmd_node ps_pdp_profiles_node = { + PS_PDP_PROFILES_NODE, + "%s(config-hlr-ps-pdp-profiles)# ", + 1, +}; + +DEFUN(cfg_ps_pdp_profiles, + cfg_ps_pdp_profiles_cmd, + "pdp-profiles default", + "Define a PDP profile set.\n" + "Unique identifier for this PDP profile set.\n") +{ + g_hlr->ps.pdp_profile.enabled = true; + + vty->node = PS_PDP_PROFILES_NODE; + return CMD_SUCCESS; +} + +DEFUN(cfg_no_ps_pdp_profiles, + cfg_no_ps_pdp_profiles_cmd, + "no pdp-profiles default", + NO_STR + "Delete PDP profile.\n" + "Unique identifier for this PDP profile set.\n") +{ + g_hlr->ps.pdp_profile.enabled = false; + return CMD_SUCCESS; +} + + + +struct cmd_node ps_pdp_profiles_profile_node = { + PS_PDP_PROFILES_PROFILE_NODE, + "%s(config-hlr-ps-pdp-profile)# ", + 1, +}; + + +/* context_id == 0 means the slot is free */ +struct osmo_gsup_pdp_info *get_pdp_profile(uint8_t context_id) +{ + for (int i = 0; i < OSMO_GSUP_MAX_NUM_PDP_INFO; i++) { + struct osmo_gsup_pdp_info *info = &g_hlr->ps.pdp_profile.pdp_infos[i]; + if (info->context_id == context_id) { + return info; + } + } + + return NULL; +} + +struct osmo_gsup_pdp_info *create_pdp_profile(uint8_t context_id) +{ + struct osmo_gsup_pdp_info *info = get_pdp_profile(0); + if (!info) + return NULL; + + memset(info, 0, sizeof(*info)); + info->context_id = context_id; + info->have_info = 1; + + g_hlr->ps.pdp_profile.num_pdp_infos++; + return info; +} + +void destroy_pdp_profile(struct osmo_gsup_pdp_info *info) +{ + info->context_id = 0; + if (info->apn_enc) + talloc_free(info->apn_enc); + + g_hlr->ps.pdp_profile.num_pdp_infos--; + memset(info, 0, sizeof(*info)); +} + +DEFUN(cfg_ps_pdp_profiles_profile, + cfg_ps_pdp_profiles_profile_cmd, + "profile <1-10>", + "Configure a PDP profile\n" + "Unique PDP context identifier. The lowest profile will be used as default context.\n") +{ + struct osmo_gsup_pdp_info *info; + uint8_t context_id = atoi(argv[0]); + + info = get_pdp_profile(context_id); + if (!info) { + info = create_pdp_profile(context_id); + if (!info) { + vty_out(vty, "Failed to create profile %d!%s", context_id, VTY_NEWLINE); + return CMD_ERR_INCOMPLETE; + } + } + + vty->node = PS_PDP_PROFILES_PROFILE_NODE; + vty->index = info; + return CMD_SUCCESS; +} + +DEFUN(cfg_no_ps_pdp_profiles_profile, + cfg_no_ps_pdp_profiles_profile_cmd, + "no profile <1-10>", + NO_STR + "Delete a PDP profile\n" + "Unique PDP context identifier. The lowest profile will be used as default context.\n") +{ + struct osmo_gsup_pdp_info *info; + uint8_t context_id = atoi(argv[0]); + + info = get_pdp_profile(context_id); + if (info) + destroy_pdp_profile(info); + + return CMD_SUCCESS; +} + +DEFUN(cfg_ps_pdp_profile_apn, cfg_ps_pdp_profile_apn_cmd, + "apn ID", + "Configure the APN.\n" + "APN name or * for wildcard apn.\n") +{ + struct osmo_gsup_pdp_info *info = vty->index; + const char *apn_name = argv[0]; + size_t apn = strlen(apn_name); + + if (apn > APN_MAXLEN) { + vty_out(vty, "APN name is too long '%s'. Max is %d!%s", apn_name, APN_MAXLEN, VTY_NEWLINE); + return CMD_ERR_INCOMPLETE; + } + + info->apn_enc = (uint8_t *) talloc_strdup(g_hlr, apn_name); + info->apn_enc_len = strlen(apn_name); + + return CMD_SUCCESS; +} + +DEFUN(cfg_no_ps_pdp_profile_apn, cfg_no_ps_pdp_profile_apn_cmd, + "no apn", + NO_STR + "Delete the APN.\n") +{ + struct osmo_gsup_pdp_info *info = vty->index; + if (info->apn_enc) { + talloc_free(info->apn_enc); + info->apn_enc = NULL; + info->apn_enc_len = 0; + } + + return CMD_SUCCESS; +} + + static int config_write_hlr(struct vty *vty) { vty_out(vty, "hlr%s", VTY_NEWLINE); @@ -149,6 +318,33 @@ return CMD_SUCCESS; } +static int config_write_hlr_ps(struct vty *vty) +{ + vty_out(vty, " ps%s", VTY_NEWLINE); + return CMD_SUCCESS; +} + +static int config_write_hlr_ps_pdp_profiles(struct vty *vty) +{ + if (!g_hlr->ps.pdp_profile.enabled) + return CMD_SUCCESS; + + vty_out(vty, " pdp-profiles default%s", VTY_NEWLINE); + for (int i = 0; i < g_hlr->ps.pdp_profile.num_pdp_infos; i++) { + struct osmo_gsup_pdp_info *pdp_info = &g_hlr->ps.pdp_profile.pdp_infos[i]; + if (!pdp_info->context_id) + continue; + + vty_out(vty, " profile %d%s", pdp_info->context_id, VTY_NEWLINE); + if (!pdp_info->have_info) + continue; + + if (pdp_info->apn_enc && pdp_info->apn_enc_len) + vty_out(vty, " apn %s%s", pdp_info->apn_enc, VTY_NEWLINE); + } + return CMD_SUCCESS; +} + static void show_one_conn(struct vty *vty, const struct osmo_gsup_conn *conn) { const struct ipa_server_conn *isc = conn->conn; @@ -538,6 +734,24 @@ install_element(GSUP_NODE, &cfg_hlr_gsup_bind_ip_cmd); install_element(GSUP_NODE, &cfg_hlr_gsup_ipa_name_cmd); + /* PS */ + install_node(&ps_node, config_write_hlr_ps); + install_element(HLR_NODE, &cfg_ps_cmd); + + install_node(&ps_pdp_profiles_node, config_write_hlr_ps_pdp_profiles); + install_element(PS_NODE, &cfg_ps_pdp_profiles_cmd); + install_element(PS_NODE, &cfg_no_ps_pdp_profiles_cmd); + + install_node(&ps_pdp_profiles_profile_node, NULL); + install_element(PS_PDP_PROFILES_NODE, &cfg_ps_pdp_profiles_profile_cmd); + install_element(PS_PDP_PROFILES_NODE, &cfg_no_ps_pdp_profiles_profile_cmd); + install_element(PS_PDP_PROFILES_PROFILE_NODE, &cfg_ps_pdp_profile_apn_cmd); + install_element(PS_PDP_PROFILES_PROFILE_NODE, &cfg_no_ps_pdp_profile_apn_cmd); + + /* TODO: + * no profiles default + */ + install_element(HLR_NODE, &cfg_database_cmd); install_element(HLR_NODE, &cfg_euse_cmd); diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty index ac5d88d..8c8b6e5 100644 --- a/tests/test_nodes.vty +++ b/tests/test_nodes.vty @@ -53,6 +53,7 @@ OsmoHLR(config-hlr)# list ... gsup + ps database PATH euse NAME no euse NAME @@ -112,6 +113,8 @@ ipa-name unnamed-HLR ussd route prefix *#100# internal own-msisdn ussd route prefix *#101# internal own-imsi + ps + pdp-profiles default end OsmoHLR# configure terminal -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/32512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I540132ee5dcfd09f4816e02e702927e1074ca50f Gerrit-Change-Number: 32512 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: HLR_Tests: add testcase for multiple APNs in subscriber data

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510 ) Change subject: HLR_Tests: add testcase for multiple APNs in subscriber data ...................................................................... HLR_Tests: add testcase for multiple APNs in subscriber data With a new HLR version there are multiple APN possible in the Subscriber Data (PDP Info). Change-Id: I8d0c08272bc239370e800d6014ab9c68087b8989 Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu> --- M hlr/HLR_Tests.ttcn M library/GSUP_Types.ttcn 2 files changed, 130 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/10/32510/1 diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn index 959c680..a778703 100644 --- a/hlr/HLR_Tests.ttcn +++ b/hlr/HLR_Tests.ttcn @@ -535,12 +535,15 @@ return ret; } +/* return_isd -> return the Insert Subscriber Data instead of the Update Location Result */ function f_perform_UL(hexstring imsi, template hexstring msisdn, template (omit) integer exp_err_cause := omit, GSUP_CnDomain dom := OSMO_GSUP_CN_DOMAIN_PS, - template (omit) octetstring source_name := omit) + template (omit) octetstring source_name := omit, + boolean return_isd := false) runs on HLR_ConnHdlr return GSUP_PDU { var GSUP_PDU ret; + var GSUP_PDU isd; timer T := 3.0; var boolean exp_fail := false; var boolean isd_done := false; @@ -570,7 +573,7 @@ setverdict(fail, "Unexpected UL ERROR"); mtc.stop; } - [not exp_fail and not isd_done] GSUP.receive(tr_GSUP_ISD_REQ(imsi, msisdn, destination_name := source_name)) -> value ret { + [not exp_fail and not isd_done] GSUP.receive(tr_GSUP_ISD_REQ(imsi, msisdn, destination_name := source_name)) -> value isd { GSUP.send(ts_GSUP_ISD_RES(imsi, source_name := source_name)); isd_done := true; repeat; @@ -584,6 +587,10 @@ mtc.stop; } } + if (return_isd) { + return isd; + } + return ret; } @@ -994,6 +1001,7 @@ res := f_perform_UL(g_pars.sub.imsi, g_pars.sub.msisdn, source_name := g_pars.source_name); setverdict(pass); } + testcase TC_gsup_ul() runs on test_CT { var HlrSubscriberList sl; var GSUP_PDU res; @@ -1015,6 +1023,70 @@ setverdict(pass); } +private function f_TC_gsup_ul_subscriber_data() runs on HLR_ConnHdlr { + var GSUP_PDU isd; + log("GSUP ul subscriber_data", isd); + isd := f_perform_UL(g_pars.sub.imsi, g_pars.sub.msisdn, source_name := g_pars.source_name, return_isd := true); + + template GSUP_IEs tr_pdp_info_internet := { + tr_GSUP_IE_PDP_CONTEXT_ID('01'O), + tr_GSUP_IE_APN(char2oct("internet")) + } + template GSUP_IEs tr_pdp_info_wildcard := { + tr_GSUP_IE_PDP_CONTEXT_ID('02'O), + tr_GSUP_IE_APN(char2oct("*")) + } + + /* Search for PDP info 'internet', '*' */ + var boolean found := false; + var GSUP_IeValue ievalue; + var GSUP_IEs pdp_info; + found := f_gsup_find_nested_ie_multiple(isd.ies, OSMO_GSUP_PDP_INFO_IE, 0, ievalue); + if (not found) { + setverdict(fail, "Multiple APNs: Coulnd't find first PDP Info IE in: ", isd); + return; + } + pdp_info := ievalue.pdp_info; + if (not match(pdp_info, tr_pdp_info_internet)) { + setverdict(fail, "Multiple APNs: first PDP Info doesn't match: ", pdp_info, "on Template: ", tr_pdp_info_internet); + return; + } + + /* wildcard '*' */ + found := f_gsup_find_nested_ie_multiple(isd.ies, OSMO_GSUP_PDP_INFO_IE, 1, ievalue); + if (not found) { + setverdict(fail, "Multiple APNs: Coulnd't find second PDP Info IE in: ", isd); + return; + } + pdp_info := ievalue.pdp_info; + if (not match(pdp_info, tr_pdp_info_wildcard)) { + setverdict(fail, "Multiple APNs: second PDP Info doesn't match: ", pdp_info, "on Template: ", tr_pdp_info_wildcard); + return; + } + + setverdict(pass); +} + +testcase TC_gsup_ul_subscriber_data() runs on test_CT { + /* Do a GSUP Update Location Request to get a Insert Subscriber Data Request (ISD). + * Check for multiple APN in the ISD: + * SGSN -> HLR: Update Location Request + * SGSN <- HLR: Insert Subscriber Data Request (Check the TLV) + * SGSN -> HLR: Insert Subscriber Data Result + * SGSN <- HLR: Update Location Result + */ + var HlrSubscriberList sl; + + f_init(false); + f_vty_config2(VTY, {"hlr", "ps"} , "no pdp-profiles default"); + f_vty_config2(VTY, {"hlr", "ps", "pdp-profiles default", "profile 1"}, "apn internet"); + f_vty_config2(VTY, {"hlr", "ps", "pdp-profiles default", "profile 2"}, "apn *"); + sl := f_gen_subs(); + f_start_handler_per_sub(refers(f_TC_gsup_ul_subscriber_data), sl); + + setverdict(pass); +} + /* Test only the VTY commands */ testcase TC_vty() runs on test_CT { var HlrSubscriber sub; @@ -1941,6 +2013,7 @@ execute( TC_gsup_sai_err_unknown_imsi() ); execute( TC_gsup_ul() ); execute( TC_gsup_ul_via_proxy() ); + execute( TC_gsup_ul_subscriber_data() ); execute( TC_vty() ); execute( TC_vty_msisdn_isd() ); execute( TC_gsup_purge_cs() ); diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn index 41181e8..032bd26 100644 --- a/library/GSUP_Types.ttcn +++ b/library/GSUP_Types.ttcn @@ -216,6 +216,7 @@ pdp_qos, tag = OSMO_GSUP_PDP_QOS_IE; pdp_type, tag = OSMO_GSUP_PDP_TYPE_IE; charg_char, tag = OSMO_GSUP_CHARG_CHAR_IE; + pdp_ctx_id, tag = OSMO_GSUP_PDP_CONTEXT_ID_IE; session_state, tag = OSMO_GSUP_SESSION_STATE_IE; session_id, tag = OSMO_GSUP_SESSION_ID_IE; ss_info, tag = OSMO_GSUP_SS_INFO_IE; @@ -272,6 +273,7 @@ GSUP_CnDomain cn_domain, /* PDP context + nested IEs */ GSUP_IEs pdp_info, + OCT1 pdp_ctx_id, octetstring apn, octetstring pdp_qos, OCT2 pdp_type, @@ -406,6 +408,23 @@ } } +template (value) GSUP_IE ts_GSUP_IE_PDP_CONTEXT_ID(OCT1 ctx_id) := { + tag := OSMO_GSUP_PDP_CONTEXT_ID_IE, + len := 0, + val := { + pdp_ctx_id := ctx_id + } +} + +template GSUP_IE tr_GSUP_IE_PDP_CONTEXT_ID(template OCT1 ctx_id) := { + tag := OSMO_GSUP_PDP_CONTEXT_ID_IE, + len := ?, + val := { + pdp_ctx_id := ctx_id + } +} + + template (value) GSUP_IE ts_GSUP_IE_PDP_TYPE(OCT2 pdp_type) := { tag := OSMO_GSUP_PDP_TYPE_IE, len := 0, @@ -764,6 +783,14 @@ } } +template GSUP_IE tr_GSUP_IE_APN(template octetstring apn) := { + tag := OSMO_GSUP_ACCESS_POINT_NAME_IE, + len := ?, + val := { + apn := apn + } +} + template GSUP_IE ts_GSUP_IE_CnDomain(template GSUP_CnDomain dom) := { tag := OSMO_GSUP_CN_DOMAIN_IE, len := 0, /* overwritten */ @@ -1689,6 +1716,21 @@ } ); +function f_gsup_find_nested_ie_multiple(GSUP_IEs ies, GSUP_IEI iei, integer nth, out GSUP_IeValue ret) return boolean { + var integer current := 0; + for (var integer i := 0; i < sizeof(ies); i := i+1) { + if (ies[i].tag == iei) { + if (current == nth) { + ret := ies[i].val; + return true; + } else { + current := current + 1; + } + } + } + return false; +} + function f_gsup_find_nested_ie(GSUP_IEs ies, GSUP_IEI iei, out GSUP_IeValue ret) return boolean { for (var integer i := 0; i < sizeof(ies); i := i+1) { if (ies[i].tag == iei) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d0c08272bc239370e800d6014ab9c68087b8989 Gerrit-Change-Number: 32510 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[L] Change in libosmo-gprs[master]: gmm, rlcmac: Properly handle P-TMSI vs TLLI

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32507 to look at the new patch set (#2). Change subject: gmm, rlcmac: Properly handle P-TMSI vs TLLI ...................................................................... gmm, rlcmac: Properly handle P-TMSI vs TLLI Change-Id: I44c95b3bc973b9dfcc79daf6b529fd2826f574e8 --- M include/osmocom/gprs/gmm/gmm_prim.h M include/osmocom/gprs/gmm/gmm_private.h M include/osmocom/gprs/rlcmac/rlcmac_prim.h M src/gmm/gmm.c M src/gmm/gmm_prim.c M src/rlcmac/rlcmac_prim.c M tests/gmm/Makefile.am M tests/gmm/gmm_prim_test.c M tests/gmm/gmm_prim_test.err M tests/gmm/gmm_prim_test.ok M tests/rlcmac/rlcmac_prim_test.c 11 files changed, 243 insertions(+), 90 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/07/32507/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/32507 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I44c95b3bc973b9dfcc79daf6b529fd2826f574e8 Gerrit-Change-Number: 32507 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[M] Change in osmo-bsc[master]: ctrl: Add penalty time control

by pespin

Attention is currently required from: matanp, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32498 ) Change subject: ctrl: Add penalty time control ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32498 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idfdd54dec72fb5f52eee22df018161d75b8c48c8 Gerrit-Change-Number: 32498 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 16:38:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[L] Change in osmo-mgw[master]: mgcp_codec: fix codec decision

by pespin

Attention is currently required from: neels, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32218 ) Change subject: mgcp_codec: fix codec decision ...................................................................... Patch Set 9: (2 comments) Patchset: PS9: It looks fine for me so far, let me know if I should join the discussion. File src/libosmo-mgcp/mgcp_codec.c: https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/e66f7fc6_5ff8ce2c PS9, Line 384: /* In case we weren't able to find an exact match, we will try to find a match that is the same codec, but the You can do early return here: codec_convertible = mgcp_codec_find_same(conn, codec); if (codec_convertible) return codec_convertible; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6c3291f825488e5d8ce136aeb18450156794aeb5 Gerrit-Change-Number: 32218 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 16:37:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmo-mgw[master]: mgcp_codec: move mgcp_codec_decide down

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32506 ) Change subject: mgcp_codec: move mgcp_codec_decide down ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32506 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2f2538ff912eae4d80d3b74b766e18c4da94d6b6 Gerrit-Change-Number: 32506 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 16:34:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-mgw[master]: mgcp_network: do not deliver RTP packets with unpatched PT

by pespin

Attention is currently required from: neels, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32290 ) Change subject: mgcp_network: do not deliver RTP packets with unpatched PT ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I013a24c1e0f853557257368cfab9192d4611aafa Gerrit-Change-Number: 32290 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 16:33:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023