April 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: trxcon: reduce DGPRS logging level to LOGL_NOTICE

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32517 ) Change subject: trxcon: reduce DGPRS logging level to LOGL_NOTICE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifccf8ccae2d9acc4039db46a87fa43f95a28e6ad Gerrit-Change-Number: 32517 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 18:24:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: trxcon: ignore TRXCON_EV_TX_DATA_CNF in TRXCON_ST_PACKET_DATA

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32516 ) Change subject: trxcon: ignore TRXCON_EV_TX_DATA_CNF in TRXCON_ST_PACKET_DATA ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie3c53ffbac1f1906cc97ef66eb74e24aee2cb2c4 Gerrit-Change-Number: 32516 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 18:24:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: trxcon: use non-blocking stderr logging by default

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32518 ) Change subject: trxcon: use non-blocking stderr logging by default ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8cbfd9b4644f8442cbedc7e452ba79816923fc10 Gerrit-Change-Number: 32518 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 18:24:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmo-hlr[master]: hlr: use talloc for memory allocation in osmo_gsup_create_insert_subs...

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/32511 ) Change subject: hlr: use talloc for memory allocation in osmo_gsup_create_insert_subscriber_data_msg ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: Can you point exactly where's the problem? afaict all the buffers being used are of known max size there? File src/gsup_server.c: https://gerrit.osmocom.org/c/osmo-hlr/+/32511/comment/b5902c30_a883e440 PS3, Line 455: void *talloc_ctx) why not using the "struct osmo_gsup_message *gsup" as a talloc_ctx? -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/32511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I00b5c2dfadcf6e0740e93b4c3292d2654d22e80c Gerrit-Change-Number: 32511 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 26 Apr 2023 18:23:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-bsc[master]: ctrl: Add cell reselection hysteresis control

by pespin

Attention is currently required from: matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32515 ) Change subject: ctrl: Add cell reselection hysteresis control ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: If you are planning to add several of those I think they should be added in some structured and planned way regarding naming. At least at some sort of "si" prefix or alike. Bear in mind once we release these commands we need to maintain them for backward compatibility, so please give it some thoughs. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia96f6656d99381c039a4b3fd02674215fbbaec91 Gerrit-Change-Number: 32515 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Wed, 26 Apr 2023 18:21:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: HLR_Tests: add testcase for multiple APNs in subscriber data

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510 ) Change subject: HLR_Tests: add testcase for multiple APNs in subscriber data ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510/comment/6c75a369_75e4… PS2, Line 543: boolean return_isd := false) this is really hacky, better provide it as an out variable. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d0c08272bc239370e800d6014ab9c68087b8989 Gerrit-Change-Number: 32510 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 26 Apr 2023 18:19:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in libosmo-sccp[master]: SCCP: implement variable limit on Optional Data (CR,CC,CREF,RLSD)

by lynxis lazus

lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32361 ) Change subject: SCCP: implement variable limit on Optional Data (CR,CC,CREF,RLSD) ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: I would like to have a `no sccp max-optional-data`. As we follow the cisco like vty, there should be a `no sccp max-optional-data` for this. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: If35697234796af8943691b2de62218e7dc93a08c Gerrit-Change-Number: 32361 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 26 Apr 2023 18:19:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: trxcon: ignore TRXCON_EV_TX_DATA_CNF in TRXCON_ST_PACKET_DATA

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32516 ) Change subject: trxcon: ignore TRXCON_EV_TX_DATA_CNF in TRXCON_ST_PACKET_DATA ...................................................................... trxcon: ignore TRXCON_EV_TX_DATA_CNF in TRXCON_ST_PACKET_DATA Change-Id: Ie3c53ffbac1f1906cc97ef66eb74e24aee2cb2c4 Related: OS#5500 --- M src/host/trxcon/src/trxcon_fsm.c M src/host/trxcon/src/trxcon_shim.c 2 files changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/16/32516/1 diff --git a/src/host/trxcon/src/trxcon_fsm.c b/src/host/trxcon/src/trxcon_fsm.c index 219f0c0..598f2bd 100644 --- a/src/host/trxcon/src/trxcon_fsm.c +++ b/src/host/trxcon/src/trxcon_fsm.c @@ -614,6 +614,8 @@ l1sched_reset(trxcon->sched, false); /* TODO: switch to (not implemented) TRXCON_ST_DCH_TUNING? */ break; + case TRXCON_EV_TX_DATA_CNF: + break; default: OSMO_ASSERT(0); } @@ -711,7 +713,8 @@ | S(TRXCON_EV_GPRS_UL_TBF_CFG_REQ) | S(TRXCON_EV_GPRS_DL_TBF_CFG_REQ) | S(TRXCON_EV_GPRS_UL_BLOCK_REQ) - | S(TRXCON_EV_RX_DATA_IND), + | S(TRXCON_EV_RX_DATA_IND) + | S(TRXCON_EV_TX_DATA_CNF), .onenter = &trxcon_st_packet_data_onenter, .onleave = &trxcon_st_packet_data_onleave, .action = &trxcon_st_packet_data_action, diff --git a/src/host/trxcon/src/trxcon_shim.c b/src/host/trxcon/src/trxcon_shim.c index 4f56d85..8b42efe 100644 --- a/src/host/trxcon/src/trxcon_shim.c +++ b/src/host/trxcon/src/trxcon_shim.c @@ -110,7 +110,6 @@ 0, 0, true); } - /* XXX: do not send for L1SCHED_DT_PACKET_DATA */ return osmo_fsm_inst_dispatch(trxcon->fi, TRXCON_EV_TX_DATA_CNF, &cnf); } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie3c53ffbac1f1906cc97ef66eb74e24aee2cb2c4 Gerrit-Change-Number: 32516 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: trxcon: use non-blocking stderr logging by default

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32518 ) Change subject: trxcon: use non-blocking stderr logging by default ...................................................................... trxcon: use non-blocking stderr logging by default The logging in trxcon is initialized by calling osmo_init_logging2(), which creates an stderr target in *blocking* mode. Blocking write()s may cause random burst scheduling delays (due to the whole process being stuck). This is not desired and becomes even more critical when operating in PS doman, which imposes strict timing requirements. trxcon does not have its own VTY interface yet, so there's currently no easy way to switch to non-blocking mode like in other osmo-apps. Let's enable it by default in trxcon_logging_init(). Change-Id: I8cbfd9b4644f8442cbedc7e452ba79816923fc10 Related: OS#5500 --- M src/host/trxcon/src/logging.c 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/18/32518/1 diff --git a/src/host/trxcon/src/logging.c b/src/host/trxcon/src/logging.c index b80f00d..e873045 100644 --- a/src/host/trxcon/src/logging.c +++ b/src/host/trxcon/src/logging.c @@ -92,6 +92,7 @@ int trxcon_logging_init(void *tall_ctx, const char *category_mask) { osmo_init_logging2(tall_ctx, &trxcon_log_info); + log_target_file_switch_to_wqueue(osmo_stderr_target); if (category_mask) log_parse_category_mask(osmo_stderr_target, category_mask); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8cbfd9b4644f8442cbedc7e452ba79816923fc10 Gerrit-Change-Number: 32518 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmocom-bb[master]: trxcon: reduce DGPRS logging level to LOGL_NOTICE

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32517 ) Change subject: trxcon: reduce DGPRS logging level to LOGL_NOTICE ...................................................................... trxcon: reduce DGPRS logging level to LOGL_NOTICE This was needed during early testing of l1gprs, but not anymore. Change-Id: Ifccf8ccae2d9acc4039db46a87fa43f95a28e6ad Related: OS#5500 --- M src/host/trxcon/src/logging.c 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/17/32517/1 diff --git a/src/host/trxcon/src/logging.c b/src/host/trxcon/src/logging.c index e94ad2d..b80f00d 100644 --- a/src/host/trxcon/src/logging.c +++ b/src/host/trxcon/src/logging.c @@ -71,7 +71,7 @@ .name = "DGPRS", .description = "L1 GPRS (MAC layer)", .color = "\033[1;36m", - .enabled = 1, .loglevel = LOGL_DEBUG, + .enabled = 1, .loglevel = LOGL_NOTICE, }, }; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifccf8ccae2d9acc4039db46a87fa43f95a28e6ad Gerrit-Change-Number: 32517 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023