April 2023 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo_dia2gsup[master]: Use GSUP APN as Service-Selection field

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32514 ) Change subject: Use GSUP APN as Service-Selection field ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/server_cb.erl: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32514/comment/41bef772_… PS1, Line 152: % 'Service-Selection' = "internet"%maps:get(access_point_name, GsupPdpInfo) so now we have 2 levels of line-comments. Because you know, erlang is not confusing enough ;) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I2a0af5d785ce62968f6e3952602d92cb4f37e4ab Gerrit-Change-Number: 32514 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 26 Apr 2023 18:18:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmo-hlr[master]: hlr: use talloc for memory allocation in osmo_gsup_create_insert_subs...

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/32511 to look at the new patch set (#3). Change subject: hlr: use talloc for memory allocation in osmo_gsup_create_insert_subscriber_data_msg ...................................................................... hlr: use talloc for memory allocation in osmo_gsup_create_insert_subscriber_data_msg Don't use static buffers for APN and MSISDN. When encoding multiple APNs the static buffer might be to small. In prepration to support multiple APNs in subscriber data Change-Id: I00b5c2dfadcf6e0740e93b4c3292d2654d22e80c --- M include/osmocom/hlr/gsup_server.h M src/gsup_server.c M src/hlr.c M src/lu_fsm.c 4 files changed, 38 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/11/32511/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/32511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I00b5c2dfadcf6e0740e93b4c3292d2654d22e80c Gerrit-Change-Number: 32511 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[M] Change in osmo-hlr[master]: hlr: use talloc for memory allocation in osmo_gsup_create_insert_subs...

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/32511 to look at the new patch set (#2). Change subject: hlr: use talloc for memory allocation in osmo_gsup_create_insert_subscriber_data_msg ...................................................................... hlr: use talloc for memory allocation in osmo_gsup_create_insert_subscriber_data_msg Don't use static buffers for APN and MSISDN. When encoding multiple APNs the static buffer might be to small. In prepration to support multiple APNs in subscriber data Change-Id: I00b5c2dfadcf6e0740e93b4c3292d2654d22e80c --- M include/osmocom/hlr/gsup_server.h M src/gsup_server.c M src/hlr.c M src/lu_fsm.c 4 files changed, 38 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/11/32511/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/32511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I00b5c2dfadcf6e0740e93b4c3292d2654d22e80c Gerrit-Change-Number: 32511 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-bsc[master]: ctrl: Add cell reselection hysteresis control

by matanp

matanp has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32515 ) Change subject: ctrl: Add cell reselection hysteresis control ...................................................................... ctrl: Add cell reselection hysteresis control Change-Id: Ia96f6656d99381c039a4b3fd02674215fbbaec91 --- M src/osmo-bsc/bts_ctrl.c 1 file changed, 47 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/15/32515/1 diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index 184a9c5..fdd08c1 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -797,6 +797,43 @@ CTRL_CMD_DEFINE(bts_penalty_time, "si3-penalty-time"); +static int verify_bts_cell_reselection_hysteresis(struct ctrl_cmd *cmd, const char *value, void *_data) +{ + const int cell_reselection_hysteresis = atoi(value); + + if (cell_reselection_hysteresis < 0 || cell_reselection_hysteresis > 14) { + cmd->reply = "Value is out of range"; + return 1; + } else if (cell_reselection_hysteresis % 2 != 0) { + cmd->reply = "Value must be even"; + return 1; + } + + return 0; +} + +static int get_bts_cell_reselection_hysteresis(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + + cmd->reply = talloc_asprintf(cmd, "%u", bts->si_common.cell_sel_par.cell_resel_hyst * 2); + if (!cmd->reply) { + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; + } + + return CTRL_CMD_REPLY; +} + +static int set_bts_cell_reselection_hysteresis(struct ctrl_cmd *cmd, void *data) +{ + struct gsm_bts *bts = cmd->node; + bts->si_common.cell_sel_par.cell_resel_hyst = atoi(cmd->value) / 2; + return CTRL_CMD_REPLY; +} + +CTRL_CMD_DEFINE(bts_cell_reselection_hysteresis, "cell-reselection-hysteresis"); + int bsc_bts_ctrl_cmds_install(void) { int rc = 0; @@ -821,6 +858,7 @@ rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_si2quater_neighbor_list_del_uarfcn); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_cell_reselection_offset); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_penalty_time); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_cell_reselection_hysteresis); rc |= neighbor_ident_ctrl_init(); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia96f6656d99381c039a4b3fd02674215fbbaec91 Gerrit-Change-Number: 32515 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: HLR_Tests: add testcase for multiple APNs in subscriber data

by lynxis lazus

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510 to look at the new patch set (#2). Change subject: HLR_Tests: add testcase for multiple APNs in subscriber data ...................................................................... HLR_Tests: add testcase for multiple APNs in subscriber data With a new HLR version there are multiple APN possible in the Subscriber Data (PDP Info). Related: SYS#6391 Change-Id: I8d0c08272bc239370e800d6014ab9c68087b8989 --- M hlr/HLR_Tests.ttcn M library/GSUP_Types.ttcn 2 files changed, 130 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/10/32510/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d0c08272bc239370e800d6014ab9c68087b8989 Gerrit-Change-Number: 32510 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Use GSUP APN as Service-Selection field

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32514 ) Change subject: Use GSUP APN as Service-Selection field ...................................................................... Use GSUP APN as Service-Selection field Previous the osmo-hlr always sent a wildcard APN as the only APN which violates the spec. Further wildcard APNs aren't support by the current Open5gs. Since I540132ee5dcfd09f4816e02e702927e1074ca50f the osmo-hlr supports multiple APN in the subscriber data. Related: SYS#6391 Change-Id: I2a0af5d785ce62968f6e3952602d92cb4f37e4ab --- M src/server_cb.erl 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/14/32514/1 diff --git a/src/server_cb.erl b/src/server_cb.erl index fc8e397..da807ef 100644 --- a/src/server_cb.erl +++ b/src/server_cb.erl @@ -149,7 +149,8 @@ 'Max-Requested-Bandwidth-DL' = 100000000}, % The default APN Configuration shall not contain the Wildcard APN (see 3GPP TS % 23.003 [3], clause 9.2); the default APN shall always contain an explicit APN - 'Service-Selection' = "internet"%maps:get(access_point_name, GsupPdpInfo) + % 'Service-Selection' = "internet"%maps:get(access_point_name, GsupPdpInfo) + 'Service-Selection' = maps:get(access_point_name, GsupPdpInfo) }. % transient (only in Experimental-Result-Code) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I2a0af5d785ce62968f6e3952602d92cb4f37e4ab Gerrit-Change-Number: 32514 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Allow to add APN wildcard via configuration

by lynxis lazus

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32513 ) Change subject: Allow to add APN wildcard via configuration ...................................................................... Abandoned superseed by https://gerrit.osmocom.org/q/topic:multiple-apns -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I5767cb3c4082809f2ac5a4361a4758b54f24ad48 Gerrit-Change-Number: 32513 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-MessageType: abandon

2 years, 2 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Allow to add APN wildcard via configuration

by lynxis lazus

lynxis lazus has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32513 ) Change subject: Allow to add APN wildcard via configuration ...................................................................... Allow to add APN wildcard via configuration If the osmo-hlr doesn't send a default APN but it is required. Set application environment append_default_apn to "true". See the example sys.config. Change-Id: I5767cb3c4082809f2ac5a4361a4758b54f24ad48 --- M examples/sys.config M src/server_cb.erl 2 files changed, 42 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/13/32513/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I5767cb3c4082809f2ac5a4361a4758b54f24ad48 Gerrit-Change-Number: 32513 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Allow to add APN wildcard via configuration

by lynxis lazus

lynxis lazus has restored this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32513 ) Change subject: Allow to add APN wildcard via configuration ...................................................................... Restored -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I5767cb3c4082809f2ac5a4361a4758b54f24ad48 Gerrit-Change-Number: 32513 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-MessageType: restore

2 years, 2 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Allow to add APN wildcard via configuration

by lynxis lazus

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32513 ) Change subject: Allow to add APN wildcard via configuration ...................................................................... Abandoned superseed by https://gerrit.osmocom.org/q/topic:multiple-apns -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/32513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I5767cb3c4082809f2ac5a4361a4758b54f24ad48 Gerrit-Change-Number: 32513 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-MessageType: abandon

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023