March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcu[master]: Makefile.am: remove phy specific EXTRA_DIST variables
by fixeria 09 Mar '23

09 Mar '23

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31816 ) Change subject: Makefile.am: remove phy specific EXTRA_DIST variables ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31816 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If8b9b8cfaad22a093a74c418651bc76f48f2d071 Gerrit-Change-Number: 31816 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 20:41:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: pcu_l1_if: do not copy IMSI when it is NULL
by fixeria 09 Mar '23

09 Mar '23

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31737 ) Change subject: pcu_l1_if: do not copy IMSI when it is NULL ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31737 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9192d50dd78be0a72ffdb9bfb9ed66aef085bcf1 Gerrit-Change-Number: 31737 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 20:36:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: doc: add sample config to illustrate how to use an E1 CCU
by fixeria 09 Mar '23

09 Mar '23

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31736 ) Change subject: doc: add sample config to illustrate how to use an E1 CCU ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31736 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I1fd0bb6b0c3fe031d5241355c66b01b6ca45b1de Gerrit-Change-Number: 31736 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 20:36:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-pcu[master]: pcu_l1_if: get rid of strange paging group calculation
by fixeria 09 Mar '23

09 Mar '23

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31650 ) Change subject: pcu_l1_if: get rid of strange paging group calculation ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I40d7fc14c9591b3de091e425faaf325421c70a0e Gerrit-Change-Number: 31650 Gerrit-PatchSet: 13 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 20:35:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in osmo-pcu[master]: support for Ericsson RBS E1 CCU
by fixeria 09 Mar '23

09 Mar '23

Attention is currently required from: neels, laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31176 ) Change subject: support for Ericsson RBS E1 CCU ...................................................................... Patch Set 32: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5c0a76667339ca984a12cbd2052f5d9e5b0f9c4d Gerrit-Change-Number: 31176 Gerrit-PatchSet: 32 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 20:31:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: Makefile.am: remove phy specific EXTRA_DIST variables
by dexter 09 Mar '23

09 Mar '23

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31816 ) Change subject: Makefile.am: remove phy specific EXTRA_DIST variables ...................................................................... Makefile.am: remove phy specific EXTRA_DIST variables EXTRA_DIST should only list files that are not source, but should be distributed anyway. Listing the source files in _HEADERS and _SOURCES should be sufficient Change-Id: If8b9b8cfaad22a093a74c418651bc76f48f2d071 --- M src/Makefile.am 1 file changed, 13 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/16/31816/1 diff --git a/src/Makefile.am b/src/Makefile.am index e747d74..d8cf42d 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -134,13 +134,6 @@ if ENABLE_SYSMODSP AM_CPPFLAGS += -I$(srcdir)/osmo-bts-sysmo -I$(SYSMOBTS_INCDIR) -EXTRA_DIST = \ - osmo-bts-sysmo/sysmo_l1_if.c \ - osmo-bts-sysmo/sysmo_l1_if.h \ - osmo-bts-sysmo/sysmo_l1_hw.c \ - osmo-bts-sysmo/femtobts.c \ - osmo-bts-sysmo/femtobts.h - noinst_HEADERS += \ osmo-bts-sysmo/sysmo_l1_if.h \ osmo-bts-sysmo/femtobts.h @@ -171,13 +164,6 @@ if ENABLE_LC15BTS_PHY AM_CPPFLAGS += $(LITECELL15_CFLAGS) -I$(srcdir)/osmo-bts-litecell15 -EXTRA_DIST = \ - osmo-bts-litecell15/lc15_l1_if.c \ - osmo-bts-litecell15/lc15_l1_if.h \ - osmo-bts-litecell15/lc15_l1_hw.c \ - osmo-bts-litecell15/lc15bts.c \ - osmo-bts-litecell15/lc15bts.h - noinst_HEADERS += \ osmo-bts-litecell15/lc15_l1_if.h \ osmo-bts-litecell15/lc15bts.h @@ -191,13 +177,6 @@ if ENABLE_OC2GBTS_PHY AM_CPPFLAGS += -I$(OC2G_INCDIR) -I$(srcdir)/osmo-bts-oc2g -EXTRA_DIST = \ - osmo-bts-oc2g/oc2g_l1_if.c \ - osmo-bts-oc2g/oc2g_l1_if.h \ - osmo-bts-oc2g/oc2g_l1_hw.c \ - osmo-bts-oc2g/oc2gbts.c \ - osmo-bts-oc2g/oc2gbts.h - noinst_HEADERS += \ osmo-bts-oc2g/oc2g_l1_if.h \ osmo-bts-oc2g/oc2gbts.h -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31816 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If8b9b8cfaad22a093a74c418651bc76f48f2d071 Gerrit-Change-Number: 31816 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: SimCardCommands.run_gsm(): use send_apdu_checksw()
by laforge 09 Mar '23

09 Mar '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31814 ) Change subject: SimCardCommands.run_gsm(): use send_apdu_checksw() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31814 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib713cf8154a3aba72bc5776a8d99ec47631ade28 Gerrit-Change-Number: 31814 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 18:52:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: fix SimCardCommands.run_gsm(): always use CLA=0xa0
by laforge 09 Mar '23

09 Mar '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31813 ) Change subject: fix SimCardCommands.run_gsm(): always use CLA=0xa0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia0abba136dbd4cdea8dbbc3c4d6abe12c2863680 Gerrit-Change-Number: 31813 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 18:52:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: pySim-shell.py: add a command for RUN GSM ALGORITHM
by laforge 09 Mar '23

09 Mar '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31815 ) Change subject: pySim-shell.py: add a command for RUN GSM ALGORITHM ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: this is a different implementation from vadim's patch. The latter added it to ISO7816Commands, which is wrong. The command is specific to the SIM application. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31815 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id7876d83d018aca79253784411d3a9d54a249a0a Gerrit-Change-Number: 31815 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 09 Mar 2023 18:52:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: SimCardCommands.run_gsm(): use send_apdu_checksw()
by laforge 09 Mar '23

09 Mar '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31814 ) Change subject: SimCardCommands.run_gsm(): use send_apdu_checksw() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: found this in a branch that was unfortunately never submitted -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31814 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib713cf8154a3aba72bc5776a8d99ec47631ade28 Gerrit-Change-Number: 31814 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 18:51:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0