March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: gprsdecode: Makefile.am: drop -Wno-missing-braces and -O3
by fixeria 12 Mar '23

12 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31853 ) Change subject: gprsdecode: Makefile.am: drop -Wno-missing-braces and -O3 ...................................................................... gprsdecode: Makefile.am: drop -Wno-missing-braces and -O3 Do not hard-code these CFLAGs, let the user decide on them. Change-Id: I3a946b853029cc4cff9c2b15aa7339f84b2cb6c9 --- M src/host/gprsdecode/Makefile.am 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/53/31853/1 diff --git a/src/host/gprsdecode/Makefile.am b/src/host/gprsdecode/Makefile.am index 542d54b..b5c8b12 100644 --- a/src/host/gprsdecode/Makefile.am +++ b/src/host/gprsdecode/Makefile.am @@ -6,8 +6,7 @@ $(NULL) AM_CFLAGS = \ - -Wall -O3 \ - -Wno-missing-braces \ + -Wall \ $(LIBOSMOGSM_CFLAGS) \ $(LIBOSMOCORE_CFLAGS) \ $(LIBOSMOCODING_CFLAGS) \ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31853 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3a946b853029cc4cff9c2b15aa7339f84b2cb6c9 Gerrit-Change-Number: 31853 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-trx[master]: tests: LMSDeviceTest: fix CPPFLAGS vs CXXFLAGS
by msuraev 12 Mar '23

12 Mar '23

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/31843 ) Change subject: tests: LMSDeviceTest: fix CPPFLAGS vs CXXFLAGS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/31843 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I82fc1eb6796f5289f0feff7bee5264bfacd6e733 Gerrit-Change-Number: 31843 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Mar 2023 19:57:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: tests: move '-I$(top_srcdir)/include/' to AM_CPPFLAGS
by msuraev 12 Mar '23

12 Mar '23

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31773 ) Change subject: tests: move '-I$(top_srcdir)/include/' to AM_CPPFLAGS ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: That looks like a nice potential addition to the linter. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31773 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic3e3dc75789850d2884d3e757f05ff01e136a5f4 Gerrit-Change-Number: 31773 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Mar 2023 19:55:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-gprs[master]: {rlcmac,llc,sndcp}: AM_LDFLAGS shall not contain *_LIBS
by msuraev 12 Mar '23

12 Mar '23

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31772 ) Change subject: {rlcmac,llc,sndcp}: AM_LDFLAGS shall not contain *_LIBS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31772 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ib211c37419a8c6a0bdfc202f6f91b255cc8420e2 Gerrit-Change-Number: 31772 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Mar 2023 19:53:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-sgsn[master]: tests: use -no-install libtool flag to avoid ./lt-* scripts
by msuraev 12 Mar '23

12 Mar '23

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/31839 ) Change subject: tests: use -no-install libtool flag to avoid ./lt-* scripts ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/31839 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8af6a38d7abbf06aa8268981c80c3bfda2f80a27 Gerrit-Change-Number: 31839 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Mar 2023 19:52:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: tests/Makefile.am: do not overwrite global LDFLAGS
by msuraev 12 Mar '23

12 Mar '23

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31838 ) Change subject: tests/Makefile.am: do not overwrite global LDFLAGS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31838 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I926df1918fd24ea7be4b390d168a8c76ef9931c0 Gerrit-Change-Number: 31838 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Mar 2023 19:50:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: {src,tests}/Makefile.am: libraries shall not be in AM_LDFLAGS
by msuraev 12 Mar '23

12 Mar '23

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31788 ) Change subject: {src,tests}/Makefile.am: libraries shall not be in AM_LDFLAGS ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibd7eb55e2cfe7daed2f8a8d74c6a3ede6f29308f Gerrit-Change-Number: 31788 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Mar 2023 19:50:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hlr[master]: tests/*/Makefile.am: move -I to AM_CPPFLAGS
by msuraev 12 Mar '23

12 Mar '23

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31785 ) Change subject: tests/*/Makefile.am: move -I to AM_CPPFLAGS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I654053e11b0cc824c198f68e4ff0a0fcb295efb0 Gerrit-Change-Number: 31785 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Mar 2023 19:48:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hlr[master]: tests/auc/Makefile.am: put object files to LDADD
by msuraev 12 Mar '23

12 Mar '23

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31784 ) Change subject: tests/auc/Makefile.am: put object files to LDADD ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/31784 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Iaefcfe7a8904841a29094fe40eb5850912544b4c Gerrit-Change-Number: 31784 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Mar 2023 19:46:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: tests/Makefile.am: clean up AM_* variables
by msuraev 12 Mar '23

12 Mar '23

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/31776 ) Change subject: tests/Makefile.am: clean up AM_* variables ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/31776 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ice892f848e06b601e67b06a4e1e25c11fb7c4128 Gerrit-Change-Number: 31776 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Mar 2023 19:45:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0