March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: virt_phy: avoid confusion between RSSI (dBm) and RxLev (0..63)
by msuraev 12 Mar '23

12 Mar '23

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31850 ) Change subject: virt_phy: avoid confusion between RSSI (dBm) and RxLev (0..63) ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31850 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4f2982cd8fa1b7a47f983c9cd11bf0180f7878ec Gerrit-Change-Number: 31850 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Mar 2023 19:26:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: virt_phy: cosmetic: make the linter happy about identifier names
by msuraev 12 Mar '23

12 Mar '23

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31852 ) Change subject: virt_phy: cosmetic: make the linter happy about identifier names ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31852 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I415f4b6f65c16a5dac84c75c5f97bf12109c74e5 Gerrit-Change-Number: 31852 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Mar 2023 19:24:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: virt_phy: cosmetic: make the linter happy about code indent
by msuraev 12 Mar '23

12 Mar '23

Attention is currently required from: fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31851 ) Change subject: virt_phy: cosmetic: make the linter happy about code indent ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31851 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iba777a4aff261006ae1aec9b583fecd12295c837 Gerrit-Change-Number: 31851 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Mar 2023 19:24:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: logging: Unregister osmo_fd before closing fd
by pespin 12 Mar '23

12 Mar '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31804 ) Change subject: logging: Unregister osmo_fd before closing fd ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > @pespin: can you explain why calling `osmo_fd_unregister()` after `close()` is wrong? AFAIU, because […] The problem is not "closing" the socket per se, but modifying the "fd" field of an osmo_fd which is registered (here setting it to -1). That was already not expected by the implementation of the API before, but it was simply not checked and assumed to be done correctly by the user of te osmo_fd API. Since recently we dediced to enforce this behavior through an assert instead of having unexpected behaviors. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31804 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0754ac3110b63d2a380068010830af6c85b0a653 Gerrit-Change-Number: 31804 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Mar 2023 19:07:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[XL] Change in osmocom-bb[master]: {trxcon,virt_phy}: shared GPRS L1 (MAC) implementation
by fixeria 12 Mar '23

12 Mar '23

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30743 to look at the new patch set (#9). Change subject: {trxcon,virt_phy}: shared GPRS L1 (MAC) implementation ...................................................................... {trxcon,virt_phy}: shared GPRS L1 (MAC) implementation Change-Id: I9567d64f9d00262e36147e8d7e541e5e246bda5f Related: OS#5500 --- M include/l1ctl_proto.h A include/l1gprs.h M src/host/trxcon/include/osmocom/bb/Makefile.am A src/host/trxcon/include/osmocom/bb/l1gprs.h M src/host/trxcon/include/osmocom/bb/trxcon/logging.h M src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h M src/host/trxcon/include/osmocom/bb/trxcon/trxcon_fsm.h M src/host/trxcon/src/Makefile.am M src/host/trxcon/src/l1ctl.c A src/host/trxcon/src/l1gprs.c M src/host/trxcon/src/logging.c M src/host/trxcon/src/trxcon_fsm.c M src/host/trxcon/src/trxcon_inst.c M src/host/virt_phy/include/osmocom/bb/Makefile.am A src/host/virt_phy/include/osmocom/bb/l1gprs.h M src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h M src/host/virt_phy/include/osmocom/bb/virtphy/logging.h M src/host/virt_phy/include/osmocom/bb/virtphy/virt_l1_model.h M src/host/virt_phy/src/Makefile.am M src/host/virt_phy/src/gsmtapl1_if.c M src/host/virt_phy/src/l1ctl_sap.c A src/host/virt_phy/src/l1gprs.c M src/host/virt_phy/src/logging.c A src/host/virt_phy/src/virt_prim_pdch.c M src/host/virt_phy/src/virtphy.c A src/shared/l1gprs.c 26 files changed, 793 insertions(+), 282 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/43/30743/9 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9567d64f9d00262e36147e8d7e541e5e246bda5f Gerrit-Change-Number: 30743 Gerrit-PatchSet: 9 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmocom-bb[master]: virt_phy: avoid confusion between RSSI (dBm) and RxLev (0..63)
by fixeria 12 Mar '23

12 Mar '23

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/31850 to look at the new patch set (#3). Change subject: virt_phy: avoid confusion between RSSI (dBm) and RxLev (0..63) ...................................................................... virt_phy: avoid confusion between RSSI (dBm) and RxLev (0..63) Change-Id: I4f2982cd8fa1b7a47f983c9cd11bf0180f7878ec Related: OS#5500 --- M src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h M src/host/virt_phy/src/gsmtapl1_if.c M src/host/virt_phy/src/virt_prim_data.c M src/host/virt_phy/src/virt_prim_traffic.c 4 files changed, 22 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/50/31850/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31850 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4f2982cd8fa1b7a47f983c9cd11bf0180f7878ec Gerrit-Change-Number: 31850 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmocom-bb[master]: virt_phy: cosmetic: make the linter happy about code indent
by fixeria 12 Mar '23

12 Mar '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/31851 to look at the new patch set (#2). Change subject: virt_phy: cosmetic: make the linter happy about code indent ...................................................................... virt_phy: cosmetic: make the linter happy about code indent Change-Id: Iba777a4aff261006ae1aec9b583fecd12295c837 Related: OS#5500 --- M src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h M src/host/virt_phy/src/logging.c M src/host/virt_phy/src/virt_prim_data.c 3 files changed, 56 insertions(+), 46 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/51/31851/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31851 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iba777a4aff261006ae1aec9b583fecd12295c837 Gerrit-Change-Number: 31851 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[M] Change in osmocom-bb[master]: virt_phy: cosmetic: make the linter happy about identifier names
by fixeria 12 Mar '23

12 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31852 ) Change subject: virt_phy: cosmetic: make the linter happy about identifier names ...................................................................... virt_phy: cosmetic: make the linter happy about identifier names Change-Id: I415f4b6f65c16a5dac84c75c5f97bf12109c74e5 Related: OS#5500 --- M src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h 1 file changed, 35 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/52/31852/1 diff --git a/src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h b/src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h index 1a61f29..e77de84 100644 --- a/src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h +++ b/src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h @@ -42,39 +42,39 @@ uint16_t arfcn); /* receive routines */ -void l1ctl_rx_fbsb_req(struct l1_model_ms *, struct msgb *msg); -void l1ctl_rx_dm_est_req(struct l1_model_ms *, struct msgb *msg); -void l1ctl_rx_dm_rel_req(struct l1_model_ms *, struct msgb *msg); -void l1ctl_rx_param_req(struct l1_model_ms *, struct msgb *msg); -void l1ctl_rx_dm_freq_req(struct l1_model_ms *, struct msgb *msg); -void l1ctl_rx_crypto_req(struct l1_model_ms *, struct msgb *msg); -void l1ctl_rx_rach_req(struct l1_model_ms *, struct msgb *msg); -void l1ctl_rx_data_req(struct l1_model_ms *, struct msgb *msg); -void l1ctl_rx_pm_req(struct l1_model_ms *, struct msgb *msg); -void l1ctl_rx_reset_req(struct l1_model_ms *, struct msgb *msg); -void l1ctl_rx_ccch_mode_req(struct l1_model_ms *, struct msgb *msg); -void l1ctl_rx_tch_mode_req(struct l1_model_ms *, struct msgb *msg); -void l1ctl_rx_neigh_pm_req(struct l1_model_ms *, struct msgb *msg); -void l1ctl_rx_traffic_req(struct l1_model_ms *, struct msgb *msg); -void l1ctl_rx_sim_req(struct l1_model_ms *, struct msgb *msg); +void l1ctl_rx_fbsb_req(struct l1_model_ms *ms, struct msgb *msg); +void l1ctl_rx_dm_est_req(struct l1_model_ms *ms, struct msgb *msg); +void l1ctl_rx_dm_rel_req(struct l1_model_ms *ms, struct msgb *msg); +void l1ctl_rx_param_req(struct l1_model_ms *ms, struct msgb *msg); +void l1ctl_rx_dm_freq_req(struct l1_model_ms *ms, struct msgb *msg); +void l1ctl_rx_crypto_req(struct l1_model_ms *ms, struct msgb *msg); +void l1ctl_rx_rach_req(struct l1_model_ms *ms, struct msgb *msg); +void l1ctl_rx_data_req(struct l1_model_ms *ms, struct msgb *msg); +void l1ctl_rx_pm_req(struct l1_model_ms *ms, struct msgb *msg); +void l1ctl_rx_reset_req(struct l1_model_ms *ms, struct msgb *msg); +void l1ctl_rx_ccch_mode_req(struct l1_model_ms *ms, struct msgb *msg); +void l1ctl_rx_tch_mode_req(struct l1_model_ms *ms, struct msgb *msg); +void l1ctl_rx_neigh_pm_req(struct l1_model_ms *ms, struct msgb *msg); +void l1ctl_rx_traffic_req(struct l1_model_ms *ms, struct msgb *msg); +void l1ctl_rx_sim_req(struct l1_model_ms *ms, struct msgb *msg); /* transmit routines */ -void l1ctl_tx_reset(struct l1_model_ms *, uint8_t msg_type, uint8_t reset_type); -void l1ctl_tx_rach_conf(struct l1_model_ms *, uint32_t fn, uint16_t arfcn); -void l1ctl_tx_data_conf(struct l1_model_ms *, uint32_t fn, uint16_t snr, uint16_t arfcn); -void l1ctl_tx_data_ind(struct l1_model_ms *, struct msgb *msg, uint16_t arfcn, uint8_t link_id, +void l1ctl_tx_reset(struct l1_model_ms *ms, uint8_t msg_type, uint8_t reset_type); +void l1ctl_tx_rach_conf(struct l1_model_ms *ms, uint32_t fn, uint16_t arfcn); +void l1ctl_tx_data_conf(struct l1_model_ms *ms, uint32_t fn, uint16_t snr, uint16_t arfcn); +void l1ctl_tx_data_ind(struct l1_model_ms *ms, struct msgb *msg, uint16_t arfcn, uint8_t link_id, uint8_t chan_nr, uint32_t fn, uint8_t snr, uint8_t signal_dbm, uint8_t num_biterr, uint8_t fire_crc); -void l1ctl_tx_traffic_conf(struct l1_model_ms *, uint32_t fn, uint16_t snr, uint16_t arfcn); -void l1ctl_tx_traffic_ind(struct l1_model_ms *, struct msgb *msg, uint16_t arfcn, uint8_t link_id, +void l1ctl_tx_traffic_conf(struct l1_model_ms *ms, uint32_t fn, uint16_t snr, uint16_t arfcn); +void l1ctl_tx_traffic_ind(struct l1_model_ms *ms, struct msgb *msg, uint16_t arfcn, uint8_t link_id, uint8_t chan_nr, uint32_t fn, uint8_t snr, uint8_t signal_dbm, uint8_t num_biterr, uint8_t fire_crc); -void l1ctl_tx_pm_conf(struct l1_model_ms *, struct l1ctl_pm_req *pm_req); -void l1ctl_tx_fbsb_conf(struct l1_model_ms *, uint8_t res, uint16_t arfcn); -void l1ctl_tx_ccch_mode_conf(struct l1_model_ms *, uint8_t ccch_mode); -void l1ctl_tx_tch_mode_conf(struct l1_model_ms *, uint8_t tch_mode, uint8_t audio_mode); +void l1ctl_tx_pm_conf(struct l1_model_ms *ms, struct l1ctl_pm_req *pm_req); +void l1ctl_tx_fbsb_conf(struct l1_model_ms *ms, uint8_t res, uint16_t arfcn); +void l1ctl_tx_ccch_mode_conf(struct l1_model_ms *ms, uint8_t ccch_mode); +void l1ctl_tx_tch_mode_conf(struct l1_model_ms *ms, uint8_t tch_mode, uint8_t audio_mode); /* scheduler functions */ uint32_t sched_fn_ul(struct gsm_time cur_time, uint8_t chan_nr, -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31852 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I415f4b6f65c16a5dac84c75c5f97bf12109c74e5 Gerrit-Change-Number: 31852 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[XL] Change in osmocom-bb[master]: {trxcon,virt_phy}: shared GPRS L1 (MAC) implementation
by Jenkins Builder 12 Mar '23

12 Mar '23

Attention is currently required from: fixeria. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30743 ) Change subject: {trxcon,virt_phy}: shared GPRS L1 (MAC) implementation ...................................................................... Patch Set 8: (3 comments) File src/host/virt_phy/include/osmocom/bb/virtphy/l1ctl_sap.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5004): https://gerrit.osmocom.org/c/osmocom-bb/+/30743/comment/c6939c90_80d72c04 PS8, Line 60: void l1ctl_rx_gprs_uldl_tbf_cfg_req(struct l1_model_ms *, struct msgb *msg); function definition argument 'struct l1_model_ms *' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5004): https://gerrit.osmocom.org/c/osmocom-bb/+/30743/comment/1acbed58_97237a8a PS8, Line 61: void l1ctl_rx_gprs_ul_block_req(struct l1_model_ms *, struct msgb *msg); function definition argument 'struct l1_model_ms *' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5004): https://gerrit.osmocom.org/c/osmocom-bb/+/30743/comment/233b4dd1_3512e22c PS8, Line 80: void l1ctl_tx_gprs_dl_block_ind(struct l1_model_ms *, const struct msgb *msg, function definition argument 'struct l1_model_ms *' should also have an identifier name -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9567d64f9d00262e36147e8d7e541e5e246bda5f Gerrit-Change-Number: 30743 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Mar 2023 12:18:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: virt_phy: avoid confusion between RSSI (dBm) and RxLev (0..63)
by Jenkins Builder 12 Mar '23

12 Mar '23

Attention is currently required from: fixeria. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31850 ) Change subject: virt_phy: avoid confusion between RSSI (dBm) and RxLev (0..63) ...................................................................... Patch Set 2: (2 comments) File src/host/virt_phy/src/virt_prim_data.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5003): https://gerrit.osmocom.org/c/osmocom-bb/+/31850/comment/cbbbd7a2_b0af730b PS2, Line 81: uint8_t rxlev, uint8_t num_biterr, uint8_t fire_crc) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5003): https://gerrit.osmocom.org/c/osmocom-bb/+/31850/comment/c8fd4528_f8e5db8c PS2, Line 81: uint8_t rxlev, uint8_t num_biterr, uint8_t fire_crc) please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31850 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4f2982cd8fa1b7a47f983c9cd11bf0180f7878ec Gerrit-Change-Number: 31850 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 Mar 2023 12:18:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0