March 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-pfcp[master]: libosmo-gtlv/Makefile.am: drop unused AM_LDFLAGS
by fixeria 10 Mar '23

10 Mar '23

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31762 ) Change subject: libosmo-gtlv/Makefile.am: drop unused AM_LDFLAGS ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/libosmo-gtlv/Makefile.am: https://gerrit.osmocom.org/c/libosmo-pfcp/+/31762/comment/4968b305_2fc2b87e PS1, Line 14: LIBOSMOCORE_LIBS I think you still want `libosmo-gtlv.la` to depend on libosmocore, right? If so, you should move `$(LIBOSMOCORE_LIBS)` to `libosmo_gtlv_la_LIBADD` (not `LDFLAGS`!). -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I6fd777bed9366c35f5b1453cde1e6f5c1617e338 Gerrit-Change-Number: 31762 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Mar 2023 22:45:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: tests: LMSDeviceTest: fix CPPFLAGS vs CXXFLAGS
by fixeria 10 Mar '23

10 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/31843 ) Change subject: tests: LMSDeviceTest: fix CPPFLAGS vs CXXFLAGS ...................................................................... tests: LMSDeviceTest: fix CPPFLAGS vs CXXFLAGS * AM_CPPFLAGS is for preprocessor flags like '-I' or '-D', * AM_CXXFLAGS is for C++ compiler flags like '-Wall'. Change-Id: I82fc1eb6796f5289f0feff7bee5264bfacd6e733 --- M tests/Transceiver52M/Makefile.am 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/43/31843/1 diff --git a/tests/Transceiver52M/Makefile.am b/tests/Transceiver52M/Makefile.am index a5b91f6..473cec6 100644 --- a/tests/Transceiver52M/Makefile.am +++ b/tests/Transceiver52M/Makefile.am @@ -33,5 +33,5 @@ $(COMMON_LA) \ $(LMS_LIBS) \ $(NULL) -LMSDeviceTest_CPPFLAGS = $(AM_CPPFLAGS) $(LMS_CFLAGS) +LMSDeviceTest_CXXFLAGS = $(AM_CFLAGS) $(LMS_CFLAGS) endif -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/31843 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I82fc1eb6796f5289f0feff7bee5264bfacd6e733 Gerrit-Change-Number: 31843 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-trx[master]: tests: use -no-install libtool flag to avoid ./lt-* scripts
by fixeria 10 Mar '23

10 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/31842 ) Change subject: tests: use -no-install libtool flag to avoid ./lt-* scripts ...................................................................... tests: use -no-install libtool flag to avoid ./lt-* scripts This option should be used for any executables which are used only for testing, or for generating other files and are consequently never installed. By specifying this option, we are telling Libtool that the executable it links will only ever be executed from where it is built in the build tree. Libtool is usually able to considerably speed up the link process for such executables. Change-Id: Ieb4ddc5799819c24ed357218c7b0197bcb6b5c91 --- M tests/CommonLibs/Makefile.am M tests/Transceiver52M/Makefile.am 2 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/42/31842/1 diff --git a/tests/CommonLibs/Makefile.am b/tests/CommonLibs/Makefile.am index 1a5b922..cfdbc58 100644 --- a/tests/CommonLibs/Makefile.am +++ b/tests/CommonLibs/Makefile.am @@ -12,6 +12,8 @@ $(LIBOSMOVTY_CFLAGS) \ $(NULL) +AM_LDFLAGS = -no-install + LDADD = \ $(COMMON_LA) \ $(LIBOSMOCORE_LIBS) \ diff --git a/tests/Transceiver52M/Makefile.am b/tests/Transceiver52M/Makefile.am index 2077c95..a5b91f6 100644 --- a/tests/Transceiver52M/Makefile.am +++ b/tests/Transceiver52M/Makefile.am @@ -7,6 +7,7 @@ $(NULL) AM_CFLAGS = -Wall -g +AM_LDFLAGS = -no-install EXTRA_DIST = convolve_test.ok convolve_test_golden.h -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/31842 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ieb4ddc5799819c24ed357218c7b0197bcb6b5c91 Gerrit-Change-Number: 31842 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-trx[master]: tests: Makefile.am: move -I flags from AM_CFLAGS to AM_CPPFLAGS
by fixeria 10 Mar '23

10 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/31840 ) Change subject: tests: Makefile.am: move -I flags from AM_CFLAGS to AM_CPPFLAGS ...................................................................... tests: Makefile.am: move -I flags from AM_CFLAGS to AM_CPPFLAGS * AM_CPPFLAGS is for preprocessor flags like '-I' or '-D', * AM_CFLAGS is for C (not C++!) compiler flags like '-Wall'. * AM_CXXFLAGS is for C++ specific compiler flags like '-Wall'. By having the preprocessor flags in the proper variable we make sure that they apply to both *.c and *.cpp files. Change-Id: I7b3504a01e3350834b35c42d8d76d5d88d84a4b9 --- M tests/CommonLibs/Makefile.am M tests/Transceiver52M/Makefile.am 2 files changed, 35 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/40/31840/1 diff --git a/tests/CommonLibs/Makefile.am b/tests/CommonLibs/Makefile.am index e6790e6..941badb 100644 --- a/tests/CommonLibs/Makefile.am +++ b/tests/CommonLibs/Makefile.am @@ -1,6 +1,17 @@ include $(top_srcdir)/Makefile.common -AM_CPPFLAGS = -Wall -I$(top_srcdir)/CommonLibs $(STD_DEFINES_AND_INCLUDES) $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) -g +AM_CPPFLAGS = \ + -I$(top_srcdir)/CommonLibs \ + $(STD_DEFINES_AND_INCLUDES) \ + $(NULL) + +AM_CXXFLAGS = \ + -Wall -g \ + $(LIBOSMOCORE_CFLAGS) \ + $(LIBOSMOCTRL_CFLAGS) \ + $(LIBOSMOVTY_CFLAGS) \ + $(NULL) + AM_LDFLAGS = $(LIBOSMOCORE_LIBS) $(LIBOSMOCTRL_LIBS) $(LIBOSMOVTY_LIBS) EXTRA_DIST = BitVectorTest.ok \ diff --git a/tests/Transceiver52M/Makefile.am b/tests/Transceiver52M/Makefile.am index 9fae41f..cb22c2a 100644 --- a/tests/Transceiver52M/Makefile.am +++ b/tests/Transceiver52M/Makefile.am @@ -1,6 +1,12 @@ include $(top_srcdir)/Makefile.common -AM_CFLAGS = -Wall -I$(top_srcdir)/Transceiver52M -I$(top_srcdir)/Transceiver52M/arch/common $(STD_DEFINES_AND_INCLUDES) -g +AM_CPPFLAGS = \ + -I$(top_srcdir)/Transceiver52M \ + -I$(top_srcdir)/Transceiver52M/arch/common \ + $(STD_DEFINES_AND_INCLUDES) \ + $(NULL) + +AM_CFLAGS = -Wall -g EXTRA_DIST = convolve_test.ok convolve_test_golden.h -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/31840 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7b3504a01e3350834b35c42d8d76d5d88d84a4b9 Gerrit-Change-Number: 31840 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-trx[master]: tests: there shall be no libraries in LDFLAGS
by fixeria 10 Mar '23

10 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/31841 ) Change subject: tests: there shall be no libraries in LDFLAGS ...................................................................... tests: there shall be no libraries in LDFLAGS Change-Id: I95b07b5a7735fb2753281555a4544f1ba967579e --- M tests/CommonLibs/Makefile.am M tests/Transceiver52M/Makefile.am 2 files changed, 19 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/41/31841/1 diff --git a/tests/CommonLibs/Makefile.am b/tests/CommonLibs/Makefile.am index 941badb..1a5b922 100644 --- a/tests/CommonLibs/Makefile.am +++ b/tests/CommonLibs/Makefile.am @@ -12,7 +12,12 @@ $(LIBOSMOVTY_CFLAGS) \ $(NULL) -AM_LDFLAGS = $(LIBOSMOCORE_LIBS) $(LIBOSMOCTRL_LIBS) $(LIBOSMOVTY_LIBS) +LDADD = \ + $(COMMON_LA) \ + $(LIBOSMOCORE_LIBS) \ + $(LIBOSMOCTRL_LIBS) \ + $(LIBOSMOVTY_LIBS) \ + $(NULL) EXTRA_DIST = BitVectorTest.ok \ PRBSTest.ok \ @@ -31,21 +36,16 @@ LogTest BitVectorTest_SOURCES = BitVectorTest.cpp -BitVectorTest_LDADD = $(COMMON_LA) PRBSTest_SOURCES = PRBSTest.cpp InterthreadTest_SOURCES = InterthreadTest.cpp -InterthreadTest_LDADD = $(COMMON_LA) -InterthreadTest_LDFLAGS = -lpthread $(AM_LDFLAGS) +InterthreadTest_LDADD = $(LDADD) -lpthread TimevalTest_SOURCES = TimevalTest.cpp -TimevalTest_LDADD = $(COMMON_LA) VectorTest_SOURCES = VectorTest.cpp -VectorTest_LDADD = $(COMMON_LA) LogTest_SOURCES = LogTest.cpp -LogTest_LDADD = $(COMMON_LA) MOSTLYCLEANFILES += testSource testDestination diff --git a/tests/Transceiver52M/Makefile.am b/tests/Transceiver52M/Makefile.am index cb22c2a..2077c95 100644 --- a/tests/Transceiver52M/Makefile.am +++ b/tests/Transceiver52M/Makefile.am @@ -26,10 +26,11 @@ if DEVICE_LMS check_PROGRAMS += LMSDeviceTest LMSDeviceTest_SOURCES = LMSDeviceTest.cpp -LMSDeviceTest_LDFLAGS = $(LIBOSMOCORE_LIBS) $(LMS_LIBS) LMSDeviceTest_LDADD = \ $(top_builddir)/Transceiver52M/device/lms/libdevice.la \ + $(LIBOSMOCORE_LIBS) \ $(COMMON_LA) \ - $(LMS_LIBS) + $(LMS_LIBS) \ + $(NULL) LMSDeviceTest_CPPFLAGS = $(AM_CPPFLAGS) $(LMS_CFLAGS) endif -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/31841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I95b07b5a7735fb2753281555a4544f1ba967579e Gerrit-Change-Number: 31841 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-sgsn[master]: tests: use -no-install libtool flag to avoid ./lt-* scripts
by fixeria 10 Mar '23

10 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/31839 ) Change subject: tests: use -no-install libtool flag to avoid ./lt-* scripts ...................................................................... tests: use -no-install libtool flag to avoid ./lt-* scripts This option should be used for any executables which are used only for testing, or for generating other files and are consequently never installed. By specifying this option, we are telling Libtool that the executable it links will only ever be executed from where it is built in the build tree. Libtool is usually able to considerably speed up the link process for such executables. Change-Id: I8af6a38d7abbf06aa8268981c80c3bfda2f80a27 --- M tests/gprs/Makefile.am M tests/gtphub/Makefile.am M tests/sgsn/Makefile.am M tests/slhc/Makefile.am M tests/sndcp_xid/Makefile.am M tests/v42bis/Makefile.am M tests/xid/Makefile.am 7 files changed, 28 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/39/31839/1 diff --git a/tests/gprs/Makefile.am b/tests/gprs/Makefile.am index f90fd6e..ddfd2ae 100644 --- a/tests/gprs/Makefile.am +++ b/tests/gprs/Makefile.am @@ -1,5 +1,6 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall -ggdb3 $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOABIS_CFLAGS) +AM_LDFLAGS = -no-install EXTRA_DIST = gprs_test.ok diff --git a/tests/gtphub/Makefile.am b/tests/gtphub/Makefile.am index 6bb1a56..22b2a52 100644 --- a/tests/gtphub/Makefile.am +++ b/tests/gtphub/Makefile.am @@ -12,6 +12,8 @@ $(LIBGTP_CFLAGS) \ $(NULL) +AM_LDFLAGS = -no-install + EXTRA_DIST = \ gtphub_test.ok \ $(NULL) @@ -28,6 +30,7 @@ -Wl,--wrap=gtphub_resolve_ggsn_addr \ -Wl,--wrap=gtphub_ares_init \ -Wl,--wrap=gtphub_write \ + $(AM_LDFLAGS) \ $(NULL) gtphub_test_LDADD = \ diff --git a/tests/sgsn/Makefile.am b/tests/sgsn/Makefile.am index d22a8d9..c6c1f4a 100644 --- a/tests/sgsn/Makefile.am +++ b/tests/sgsn/Makefile.am @@ -22,6 +22,8 @@ $(NULL) endif +AM_LDFLAGS = -no-install + EXTRA_DIST = \ sgsn_test.ok \ $(NULL) @@ -45,6 +47,7 @@ -Wl,--wrap=gprs_subscr_request_update_location \ -Wl,--wrap=gprs_subscr_request_auth_info \ -Wl,--wrap=osmo_gsup_client_send \ + $(AM_LDFLAGS) \ $(NULL) sgsn_test_LDADD = \ diff --git a/tests/slhc/Makefile.am b/tests/slhc/Makefile.am index 0167f44..33cb7fa 100644 --- a/tests/slhc/Makefile.am +++ b/tests/slhc/Makefile.am @@ -1,5 +1,6 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall -ggdb3 $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBCARES_CFLAGS) +AM_LDFLAGS = -no-install EXTRA_DIST = slhc_test.ok diff --git a/tests/sndcp_xid/Makefile.am b/tests/sndcp_xid/Makefile.am index 4513c05..c4702b8 100644 --- a/tests/sndcp_xid/Makefile.am +++ b/tests/sndcp_xid/Makefile.am @@ -1,5 +1,6 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall -ggdb3 $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBCARES_CFLAGS) +AM_LDFLAGS = -no-install EXTRA_DIST = sndcp_xid_test.ok diff --git a/tests/v42bis/Makefile.am b/tests/v42bis/Makefile.am index 56b31f6..0e544a6 100644 --- a/tests/v42bis/Makefile.am +++ b/tests/v42bis/Makefile.am @@ -1,5 +1,6 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall -ggdb3 $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBCARES_CFLAGS) +AM_LDFLAGS = -no-install EXTRA_DIST = v42bis_test.ok diff --git a/tests/xid/Makefile.am b/tests/xid/Makefile.am index d3c205e..d3a260b 100644 --- a/tests/xid/Makefile.am +++ b/tests/xid/Makefile.am @@ -11,6 +11,8 @@ $(LIBCARES_CFLAGS) \ $(NULL) +AM_LDFLAGS = -no-install + EXTRA_DIST = \ xid_test.ok \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/31839 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8af6a38d7abbf06aa8268981c80c3bfda2f80a27 Gerrit-Change-Number: 31839 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-pcu[master]: tests/Makefile.am: do not overwrite global LDFLAGS
by fixeria 10 Mar '23

10 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31838 ) Change subject: tests/Makefile.am: do not overwrite global LDFLAGS ...................................................................... tests/Makefile.am: do not overwrite global LDFLAGS We still want -no-install to be used for these tests. Change-Id: I926df1918fd24ea7be4b390d168a8c76ef9931c0 --- M tests/Makefile.am 1 file changed, 21 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/38/31838/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index df63dd1..1c7b072 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -57,7 +57,10 @@ $(LIBOSMOCTRL_LIBS) \ $(LDADD) \ $(NULL) -tbf_TbfTest_LDFLAGS = -Wl,--wrap=pcu_sock_send +tbf_TbfTest_LDFLAGS = \ + -Wl,--wrap=pcu_sock_send \ + $(AM_LDFLAGS) \ + $(NULL) bitcomp_BitcompTest_SOURCES = bitcomp/BitcompTest.cpp ../src/egprs_rlc_compression.cpp bitcomp_BitcompTest_LDADD = \ @@ -105,7 +108,9 @@ $(NULL) ms_MsTest_LDFLAGS = \ - -Wl,-u,bssgp_prim_cb + -Wl,-u,bssgp_prim_cb \ + $(AM_LDFLAGS) \ + $(NULL) llc_LlcTest_SOURCES = llc/LlcTest.cpp llc_LlcTest_LDADD = \ @@ -117,7 +122,9 @@ $(NULL) llc_LlcTest_LDFLAGS = \ - -Wl,-u,bssgp_prim_cb + -Wl,-u,bssgp_prim_cb \ + $(AM_LDFLAGS) \ + $(NULL) llist_LListTest_SOURCES = llist/LListTest.cpp llist_LListTest_LDADD = \ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31838 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I926df1918fd24ea7be4b390d168a8c76ef9931c0 Gerrit-Change-Number: 31838 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-msc[master]: tests: use -no-install libtool flag to avoid ./lt-* scripts
by fixeria 10 Mar '23

10 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/31837 ) Change subject: tests: use -no-install libtool flag to avoid ./lt-* scripts ...................................................................... tests: use -no-install libtool flag to avoid ./lt-* scripts This option should be used for any executables which are used only for testing, or for generating other files and are consequently never installed. By specifying this option, we are telling Libtool that the executable it links will only ever be executed from where it is built in the build tree. Libtool is usually able to considerably speed up the link process for such executables. Also take a chance to add the missing $(COVERAGE_LDFLAGS). Change-Id: I664a9d5abed2777deee302f9d3afd1bbfde7a844 --- M tests/db_sms/Makefile.am M tests/mncc/Makefile.am M tests/msc_vlr/Makefile.am M tests/sdp_msg/Makefile.am M tests/smpp/Makefile.am M tests/sms_queue/Makefile.am 6 files changed, 42 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/37/31837/1 diff --git a/tests/db_sms/Makefile.am b/tests/db_sms/Makefile.am index 946d6a2..9dabfe7 100644 --- a/tests/db_sms/Makefile.am +++ b/tests/db_sms/Makefile.am @@ -19,6 +19,11 @@ $(LIBSQLITE3_CFLAGS) \ $(NULL) +AM_LDFLAGS = \ + $(COVERAGE_LDFLAGS) \ + -no-install \ + $(NULL) + EXTRA_DIST = \ db_sms_test.ok \ db_sms_test.err \ diff --git a/tests/mncc/Makefile.am b/tests/mncc/Makefile.am index b836fe3..a4c2960 100644 --- a/tests/mncc/Makefile.am +++ b/tests/mncc/Makefile.am @@ -9,6 +9,11 @@ $(LIBOSMOCORE_CFLAGS) \ $(NULL) +AM_LDFLAGS = \ + $(COVERAGE_LDFLAGS) \ + -no-install \ + $(NULL) + LDADD = \ $(top_builddir)/src/libmsc/libmsc.a \ $(LIBOSMOCORE_LIBS) \ diff --git a/tests/msc_vlr/Makefile.am b/tests/msc_vlr/Makefile.am index 2ba7180..cbdd6a4 100644 --- a/tests/msc_vlr/Makefile.am +++ b/tests/msc_vlr/Makefile.am @@ -26,6 +26,8 @@ -Wl,--wrap=osmo_get_rand_id \ -Wl,--wrap=ran_peers_down_paging \ -Wl,--wrap=call_leg_ensure_ci \ + $(COVERAGE_LDFLAGS) \ + -no-install \ $(NULL) LDADD = \ diff --git a/tests/sdp_msg/Makefile.am b/tests/sdp_msg/Makefile.am index a2e5fbc..f86e5f7 100644 --- a/tests/sdp_msg/Makefile.am +++ b/tests/sdp_msg/Makefile.am @@ -9,6 +9,11 @@ $(LIBOSMOCORE_CFLAGS) \ $(NULL) +AM_LDFLAGS = \ + $(COVERAGE_LDFLAGS) \ + -no-install \ + $(NULL) + LDADD = \ $(top_builddir)/src/libmsc/libmsc.a \ $(LIBOSMOCORE_LIBS) \ diff --git a/tests/smpp/Makefile.am b/tests/smpp/Makefile.am index fabfd2d..ff19d3d 100644 --- a/tests/smpp/Makefile.am +++ b/tests/smpp/Makefile.am @@ -19,6 +19,7 @@ AM_LDFLAGS = \ $(COVERAGE_LDFLAGS) \ + -no-install \ $(NULL) EXTRA_DIST = \ diff --git a/tests/sms_queue/Makefile.am b/tests/sms_queue/Makefile.am index d50a8d6..055a229 100644 --- a/tests/sms_queue/Makefile.am +++ b/tests/sms_queue/Makefile.am @@ -19,6 +19,11 @@ $(LIBSQLITE3_CFLAGS) \ $(NULL) +AM_LDFLAGS = \ + $(COVERAGE_LDFLAGS) \ + -no-install \ + $(NULL) + EXTRA_DIST = \ sms_queue_test.ok \ sms_queue_test.err \ @@ -51,4 +56,5 @@ sms_queue_test_LDFLAGS = \ -Wl,--wrap=db_sms_get_next_unsent_rr_msisdn \ + $(AM_LDFLAGS) \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31837 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I664a9d5abed2777deee302f9d3afd1bbfde7a844 Gerrit-Change-Number: 31837 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-mgw[master]: */Makefile.am: libraries shall not be in AM_LDFLAGS
by fixeria 10 Mar '23

10 Mar '23

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/31786 to look at the new patch set (#3). Change subject: */Makefile.am: libraries shall not be in AM_LDFLAGS ...................................................................... */Makefile.am: libraries shall not be in AM_LDFLAGS Change-Id: Ie9df855ee09b0761bd617fab58ca26450ac0c754 --- M src/Makefile.am M src/libosmo-mgcp-client/Makefile.am M src/libosmo-mgcp/Makefile.am 3 files changed, 14 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/86/31786/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie9df855ee09b0761bd617fab58ca26450ac0c754 Gerrit-Change-Number: 31786 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-mgw[master]: tests: use -no-install libtool flag to avoid ./lt-* scripts
by fixeria 10 Mar '23

10 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31836 ) Change subject: tests: use -no-install libtool flag to avoid ./lt-* scripts ...................................................................... tests: use -no-install libtool flag to avoid ./lt-* scripts This option should be used for any executables which are used only for testing, or for generating other files and are consequently never installed. By specifying this option, we are telling Libtool that the executable it links will only ever be executed from where it is built in the build tree. Libtool is usually able to considerably speed up the link process for such executables. Change-Id: I4bc03bdc1f2de2574558e2ad753e116486993a7f --- M tests/mgcp/Makefile.am M tests/mgcp_client/Makefile.am 2 files changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/36/31836/1 diff --git a/tests/mgcp/Makefile.am b/tests/mgcp/Makefile.am index af6201a..73ad1cf 100644 --- a/tests/mgcp/Makefile.am +++ b/tests/mgcp/Makefile.am @@ -18,6 +18,7 @@ AM_LDFLAGS = \ $(COVERAGE_LDFLAGS) \ + -no-install \ $(NULL) EXTRA_DIST = \ diff --git a/tests/mgcp_client/Makefile.am b/tests/mgcp_client/Makefile.am index 3895d02..f6f1838 100644 --- a/tests/mgcp_client/Makefile.am +++ b/tests/mgcp_client/Makefile.am @@ -15,6 +15,7 @@ AM_LDFLAGS = \ $(COVERAGE_LDFLAGS) \ + -no-install \ $(NULL) EXTRA_DIST = \ -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4bc03bdc1f2de2574558e2ad753e116486993a7f Gerrit-Change-Number: 31836 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0