March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: abis_rsl: Document spec ref of CCCH Load Ind
by pespin 30 Mar '23

30 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32158 ) Change subject: abis_rsl: Document spec ref of CCCH Load Ind ...................................................................... abis_rsl: Document spec ref of CCCH Load Ind Change-Id: Iada13bb29688249eecbd492388a6d4b0cc95575d --- M src/osmo-bsc/abis_rsl.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/58/32158/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 1880996..6a9712e 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -2296,7 +2296,7 @@ return rc; } -/* current load on the CCCH */ +/* 5.4 and 8.5.2 Rx CCCH Load Ind */ static int rsl_rx_ccch_load(struct msgb *msg) { struct e1inp_sign_link *sign_link = msg->dst; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iada13bb29688249eecbd492388a6d4b0cc95575d Gerrit-Change-Number: 32158 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmocom-bb[master]: layer23: modem: llc: Fix typo LLGM -> LLGMM
by fixeria 30 Mar '23

30 Mar '23

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32157 ) Change subject: layer23: modem: llc: Fix typo LLGM -> LLGMM ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/32157 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I786661894fc6772784ba6f0d2fdb45bbdca5254c Gerrit-Change-Number: 32157 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Mar 2023 12:40:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-gbproxy[master]: tests: do not depend on $(BUILT_SOURCES), but on osmo-gbproxy
by fixeria 30 Mar '23

30 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/32147 ) Change subject: tests: do not depend on $(BUILT_SOURCES), but on osmo-gbproxy ...................................................................... tests: do not depend on $(BUILT_SOURCES), but on osmo-gbproxy $(BUILT_SOURCES) is not defined, makes no sense to depend on it. Change-Id: Iefb7ae1a660891a556cf6bf2e46e1d4440da1683 --- M tests/Makefile.am 1 file changed, 16 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/tests/Makefile.am b/tests/Makefile.am index 48d6579..8f83fa4 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -36,15 +36,15 @@ $(NULL) if ENABLE_EXT_TESTS -python-tests: $(BUILT_SOURCES) +python-tests: $(MAKE) vty-test $(MAKE) ctrl-python-test else -python-tests: $(BUILT_SOURCES) +python-tests: echo "Not running python-based tests (determined at configure-time)" endif -vty-python-test: $(BUILT_SOURCES) +vty-python-test: $(top_builddir)/src/osmo-gbproxy osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v $(srcdir)/vty_test_runner.py -w $(abs_top_builddir) -v @@ -53,7 +53,7 @@ # To update the VTY script from current application behavior, # pass -u to vty_script_runner.py by doing: # make vty-transcript-test U=-u -vty-transcript-test: +vty-transcript-test: $(top_builddir)/src/osmo-gbproxy osmo_verify_transcript_vty.py -v \ -n OsmoGbProxy -p 4246 \ -r "$(top_builddir)/src/osmo-gbproxy -c $(top_srcdir)/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg" \ @@ -69,7 +69,7 @@ $(MAKE) vty-python-test $(MAKE) vty-transcript-test -ctrl-python-test: $(BUILT_SOURCES) +ctrl-python-test: $(top_builddir)/src/osmo-gbproxy $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v rm -f $(top_builddir)/sms.db $(top_builddir)/gsn_restart $(top_builddir)/gtphub_restart_count -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/32147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Iefb7ae1a660891a556cf6bf2e46e1d4440da1683 Gerrit-Change-Number: 32147 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnodeb[master]: tests: do not depend on undefined $(BUILT_SOURCES)
by fixeria 30 Mar '23

30 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/32145 ) Change subject: tests: do not depend on undefined $(BUILT_SOURCES) ...................................................................... tests: do not depend on undefined $(BUILT_SOURCES) Change-Id: I43c78aac0d23274d2a9bb01021cde0371c231be2 --- M tests/Makefile.am 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/tests/Makefile.am b/tests/Makefile.am index 37aeda6..d2be48e 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -34,7 +34,7 @@ $(NULL) if ENABLE_EXT_TESTS -python-tests: $(BUILT_SOURCES) +python-tests: echo "" # TODO: Enable once we have a VTY/CTRL interface: # $(MAKE) vty-test @@ -42,7 +42,7 @@ # osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v # $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v else -python-tests: $(BUILT_SOURCES) +python-tests: echo "Not running python-based tests (determined at configure-time)" endif -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/32145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I43c78aac0d23274d2a9bb01021cde0371c231be2 Gerrit-Change-Number: 32145 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnodeb[master]: build: remove $(COVERAGE_LDFLAGS) from osmo_hnodeb_LDADD
by fixeria 30 Mar '23

30 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/32143 ) Change subject: build: remove $(COVERAGE_LDFLAGS) from osmo_hnodeb_LDADD ...................................................................... build: remove $(COVERAGE_LDFLAGS) from osmo_hnodeb_LDADD Change-Id: Id088775f444640df863c346b225c1bae61725249 --- M src/osmo-hnodeb/Makefile.am 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo-hnodeb/Makefile.am b/src/osmo-hnodeb/Makefile.am index 27987a1..0d2cf02 100644 --- a/src/osmo-hnodeb/Makefile.am +++ b/src/osmo-hnodeb/Makefile.am @@ -54,7 +54,6 @@ $(LIBOSMOVTY_LIBS) \ $(LIBOSMOCTRL_LIBS) \ $(LIBOSMONETIF_LIBS) \ - $(COVERAGE_LDFLAGS) \ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOTRAU_LIBS) \ $(LIBOSMOSIGTRAN_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/32143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Id088775f444640df863c346b225c1bae61725249 Gerrit-Change-Number: 32143 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnodeb[master]: tests: make 'vty-test' target depend on the respective binary
by fixeria 30 Mar '23

30 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/32144 ) Change subject: tests: make 'vty-test' target depend on the respective binary ...................................................................... tests: make 'vty-test' target depend on the respective binary Change-Id: I53ff9a1659a0e25a6c3a5bc987dbae82d0312259 --- M tests/Makefile.am 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/tests/Makefile.am b/tests/Makefile.am index ed101ae..37aeda6 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -52,7 +52,7 @@ # To update the VTY script from current application behavior, # pass -u to vty_script_runner.py by doing: # make vty-test U=-u -vty-test: +vty-test: $(top_builddir)/src/osmo-hnodeb/osmo-hnodeb osmo_verify_transcript_vty.py -v \ -n OsmoHNodeB -p 4273 \ -r "$(top_builddir)/src/osmo-hnodeb/osmo-hnodeb -c $(top_srcdir)/doc/examples/osmo-hnodeb/osmo-hnodeb.cfg" \ -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/32144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I53ff9a1659a0e25a6c3a5bc987dbae82d0312259 Gerrit-Change-Number: 32144 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnbgw[master]: tests: do not depend on undefined $(BUILT_SOURCES)
by fixeria 30 Mar '23

30 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32141 ) Change subject: tests: do not depend on undefined $(BUILT_SOURCES) ...................................................................... tests: do not depend on undefined $(BUILT_SOURCES) Change-Id: I7536be8aa3f0ab39f183e00cf4382636038db4b7 --- M tests/Makefile.am 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/tests/Makefile.am b/tests/Makefile.am index b9f0279..806bfb1 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -35,7 +35,7 @@ $(NULL) if ENABLE_EXT_TESTS -python-tests: $(BUILT_SOURCES) +python-tests: echo "" # TODO: Enable once we have a VTY/CTRL interface: # $(MAKE) vty-test @@ -43,7 +43,7 @@ # osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v # $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v else -python-tests: $(BUILT_SOURCES) +python-tests: echo "Not running python-based tests (determined at configure-time)" endif -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I7536be8aa3f0ab39f183e00cf4382636038db4b7 Gerrit-Change-Number: 32141 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnbgw[master]: tests: make 'vty-test' target depend on osmo-hnbgw binary
by fixeria 30 Mar '23

30 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32140 ) Change subject: tests: make 'vty-test' target depend on osmo-hnbgw binary ...................................................................... tests: make 'vty-test' target depend on osmo-hnbgw binary Change-Id: Iaaa1dd622fde460a250c11eb97cf0b25469e55c4 --- M tests/Makefile.am 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/tests/Makefile.am b/tests/Makefile.am index f9da51f..b9f0279 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -53,10 +53,11 @@ # To update the VTY script from current application behavior, # pass -u to vty_script_runner.py by doing: # make vty-test U=-u -vty-test: +vty-test: $(top_builddir)/src/osmo-hnbgw/osmo-hnbgw osmo_verify_transcript_vty.py -v \ -n OsmoHNBGW -p 4261 \ - -r "$(top_builddir)/src/osmo-hnbgw/osmo-hnbgw -c $(top_srcdir)/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg" \ + -r "$(top_builddir)/src/osmo-hnbgw/osmo-hnbgw \ + -c $(top_srcdir)/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg" \ $(U) $(srcdir)/$(VTY_TEST) check-local: atconfig $(TESTSUITE) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32140 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iaaa1dd622fde460a250c11eb97cf0b25469e55c4 Gerrit-Change-Number: 32140 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnbgw[master]: tests: use -no-install libtool flag to avoid ./lt-* scripts
by fixeria 30 Mar '23

30 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32139 ) Change subject: tests: use -no-install libtool flag to avoid ./lt-* scripts ...................................................................... tests: use -no-install libtool flag to avoid ./lt-* scripts This option should be used for any executables which are used only for testing, or for generating other files and are consequently never installed. By specifying this option, we are telling Libtool that the executable it links will only ever be executed from where it is built in the build tree. Libtool is usually able to considerably speed up the link process for such executables. Change-Id: Id5f88c331cf1dfd3f38120b4ef59ced9a563d4f0 --- M tests/ranap_rab_ass/Makefile.am 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/tests/ranap_rab_ass/Makefile.am b/tests/ranap_rab_ass/Makefile.am index 1278ae8..918682c 100644 --- a/tests/ranap_rab_ass/Makefile.am +++ b/tests/ranap_rab_ass/Makefile.am @@ -15,6 +15,8 @@ $(COVERAGE_CFLAGS) \ $(NULL) +AM_LDFLAGS = -no-install + EXTRA_DIST = \ ranap_rab_ass_test.ok \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Id5f88c331cf1dfd3f38120b4ef59ced9a563d4f0 Gerrit-Change-Number: 32139 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-hnbgw[master]: tests: use check_PROGRAMS for tests, not noinst_PROGRAMS
by fixeria 30 Mar '23

30 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32138 ) Change subject: tests: use check_PROGRAMS for tests, not noinst_PROGRAMS ...................................................................... tests: use check_PROGRAMS for tests, not noinst_PROGRAMS Change-Id: I616ed6920af98502424e4eab6cffde5d39d9698e --- M tests/ranap_rab_ass/Makefile.am 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/tests/ranap_rab_ass/Makefile.am b/tests/ranap_rab_ass/Makefile.am index cdda8e3..1278ae8 100644 --- a/tests/ranap_rab_ass/Makefile.am +++ b/tests/ranap_rab_ass/Makefile.am @@ -19,7 +19,7 @@ ranap_rab_ass_test.ok \ $(NULL) -noinst_PROGRAMS = \ +check_PROGRAMS = \ ranap_rab_ass_test \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I616ed6920af98502424e4eab6cffde5d39d9698e Gerrit-Change-Number: 32138 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0