March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: doc/{examples,manuals}: remove dummy 'gprs nsvc 1'
by fixeria 31 Mar '23

31 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32168 ) Change subject: doc/{examples,manuals}: remove dummy 'gprs nsvc 1' ...................................................................... doc/{examples,manuals}: remove dummy 'gprs nsvc 1' Change-Id: I976471ad15dbb7be832dc1a87ca794009ee1aa7c Related: OS#5979 --- M doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg M doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg M doc/manuals/chapters/bts-examples.adoc 3 files changed, 10 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/68/32168/1 diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg index b5b5134..38e7afb 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-16kbps.cfg @@ -58,10 +58,6 @@ gprs nsvc 0 local udp port 23100 gprs nsvc 0 remote udp port 23000 gprs nsvc 0 remote ip 127.0.0.1 - gprs nsvc 1 nsvci 0 - gprs nsvc 1 local udp port 0 - gprs nsvc 1 remote udp port 0 - gprs nsvc 1 remote ip 0.0.0.0 is-connection-list add 4 512 4 is-connection-list add 8 516 1 is-connection-list add 12 517 1 diff --git a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg index e01223e..1f33577 100644 --- a/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg +++ b/doc/examples/osmo-bsc/ericsson/osmo-bsc.dug20-rus02-1trx-1pdch-64kbps.cfg @@ -55,10 +55,6 @@ gprs nsvc 0 local udp port 23100 gprs nsvc 0 remote udp port 23000 gprs nsvc 0 remote ip 127.0.0.1 - gprs nsvc 1 nsvci 0 - gprs nsvc 1 local udp port 0 - gprs nsvc 1 remote udp port 0 - gprs nsvc 1 remote ip 0.0.0.0 is-connection-list add 4 712 36 trx 0 rf_locked 0 diff --git a/doc/manuals/chapters/bts-examples.adoc b/doc/manuals/chapters/bts-examples.adoc index 27278fb..d866f4f 100644 --- a/doc/manuals/chapters/bts-examples.adoc +++ b/doc/manuals/chapters/bts-examples.adoc @@ -332,10 +332,6 @@ gprs nsvc 0 local udp port 23100 gprs nsvc 0 remote udp port 23000 gprs nsvc 0 remote ip 127.0.0.1 - gprs nsvc 1 nsvci 0 - gprs nsvc 1 local udp port 0 - gprs nsvc 1 remote udp port 0 - gprs nsvc 1 remote ip 0.0.0.0 is-connection-list add 4 712 36 <3> trx 0 rf_locked 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32168 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I976471ad15dbb7be832dc1a87ca794009ee1aa7c Gerrit-Change-Number: 32168 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bsc[master]: tests: add more tests for GPRS NSVC parameters
by fixeria 31 Mar '23

31 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32171 ) Change subject: tests: add more tests for GPRS NSVC parameters ...................................................................... tests: add more tests for GPRS NSVC parameters Change-Id: I13d6ac887ddb1c9bc5d1e4122f20405a28f135d4 Related: OS#5979 --- M tests/gprs_params.vty 1 file changed, 66 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/71/32171/1 diff --git a/tests/gprs_params.vty b/tests/gprs_params.vty index 3edc540..048420b 100644 --- a/tests/gprs_params.vty +++ b/tests/gprs_params.vty @@ -46,3 +46,59 @@ gprs nsvc 1 nsvci 0 gprs nsvc 1 local udp port 23101 ... + + +OsmoBSC(config-net-bts)# ### NSVC sub-command syntax +OsmoBSC(config-net-bts)# gprs nsvc? + nsvc Network Service Virtual Connection (NS-VC) +OsmoBSC(config-net-bts)# gprs nsvc ? + <0-1> NSVC Logical Number +OsmoBSC(config-net-bts)# gprs nsvc 0 ? + nsvci NS Virtual Connection Identifier + local GPRS NS Local UDP Port + remote GPRS NS Remote UDP Port +OsmoBSC(config-net-bts)# gprs nsvc 0 nsvci ? + <0-65535> GPRS NS VC Identifier +OsmoBSC(config-net-bts)# gprs nsvc 0 local ? + udp GPRS NS Local UDP Port +OsmoBSC(config-net-bts)# gprs nsvc 0 local udp ? + port GPRS NS Local UDP Port +OsmoBSC(config-net-bts)# gprs nsvc 0 local udp port ? + <0-65535> GPRS NS Local UDP Port Number +OsmoBSC(config-net-bts)# gprs nsvc 0 remote ? + udp GPRS NS Remote UDP Port + ip GPRS NS Remote IP Address +OsmoBSC(config-net-bts)# gprs nsvc 0 remote udp ? + port GPRS NS Remote UDP Port +OsmoBSC(config-net-bts)# gprs nsvc 0 remote udp port ? + <0-65535> GPRS NS Remote UDP Port Number +OsmoBSC(config-net-bts)# gprs nsvc 0 remote ip ? + A.B.C.D GPRS NS Remote IPv4 Address + X:X::X:X GPRS NS Remote IPv6 Address + +OsmoBSC(config-net-bts)# ### NSVC sub-command params +OsmoBSC(config-net-bts)# gprs nsvc 0 nsvci 4242 +OsmoBSC(config-net-bts)# gprs nsvc 1 nsvci 2424 +OsmoBSC(config-net-bts)# show running-config +... + bts 0 +... + gprs nsvc 0 nsvci 4242 + gprs nsvc 0 local udp port 23100 + gprs nsvc 1 nsvci 2424 + gprs nsvc 1 local udp port 23101 +... +OsmoBSC(config-net-bts)# gprs nsvc 1 local udp port 23023 +OsmoBSC(config-net-bts)# gprs nsvc 1 remote udp port 23032 +OsmoBSC(config-net-bts)# gprs nsvc 1 remote ip 1.2.3.4 +OsmoBSC(config-net-bts)# show running-config +... + bts 0 +... + gprs nsvc 0 nsvci 4242 + gprs nsvc 0 local udp port 23100 + gprs nsvc 1 nsvci 2424 + gprs nsvc 1 local udp port 23023 + gprs nsvc 1 remote ip 1.2.3.4 + gprs nsvc 1 remote udp port 23032 +... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32171 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I13d6ac887ddb1c9bc5d1e4122f20405a28f135d4 Gerrit-Change-Number: 32171 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-bsc[master]: tests: rename and extend gprs_{bvci_default->params}.vty
by fixeria 31 Mar '23

31 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32169 ) Change subject: tests: rename and extend gprs_{bvci_default->params}.vty ...................................................................... tests: rename and extend gprs_{bvci_default->params}.vty Match default values for all GPRS related params, not only the BVCI. This patch demonstrates a problem with default NSVC bind ports: gprs nsvc 0 nsvci 0 gprs nsvc 0 local udp port 0 gprs nsvc 1 nsvci 0 gprs nsvc 1 local udp port 0 The PCU obviously cannot bind to port 0, and will keep re-starting. We should have a sane default value for the local UDP port (like our usual 23000). "0" is not a sane default, as it can never work. The user might simply add remote ip/port and not explicitly set a local port and run into that problem. Change-Id: Ia02e9a97137eb7724f22526fc3768331b35ac55d Related: OS#5979 --- D tests/gprs_bvci_default.vty A tests/gprs_params.vty 2 files changed, 73 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/69/32169/1 diff --git a/tests/gprs_bvci_default.vty b/tests/gprs_bvci_default.vty deleted file mode 100644 index 4bd95ce..0000000 --- a/tests/gprs_bvci_default.vty +++ /dev/null @@ -1,13 +0,0 @@ -OsmoBSC> enable -OsmoBSC# configure terminal -OsmoBSC(config)# network -OsmoBSC(config-net)# bts 0 -OsmoBSC(config-net-bts)# gprs mode gprs -OsmoBSC(config-net-bts)# exit - -OsmoBSC(config-net)# show running-config -... - bts 0 -... - gprs cell bvci 2 -... diff --git a/tests/gprs_params.vty b/tests/gprs_params.vty new file mode 100644 index 0000000..87c64b1 --- /dev/null +++ b/tests/gprs_params.vty @@ -0,0 +1,48 @@ +OsmoBSC> enable +OsmoBSC# configure terminal +OsmoBSC(config)# network +OsmoBSC(config-net)# bts 0 + +OsmoBSC(config-net-bts)# ### GPRS is disabled by default +OsmoBSC(config-net-bts)# show running-config +... + bts 0 +... + gprs mode none +... + +OsmoBSC(config-net-bts)# ### Default [E]GPRS params +OsmoBSC(config-net-bts)# gprs mode gprs +OsmoBSC(config-net-bts)# show running-config +... + bts 0 +... + gprs mode gprs + gprs routing area 0 + gprs network-control-order nc0 + gprs power-control alpha 0 + gprs cell bvci 2 + gprs cell timer blocking-timer 3 + gprs cell timer blocking-retries 3 + gprs cell timer unblocking-retries 3 + gprs cell timer reset-timer 3 + gprs cell timer reset-retries 3 + gprs cell timer suspend-timer 10 + gprs cell timer suspend-retries 3 + gprs cell timer resume-timer 10 + gprs cell timer resume-retries 3 + gprs cell timer capability-update-timer 10 + gprs cell timer capability-update-retries 3 + gprs nsei 0 + gprs ns timer tns-block 3 + gprs ns timer tns-block-retries 3 + gprs ns timer tns-reset 3 + gprs ns timer tns-reset-retries 3 + gprs ns timer tns-test 30 + gprs ns timer tns-alive 3 + gprs ns timer tns-alive-retries 10 + gprs nsvc 0 nsvci 0 + gprs nsvc 0 local udp port 0 + gprs nsvc 1 nsvci 0 + gprs nsvc 1 local udp port 0 +... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32169 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia02e9a97137eb7724f22526fc3768331b35ac55d Gerrit-Change-Number: 32169 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bsc[master]: gprs: disallow setting NSVC remote port to 0
by fixeria 31 Mar '23

31 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32172 ) Change subject: gprs: disallow setting NSVC remote port to 0 ...................................................................... gprs: disallow setting NSVC remote port to 0 0 is not a valid remote port and shall not be permitted. Change-Id: I46d5ad247ff2da7b319da0793e1d57561183bc8e Related: OS#5979 --- M src/osmo-bsc/bts_vty.c M tests/gprs_params.vty 2 files changed, 17 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/72/32172/1 diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index e02c2d5..21c7b43 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -1486,7 +1486,7 @@ DEFUN_USRATTR(cfg_bts_gprs_nsvc_rport, cfg_bts_gprs_nsvc_rport_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_OML_LINK), - "gprs nsvc <0-1> remote udp port <0-65535>", + "gprs nsvc <0-1> remote udp port <1-65535>", GPRS_TEXT NSVC_TEXT "GPRS NS Remote UDP Port\n" "GPRS NS Remote UDP Port\n" diff --git a/tests/gprs_params.vty b/tests/gprs_params.vty index 048420b..9b2622b 100644 --- a/tests/gprs_params.vty +++ b/tests/gprs_params.vty @@ -71,7 +71,7 @@ OsmoBSC(config-net-bts)# gprs nsvc 0 remote udp ? port GPRS NS Remote UDP Port OsmoBSC(config-net-bts)# gprs nsvc 0 remote udp port ? - <0-65535> GPRS NS Remote UDP Port Number + <1-65535> GPRS NS Remote UDP Port Number OsmoBSC(config-net-bts)# gprs nsvc 0 remote ip ? A.B.C.D GPRS NS Remote IPv4 Address X:X::X:X GPRS NS Remote IPv6 Address @@ -102,3 +102,6 @@ gprs nsvc 1 remote ip 1.2.3.4 gprs nsvc 1 remote udp port 23032 ... + +OsmoBSC(config-net-bts)# gprs nsvc 0 remote udp port 0 +% Unknown command. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32172 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I46d5ad247ff2da7b319da0793e1d57561183bc8e Gerrit-Change-Number: 32172 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: core: remove unnecessary #include <osmocom/core/talloc.h>
by falconia 30 Mar '23

30 Mar '23

Attention is currently required from: fixeria. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32167 ) Change subject: core: remove unnecessary #include <osmocom/core/talloc.h> ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32167 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4b9ffd7a329081df3d2c0b0ee8698a3cf759e94e Gerrit-Change-Number: 32167 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Mar 2023 23:13:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: fixup (partial revert): "coding: clean up Makefile.am"
by falconia 30 Mar '23

30 Mar '23

Attention is currently required from: fixeria. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32166 ) Change subject: fixup (partial revert): "coding: clean up Makefile.am" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32166 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic1bd82159a827af21fe36bea998f8f58f732473a Gerrit-Change-Number: 32166 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Mar 2023 23:09:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: fixup (partial revert): "coding: clean up Makefile.am"
by fixeria 30 Mar '23

30 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/32166 ) Change subject: fixup (partial revert): "coding: clean up Makefile.am" ...................................................................... fixup (partial revert): "coding: clean up Makefile.am" This is a partial revert of "9dca9027 coding: clean up Makefile.am". Even though libosmocoding does not use talloc API, it still depends on this library indirectly via libosmo{core,codec,gsm}. Furthermore, some of libosmocore's header files do #include <osmocom/core/talloc.h>, and thus #include <talloc.h> via this internal header. Under Slackware 14.2 talloc.h header lives in /usr/include/samba-4.0, and without $(TALLOC_CFLAGS) compilation of libmsocoding fails due to the preprocessor failing to find this header. The culprit is my recent patch 9dca9027 removing $(TALLOC_CFLAGS) and $(TALLOC_LIBS). Put $(TALLOC_CFLAGS) back to AM_CFLAGS; it will likely be emply under distributions having talloc.h header in the standard include dir. The $(TALLOC_LIBS) does not need to be resurrected because libtool will add '-ltalloc' automatically for each libosmo*.la in LIBADD. Change-Id: Ic1bd82159a827af21fe36bea998f8f58f732473a Related: OS#5960 --- M src/coding/Makefile.am 1 file changed, 28 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/66/32166/1 diff --git a/src/coding/Makefile.am b/src/coding/Makefile.am index bb7bde2..987e073 100644 --- a/src/coding/Makefile.am +++ b/src/coding/Makefile.am @@ -8,7 +8,7 @@ -I"$(top_builddir)/include" \ -I"$(top_builddir)" \ $(NULL) -AM_CFLAGS = -Wall +AM_CFLAGS = -Wall $(TALLOC_CFLAGS) if ENABLE_PSEUDOTALLOC AM_CPPFLAGS += -I$(top_srcdir)/src/pseudotalloc -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32166 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic1bd82159a827af21fe36bea998f8f58f732473a Gerrit-Change-Number: 32166 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: core: remove unnecessary #include <osmocom/core/talloc.h>
by fixeria 30 Mar '23

30 Mar '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/32167 ) Change subject: core: remove unnecessary #include <osmocom/core/talloc.h> ...................................................................... core: remove unnecessary #include <osmocom/core/talloc.h> Including this header just for TALLOC_CTX is an overkill, we use 'void *' for talloc contexts in nearly all other Osmocom projects. Change-Id: I4b9ffd7a329081df3d2c0b0ee8698a3cf759e94e Related: OS#5960 --- M include/osmocom/core/bitvec.h M include/osmocom/core/strrb.h M src/core/bitvec.c M src/core/strrb.c 4 files changed, 18 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/67/32167/1 diff --git a/include/osmocom/core/bitvec.h b/include/osmocom/core/bitvec.h index 70b0e27..1e2fe7b 100644 --- a/include/osmocom/core/bitvec.h +++ b/include/osmocom/core/bitvec.h @@ -23,7 +23,6 @@ * \file bitvec.h */ #include <stdint.h> -#include <osmocom/core/talloc.h> #include <osmocom/core/defs.h> #include <stdbool.h> @@ -61,7 +60,7 @@ int bitvec_spare_padding(struct bitvec *bv, unsigned int up_to_bit); int bitvec_get_bytes(struct bitvec *bv, uint8_t *bytes, unsigned int count); int bitvec_set_bytes(struct bitvec *bv, const uint8_t *bytes, unsigned int count); -struct bitvec *bitvec_alloc(unsigned int size, TALLOC_CTX *bvctx); +struct bitvec *bitvec_alloc(unsigned int size, void *bvctx); void bitvec_free(struct bitvec *bv); int bitvec_unhex(struct bitvec *bv, const char *src); unsigned int bitvec_pack(const struct bitvec *bv, uint8_t *buffer); diff --git a/include/osmocom/core/strrb.h b/include/osmocom/core/strrb.h index e3d3201..92d6a2f 100644 --- a/include/osmocom/core/strrb.h +++ b/include/osmocom/core/strrb.h @@ -26,8 +26,6 @@ #include <stdbool.h> #include <stdint.h> -#include <osmocom/core/talloc.h> - /*! A structure representing an osmocom string ringbuffer */ #define RB_MAX_MESSAGE_SIZE 240 @@ -38,7 +36,7 @@ char **buffer; /*!< storage for messages */ }; -struct osmo_strrb *osmo_strrb_create(TALLOC_CTX * ctx, size_t rb_size); +struct osmo_strrb *osmo_strrb_create(void *talloc_ctx, size_t rb_size); bool osmo_strrb_is_empty(const struct osmo_strrb *rb); const char *osmo_strrb_get_nth(const struct osmo_strrb *rb, unsigned int string_index); diff --git a/src/core/bitvec.c b/src/core/bitvec.c index 350f738..38ea1bb 100644 --- a/src/core/bitvec.c +++ b/src/core/bitvec.c @@ -395,7 +395,7 @@ * \param[in] size Number of bytes in the vector * \param[in] ctx Context from which to allocate * \return pointer to allocated vector; NULL in case of error */ -struct bitvec *bitvec_alloc(unsigned int size, TALLOC_CTX *ctx) +struct bitvec *bitvec_alloc(unsigned int size, void *ctx) { struct bitvec *bv = talloc(ctx, struct bitvec); if (!bv) diff --git a/src/core/strrb.c b/src/core/strrb.c index df7edb3..c5a5ed6 100644 --- a/src/core/strrb.c +++ b/src/core/strrb.c @@ -52,12 +52,12 @@ * This function creates and initializes a ringbuffer. * Note that the ringbuffer stores at most rb_size - 1 messages. */ -struct osmo_strrb *osmo_strrb_create(TALLOC_CTX * ctx, size_t rb_size) +struct osmo_strrb *osmo_strrb_create(void *talloc_ctx, size_t rb_size) { struct osmo_strrb *rb = NULL; unsigned int i; - rb = talloc_zero(ctx, struct osmo_strrb); + rb = talloc_zero(talloc_ctx, struct osmo_strrb); if (!rb) goto alloc_error; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32167 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4b9ffd7a329081df3d2c0b0ee8698a3cf759e94e Gerrit-Change-Number: 32167 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-mgw[master]: mgcp_client: simpler error handling
by Jenkins Builder 30 Mar '23

30 Mar '23

Attention is currently required from: neels. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/32162 ) Change subject: mgcp_client: simpler error handling ...................................................................... Patch Set 2: (2 comments) File src/libosmo-mgcp-client/mgcp_client.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5626): https://gerrit.osmocom.org/c/osmo-mgw/+/32162/comment/97001204_73c2bf37 PS2, Line 1401: mgcp_msg->x_osmo_ign & MGCP_X_OSMO_IGN_CALLID ? " C": ""); spaces required around that ':' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5626): https://gerrit.osmocom.org/c/osmo-mgw/+/32162/comment/8aa7f974_1409a3e3 PS2, Line 1412: mgcp_msg->x_osmo_osmux_cid == -1 ? " *": buf); spaces required around that ':' (ctx:VxW) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32162 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I904d56f56053952c2ebbbe5dca744fafa32b333e Gerrit-Change-Number: 32162 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Mar 2023 22:08:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-mgw[master]: mgcp_client: simpler error handling
by neels 30 Mar '23

30 Mar '23

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/32162 to look at the new patch set (#2). Change subject: mgcp_client: simpler error handling ...................................................................... mgcp_client: simpler error handling add_sdp(), add_lco(): - do not msgb_free() within these functions. Just return error, and move the msgb_free() to the caler. - when failing to write to the msgb, directly return error. Change-Id: I904d56f56053952c2ebbbe5dca744fafa32b333e --- M src/libosmo-mgcp-client/mgcp_client.c 1 file changed, 92 insertions(+), 87 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/62/32162/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32162 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I904d56f56053952c2ebbbe5dca744fafa32b333e Gerrit-Change-Number: 32162 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0