Attention is currently required from: neels.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/32162 )
Change subject: mgcp_client: simpler error handling
......................................................................
Patch Set 2:
(2 comments)
File src/libosmo-mgcp-client/mgcp_client.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5626):
https://gerrit.osmocom.org/c/osmo-mgw/+/32162/comment/97001204_73c2bf37
PS2, Line 1401: mgcp_msg->x_osmo_ign & MGCP_X_OSMO_IGN_CALLID ? "
C": "");
spaces required around that ':' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5626):
https://gerrit.osmocom.org/c/osmo-mgw/+/32162/comment/8aa7f974_1409a3e3
PS2, Line 1412: mgcp_msg->x_osmo_osmux_cid == -1 ? " *": buf);
spaces required around that ':' (ctx:VxW)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/32162
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I904d56f56053952c2ebbbe5dca744fafa32b333e
Gerrit-Change-Number: 32162
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Mar 2023 22:08:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment