March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: virt_phy: clean up and improve Makefile.am
by laforge 13 Mar '23

13 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31849 ) Change subject: virt_phy: clean up and improve Makefile.am ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31849 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iccd07614aabfc2845424d25962f48e4231a50a90 Gerrit-Change-Number: 31849 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 21:41:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmocom-bb[master]: virt_phy: rearrange and clean up header files
by laforge 13 Mar '23

13 Mar '23

Attention is currently required from: fixeria, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31848 ) Change subject: virt_phy: rearrange and clean up header files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I25145630ec53c2b8065a42fb12a778eec010f10c Gerrit-Change-Number: 31848 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 21:40:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: trxcon: do not send DATA.cnf for L1SCHED_DT_TRAFFIC
by laforge 13 Mar '23

13 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31651 ) Change subject: trxcon: do not send DATA.cnf for L1SCHED_DT_TRAFFIC ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iee5ee404f1eb77091c388a641d0a78d01a8d7e7f Gerrit-Change-Number: 31651 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 21:40:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: modem: clean up #includes (using include-what-you-use)
by laforge 13 Mar '23

13 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31655 ) Change subject: modem: clean up #includes (using include-what-you-use) ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I728f3eea1590f46bef6e0eb4beb9714f6c9a1614 Gerrit-Change-Number: 31655 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 21:39:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmocom-bb[master]: modem: get rid of app_data.chan_req, use ms->rrlayer
by laforge 13 Mar '23

13 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31653 ) Change subject: modem: get rid of app_data.chan_req, use ms->rrlayer ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I77d0a834a73c511f157c6f1524b9e98df3f4def4 Gerrit-Change-Number: 31653 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 21:37:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: modem: get rid of app_data.{ccch_mode,si}, use ms->cellsel
by laforge 13 Mar '23

13 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31652 ) Change subject: modem: get rid of app_data.{ccch_mode,si}, use ms->cellsel ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib711a3b893c43c0875c431c90cd0a2ebfafe1926 Gerrit-Change-Number: 31652 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 21:37:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: layer23: implement Rx/Tx API for GPRS related messages
by laforge 13 Mar '23

13 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31571 ) Change subject: layer23: implement Rx/Tx API for GPRS related messages ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I87950e893ef96ff8328f43f1548111aa9f66439b Gerrit-Change-Number: 31571 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Mar 2023 21:37:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-trx[master]: tests: use -no-install libtool flag to avoid ./lt-* scripts
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/31842 ) Change subject: tests: use -no-install libtool flag to avoid ./lt-* scripts ...................................................................... tests: use -no-install libtool flag to avoid ./lt-* scripts This option should be used for any executables which are used only for testing, or for generating other files and are consequently never installed. By specifying this option, we are telling Libtool that the executable it links will only ever be executed from where it is built in the build tree. Libtool is usually able to considerably speed up the link process for such executables. Change-Id: Ieb4ddc5799819c24ed357218c7b0197bcb6b5c91 --- M tests/CommonLibs/Makefile.am M tests/Transceiver52M/Makefile.am 2 files changed, 19 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/tests/CommonLibs/Makefile.am b/tests/CommonLibs/Makefile.am index 1a5b922..cfdbc58 100644 --- a/tests/CommonLibs/Makefile.am +++ b/tests/CommonLibs/Makefile.am @@ -12,6 +12,8 @@ $(LIBOSMOVTY_CFLAGS) \ $(NULL) +AM_LDFLAGS = -no-install + LDADD = \ $(COMMON_LA) \ $(LIBOSMOCORE_LIBS) \ diff --git a/tests/Transceiver52M/Makefile.am b/tests/Transceiver52M/Makefile.am index 2077c95..a5b91f6 100644 --- a/tests/Transceiver52M/Makefile.am +++ b/tests/Transceiver52M/Makefile.am @@ -7,6 +7,7 @@ $(NULL) AM_CFLAGS = -Wall -g +AM_LDFLAGS = -no-install EXTRA_DIST = convolve_test.ok convolve_test_golden.h -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/31842 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ieb4ddc5799819c24ed357218c7b0197bcb6b5c91 Gerrit-Change-Number: 31842 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-trx[master]: tests: Makefile.am: move -I flags from AM_CFLAGS to AM_CPPFLAGS
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/31840 ) Change subject: tests: Makefile.am: move -I flags from AM_CFLAGS to AM_CPPFLAGS ...................................................................... tests: Makefile.am: move -I flags from AM_CFLAGS to AM_CPPFLAGS * AM_CPPFLAGS is for preprocessor flags like '-I' or '-D', * AM_CFLAGS is for C (not C++!) compiler flags like '-Wall'. * AM_CXXFLAGS is for C++ specific compiler flags like '-Wall'. By having the preprocessor flags in the proper variable we make sure that they apply to both *.c and *.cpp files. Change-Id: I7b3504a01e3350834b35c42d8d76d5d88d84a4b9 --- M tests/CommonLibs/Makefile.am M tests/Transceiver52M/Makefile.am 2 files changed, 35 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/tests/CommonLibs/Makefile.am b/tests/CommonLibs/Makefile.am index e6790e6..941badb 100644 --- a/tests/CommonLibs/Makefile.am +++ b/tests/CommonLibs/Makefile.am @@ -1,6 +1,17 @@ include $(top_srcdir)/Makefile.common -AM_CPPFLAGS = -Wall -I$(top_srcdir)/CommonLibs $(STD_DEFINES_AND_INCLUDES) $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) -g +AM_CPPFLAGS = \ + -I$(top_srcdir)/CommonLibs \ + $(STD_DEFINES_AND_INCLUDES) \ + $(NULL) + +AM_CXXFLAGS = \ + -Wall -g \ + $(LIBOSMOCORE_CFLAGS) \ + $(LIBOSMOCTRL_CFLAGS) \ + $(LIBOSMOVTY_CFLAGS) \ + $(NULL) + AM_LDFLAGS = $(LIBOSMOCORE_LIBS) $(LIBOSMOCTRL_LIBS) $(LIBOSMOVTY_LIBS) EXTRA_DIST = BitVectorTest.ok \ diff --git a/tests/Transceiver52M/Makefile.am b/tests/Transceiver52M/Makefile.am index 9fae41f..cb22c2a 100644 --- a/tests/Transceiver52M/Makefile.am +++ b/tests/Transceiver52M/Makefile.am @@ -1,6 +1,12 @@ include $(top_srcdir)/Makefile.common -AM_CFLAGS = -Wall -I$(top_srcdir)/Transceiver52M -I$(top_srcdir)/Transceiver52M/arch/common $(STD_DEFINES_AND_INCLUDES) -g +AM_CPPFLAGS = \ + -I$(top_srcdir)/Transceiver52M \ + -I$(top_srcdir)/Transceiver52M/arch/common \ + $(STD_DEFINES_AND_INCLUDES) \ + $(NULL) + +AM_CFLAGS = -Wall -g EXTRA_DIST = convolve_test.ok convolve_test_golden.h -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/31840 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7b3504a01e3350834b35c42d8d76d5d88d84a4b9 Gerrit-Change-Number: 31840 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-trx[master]: tests: there shall be no libraries in LDFLAGS
by fixeria 13 Mar '23

13 Mar '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/31841 ) Change subject: tests: there shall be no libraries in LDFLAGS ...................................................................... tests: there shall be no libraries in LDFLAGS Change-Id: I95b07b5a7735fb2753281555a4544f1ba967579e --- M tests/CommonLibs/Makefile.am M tests/Transceiver52M/Makefile.am 2 files changed, 19 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified msuraev: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/tests/CommonLibs/Makefile.am b/tests/CommonLibs/Makefile.am index 941badb..1a5b922 100644 --- a/tests/CommonLibs/Makefile.am +++ b/tests/CommonLibs/Makefile.am @@ -12,7 +12,12 @@ $(LIBOSMOVTY_CFLAGS) \ $(NULL) -AM_LDFLAGS = $(LIBOSMOCORE_LIBS) $(LIBOSMOCTRL_LIBS) $(LIBOSMOVTY_LIBS) +LDADD = \ + $(COMMON_LA) \ + $(LIBOSMOCORE_LIBS) \ + $(LIBOSMOCTRL_LIBS) \ + $(LIBOSMOVTY_LIBS) \ + $(NULL) EXTRA_DIST = BitVectorTest.ok \ PRBSTest.ok \ @@ -31,21 +36,16 @@ LogTest BitVectorTest_SOURCES = BitVectorTest.cpp -BitVectorTest_LDADD = $(COMMON_LA) PRBSTest_SOURCES = PRBSTest.cpp InterthreadTest_SOURCES = InterthreadTest.cpp -InterthreadTest_LDADD = $(COMMON_LA) -InterthreadTest_LDFLAGS = -lpthread $(AM_LDFLAGS) +InterthreadTest_LDADD = $(LDADD) -lpthread TimevalTest_SOURCES = TimevalTest.cpp -TimevalTest_LDADD = $(COMMON_LA) VectorTest_SOURCES = VectorTest.cpp -VectorTest_LDADD = $(COMMON_LA) LogTest_SOURCES = LogTest.cpp -LogTest_LDADD = $(COMMON_LA) MOSTLYCLEANFILES += testSource testDestination diff --git a/tests/Transceiver52M/Makefile.am b/tests/Transceiver52M/Makefile.am index cb22c2a..2077c95 100644 --- a/tests/Transceiver52M/Makefile.am +++ b/tests/Transceiver52M/Makefile.am @@ -26,10 +26,11 @@ if DEVICE_LMS check_PROGRAMS += LMSDeviceTest LMSDeviceTest_SOURCES = LMSDeviceTest.cpp -LMSDeviceTest_LDFLAGS = $(LIBOSMOCORE_LIBS) $(LMS_LIBS) LMSDeviceTest_LDADD = \ $(top_builddir)/Transceiver52M/device/lms/libdevice.la \ + $(LIBOSMOCORE_LIBS) \ $(COMMON_LA) \ - $(LMS_LIBS) + $(LMS_LIBS) \ + $(NULL) LMSDeviceTest_CPPFLAGS = $(AM_CPPFLAGS) $(LMS_CFLAGS) endif -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/31841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I95b07b5a7735fb2753281555a4544f1ba967579e Gerrit-Change-Number: 31841 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0