March 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: rsl_rx_ipac_XXcx: parse csd_fmt_d/ir
by osmith 14 Mar '23

14 Mar '23

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31795 ) Change subject: rsl_rx_ipac_XXcx: parse csd_fmt_d/ir ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31795 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibfc7811387df5224682d7e6a313d38648d3d8c48 Gerrit-Change-Number: 31795 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 09:59:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: GSMTAP: allow configuring src IP for log messages
by pespin 14 Mar '23

14 Mar '23

Attention is currently required from: osmith, neels, fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31513 ) Change subject: GSMTAP: allow configuring src IP for log messages ...................................................................... Patch Set 13: (1 comment) File src/core/logging_gsmtap.c: https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/5ccaad22_0167694d PS12, Line 186: target->tgt_gsmtap.src_addr = talloc_strdup(target, src); > Ah, got it now - logging_vty_test is generic test fixture made by Neels. […] Ah! now I see it, I didn't see that logging_vty_test.vty was modified in this commit :) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9000269ce5b3dce1e757271b7c42e77b68d38f25 Gerrit-Change-Number: 31513 Gerrit-PatchSet: 13 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 09:42:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: PCU IF: Update NSE timer field
by pespin 14 Mar '23

14 Mar '23

Attention is currently required from: arehbein, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31885 ) Change subject: PCU IF: Update NSE timer field ...................................................................... Patch Set 1: (1 comment) File include/osmo-bts/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-bts/+/31885/comment/46bb9cb4_542311ba PS1, Line 156: PCU_IF_NUM_NSE_TIMERS > You cannot enlarge a buffer in the middle of the message because this breaks backward compatibility. […] Yes let's make this part of the same PCUIF version bump (0x0a->0x0b iirc). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7385574ef4bd4529d2e7e3d2000b7a1551ef1fcb Gerrit-Change-Number: 31885 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 09:40:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: PCU IF: Update NSE timer field
by fixeria 14 Mar '23

14 Mar '23

Attention is currently required from: arehbein. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31886 ) Change subject: PCU IF: Update NSE timer field ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: Same here, you cannot change the message structure while keeping the PCUIF version unchanged. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31886 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I29370c706b50c12e65877abc10924631e1ab7711 Gerrit-Change-Number: 31886 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 09:29:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: PCU IF: Update NSE timer field
by fixeria 14 Mar '23

14 Mar '23

Attention is currently required from: arehbein, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31885 ) Change subject: PCU IF: Update NSE timer field ...................................................................... Patch Set 1: Code-Review-2 (1 comment) File include/osmo-bts/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-bts/+/31885/comment/0c79b1ee_06b6b60e PS1, Line 156: PCU_IF_NUM_NSE_TIMERS You cannot enlarge a buffer in the middle of the message because this breaks backward compatibility. You'll need to bump the protocol version. Please coordinate this with @dexter, who is also adding new stuff to the PCUIF. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7385574ef4bd4529d2e7e3d2000b7a1551ef1fcb Gerrit-Change-Number: 31885 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 09:25:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: doc: rsl: add RSL_IE_IPAC_RTP_CSD_FORMAT
by pespin 14 Mar '23

14 Mar '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31794 ) Change subject: doc: rsl: add RSL_IE_IPAC_RTP_CSD_FORMAT ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31794 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic8f40076698f2b341cc0096fd96ba2051a41f077 Gerrit-Change-Number: 31794 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 09:09:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gm_12_21.h: Add cross-component parameter defaults (NSE timing)
by osmith 14 Mar '23

14 Mar '23

Attention is currently required from: arehbein. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31877 ) Change subject: gm_12_21.h: Add cross-component parameter defaults (NSE timing) ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Please rebase your patchset on master, that's the reason why the CI error appears. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31877 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I51d1fd8b596523ae2ac8fb6a186ce7a702334c27 Gerrit-Change-Number: 31877 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 08:25:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: PCU IF: Update NSE timer field
by arehbein 13 Mar '23

13 Mar '23

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31886 ) Change subject: PCU IF: Update NSE timer field ...................................................................... PCU IF: Update NSE timer field Include additional octet for tsns-prov Required change (osmo-bsc): Ie46ec5cb7095bc1dfe3effd0e76d6ccfd6bd2f3f Required change (osmo-bts): I7385574ef4bd4529d2e7e3d2000b7a1551ef1fcb Related: OS#5335 Change-Id: I29370c706b50c12e65877abc10924631e1ab7711 --- M include/osmocom/pcu/pcuif_proto.h M src/pcu_l1_if.cpp 2 files changed, 32 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/86/31886/1 diff --git a/include/osmocom/pcu/pcuif_proto.h b/include/osmocom/pcu/pcuif_proto.h index 53312e8..78bcccd 100644 --- a/include/osmocom/pcu/pcuif_proto.h +++ b/include/osmocom/pcu/pcuif_proto.h @@ -145,6 +145,18 @@ struct gsm_pcu_if_info_trx_ts ts[8]; } __attribute__ ((packed)); +enum gsm_pcu_if_info_ind_nse_timer_offsets { + PCU_IF_TNS_BLOCK_OFFSET = 0, + PCU_IF_TNS_BLOCK_RETRIES_OFFSET, + PCU_IF_TNS_RESET_OFFSET, + PCU_IF_TNS_RESET_RETRIES_OFFSET, + PCU_IF_TNS_TEST_OFFSET, + PCU_IF_TNS_ALIVE_OFFSET, + PCU_IF_TNS_ALIVE_RETRIES_OFFSET, + PCU_IF_TSNS_PROV_OFFSET, + _NUM_PCU_IF_NSE_TIMER_OFFSETS +}; + struct gsm_pcu_if_info_ind { uint32_t version; uint32_t flags; @@ -156,7 +168,7 @@ uint16_t lac, rac; /* NSE */ uint16_t nsei; - uint8_t nse_timer[7]; + uint8_t nse_timer[_NUM_PCU_IF_NSE_TIMER_OFFSETS]; uint8_t cell_timer[11]; /* cell */ uint16_t cell_id; @@ -187,16 +199,6 @@ } remote_ip[PCU_IF_NUM_NSVC]; } __attribute__ ((packed)); -enum gsm_pcu_if_info_ind_nse_timer_offsets { - PCU_IF_TNS_BLOCK_OFFSET = 0, - PCU_IF_TNS_BLOCK_RETRIES_OFFSET, - PCU_IF_TNS_RESET_OFFSET, - PCU_IF_TNS_RESET_RETRIES_OFFSET, - PCU_IF_TNS_TEST_OFFSET, - PCU_IF_TNS_ALIVE_RETRIES_OFFSET, - PCU_IF_TSNS_PROV_OFFSET -}; - /* E1 CCU connection parameters */ struct gsm_pcu_if_e1_ccu_ind { /* GSM/GPRS air interface */ diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index c03ead2..58612de 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -765,11 +765,11 @@ LOGP(DL1IF, LOGL_DEBUG, " cell_id=%d\n", info_ind->cell_id); LOGP(DL1IF, LOGL_DEBUG, " bsic=%d\n", info_ind->bsic); LOGP(DL1IF, LOGL_DEBUG, " nsei=%d\n", info_ind->nsei); - LOGP(DL1IF, LOGL_DEBUG, " nse_timer=%d %d %d %d %d %d %d\n", + LOGP(DL1IF, LOGL_DEBUG, " nse_timer=%d %d %d %d %d %d %d %d\n", info_ind->nse_timer[PCU_IF_TNS_BLOCK_OFFSET], info_ind->nse_timer[PCU_IF_TNS_BLOCK_RETRIES_OFFSET], info_ind->nse_timer[PCU_IF_TNS_RESET_OFFSET], info_ind->nse_timer[PCU_IF_TNS_RESET_RETRIES_OFFSET], - info_ind->nse_timer[PCU_IF_TNS_TEST_OFFSET], info_ind->nse_timer[PCU_IF_TNS_ALIVE_RETRIES_OFFSET], - info_ind->nse_timer[PCU_IF_TSNS_PROV_OFFSET]); + info_ind->nse_timer[PCU_IF_TNS_TEST_OFFSET], info_ind->nse_timer[PCU_IF_TNS_ALIVE_OFFSET], + info_ind->nse_timer[PCU_IF_TNS_ALIVE_RETRIES_OFFSET], info_ind->nse_timer[PCU_IF_TSNS_PROV_OFFSET]); /* TODO: Add enum bssgp_timing_offsets indices */ LOGP(DL1IF, LOGL_DEBUG, " cell_timer=%d %d %d %d %d %d %d %d %d %d " "%d\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31886 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I29370c706b50c12e65877abc10924631e1ab7711 Gerrit-Change-Number: 31886 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bts[master]: Include constants for cross component defaults (RLC)
by arehbein 13 Mar '23

13 Mar '23

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31883 ) Change subject: Include constants for cross component defaults (RLC) ...................................................................... Include constants for cross component defaults (RLC) Required change (libosmocore): Ie83a0160aed303e2a6d1a90e581770d1087b22ed Related: OS#5335 Change-Id: I9c53b57ed60bceab7c05d2c1b7de5ee8f14111ca --- M src/common/bts.c 1 file changed, 23 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/83/31883/1 diff --git a/src/common/bts.c b/src/common/bts.c index 11cc05d..f1ece5a 100644 --- a/src/common/bts.c +++ b/src/common/bts.c @@ -154,17 +154,17 @@ { 3, 3, 3, 3, 3, 10, 3, 10, 3, 10, 3 }; static const struct gprs_rlc_cfg rlc_cfg_default = { .parameter = { - [NM_RLC_T3142_OFFSET] = 20, - [NM_RLC_T3169_OFFSET] = 5, - [NM_RLC_T3191_OFFSET] = 5, - [NM_RLC_T3193_OFFSET] = 160, /* 10ms */ - [NM_RLC_T3195_OFFSET] = 5, - [NM_RLC_N3101_OFFSET] = 10, - [NM_RLC_N3103_OFFSET] = 4, - [NM_RLC_N3105_OFFSET] = 8, - [NM_CV_COUNTDOWN_OFFSET] = 15, - [NM_T_DL_TBF_EXT_OFFSET] = 250 * 10, /* ms */ - [NM_T_UL_TBF_EXT_OFFSET] = 250 * 10, /* ms */ + [NM_RLC_T3142_OFFSET] = NM_PAR_T3142_DEFAULT, + [NM_RLC_T3169_OFFSET] = NM_PAR_T3169_DEFAULT, + [NM_RLC_T3191_OFFSET] = NM_PAR_T3191_DEFAULT, + [NM_RLC_T3193_OFFSET] = NM_PAR_T3193_DEFAULT_MSEC/10, + [NM_RLC_T3195_OFFSET] = NM_PAR_T3195_DEFAULT, + [NM_RLC_N3101_OFFSET] = NM_PAR_N3101_DEFAULT, + [NM_RLC_N3103_OFFSET] = NM_PAR_N3103_DEFAULT, + [NM_RLC_N3105_OFFSET] = NM_PAR_N3105_DEFAULT, + [NM_CV_COUNTDOWN_OFFSET] = NM_PAR_COUNTDOWN_VALUE_DEFAULT, + [NM_T_DL_TBF_EXT_OFFSET] = NM_PAR_UL_TBF_EXT_DEFAULT_MSEC, + [NM_T_UL_TBF_EXT_OFFSET] = NM_PAR_DL_TBF_EXT_DEFAULT_MSEC, }, .paging = { .repeat_time = 5 * 50, /* ms */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31883 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9c53b57ed60bceab7c05d2c1b7de5ee8f14111ca Gerrit-Change-Number: 31883 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-bts[master]: PCU IF: Update NSE timer field
by arehbein 13 Mar '23

13 Mar '23

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31885 ) Change subject: PCU IF: Update NSE timer field ...................................................................... PCU IF: Update NSE timer field Include additional octet for tsns-prov Required change (osmo-bsc): Ie46ec5cb7095bc1dfe3effd0e76d6ccfd6bd2f3f Related: OS#5335 Change-Id: I7385574ef4bd4529d2e7e3d2000b7a1551ef1fcb --- M include/osmo-bts/pcuif_proto.h M src/common/pcu_sock.c 2 files changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/85/31885/1 diff --git a/include/osmo-bts/pcuif_proto.h b/include/osmo-bts/pcuif_proto.h index 0fece48..061f0c5 100644 --- a/include/osmo-bts/pcuif_proto.h +++ b/include/osmo-bts/pcuif_proto.h @@ -140,6 +140,8 @@ struct gsm_pcu_if_info_trx_ts ts[8]; } __attribute__ ((packed)); +#define PCU_IF_NUM_NSE_TIMERS 8 + struct gsm_pcu_if_info_ind { uint32_t version; uint32_t flags; @@ -151,7 +153,7 @@ uint16_t lac, rac; /* NSE */ uint16_t nsei; - uint8_t nse_timer[7]; + uint8_t nse_timer[PCU_IF_NUM_NSE_TIMERS]; uint8_t cell_timer[11]; /* cell */ uint16_t cell_id; diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 45da3e4..9fcd8f0 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -271,7 +271,7 @@ /* NSE */ info_ind->nsei = bts->gprs.nse.nsei; - memcpy(info_ind->nse_timer, bts->gprs.nse.timer, 7); + memcpy(info_ind->nse_timer, bts->gprs.nse.timer, PCU_IF_NUM_NSE_TIMERS); memcpy(info_ind->cell_timer, bts->gprs.cell.timer, 11); /* cell attributes */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7385574ef4bd4529d2e7e3d2000b7a1551ef1fcb Gerrit-Change-Number: 31885 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

1 0